)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":1653,"name":"garyk","email":"gkotton@vmware.com","username":"garyk"},"change_message_id":"bc500dfe2007930e346f96254ff633969b3a1b06","unresolved":false,"context_lines":[{"line_number":9,"context_line":"The goal of this patch was to remove the use of the database in the unit"},{"line_number":10,"context_line":"tests for the InstanceGroup objects. We now mock out all database"},{"line_number":11,"context_line":"interactions in the object unit tests and verify that the calls to the"},{"line_number":12,"context_line":"DB API are appropriate."},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"Change-Id: I98740029ed1115491438e93bfcb981b1f1bd7095"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"ba3cc151_d6220452","line":12,"updated":"2015-07-01 11:36:04.000000000","message":"my only concern with this is that i have seen patches that indicate that object do not use the db correctly - for example with the bw limits. having said that none of the other object tests have db usage and its all mock.","commit_id":"0d1fb8f6e6c710438acadcf3fa987fce273c518d"}],"nova/tests/unit/objects/test_instance_group.py":[{"author":{"_account_id":1653,"name":"garyk","email":"gkotton@vmware.com","username":"garyk"},"change_message_id":"bc500dfe2007930e346f96254ff633969b3a1b06","unresolved":false,"context_lines":[{"line_number":49,"context_line":"        obj \u003d objects.InstanceGroup.get_by_uuid(mock.sentinel.ctx,"},{"line_number":50,"context_line":"                                                       _DB_UUID)"},{"line_number":51,"context_line":"        mock_db_get.assert_called_once_with(mock.sentinel.ctx, _DB_UUID)"},{"line_number":52,"context_line":"        self.assertEqual(obj.members, _INST_GROUP_DB[\u0027members\u0027])"},{"line_number":53,"context_line":"        self.assertEqual(obj.policies, _INST_GROUP_DB[\u0027policies\u0027])"},{"line_number":54,"context_line":"        self.assertEqual(obj.uuid, _DB_UUID)"},{"line_number":55,"context_line":"        self.project_id \u003d _INST_GROUP_DB[\u0027project_id\u0027]"}],"source_content_type":"text/x-python","patch_set":1,"id":"ba3cc151_b6ec20f4","line":52,"updated":"2015-07-01 11:36:04.000000000","message":"expected value is generally the first","commit_id":"0d1fb8f6e6c710438acadcf3fa987fce273c518d"},{"author":{"_account_id":1653,"name":"garyk","email":"gkotton@vmware.com","username":"garyk"},"change_message_id":"bc500dfe2007930e346f96254ff633969b3a1b06","unresolved":false,"context_lines":[{"line_number":52,"context_line":"        self.assertEqual(obj.members, _INST_GROUP_DB[\u0027members\u0027])"},{"line_number":53,"context_line":"        self.assertEqual(obj.policies, _INST_GROUP_DB[\u0027policies\u0027])"},{"line_number":54,"context_line":"        self.assertEqual(obj.uuid, _DB_UUID)"},{"line_number":55,"context_line":"        self.project_id \u003d _INST_GROUP_DB[\u0027project_id\u0027]"},{"line_number":56,"context_line":"        self.user_id \u003d _INST_GROUP_DB[\u0027user_id\u0027]"},{"line_number":57,"context_line":"        self.name \u003d _INST_GROUP_DB[\u0027name\u0027]"},{"line_number":58,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"ba3cc151_36aed098","line":55,"updated":"2015-07-01 11:36:04.000000000","message":"why do we need lines 55-57","commit_id":"0d1fb8f6e6c710438acadcf3fa987fce273c518d"},{"author":{"_account_id":7,"name":"Jay Pipes","email":"jaypipes@gmail.com","username":"jaypipes"},"change_message_id":"e8993bb7944aed0fe8eaa022fabc6489ed400a45","unresolved":false,"context_lines":[{"line_number":52,"context_line":"        self.assertEqual(obj.members, _INST_GROUP_DB[\u0027members\u0027])"},{"line_number":53,"context_line":"        self.assertEqual(obj.policies, _INST_GROUP_DB[\u0027policies\u0027])"},{"line_number":54,"context_line":"        self.assertEqual(obj.uuid, _DB_UUID)"},{"line_number":55,"context_line":"        self.project_id \u003d _INST_GROUP_DB[\u0027project_id\u0027]"},{"line_number":56,"context_line":"        self.user_id \u003d _INST_GROUP_DB[\u0027user_id\u0027]"},{"line_number":57,"context_line":"        self.name \u003d _INST_GROUP_DB[\u0027name\u0027]"},{"line_number":58,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"ba3cc151_30556df9","line":55,"in_reply_to":"ba3cc151_36aed098","updated":"2015-07-01 14:00:24.000000000","message":"Doh, they were supposed to be assertions :) will correct.","commit_id":"0d1fb8f6e6c710438acadcf3fa987fce273c518d"},{"author":{"_account_id":1653,"name":"garyk","email":"gkotton@vmware.com","username":"garyk"},"change_message_id":"bc500dfe2007930e346f96254ff633969b3a1b06","unresolved":false,"context_lines":[{"line_number":66,"context_line":"        self.assertEqual(obj.members, _INST_GROUP_DB[\u0027members\u0027])"},{"line_number":67,"context_line":"        self.assertEqual(obj.policies, _INST_GROUP_DB[\u0027policies\u0027])"},{"line_number":68,"context_line":"        self.assertEqual(obj.uuid, _DB_UUID)"},{"line_number":69,"context_line":"        self.project_id \u003d _INST_GROUP_DB[\u0027project_id\u0027]"},{"line_number":70,"context_line":"        self.user_id \u003d _INST_GROUP_DB[\u0027user_id\u0027]"},{"line_number":71,"context_line":"        self.name \u003d _INST_GROUP_DB[\u0027name\u0027]"},{"line_number":72,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"ba3cc151_969d5c68","line":69,"updated":"2015-07-01 11:36:04.000000000","message":"same question here 69-71","commit_id":"0d1fb8f6e6c710438acadcf3fa987fce273c518d"}]}