)]}'
{"nova/virt/libvirt/driver.py":[{"author":{"_account_id":1653,"name":"garyk","email":"gkotton@vmware.com","username":"garyk"},"change_message_id":"4ed4f4f99bb6bc9a11648f22b0f32fddea6b73be","unresolved":false,"context_lines":[{"line_number":3866,"context_line":"            return"},{"line_number":3867,"context_line":""},{"line_number":3868,"context_line":"        membacking \u003d None"},{"line_number":3869,"context_line":"        if wantsmempages:"},{"line_number":3870,"context_line":"            membacking \u003d self._set_memory_backing_hugepages_support("},{"line_number":3871,"context_line":"                membacking, inst_topology, numatune)"},{"line_number":3872,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"ba3cc151_3781e7c3","line":3869,"updated":"2015-07-01 13:26:03.000000000","message":"please see line 3865 we do not need this if","commit_id":"49537c4607cec05d60e80b26e459c0bcb3ea05e9"},{"author":{"_account_id":7730,"name":"Sahid Orentino Ferdjaoui","email":"sahid.ferdjaoui@industrialdiscipline.com","username":"sahid"},"change_message_id":"c2eceed2633790ab5a807b6ef6f3ea403632fcbe","unresolved":false,"context_lines":[{"line_number":3866,"context_line":"            return"},{"line_number":3867,"context_line":""},{"line_number":3868,"context_line":"        membacking \u003d None"},{"line_number":3869,"context_line":"        if wantsmempages:"},{"line_number":3870,"context_line":"            membacking \u003d self._set_memory_backing_hugepages_support("},{"line_number":3871,"context_line":"                membacking, inst_topology, numatune)"},{"line_number":3872,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"ba3cc151_cdecaef5","line":3869,"in_reply_to":"ba3cc151_3781e7c3","updated":"2015-07-01 13:50:37.000000000","message":"Yes no need now, but line 3878 https://review.openstack.org/#/c/197569/1/nova/virt/libvirt/driver.py,cm","commit_id":"49537c4607cec05d60e80b26e459c0bcb3ea05e9"},{"author":{"_account_id":6062,"name":"jichenjc","email":"jichenjc@cn.ibm.com","username":"jichenjc"},"change_message_id":"d3929664b9fac27a30b2556bc290ef1c142b88b5","unresolved":false,"context_lines":[{"line_number":3867,"context_line":"                    break"},{"line_number":3868,"context_line":""},{"line_number":3869,"context_line":"        if not wantsmempages:"},{"line_number":3870,"context_line":"            return"},{"line_number":3871,"context_line":""},{"line_number":3872,"context_line":"        membacking \u003d None"},{"line_number":3873,"context_line":"        if wantsmempages:"}],"source_content_type":"text/x-python","patch_set":3,"id":"ba3cc151_c4e427e1","line":3870,"updated":"2015-07-09 15:57:44.000000000","message":"actually, we can remove those 2 lines","commit_id":"13908c6de4d0f9871242926992e0c68c5a9c1841"},{"author":{"_account_id":7730,"name":"Sahid Orentino Ferdjaoui","email":"sahid.ferdjaoui@industrialdiscipline.com","username":"sahid"},"change_message_id":"06797151b17371839d720b855aa142eeb16e7b1c","unresolved":false,"context_lines":[{"line_number":3867,"context_line":"                    break"},{"line_number":3868,"context_line":""},{"line_number":3869,"context_line":"        if not wantsmempages:"},{"line_number":3870,"context_line":"            return"},{"line_number":3871,"context_line":""},{"line_number":3872,"context_line":"        membacking \u003d None"},{"line_number":3873,"context_line":"        if wantsmempages:"}],"source_content_type":"text/x-python","patch_set":3,"id":"9a41bdd9_95c67998","line":3870,"in_reply_to":"ba3cc151_c4e427e1","updated":"2015-07-15 12:48:28.000000000","message":"Done","commit_id":"13908c6de4d0f9871242926992e0c68c5a9c1841"},{"author":{"_account_id":1653,"name":"garyk","email":"gkotton@vmware.com","username":"garyk"},"change_message_id":"39a900ca18093bb7665a4a55b4284f2c0677138e","unresolved":false,"context_lines":[{"line_number":3845,"context_line":"                    wantsmempages \u003d True"},{"line_number":3846,"context_line":"                    break"},{"line_number":3847,"context_line":""},{"line_number":3848,"context_line":"        membacking \u003d None"},{"line_number":3849,"context_line":"        if wantsmempages:"},{"line_number":3850,"context_line":"            membacking \u003d self._set_memory_backing_hugepages_support("},{"line_number":3851,"context_line":"                membacking, inst_topology, numatune)"}],"source_content_type":"text/x-python","patch_set":6,"id":"da20952f_7231150b","line":3848,"updated":"2015-08-27 10:30:08.000000000","message":"Why not:\n        if wantsmempages:\n            return self._set_memory_backing_hugepages_support(\n                membacking, inst_topology, numatune)\n\nBy default a method returns None","commit_id":"72fd5fc043eb04e18d381b4409e5f21c7f51646a"},{"author":{"_account_id":7730,"name":"Sahid Orentino Ferdjaoui","email":"sahid.ferdjaoui@industrialdiscipline.com","username":"sahid"},"change_message_id":"e7a89d55dc749dd028110edf98065c6f2d834452","unresolved":false,"context_lines":[{"line_number":3845,"context_line":"                    wantsmempages \u003d True"},{"line_number":3846,"context_line":"                    break"},{"line_number":3847,"context_line":""},{"line_number":3848,"context_line":"        membacking \u003d None"},{"line_number":3849,"context_line":"        if wantsmempages:"},{"line_number":3850,"context_line":"            membacking \u003d self._set_memory_backing_hugepages_support("},{"line_number":3851,"context_line":"                membacking, inst_topology, numatune)"}],"source_content_type":"text/x-python","patch_set":6,"id":"da20952f_4d5d50e8","line":3848,"in_reply_to":"da20952f_7231150b","updated":"2015-08-27 10:36:03.000000000","message":"The point of having structure code like that is to make easier new update on membacking\u0027s config\n\n    if wantsmempages:\n      membacking \u003d self._set_memory_backing_hugepages_support(\n                membacking, inst_topology, numatune)\n      membacking \u003d self._set_memory_backing_foobar_support(\n                membacking, inst_topology, numatune)\n\n    return membacking","commit_id":"72fd5fc043eb04e18d381b4409e5f21c7f51646a"},{"author":{"_account_id":1653,"name":"garyk","email":"gkotton@vmware.com","username":"garyk"},"change_message_id":"39a900ca18093bb7665a4a55b4284f2c0677138e","unresolved":false,"context_lines":[{"line_number":4047,"context_line":"        guest.cputune \u003d guest_numa_config.cputune"},{"line_number":4048,"context_line":"        guest.numatune \u003d guest_numa_config.numatune"},{"line_number":4049,"context_line":""},{"line_number":4050,"context_line":"        guest.membacking \u003d self._get_guest_memory_backing_config("},{"line_number":4051,"context_line":"            instance.numa_topology,"},{"line_number":4052,"context_line":"            guest_numa_config.numatune,"},{"line_number":4053,"context_line":"            flavor,"}],"source_content_type":"text/x-python","patch_set":6,"id":"da20952f_d203410e","line":4050,"updated":"2015-08-27 10:30:08.000000000","message":"why not pass instance - that has flavor numa_topology etc.","commit_id":"72fd5fc043eb04e18d381b4409e5f21c7f51646a"},{"author":{"_account_id":7730,"name":"Sahid Orentino Ferdjaoui","email":"sahid.ferdjaoui@industrialdiscipline.com","username":"sahid"},"change_message_id":"e7a89d55dc749dd028110edf98065c6f2d834452","unresolved":false,"context_lines":[{"line_number":4047,"context_line":"        guest.cputune \u003d guest_numa_config.cputune"},{"line_number":4048,"context_line":"        guest.numatune \u003d guest_numa_config.numatune"},{"line_number":4049,"context_line":""},{"line_number":4050,"context_line":"        guest.membacking \u003d self._get_guest_memory_backing_config("},{"line_number":4051,"context_line":"            instance.numa_topology,"},{"line_number":4052,"context_line":"            guest_numa_config.numatune,"},{"line_number":4053,"context_line":"            flavor,"}],"source_content_type":"text/x-python","patch_set":6,"id":"da20952f_ad1aec15","line":4050,"in_reply_to":"da20952f_d203410e","updated":"2015-08-27 10:36:03.000000000","message":"No need of instance, only numa_topology","commit_id":"72fd5fc043eb04e18d381b4409e5f21c7f51646a"},{"author":{"_account_id":1779,"name":"Daniel Berrange","email":"berrange@redhat.com","username":"berrange"},"change_message_id":"cb5ad54d8e81ef03f98923eb26c9e0e3a761fc00","unresolved":false,"context_lines":[{"line_number":3943,"context_line":"        membacking \u003d None"},{"line_number":3944,"context_line":"        if wantsmempages:"},{"line_number":3945,"context_line":"            membacking \u003d self._set_memory_backing_hugepages_support("},{"line_number":3946,"context_line":"                membacking, inst_topology, numatune)"},{"line_number":3947,"context_line":""},{"line_number":3948,"context_line":"        return membacking"},{"line_number":3949,"context_line":""}],"source_content_type":"text/x-python","patch_set":9,"id":"9a1a9d01_3d4773bd","line":3946,"updated":"2015-09-29 15:50:29.000000000","message":"Passing in and returning membacking is slightly unpleasant. i think it\u0027d be nicer as\n\n  pages \u003d self._get_memory_backing_hugepags(inst_topology, numatune)\n  if pages:\n    membacking \u003d vconfig.LibvirtConfigGuestMemoryBacking()\n    membacking.hugepages \u003d pages","commit_id":"9bb60165cd8f5225139d8133d5be90c5e46203bc"},{"author":{"_account_id":1779,"name":"Daniel Berrange","email":"berrange@redhat.com","username":"berrange"},"change_message_id":"cb5ad54d8e81ef03f98923eb26c9e0e3a761fc00","unresolved":false,"context_lines":[{"line_number":3948,"context_line":"        return membacking"},{"line_number":3949,"context_line":""},{"line_number":3950,"context_line":"    def _set_memory_backing_hugepages_support("},{"line_number":3951,"context_line":"            self, membacking, inst_topology, numatune):"},{"line_number":3952,"context_line":"        if not self._has_hugepage_support():"},{"line_number":3953,"context_line":"            # We should not get here, since we should have avoided"},{"line_number":3954,"context_line":"            # reporting NUMA topology from _get_host_numa_topology"}],"source_content_type":"text/x-python","patch_set":9,"id":"9a1a9d01_bd96233c","line":3951,"updated":"2015-09-29 15:50:29.000000000","message":"Then change to \u0027_get_memory_backing_hugepages\u0027 and remove the \u0027membacking\u0027 parameter here.","commit_id":"9bb60165cd8f5225139d8133d5be90c5e46203bc"},{"author":{"_account_id":1779,"name":"Daniel Berrange","email":"berrange@redhat.com","username":"berrange"},"change_message_id":"cb5ad54d8e81ef03f98923eb26c9e0e3a761fc00","unresolved":false,"context_lines":[{"line_number":3987,"context_line":"                membacking \u003d vconfig.LibvirtConfigGuestMemoryBacking()"},{"line_number":3988,"context_line":"            membacking.hugepages \u003d pages"},{"line_number":3989,"context_line":""},{"line_number":3990,"context_line":"        return membacking"},{"line_number":3991,"context_line":""},{"line_number":3992,"context_line":"    def _get_flavor(self, ctxt, instance, flavor):"},{"line_number":3993,"context_line":"        if flavor is not None:"}],"source_content_type":"text/x-python","patch_set":9,"id":"9a1a9d01_7da5eb9f","line":3990,"updated":"2015-09-29 15:50:29.000000000","message":"Get rid of these 5 lines and just do\n\n   return pages","commit_id":"9bb60165cd8f5225139d8133d5be90c5e46203bc"},{"author":{"_account_id":1779,"name":"Daniel Berrange","email":"berrange@redhat.com","username":"berrange"},"change_message_id":"cb5ad54d8e81ef03f98923eb26c9e0e3a761fc00","unresolved":false,"context_lines":[{"line_number":4147,"context_line":"            instance.numa_topology,"},{"line_number":4148,"context_line":"            guest_numa_config.numatune,"},{"line_number":4149,"context_line":"            flavor,"},{"line_number":4150,"context_line":"            image_meta)"},{"line_number":4151,"context_line":""},{"line_number":4152,"context_line":"        guest.metadata.append(self._get_guest_config_meta(context,"},{"line_number":4153,"context_line":"                                                          instance))"}],"source_content_type":"text/x-python","patch_set":9,"id":"9a1a9d01_7d6f2b2b","line":4150,"updated":"2015-09-29 15:50:29.000000000","message":"These two extra params are not used in this patch, so I\u0027d postpone adding them until your later patch which actually needs them","commit_id":"9bb60165cd8f5225139d8133d5be90c5e46203bc"},{"author":{"_account_id":6062,"name":"jichenjc","email":"jichenjc@cn.ibm.com","username":"jichenjc"},"change_message_id":"beb1316af2789d717b731f75f74022e689008889","unresolved":false,"context_lines":[{"line_number":4140,"context_line":""},{"line_number":4141,"context_line":"        guest.membacking \u003d self._get_guest_memory_backing_config("},{"line_number":4142,"context_line":"            instance.numa_topology,"},{"line_number":4143,"context_line":"            guest_numa_config.numatune)"},{"line_number":4144,"context_line":""},{"line_number":4145,"context_line":"        guest.metadata.append(self._get_guest_config_meta(context,"},{"line_number":4146,"context_line":"                                                          instance))"}],"source_content_type":"text/x-python","patch_set":10,"id":"7a2fa921_05ddc00d","line":4143,"updated":"2015-10-07 12:21:44.000000000","message":"not related change ...","commit_id":"67cebfd66d6875623b802e264693c4c000ed5a6c"},{"author":{"_account_id":782,"name":"John Garbutt","email":"john@johngarbutt.com","username":"johngarbutt"},"change_message_id":"c56e4d4e1f790fd502e4b065495d8016a707bc7c","unresolved":false,"context_lines":[{"line_number":4201,"context_line":""},{"line_number":4202,"context_line":"        guest.membacking \u003d self._get_guest_memory_backing_config("},{"line_number":4203,"context_line":"            instance.numa_topology,"},{"line_number":4204,"context_line":"            guest_numa_config.numatune)"},{"line_number":4205,"context_line":""},{"line_number":4206,"context_line":"        guest.metadata.append(self._get_guest_config_meta(context,"},{"line_number":4207,"context_line":"                                                          instance))"}],"source_content_type":"text/x-python","patch_set":12,"id":"ba8a016a_d75eeb75","line":4204,"updated":"2015-11-16 11:55:54.000000000","message":"Nit: not keen on unrelated changes, but OK.","commit_id":"ee9b644118ce94599d4e4b937f932551e10207cb"}]}