)]}'
{"nova/virt/libvirt/config.py":[{"author":{"_account_id":17021,"name":"Adriaan Schmidt","email":"adriaan.schmidt@siemens.com","username":"adriaan42"},"change_message_id":"7e0d50e8982a74771b73edd6fedc1d88a2391416","unresolved":false,"context_lines":[{"line_number":1580,"context_line":""},{"line_number":1581,"context_line":"        self.vcpus \u003d None"},{"line_number":1582,"context_line":"        self.scheduler \u003d \"rr\""},{"line_number":1583,"context_line":"        self.priority \u003d 1"},{"line_number":1584,"context_line":""},{"line_number":1585,"context_line":"    def format_dom(self):"},{"line_number":1586,"context_line":"        root \u003d super(LibvirtConfigGuestCPUTuneVCPUSched, self).format_dom()"}],"source_content_type":"text/x-python","patch_set":6,"id":"3a50d1a3_07c26e53","line":1583,"updated":"2015-08-04 13:02:39.000000000","message":"Could we make the scheduling policy and priority configurable on a per-host basis? E.g., by introducing a new option in the config file?","commit_id":"923272e6297fa3b1801c1e8f795ac8d7c0dd0058"},{"author":{"_account_id":7730,"name":"Sahid Orentino Ferdjaoui","email":"sahid.ferdjaoui@industrialdiscipline.com","username":"sahid"},"change_message_id":"e75616208290b2773f7d9637e4c3034acd4d31c9","unresolved":false,"context_lines":[{"line_number":1580,"context_line":""},{"line_number":1581,"context_line":"        self.vcpus \u003d None"},{"line_number":1582,"context_line":"        self.scheduler \u003d \"rr\""},{"line_number":1583,"context_line":"        self.priority \u003d 1"},{"line_number":1584,"context_line":""},{"line_number":1585,"context_line":"    def format_dom(self):"},{"line_number":1586,"context_line":"        root \u003d super(LibvirtConfigGuestCPUTuneVCPUSched, self).format_dom()"}],"source_content_type":"text/x-python","patch_set":6,"id":"fa1b9901_49052ac0","line":1583,"in_reply_to":"3a50d1a3_07c26e53","updated":"2015-08-24 14:30:47.000000000","message":"So I guess it is something we can do, introduce global option in libvirt to configure priority for all guests running on host.\n\nThat change also means we will use \u0027fifo\u0027 for scheduler policy, at least the default behavior with priority 1 will run like a Round Robin scheduler.","commit_id":"923272e6297fa3b1801c1e8f795ac8d7c0dd0058"},{"author":{"_account_id":7730,"name":"Sahid Orentino Ferdjaoui","email":"sahid.ferdjaoui@industrialdiscipline.com","username":"sahid"},"change_message_id":"5afd7259fc93cc468216dd27a5a94a5ff9843432","unresolved":false,"context_lines":[{"line_number":1580,"context_line":""},{"line_number":1581,"context_line":"        self.vcpus \u003d None"},{"line_number":1582,"context_line":"        self.scheduler \u003d \"rr\""},{"line_number":1583,"context_line":"        self.priority \u003d 1"},{"line_number":1584,"context_line":""},{"line_number":1585,"context_line":"    def format_dom(self):"},{"line_number":1586,"context_line":"        root \u003d super(LibvirtConfigGuestCPUTuneVCPUSched, self).format_dom()"}],"source_content_type":"text/x-python","patch_set":6,"id":"ba15a1d1_ef03a240","line":1583,"in_reply_to":"ba15a1d1_47e2e630","updated":"2015-09-23 08:52:54.000000000","message":"Done","commit_id":"923272e6297fa3b1801c1e8f795ac8d7c0dd0058"},{"author":{"_account_id":1779,"name":"Daniel Berrange","email":"berrange@redhat.com","username":"berrange"},"change_message_id":"3f106daf9896b6b5bb668e4ff686a7572c4ec902","unresolved":false,"context_lines":[{"line_number":1580,"context_line":""},{"line_number":1581,"context_line":"        self.vcpus \u003d None"},{"line_number":1582,"context_line":"        self.scheduler \u003d \"rr\""},{"line_number":1583,"context_line":"        self.priority \u003d 1"},{"line_number":1584,"context_line":""},{"line_number":1585,"context_line":"    def format_dom(self):"},{"line_number":1586,"context_line":"        root \u003d super(LibvirtConfigGuestCPUTuneVCPUSched, self).format_dom()"}],"source_content_type":"text/x-python","patch_set":6,"id":"ba15a1d1_47e2e630","line":1583,"in_reply_to":"fa1b9901_49052ac0","updated":"2015-09-22 09:56:37.000000000","message":"NB, this file is just concerned with XML parsing/formatting, so any configurability would be in the driver.py file. I think it might be better to just leave this attributes set to None by default, and require the driver to specify values explicitly","commit_id":"923272e6297fa3b1801c1e8f795ac8d7c0dd0058"},{"author":{"_account_id":1779,"name":"Daniel Berrange","email":"berrange@redhat.com","username":"berrange"},"change_message_id":"6660fa68585acd9d57b8419cc819356e05b6bccb","unresolved":false,"context_lines":[{"line_number":1621,"context_line":"        self.period \u003d None"},{"line_number":1622,"context_line":"        self.vcpupin \u003d []"},{"line_number":1623,"context_line":"        self.emulatorpin \u003d None"},{"line_number":1624,"context_line":"        self.vcpusched \u003d None"},{"line_number":1625,"context_line":""},{"line_number":1626,"context_line":"    def format_dom(self):"},{"line_number":1627,"context_line":"        root \u003d super(LibvirtConfigGuestCPUTune, self).format_dom()"}],"source_content_type":"text/x-python","patch_set":10,"id":"7a2fa921_74ae7a99","line":1624,"updated":"2015-10-08 09:27:59.000000000","message":"From the libvirt XML schema POV, vcpusched ought to be a list, as self.vcpupin is. Even though I know you don\u0027t need to use more than one instance in Nova right now, I\u0027d prefer us to follow the schema.","commit_id":"5552112cb213ada213bce1be0d95160c35dd451a"}],"nova/virt/libvirt/driver.py":[{"author":{"_account_id":1779,"name":"Daniel Berrange","email":"berrange@redhat.com","username":"berrange"},"change_message_id":"030557f0a632501d50839b480e5157a1cf1d631c","unresolved":false,"context_lines":[{"line_number":275,"context_line":"               default\u003d1,"},{"line_number":276,"context_line":"               help\u003d\u0027In a realtime host context vCPUs for guest will run in \u0027"},{"line_number":277,"context_line":"                    \u0027that scheduling priority. Priority depends on the host \u0027"},{"line_number":278,"context_line":"                    \u0027kernel (usually 1-99)\u0027)"},{"line_number":279,"context_line":"    ]"},{"line_number":280,"context_line":""},{"line_number":281,"context_line":"CONF \u003d cfg.CONF"}],"source_content_type":"text/x-python","patch_set":9,"id":"9a1a9d01_5de02796","line":278,"updated":"2015-09-29 15:52:01.000000000","message":"This should not be introduced until you need it, so move to your last patch.","commit_id":"bb9c9e20a8c88543677d2e3a8ea6628382fff6c7"}]}