)]}'
{"nova/network/manager.py":[{"author":{"_account_id":5638,"name":"Davanum Srinivas","email":"davanum@gmail.com","username":"dims-v"},"change_message_id":"c0ea28213267d448fb868171c7e42c01d6974715","unresolved":false,"context_lines":[{"line_number":1126,"context_line":"            # should ignore the request so we don\u0027t disassociate the fixed IP"},{"line_number":1127,"context_line":"            # from the wrong instance."},{"line_number":1128,"context_line":"            if mac:"},{"line_number":1129,"context_line":"                LOG.debug(\u0027Checking to see if virtual interface with MAC \u0027"},{"line_number":1130,"context_line":"                          \u0027%(mac)s is still associated to instance: \u0027"},{"line_number":1131,"context_line":"                          \u0027%(instance)s\u0027,"},{"line_number":1132,"context_line":"                          {\u0027mac\u0027: mac, \u0027instance\u0027: fixed_ip.instance_uuid})"}],"source_content_type":"text/x-python","patch_set":1,"id":"9a41bdd9_1330fc55","line":1129,"updated":"2015-07-11 02:39:41.000000000","message":"a bit off on how we pass in instance here and instance_uuid in line 1143. but oh well, it will work :)","commit_id":"74e54e4f123ee1e65735639d4a04ea0f04509363"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"733b03aa5a0316c310594d08c9907caa961c71f9","unresolved":false,"context_lines":[{"line_number":1126,"context_line":"            # should ignore the request so we don\u0027t disassociate the fixed IP"},{"line_number":1127,"context_line":"            # from the wrong instance."},{"line_number":1128,"context_line":"            if mac:"},{"line_number":1129,"context_line":"                LOG.debug(\u0027Checking to see if virtual interface with MAC \u0027"},{"line_number":1130,"context_line":"                          \u0027%(mac)s is still associated to instance: \u0027"},{"line_number":1131,"context_line":"                          \u0027%(instance)s\u0027,"},{"line_number":1132,"context_line":"                          {\u0027mac\u0027: mac, \u0027instance\u0027: fixed_ip.instance_uuid})"}],"source_content_type":"text/x-python","patch_set":1,"id":"fa1b9901_f7a72909","line":1129,"in_reply_to":"1a4dcd0f_7580038c","updated":"2015-08-24 19:38:38.000000000","message":"I\u0027ve forgotten the original reason beyond my previous reply.  I can change the instance to be a kwarg if that\u0027s what people want.","commit_id":"74e54e4f123ee1e65735639d4a04ea0f04509363"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"23ccfd7400e258e4344ed86daf3ed592bf28a8c2","unresolved":false,"context_lines":[{"line_number":1126,"context_line":"            # should ignore the request so we don\u0027t disassociate the fixed IP"},{"line_number":1127,"context_line":"            # from the wrong instance."},{"line_number":1128,"context_line":"            if mac:"},{"line_number":1129,"context_line":"                LOG.debug(\u0027Checking to see if virtual interface with MAC \u0027"},{"line_number":1130,"context_line":"                          \u0027%(mac)s is still associated to instance: \u0027"},{"line_number":1131,"context_line":"                          \u0027%(instance)s\u0027,"},{"line_number":1132,"context_line":"                          {\u0027mac\u0027: mac, \u0027instance\u0027: fixed_ip.instance_uuid})"}],"source_content_type":"text/x-python","patch_set":1,"id":"9a41bdd9_c67cbd74","line":1129,"in_reply_to":"9a41bdd9_1330fc55","updated":"2015-07-13 21:09:44.000000000","message":"The difference was intentional in how the message is written out in the logs.  In this case it\u0027s part of the message, in the other on line 1143 the instance uuid is a prefix in the message so it\u0027s just there for context.  I think either would be fine.","commit_id":"74e54e4f123ee1e65735639d4a04ea0f04509363"},{"author":{"_account_id":2271,"name":"Michael Still","email":"mikal@stillhq.com","username":"mikalstill"},"change_message_id":"3e27385b098bf8eaddae3342e3a3fefbb25a3b4b","unresolved":false,"context_lines":[{"line_number":1126,"context_line":"            # should ignore the request so we don\u0027t disassociate the fixed IP"},{"line_number":1127,"context_line":"            # from the wrong instance."},{"line_number":1128,"context_line":"            if mac:"},{"line_number":1129,"context_line":"                LOG.debug(\u0027Checking to see if virtual interface with MAC \u0027"},{"line_number":1130,"context_line":"                          \u0027%(mac)s is still associated to instance: \u0027"},{"line_number":1131,"context_line":"                          \u0027%(instance)s\u0027,"},{"line_number":1132,"context_line":"                          {\u0027mac\u0027: mac, \u0027instance\u0027: fixed_ip.instance_uuid})"}],"source_content_type":"text/x-python","patch_set":1,"id":"1a4dcd0f_7580038c","line":1129,"in_reply_to":"9a41bdd9_c67cbd74","updated":"2015-08-15 00:40:46.000000000","message":"What\u0027s the value of having it as part of the message though? Having it passed in the normal way presumably meets your needs and makes this message more useful to operators who might one day be debugging here.","commit_id":"74e54e4f123ee1e65735639d4a04ea0f04509363"},{"author":{"_account_id":2271,"name":"Michael Still","email":"mikal@stillhq.com","username":"mikalstill"},"change_message_id":"3e27385b098bf8eaddae3342e3a3fefbb25a3b4b","unresolved":false,"context_lines":[{"line_number":1132,"context_line":"                          {\u0027mac\u0027: mac, \u0027instance\u0027: fixed_ip.instance_uuid})"},{"line_number":1133,"context_line":"                vif \u003d objects.VirtualInterface.get_by_address(context, mac)"},{"line_number":1134,"context_line":"                if vif:"},{"line_number":1135,"context_line":"                    LOG.debug(\u0027Found VIF: %s\u0027, vif)"},{"line_number":1136,"context_line":"                    if vif.instance_uuid !\u003d fixed_ip.instance_uuid:"},{"line_number":1137,"context_line":"                        LOG.info(_LI(\"Ignoring request to release fixed IP \""},{"line_number":1138,"context_line":"                                     \"%(address)s with MAC %(mac)s since it \""}],"source_content_type":"text/x-python","patch_set":1,"id":"1a4dcd0f_554ce79c","line":1135,"range":{"start_line":1135,"start_character":31,"end_line":1135,"end_character":36},"updated":"2015-08-15 00:40:46.000000000","message":"I\u0027d add an instance argument to this one too to make it more grepable.","commit_id":"74e54e4f123ee1e65735639d4a04ea0f04509363"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"733b03aa5a0316c310594d08c9907caa961c71f9","unresolved":false,"context_lines":[{"line_number":1132,"context_line":"                          {\u0027mac\u0027: mac, \u0027instance\u0027: fixed_ip.instance_uuid})"},{"line_number":1133,"context_line":"                vif \u003d objects.VirtualInterface.get_by_address(context, mac)"},{"line_number":1134,"context_line":"                if vif:"},{"line_number":1135,"context_line":"                    LOG.debug(\u0027Found VIF: %s\u0027, vif)"},{"line_number":1136,"context_line":"                    if vif.instance_uuid !\u003d fixed_ip.instance_uuid:"},{"line_number":1137,"context_line":"                        LOG.info(_LI(\"Ignoring request to release fixed IP \""},{"line_number":1138,"context_line":"                                     \"%(address)s with MAC %(mac)s since it \""}],"source_content_type":"text/x-python","patch_set":1,"id":"fa1b9901_f7f5e9ec","line":1135,"in_reply_to":"1a4dcd0f_554ce79c","updated":"2015-08-24 19:38:38.000000000","message":"I can do that.","commit_id":"74e54e4f123ee1e65735639d4a04ea0f04509363"},{"author":{"_account_id":2271,"name":"Michael Still","email":"mikal@stillhq.com","username":"mikalstill"},"change_message_id":"3e27385b098bf8eaddae3342e3a3fefbb25a3b4b","unresolved":false,"context_lines":[{"line_number":1143,"context_line":"                                 instance_uuid\u003dfixed_ip.instance_uuid)"},{"line_number":1144,"context_line":"                        return"},{"line_number":1145,"context_line":"                else:"},{"line_number":1146,"context_line":"                    LOG.debug(\u0027No VIF was found for MAC: %s\u0027, mac)"},{"line_number":1147,"context_line":""},{"line_number":1148,"context_line":"            LOG.debug(\u0027Disassociating fixed IP %s from instance.\u0027, address,"},{"line_number":1149,"context_line":"                      instance_uuid\u003dfixed_ip.instance_uuid)"}],"source_content_type":"text/x-python","patch_set":1,"id":"1a4dcd0f_f542d367","line":1146,"range":{"start_line":1146,"start_character":20,"end_line":1146,"end_character":23},"updated":"2015-08-15 00:40:46.000000000","message":"Ditto","commit_id":"74e54e4f123ee1e65735639d4a04ea0f04509363"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"733b03aa5a0316c310594d08c9907caa961c71f9","unresolved":false,"context_lines":[{"line_number":1143,"context_line":"                                 instance_uuid\u003dfixed_ip.instance_uuid)"},{"line_number":1144,"context_line":"                        return"},{"line_number":1145,"context_line":"                else:"},{"line_number":1146,"context_line":"                    LOG.debug(\u0027No VIF was found for MAC: %s\u0027, mac)"},{"line_number":1147,"context_line":""},{"line_number":1148,"context_line":"            LOG.debug(\u0027Disassociating fixed IP %s from instance.\u0027, address,"},{"line_number":1149,"context_line":"                      instance_uuid\u003dfixed_ip.instance_uuid)"}],"source_content_type":"text/x-python","patch_set":1,"id":"fa1b9901_37d36161","line":1146,"in_reply_to":"1a4dcd0f_f542d367","updated":"2015-08-24 19:38:38.000000000","message":"Done","commit_id":"74e54e4f123ee1e65735639d4a04ea0f04509363"},{"author":{"_account_id":1653,"name":"garyk","email":"gkotton@vmware.com","username":"garyk"},"change_message_id":"4b099ed0b4b3c45fd4d5c6412b4c3583c096a309","unresolved":false,"context_lines":[{"line_number":1129,"context_line":"            if mac:"},{"line_number":1130,"context_line":"                LOG.debug(\u0027Checking to see if virtual interface with MAC \u0027"},{"line_number":1131,"context_line":"                          \u0027%(mac)s is still associated to instance.\u0027,"},{"line_number":1132,"context_line":"                          {\u0027mac\u0027: mac}, instance_uuid\u003dfixed_ip.instance_uuid)"},{"line_number":1133,"context_line":"                vif \u003d objects.VirtualInterface.get_by_address(context, mac)"},{"line_number":1134,"context_line":"                if vif:"},{"line_number":1135,"context_line":"                    LOG.debug(\u0027Found VIF: %s\u0027, vif,"}],"source_content_type":"text/x-python","patch_set":2,"id":"da20952f_405e1245","line":1132,"updated":"2015-08-29 03:10:47.000000000","message":"if there is one variable then you do not need a dictionary - but that is really nit picking","commit_id":"fd471b2fc1fee6e859ee3657b53548a61c0f3a1e"}]}