)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":4419,"name":"Matthew Sherborne","email":"msherborne+openstack@gmail.com","username":"msherborne+openstack"},"change_message_id":"0ab95ba804e76e7e5f2d1199fb4edcab0ad4a2e3","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Fix wrong quota reservation when deleting resizing instance"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"when we delete an instance which is resizing from m1.small to m1.tiny, we use"},{"line_number":10,"context_line":"instance[\u0027memory_mb\u0027], instance[\u0027vcpus\u0027] to create quota\u0027s reservations, if the"},{"line_number":11,"context_line":"resizing is not \u0027finished\u0027, the in_use value in quota_usages is NOT"},{"line_number":12,"context_line":"commited(2048M), but the instance[\u0027memory_mb\u0027], instance[\u0027vcpus\u0027] is"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":5,"id":"AAAAM3%2F%2FgW4%3D","line":9,"updated":"2013-01-18 04:40:02.000000000","message":"When - capital W at start of paragraph please :)","commit_id":"8b1c44ffbd04584f84de8975cc6819214887e312"},{"author":{"_account_id":4419,"name":"Matthew Sherborne","email":"msherborne+openstack@gmail.com","username":"msherborne+openstack"},"change_message_id":"0ab95ba804e76e7e5f2d1199fb4edcab0ad4a2e3","unresolved":false,"context_lines":[{"line_number":7,"context_line":"Fix wrong quota reservation when deleting resizing instance"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"when we delete an instance which is resizing from m1.small to m1.tiny, we use"},{"line_number":10,"context_line":"instance[\u0027memory_mb\u0027], instance[\u0027vcpus\u0027] to create quota\u0027s reservations, if the"},{"line_number":11,"context_line":"resizing is not \u0027finished\u0027, the in_use value in quota_usages is NOT"},{"line_number":12,"context_line":"commited(2048M), but the instance[\u0027memory_mb\u0027], instance[\u0027vcpus\u0027] is"},{"line_number":13,"context_line":"updated(512M) in _finish_resize(), so the deleting operation after updating"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":5,"id":"AAAAM3%2F%2FgWw%3D","line":10,"updated":"2013-01-18 04:40:02.000000000","message":"instance[\u0027memory_mb\u0027] *and* instance[\u0027vcpus\u0027]","commit_id":"8b1c44ffbd04584f84de8975cc6819214887e312"},{"author":{"_account_id":4419,"name":"Matthew Sherborne","email":"msherborne+openstack@gmail.com","username":"msherborne+openstack"},"change_message_id":"0ab95ba804e76e7e5f2d1199fb4edcab0ad4a2e3","unresolved":false,"context_lines":[{"line_number":9,"context_line":"when we delete an instance which is resizing from m1.small to m1.tiny, we use"},{"line_number":10,"context_line":"instance[\u0027memory_mb\u0027], instance[\u0027vcpus\u0027] to create quota\u0027s reservations, if the"},{"line_number":11,"context_line":"resizing is not \u0027finished\u0027, the in_use value in quota_usages is NOT"},{"line_number":12,"context_line":"commited(2048M), but the instance[\u0027memory_mb\u0027], instance[\u0027vcpus\u0027] is"},{"line_number":13,"context_line":"updated(512M) in _finish_resize(), so the deleting operation after updating"},{"line_number":14,"context_line":"will commit a wrong reservations(-512M), and the in_use value changes to"},{"line_number":15,"context_line":"2048-512\u003d1536."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":5,"id":"AAAAM3%2F%2FgWo%3D","line":12,"updated":"2013-01-18 04:40:02.000000000","message":"... instance[\u0027memory_mb\u0027] *and* instance[\u0027vcpus\u0027] *values are*","commit_id":"8b1c44ffbd04584f84de8975cc6819214887e312"},{"author":{"_account_id":4419,"name":"Matthew Sherborne","email":"msherborne+openstack@gmail.com","username":"msherborne+openstack"},"change_message_id":"0ab95ba804e76e7e5f2d1199fb4edcab0ad4a2e3","unresolved":false,"context_lines":[{"line_number":11,"context_line":"resizing is not \u0027finished\u0027, the in_use value in quota_usages is NOT"},{"line_number":12,"context_line":"commited(2048M), but the instance[\u0027memory_mb\u0027], instance[\u0027vcpus\u0027] is"},{"line_number":13,"context_line":"updated(512M) in _finish_resize(), so the deleting operation after updating"},{"line_number":14,"context_line":"will commit a wrong reservations(-512M), and the in_use value changes to"},{"line_number":15,"context_line":"2048-512\u003d1536."},{"line_number":16,"context_line":""},{"line_number":17,"context_line":"Fixes bug #1099729"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":5,"id":"AAAAM3%2F%2FgWs%3D","line":14,"updated":"2013-01-18 04:40:02.000000000","message":"reservation (no \u0027s\u0027 on the end).","commit_id":"8b1c44ffbd04584f84de8975cc6819214887e312"}],"nova/compute/api.py":[{"author":{"_account_id":679,"name":"Kevin L. Mitchell","email":"klmitch@mit.edu","username":"klmitch"},"change_message_id":"f57d08fb4bd29a903eed568a97c2f807fbd9cc48","unresolved":false,"context_lines":[{"line_number":954,"context_line":"                # see https://bugs.launchpad.net/nova/+bug/1099729"},{"line_number":955,"context_line":"                # for more details"},{"line_number":956,"context_line":"                if (old[\u0027task_state\u0027] in (task_states.RESIZE_MIGRATED,"},{"line_number":957,"context_line":"                                            task_states.RESIZE_FINISH)):"},{"line_number":958,"context_line":"                    get_migration \u003d \\"},{"line_number":959,"context_line":"                                self.db.migration_get_by_instance_and_status"},{"line_number":960,"context_line":"                    try:"}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAAM3%2F%2Fi58%3D","line":957,"updated":"2013-01-16 16:35:02.000000000","message":"You don\u0027t actually need the outer set of parentheses for this case.  Also, I have a slight preference that the second line be indented two spaces less, so that it lines up with the open parenthesis of the tuple.  (3 spaces if you remove the enclosing outer set of parentheses.)\n\n(femtonit)","commit_id":"cb4389157ad83e1d9cc2273f99297b5d58501f2c"},{"author":{"_account_id":679,"name":"Kevin L. Mitchell","email":"klmitch@mit.edu","username":"klmitch"},"change_message_id":"f57d08fb4bd29a903eed568a97c2f807fbd9cc48","unresolved":false,"context_lines":[{"line_number":963,"context_line":"                    except exception.MigrationNotFoundByStatus:"},{"line_number":964,"context_line":"                        migration_ref \u003d None"},{"line_number":965,"context_line":"                    if (migration_ref and"},{"line_number":966,"context_line":"                        updated[\u0027instance_type_id\u0027] \u003d\u003d"},{"line_number":967,"context_line":"                                      migration_ref[\u0027new_instance_type_id\u0027]):"},{"line_number":968,"context_line":"                        old_inst_type_id \u003d \\"},{"line_number":969,"context_line":"                                        migration_ref[\u0027old_instance_type_id\u0027]"}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAAM3%2F%2Fi54%3D","line":966,"updated":"2013-01-16 16:35:02.000000000","message":"It would be nice if this line were indented a little deeper, to differentiate it from the following code line; i.e.:\n\n    if (migration_ref and\n            updated[\u0027instance_type_id\u0027] \u003d\u003d\n                migration_ref[\u0027new_instance_type_id\u0027]):\n        old_inst_type_id \u003d migration_ref[\u0027old_instance_type_id\u0027]\n        …","commit_id":"cb4389157ad83e1d9cc2273f99297b5d58501f2c"},{"author":{"_account_id":679,"name":"Kevin L. Mitchell","email":"klmitch@mit.edu","username":"klmitch"},"change_message_id":"f57d08fb4bd29a903eed568a97c2f807fbd9cc48","unresolved":false,"context_lines":[{"line_number":969,"context_line":"                                        migration_ref[\u0027old_instance_type_id\u0027]"},{"line_number":970,"context_line":"                        try:"},{"line_number":971,"context_line":"                            old_instance_type \u003d \\"},{"line_number":972,"context_line":"                             instance_types.get_instance_type(old_inst_type_id)"},{"line_number":973,"context_line":"                        except exception.InstanceTypeNotFound:"},{"line_number":974,"context_line":"                            LOG.warning(_(\"instance type %(old_inst_type_id)d \""},{"line_number":975,"context_line":"                                       \"not found\") % locals())"}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAAM3%2F%2Fi5k%3D","line":972,"updated":"2013-01-16 16:35:02.000000000","message":"It would be nice to indent this a little deeper; I\u0027d like to see at least 4 spaces, rather than just 1.  That said, I can see you\u0027re rubbing up against the 79-character line length limit; maybe it would be worth pulling this logic out into a separate function/method?","commit_id":"cb4389157ad83e1d9cc2273f99297b5d58501f2c"},{"author":{"_account_id":679,"name":"Kevin L. Mitchell","email":"klmitch@mit.edu","username":"klmitch"},"change_message_id":"3d468eed2e8947a477378d9521a0a59861f0d8c5","unresolved":false,"context_lines":[{"line_number":1030,"context_line":"        instance_vcpus \u003d old_instance[\u0027vcpus\u0027]"},{"line_number":1031,"context_line":"        instance_memory_mb \u003d old_instance[\u0027memory_mb\u0027]"},{"line_number":1032,"context_line":"        # NOTE(wangpan): if the instance is resizing, and the resources"},{"line_number":1033,"context_line":"        #                is updated to new instance type, we should use"},{"line_number":1034,"context_line":"        #                the old instance type to create reservation."},{"line_number":1035,"context_line":"        # see https://bugs.launchpad.net/nova/+bug/1099729 for more details"},{"line_number":1036,"context_line":"        if old_instance[\u0027task_state\u0027] in (task_states.RESIZE_MIGRATED,"}],"source_content_type":"text/x-python","patch_set":4,"id":"AAAAM3%2F%2FhJk%3D","line":1033,"updated":"2013-01-17 17:03:04.000000000","message":"English nit: \"the resources are updated\" (femtonit)","commit_id":"6f4fe3e2cbc4055d6cefc28aeff946e4a163ead9"},{"author":{"_account_id":4468,"name":"Wangpan","email":"hzwangpan@corp.netease.com","username":"hzwangpan"},"change_message_id":"85a0a786eeb8ec83dc6def80e03d3c2102a80d69","unresolved":false,"context_lines":[{"line_number":1030,"context_line":"        instance_vcpus \u003d old_instance[\u0027vcpus\u0027]"},{"line_number":1031,"context_line":"        instance_memory_mb \u003d old_instance[\u0027memory_mb\u0027]"},{"line_number":1032,"context_line":"        # NOTE(wangpan): if the instance is resizing, and the resources"},{"line_number":1033,"context_line":"        #                is updated to new instance type, we should use"},{"line_number":1034,"context_line":"        #                the old instance type to create reservation."},{"line_number":1035,"context_line":"        # see https://bugs.launchpad.net/nova/+bug/1099729 for more details"},{"line_number":1036,"context_line":"        if old_instance[\u0027task_state\u0027] in (task_states.RESIZE_MIGRATED,"}],"source_content_type":"text/x-python","patch_set":4,"id":"AAAAM3%2F%2FgXw%3D","line":1033,"in_reply_to":"AAAAM3%2F%2FhJk%3D","updated":"2013-01-18 02:06:10.000000000","message":"Done","commit_id":"6f4fe3e2cbc4055d6cefc28aeff946e4a163ead9"}]}