)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"12d1673f172201fa430ae6e514bbe3217f6487c4","unresolved":false,"context_lines":[{"line_number":12,"context_line":"the instance object tests to use fake_db_instance to break it away from the api"},{"line_number":13,"context_line":"fakes module."},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"Related to bp/drop-flavor-compat"},{"line_number":16,"context_line":""},{"line_number":17,"context_line":"Change-Id: Ib790dce76394ce64e9a0faed0f51cce08d256cd5"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"ba3cc151_8b74e3ce","line":15,"updated":"2015-07-09 19:59:24.000000000","message":"This link isn\u0027t a link.","commit_id":"ed95d3a05743f5c2252537525c4c180b223bfcb3"}],"nova/tests/unit/objects/test_instance.py":[{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"630de9f688a37c3bcf11f400e1b08521641f57bd","unresolved":false,"context_lines":[{"line_number":50,"context_line":"        db_inst \u003d fake_instance.fake_db_instance(id\u003d2,"},{"line_number":51,"context_line":"                                                 access_ip_v4\u003d\u00271.2.3.4\u0027,"},{"line_number":52,"context_line":"                                                 access_ip_v6\u003d\u0027::1\u0027)"},{"line_number":53,"context_line":"        db_inst[\u0027uuid\u0027] \u003d \u002734fd7606-2ed5-42c7-ad46-76240c088801\u0027"},{"line_number":54,"context_line":"        db_inst[\u0027cell_name\u0027] \u003d \u0027api!child\u0027"},{"line_number":55,"context_line":"        db_inst[\u0027scheduled_at\u0027] \u003d None"},{"line_number":56,"context_line":"        db_inst[\u0027terminated_at\u0027] \u003d None"}],"source_content_type":"text/x-python","patch_set":3,"id":"ba3cc151_8b22a3b7","line":53,"updated":"2015-07-09 20:05:25.000000000","message":"Hrm, do we want to hard-code this?  Since the tests run in parallel I was wondering if we could have any issues with multiple tests running against the same instance uuid.  These all eventually extend from test_objects._BaseTestCase which extends TestCase, so there could be a DB slip at some point.\n\n_TestInstanceListObject doesn\u0027t do this, it just uses the random uuid that comes from fake_instance.fake_db_instance.","commit_id":"ed95d3a05743f5c2252537525c4c180b223bfcb3"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"9bc40805eafddbb9abd94b93e8b8f65b45b73bfd","unresolved":false,"context_lines":[{"line_number":50,"context_line":"        db_inst \u003d fake_instance.fake_db_instance(id\u003d2,"},{"line_number":51,"context_line":"                                                 access_ip_v4\u003d\u00271.2.3.4\u0027,"},{"line_number":52,"context_line":"                                                 access_ip_v6\u003d\u0027::1\u0027)"},{"line_number":53,"context_line":"        db_inst[\u0027uuid\u0027] \u003d \u002734fd7606-2ed5-42c7-ad46-76240c088801\u0027"},{"line_number":54,"context_line":"        db_inst[\u0027cell_name\u0027] \u003d \u0027api!child\u0027"},{"line_number":55,"context_line":"        db_inst[\u0027scheduled_at\u0027] \u003d None"},{"line_number":56,"context_line":"        db_inst[\u0027terminated_at\u0027] \u003d None"}],"source_content_type":"text/x-python","patch_set":3,"id":"3a50d1a3_4d6ac2b4","line":53,"in_reply_to":"ba3cc151_8b22a3b7","updated":"2015-07-22 14:23:09.000000000","message":"Dan pointed out that this was always hard-coded:\n\nhttp://git.openstack.org/cgit/openstack/nova/tree/nova/tests/unit/api/openstack/fakes.py#n57\n\nI was confusing fakes.stub_instance with fake_instance.fake_instance_obj which generates a random uuid.\n\nSo I\u0027m fine with this.","commit_id":"ed95d3a05743f5c2252537525c4c180b223bfcb3"},{"author":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"change_message_id":"809163f330909d9a9ccd9e1c7c77f4162394eb14","unresolved":false,"context_lines":[{"line_number":50,"context_line":"        db_inst \u003d fake_instance.fake_db_instance(id\u003d2,"},{"line_number":51,"context_line":"                                                 access_ip_v4\u003d\u00271.2.3.4\u0027,"},{"line_number":52,"context_line":"                                                 access_ip_v6\u003d\u0027::1\u0027)"},{"line_number":53,"context_line":"        db_inst[\u0027uuid\u0027] \u003d \u002734fd7606-2ed5-42c7-ad46-76240c088801\u0027"},{"line_number":54,"context_line":"        db_inst[\u0027cell_name\u0027] \u003d \u0027api!child\u0027"},{"line_number":55,"context_line":"        db_inst[\u0027scheduled_at\u0027] \u003d None"},{"line_number":56,"context_line":"        db_inst[\u0027terminated_at\u0027] \u003d None"}],"source_content_type":"text/x-python","patch_set":3,"id":"3a50d1a3_4dd0821f","line":53,"in_reply_to":"ba3cc151_8b22a3b7","updated":"2015-07-22 14:27:05.000000000","message":"This is because we were using fakes.stub_instance() which had a stable UUID. Since this is an @property, we may call this multiple times and be expected to return the same thing.\n\nWe don\u0027t need to worry about the parallel calls I don\u0027t think because if they are running, they\u0027re in separate processes (and thus separate memory DBs).","commit_id":"ed95d3a05743f5c2252537525c4c180b223bfcb3"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"630de9f688a37c3bcf11f400e1b08521641f57bd","unresolved":false,"context_lines":[{"line_number":59,"context_line":"        db_inst[\u0027updated_at\u0027] \u003d None"},{"line_number":60,"context_line":"        db_inst[\u0027launched_at\u0027] \u003d datetime.datetime(1955, 11, 12,"},{"line_number":61,"context_line":"                                                   22, 4, 0)"},{"line_number":62,"context_line":"        db_inst[\u0027deleted\u0027] \u003d False"},{"line_number":63,"context_line":"        db_inst[\u0027security_groups\u0027] \u003d []"},{"line_number":64,"context_line":"        db_inst[\u0027pci_devices\u0027] \u003d []"},{"line_number":65,"context_line":"        db_inst[\u0027user_id\u0027] \u003d self.context.user_id"}],"source_content_type":"text/x-python","patch_set":3,"id":"ba3cc151_9d5426fe","line":62,"updated":"2015-07-09 20:05:25.000000000","message":"nit: it was False before so not really an issue, but this should really probably be 0 given it\u0027s an integer in the data model:\n\nhttp://git.openstack.org/cgit/openstack/oslo.db/tree/oslo_db/sqlalchemy/models.py#n142\n\nI see it\u0027s handled correctly in _TestInstanceListObject below.","commit_id":"ed95d3a05743f5c2252537525c4c180b223bfcb3"}]}