)]}'
{"nova/virt/libvirt/driver.py":[{"author":{"_account_id":7166,"name":"Sylvain Bauza","email":"sbauza@redhat.com","username":"sbauza"},"change_message_id":"69cf9be755f0dee8f77ab687b5b6c3593bc28461","unresolved":false,"context_lines":[{"line_number":4654,"context_line":"        cpu_info[\u0027arch\u0027] \u003d caps.host.cpu.arch"},{"line_number":4655,"context_line":"        cpu_info[\u0027model\u0027] \u003d caps.host.cpu.model"},{"line_number":4656,"context_line":"        cpu_info[\u0027vendor\u0027] \u003d caps.host.cpu.vendor"},{"line_number":4657,"context_line":"        cpu_info[\u0027frequency\u0027] \u003d self._host.get_cpu_frequency()"},{"line_number":4658,"context_line":""},{"line_number":4659,"context_line":"        topology \u003d dict()"},{"line_number":4660,"context_line":"        topology[\u0027sockets\u0027] \u003d caps.host.cpu.sockets"}],"source_content_type":"text/x-python","patch_set":2,"id":"3a50d1a3_76fae244","line":4657,"updated":"2015-07-22 17:14:39.000000000","message":"Given the discussion we had in http://lists.openstack.org/pipermail/openstack-dev/2015-June/068301.html I think it\u0027s fair to add it in the cpu_info dictionary but I also think we should just remove it from the metrics in a dependent patch.\n\nAlso, you should also provide the cpu frequency within the get_capabilities() method like the other fields IMHO","commit_id":"97f1158da43a7d47a63e288234a2f389c2a85f00"},{"author":{"_account_id":1779,"name":"Daniel Berrange","email":"berrange@redhat.com","username":"berrange"},"change_message_id":"e1422dee71ca58ff8e44e425eb5de23bdc611385","unresolved":false,"context_lines":[{"line_number":4654,"context_line":"        cpu_info[\u0027arch\u0027] \u003d caps.host.cpu.arch"},{"line_number":4655,"context_line":"        cpu_info[\u0027model\u0027] \u003d caps.host.cpu.model"},{"line_number":4656,"context_line":"        cpu_info[\u0027vendor\u0027] \u003d caps.host.cpu.vendor"},{"line_number":4657,"context_line":"        cpu_info[\u0027frequency\u0027] \u003d self._host.get_cpu_frequency()"},{"line_number":4658,"context_line":""},{"line_number":4659,"context_line":"        topology \u003d dict()"},{"line_number":4660,"context_line":"        topology[\u0027sockets\u0027] \u003d caps.host.cpu.sockets"}],"source_content_type":"text/x-python","patch_set":2,"id":"1a4dcd0f_5d806546","line":4657,"in_reply_to":"3a50d1a3_76fae244","updated":"2015-08-05 09:58:45.000000000","message":"It isn\u0027t appropriate to do it in the get_capabilities() method - that method is directly returning the libvirt capabilieis XML in parsed form - the frequency is not providing by libvirt there.","commit_id":"97f1158da43a7d47a63e288234a2f389c2a85f00"}]}