)]}'
{"nova/objects/fields.py":[{"author":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"change_message_id":"43e4a72b48b213c576818a499dbb8aa08d6a3f0e","unresolved":false,"context_lines":[{"line_number":363,"context_line":"            valid_values\u003dMonitorMetricType.ALL)"},{"line_number":364,"context_line":""},{"line_number":365,"context_line":""},{"line_number":366,"context_line":"class VersionRange(fields.String):"},{"line_number":367,"context_line":"    @staticmethod"},{"line_number":368,"context_line":"    def coerce(obj, attr, value):"},{"line_number":369,"context_line":"        try:"}],"source_content_type":"text/x-python","patch_set":4,"id":"9a41bdd9_40774c9f","line":366,"updated":"2015-07-17 16:07:41.000000000","message":"We have stuff coming in o.vo soon that will make this easier, just FYI.","commit_id":"dc291d17521140d93331ceadc95e0490e5e44808"}],"nova/objects/image_meta.py":[{"author":{"_account_id":5754,"name":"Alex Xu","email":"hejie.xu@intel.com","username":"xuhj"},"change_message_id":"1f33f55cfcf86afc86cd473334c151712c6c8a52","unresolved":false,"context_lines":[{"line_number":223,"context_line":"        \u0027hw_hv_type\u0027: fields.HVTypeField(),"},{"line_number":224,"context_line":""},{"line_number":225,"context_line":"        # hypervisor supported version, eg. \u0027\u003e\u003d2.6\u0027"},{"line_number":226,"context_line":"        \u0027hw_hv_requested_version\u0027: fields.VersionRangeField(),"},{"line_number":227,"context_line":""},{"line_number":228,"context_line":"        # if true download using bittorrent"},{"line_number":229,"context_line":"        \u0027img_bittorrent\u0027: fields.FlexibleBooleanField(),"}],"source_content_type":"text/x-python","patch_set":2,"id":"9a41bdd9_51726012","line":226,"updated":"2015-07-15 01:51:11.000000000","message":"this properties, it is called as \u0027hypervisor_version_requires\u0027, there isn\u0027t \u0027hw_\u0027 prefix.\n\nSo we should mapping at _legacy_property_map?","commit_id":"c52761a7c777fc262a6b87d8b62a40d7b0b9c583"},{"author":{"_account_id":5754,"name":"Alex Xu","email":"hejie.xu@intel.com","username":"xuhj"},"change_message_id":"d0f6899d5eff1fd60e46be9da2e1c9273d08c366","unresolved":false,"context_lines":[{"line_number":223,"context_line":"        \u0027hw_hv_type\u0027: fields.HVTypeField(),"},{"line_number":224,"context_line":""},{"line_number":225,"context_line":"        # hypervisor supported version, eg. \u0027\u003e\u003d2.6\u0027"},{"line_number":226,"context_line":"        \u0027hw_hv_requested_version\u0027: fields.VersionRangeField(),"},{"line_number":227,"context_line":""},{"line_number":228,"context_line":"        # if true download using bittorrent"},{"line_number":229,"context_line":"        \u0027img_bittorrent\u0027: fields.FlexibleBooleanField(),"}],"source_content_type":"text/x-python","patch_set":3,"id":"9a41bdd9_da7600d8","line":226,"updated":"2015-07-17 08:40:14.000000000","message":"this properties, it is called as \u0027hypervisor_version_requires\u0027, original.\n\nSo we should mapping at _legacy_property_map?","commit_id":"090f565acfaf565553f00615d04f3c16546abe10"},{"author":{"_account_id":7166,"name":"Sylvain Bauza","email":"sbauza@redhat.com","username":"sbauza"},"change_message_id":"e39cf440703bdfd10700afe69b171b55275d311f","unresolved":false,"context_lines":[{"line_number":223,"context_line":"        \u0027hw_hv_type\u0027: fields.HVTypeField(),"},{"line_number":224,"context_line":""},{"line_number":225,"context_line":"        # hypervisor supported version, eg. \u0027\u003e\u003d2.6\u0027"},{"line_number":226,"context_line":"        \u0027hw_hv_requested_version\u0027: fields.VersionRangeField(),"},{"line_number":227,"context_line":""},{"line_number":228,"context_line":"        # if true download using bittorrent"},{"line_number":229,"context_line":"        \u0027img_bittorrent\u0027: fields.FlexibleBooleanField(),"}],"source_content_type":"text/x-python","patch_set":3,"id":"9a41bdd9_b32ec7a3","line":226,"in_reply_to":"9a41bdd9_da7600d8","updated":"2015-07-17 09:39:38.000000000","message":"nothing really uses that property unless the filter (as described in the commit msg), so it was missed. I don\u0027t see much value of adding the legacy key because it\u0027s not really needed since the filter is not yet using the ImageMeta object","commit_id":"090f565acfaf565553f00615d04f3c16546abe10"},{"author":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"change_message_id":"43e4a72b48b213c576818a499dbb8aa08d6a3f0e","unresolved":false,"context_lines":[{"line_number":25,"context_line":"class ImageMeta(base.NovaObject):"},{"line_number":26,"context_line":"    # Version 1.0: Initial version"},{"line_number":27,"context_line":"    # Version 1.1: updated ImageMetaProps"},{"line_number":28,"context_line":"    # Version 1.2: updated ImageMetaProps"},{"line_number":29,"context_line":"    VERSION \u003d \u00271.2\u0027"},{"line_number":30,"context_line":""},{"line_number":31,"context_line":"    # These are driven by what the image client API returns"}],"source_content_type":"text/x-python","patch_set":4,"id":"9a41bdd9_808b1468","line":28,"updated":"2015-07-17 16:07:41.000000000","message":"This should really have the child version in it, but since you\u0027re copying the previous offense and this is at the bottom of the stack I guess we can punt unless you have to respin this. But, it really needs to be documented.","commit_id":"dc291d17521140d93331ceadc95e0490e5e44808"},{"author":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"change_message_id":"43e4a72b48b213c576818a499dbb8aa08d6a3f0e","unresolved":false,"context_lines":[{"line_number":220,"context_line":"        \u0027hw_watchdog_action\u0027: fields.WatchdogActionField(),"},{"line_number":221,"context_line":""},{"line_number":222,"context_line":"        # type of the hypervisor, eg kvm, ironic, xen"},{"line_number":223,"context_line":"        \u0027hw_hv_type\u0027: fields.HVTypeField(),"},{"line_number":224,"context_line":""},{"line_number":225,"context_line":"        # hypervisor supported version, eg. \u0027\u003e\u003d2.6\u0027"},{"line_number":226,"context_line":"        \u0027hw_hv_requested_version\u0027: fields.VersionRangeField(),"}],"source_content_type":"text/x-python","patch_set":4,"id":"9a41bdd9_403aec99","line":223,"updated":"2015-07-17 16:07:41.000000000","message":"Hmm, not sure this is properly a hw_ field... Is this a flavor property?","commit_id":"dc291d17521140d93331ceadc95e0490e5e44808"},{"author":{"_account_id":1779,"name":"Daniel Berrange","email":"berrange@redhat.com","username":"berrange"},"change_message_id":"2151b7d13e970c87579a22b6069e8ff16d0b63aa","unresolved":false,"context_lines":[{"line_number":220,"context_line":"        \u0027hw_watchdog_action\u0027: fields.WatchdogActionField(),"},{"line_number":221,"context_line":""},{"line_number":222,"context_line":"        # type of the hypervisor, eg kvm, ironic, xen"},{"line_number":223,"context_line":"        \u0027hw_hv_type\u0027: fields.HVTypeField(),"},{"line_number":224,"context_line":""},{"line_number":225,"context_line":"        # hypervisor supported version, eg. \u0027\u003e\u003d2.6\u0027"},{"line_number":226,"context_line":"        \u0027hw_hv_requested_version\u0027: fields.VersionRangeField(),"}],"source_content_type":"text/x-python","patch_set":4,"id":"3a50d1a3_d841403b","line":223,"in_reply_to":"9a41bdd9_403aec99","updated":"2015-07-20 09:21:13.000000000","message":"Yeah, I guess this is really expressing a constraint for scheduling placement of the image, rather than expressing the guest hardware configuration. So from that POV it should be \u0027img_hv_type\u0027 and \u0027img_hv_requested_version\u0027","commit_id":"dc291d17521140d93331ceadc95e0490e5e44808"},{"author":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"change_message_id":"43e4a72b48b213c576818a499dbb8aa08d6a3f0e","unresolved":false,"context_lines":[{"line_number":223,"context_line":"        \u0027hw_hv_type\u0027: fields.HVTypeField(),"},{"line_number":224,"context_line":""},{"line_number":225,"context_line":"        # hypervisor supported version, eg. \u0027\u003e\u003d2.6\u0027"},{"line_number":226,"context_line":"        \u0027hw_hv_requested_version\u0027: fields.VersionRangeField(),"},{"line_number":227,"context_line":""},{"line_number":228,"context_line":"        # if true download using bittorrent"},{"line_number":229,"context_line":"        \u0027img_bittorrent\u0027: fields.FlexibleBooleanField(),"}],"source_content_type":"text/x-python","patch_set":4,"id":"9a41bdd9_0044e418","line":226,"updated":"2015-07-17 16:07:41.000000000","message":"This as well. This seems like an image property, but not hw_.","commit_id":"dc291d17521140d93331ceadc95e0490e5e44808"},{"author":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"change_message_id":"e99cba4853bcbee09771035161ab6fe12d495dcd","unresolved":false,"context_lines":[{"line_number":61,"context_line":"    obj_relationships \u003d {"},{"line_number":62,"context_line":"        \u0027properties\u0027: [(\u00271.0\u0027, \u00271.0\u0027),"},{"line_number":63,"context_line":"                       (\u00271.1\u0027, \u00271.1\u0027),"},{"line_number":64,"context_line":"                       (\u00271.2\u0027, \u00271.2\u0027)],"},{"line_number":65,"context_line":"    }"},{"line_number":66,"context_line":""},{"line_number":67,"context_line":"    @classmethod"}],"source_content_type":"text/x-python","patch_set":6,"id":"3a50d1a3_b13511db","line":64,"updated":"2015-07-21 18:29:06.000000000","message":"Can you  fix the formatting here so we don\u0027t keep having to hit both lines? So, make you 1.2 line end with a comma and put the closing bracket on the following line?","commit_id":"2bc34aa45391d52480b11ff5b1c15bed05c69b11"}]}