)]}'
{"nova/virt/xenapi/vmops.py":[{"author":{"_account_id":1030,"name":"Chris Behrens","email":"cbehrens@codestud.com","username":"cbehrens"},"change_message_id":"ebe9e3fc76103b73f418bd49cbd73d37328231a2","unresolved":false,"context_lines":[{"line_number":628,"context_line":"            _params \u003d {\u0027params\u0027: pickle.dumps(params)}"},{"line_number":629,"context_line":"            task \u003d self._session.async_call_plugin(\u0027migration\u0027,"},{"line_number":630,"context_line":"                                                   \u0027transfer_vhd\u0027,"},{"line_number":631,"context_line":"                                                   _params)"},{"line_number":632,"context_line":"            self._session.wait_for_task(task, instance_id)"},{"line_number":633,"context_line":"        except self.XenAPI.Failure:"},{"line_number":634,"context_line":"            msg \u003d _(\"Failed to transfer vhd to new host\")"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAC3%2F%2F%2Fzc%3D","side":"PARENT","line":631,"updated":"2011-12-01 06:31:01.000000000","message":"this plugin method is not modified in this patch, but needs to be.","commit_id":"a83e83ac187141e106206232dc1f0f6fcb88947e"},{"author":{"_account_id":1030,"name":"Chris Behrens","email":"cbehrens@codestud.com","username":"cbehrens"},"change_message_id":"7d0d1191d5c0573b85d903a3afc012eefc9471c4","unresolved":false,"context_lines":[{"line_number":628,"context_line":"            _params \u003d {\u0027params\u0027: pickle.dumps(params)}"},{"line_number":629,"context_line":"            task \u003d self._session.async_call_plugin(\u0027migration\u0027,"},{"line_number":630,"context_line":"                                                   \u0027transfer_vhd\u0027,"},{"line_number":631,"context_line":"                                                   _params)"},{"line_number":632,"context_line":"            self._session.wait_for_task(task, instance_id)"},{"line_number":633,"context_line":"        except self.XenAPI.Failure:"},{"line_number":634,"context_line":"            msg \u003d _(\"Failed to transfer vhd to new host\")"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAC3%2F%2F%2FzU%3D","side":"PARENT","line":631,"in_reply_to":"AAAAC3%2F%2F%2Fzc%3D","updated":"2011-12-01 06:32:48.000000000","message":"Oops... I see it.  It\u0027s late. :)","commit_id":"a83e83ac187141e106206232dc1f0f6fcb88947e"},{"author":{"_account_id":1030,"name":"Chris Behrens","email":"cbehrens@codestud.com","username":"cbehrens"},"change_message_id":"ebe9e3fc76103b73f418bd49cbd73d37328231a2","unresolved":false,"context_lines":[{"line_number":318,"context_line":""},{"line_number":319,"context_line":"    def _attach_disks(self, instance, disk_image_type, vm_ref, first_vdi_ref,"},{"line_number":320,"context_line":"            vdis):"},{"line_number":321,"context_line":"        instance_uuid \u003d instance.uuid"},{"line_number":322,"context_line":"        # device 0 reserved for RW disk"},{"line_number":323,"context_line":"        userdevice \u003d 0"},{"line_number":324,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAC3%2F%2F%2F0A%3D","line":321,"updated":"2011-12-01 06:31:01.000000000","message":"Can we use instance[\u0027uuid\u0027] instead?  I see this \u0027format\u0027 rarely used and it\u0027ll help future changes.","commit_id":"821065e875cd015044bd101552240381df3a4ce1"},{"author":{"_account_id":998,"name":"Naveed Massjouni","email":"naveedm9@gmail.com","username":"ironcamel"},"change_message_id":"84daeed3985fd65dede257940fe17c6655b9d30a","unresolved":false,"context_lines":[{"line_number":318,"context_line":""},{"line_number":319,"context_line":"    def _attach_disks(self, instance, disk_image_type, vm_ref, first_vdi_ref,"},{"line_number":320,"context_line":"            vdis):"},{"line_number":321,"context_line":"        instance_uuid \u003d instance.uuid"},{"line_number":322,"context_line":"        # device 0 reserved for RW disk"},{"line_number":323,"context_line":"        userdevice \u003d 0"},{"line_number":324,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAC3%2F%2F%2FvU%3D","line":321,"in_reply_to":"AAAAC3%2F%2F%2F0A%3D","updated":"2011-12-01 17:26:57.000000000","message":"instance_uuid is all over the place with recent changes that have been merged in. Take a look at nova/compute/manager.py on a fresh master branch for example. Though I have no problem using instance[\u0027uuid\u0027].","commit_id":"821065e875cd015044bd101552240381df3a4ce1"},{"author":{"_account_id":998,"name":"Naveed Massjouni","email":"naveedm9@gmail.com","username":"ironcamel"},"change_message_id":"135798b04fc423bf34c58f56c3a5c9ecabdd595e","unresolved":false,"context_lines":[{"line_number":318,"context_line":""},{"line_number":319,"context_line":"    def _attach_disks(self, instance, disk_image_type, vm_ref, first_vdi_ref,"},{"line_number":320,"context_line":"            vdis):"},{"line_number":321,"context_line":"        instance_uuid \u003d instance.uuid"},{"line_number":322,"context_line":"        # device 0 reserved for RW disk"},{"line_number":323,"context_line":"        userdevice \u003d 0"},{"line_number":324,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAC3%2F%2F%2Fu0%3D","line":321,"in_reply_to":"AAAAC3%2F%2F%2FvU%3D","updated":"2011-12-01 17:56:02.000000000","message":"Oops, I thought you were taking issue with the name instance_uuid. I see now that you don\u0027t like the . operator. Got it.","commit_id":"821065e875cd015044bd101552240381df3a4ce1"},{"author":{"_account_id":1030,"name":"Chris Behrens","email":"cbehrens@codestud.com","username":"cbehrens"},"change_message_id":"ebe9e3fc76103b73f418bd49cbd73d37328231a2","unresolved":false,"context_lines":[{"line_number":910,"context_line":"                    \"skipping shutdown...\") % locals())"},{"line_number":911,"context_line":"            return"},{"line_number":912,"context_line":""},{"line_number":913,"context_line":"        instance_uuid \u003d instance.uuid"},{"line_number":914,"context_line":"        LOG.debug(_(\"Shutting down VM for Instance %(instance_uuid)s\")"},{"line_number":915,"context_line":"                  % locals())"},{"line_number":916,"context_line":"        try:"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAC3%2F%2F%2Fz8%3D","line":913,"updated":"2011-12-01 06:31:01.000000000","message":"same as above.","commit_id":"821065e875cd015044bd101552240381df3a4ce1"},{"author":{"_account_id":1030,"name":"Chris Behrens","email":"cbehrens@codestud.com","username":"cbehrens"},"change_message_id":"ebe9e3fc76103b73f418bd49cbd73d37328231a2","unresolved":false,"context_lines":[{"line_number":942,"context_line":""},{"line_number":943,"context_line":"    def _destroy_vdis(self, instance, vm_ref):"},{"line_number":944,"context_line":"        \"\"\"Destroys all VDIs associated with a VM.\"\"\""},{"line_number":945,"context_line":"        instance_uuid \u003d instance.uuid"},{"line_number":946,"context_line":"        LOG.debug(_(\"Destroying VDIs for Instance %(instance_uuid)s\")"},{"line_number":947,"context_line":"                  % locals())"},{"line_number":948,"context_line":"        vdi_refs \u003d VMHelper.lookup_vm_vdis(self._session, vm_ref)"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAC3%2F%2F%2Fz4%3D","line":945,"updated":"2011-12-01 06:31:01.000000000","message":"same.","commit_id":"821065e875cd015044bd101552240381df3a4ce1"},{"author":{"_account_id":1030,"name":"Chris Behrens","email":"cbehrens@codestud.com","username":"cbehrens"},"change_message_id":"ebe9e3fc76103b73f418bd49cbd73d37328231a2","unresolved":false,"context_lines":[{"line_number":998,"context_line":"               and the ramdisk."},{"line_number":999,"context_line":""},{"line_number":1000,"context_line":"        \"\"\""},{"line_number":1001,"context_line":"        instance_uuid \u003d instance.uuid"},{"line_number":1002,"context_line":"        if not instance.kernel_id and not instance.ramdisk_id:"},{"line_number":1003,"context_line":"            # 1. No kernel or ramdisk"},{"line_number":1004,"context_line":"            LOG.debug(_(\"Instance %(instance_uuid)s using RAW or VHD, \""}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAC3%2F%2F%2Fz0%3D","line":1001,"updated":"2011-12-01 06:31:01.000000000","message":"same.","commit_id":"821065e875cd015044bd101552240381df3a4ce1"},{"author":{"_account_id":1030,"name":"Chris Behrens","email":"cbehrens@codestud.com","username":"cbehrens"},"change_message_id":"ebe9e3fc76103b73f418bd49cbd73d37328231a2","unresolved":false,"context_lines":[{"line_number":1020,"context_line":"    def _destroy_vm(self, instance, vm_ref):"},{"line_number":1021,"context_line":"        \"\"\"Destroys a VM record.\"\"\""},{"line_number":1022,"context_line":"        instance_id \u003d instance.id"},{"line_number":1023,"context_line":"        instance_uuid \u003d instance.uuid"},{"line_number":1024,"context_line":"        try:"},{"line_number":1025,"context_line":"            task \u003d self._session.call_xenapi(\u0027Async.VM.destroy\u0027, vm_ref)"},{"line_number":1026,"context_line":"            self._session.wait_for_task(task, instance_id)"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAC3%2F%2F%2Fzw%3D","line":1023,"updated":"2011-12-01 06:31:01.000000000","message":"same.","commit_id":"821065e875cd015044bd101552240381df3a4ce1"},{"author":{"_account_id":1030,"name":"Chris Behrens","email":"cbehrens@codestud.com","username":"cbehrens"},"change_message_id":"ebe9e3fc76103b73f418bd49cbd73d37328231a2","unresolved":false,"context_lines":[{"line_number":1044,"context_line":"        destroy_* methods are internal."},{"line_number":1045,"context_line":""},{"line_number":1046,"context_line":"        \"\"\""},{"line_number":1047,"context_line":"        instance_uuid \u003d instance.uuid"},{"line_number":1048,"context_line":"        LOG.info(_(\"Destroying VM for Instance %(instance_uuid)s\") % locals())"},{"line_number":1049,"context_line":"        vm_ref \u003d VMHelper.lookup(self._session, instance.name)"},{"line_number":1050,"context_line":"        return self._destroy(instance, vm_ref, network_info, shutdown\u003dTrue)"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAC3%2F%2F%2Fzs%3D","line":1047,"updated":"2011-12-01 06:31:01.000000000","message":"same.","commit_id":"821065e875cd015044bd101552240381df3a4ce1"},{"author":{"_account_id":1030,"name":"Chris Behrens","email":"cbehrens@codestud.com","username":"cbehrens"},"change_message_id":"ebe9e3fc76103b73f418bd49cbd73d37328231a2","unresolved":false,"context_lines":[{"line_number":1136,"context_line":"                                        \"%s-rescue\" % instance.name)"},{"line_number":1137,"context_line":""},{"line_number":1138,"context_line":"        if not rescue_vm_ref:"},{"line_number":1139,"context_line":"            raise exception.InstanceNotInRescueMode(instance_id\u003dinstance.uuid)"},{"line_number":1140,"context_line":""},{"line_number":1141,"context_line":"        original_vm_ref \u003d VMHelper.lookup(self._session, instance.name)"},{"line_number":1142,"context_line":"        instance._rescue \u003d False"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAC3%2F%2F%2Fzo%3D","line":1139,"updated":"2011-12-01 06:31:01.000000000","message":"same.","commit_id":"821065e875cd015044bd101552240381df3a4ce1"},{"author":{"_account_id":1030,"name":"Chris Behrens","email":"cbehrens@codestud.com","username":"cbehrens"},"change_message_id":"ebe9e3fc76103b73f418bd49cbd73d37328231a2","unresolved":false,"context_lines":[{"line_number":1468,"context_line":"        try:"},{"line_number":1469,"context_line":"            return json.loads(ret)"},{"line_number":1470,"context_line":"        except TypeError:"},{"line_number":1471,"context_line":"            instance_uuid \u003d vm.uuid"},{"line_number":1472,"context_line":"            LOG.error(_(\u0027The agent call to %(method)s returned an invalid\u0027"},{"line_number":1473,"context_line":"                      \u0027 response: %(ret)r. VM id\u003d%(instance_uuid)s;\u0027"},{"line_number":1474,"context_line":"                      \u0027 path\u003d%(path)s; args\u003d%(addl_args)r\u0027) % locals())"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAC3%2F%2F%2Fzk%3D","line":1471,"updated":"2011-12-01 06:31:01.000000000","message":"same.  also feels like \u0027vm\u0027 should be \u0027instance\u0027 as that\u0027s what it is here... but I realize you didn\u0027t name this argument. :)","commit_id":"821065e875cd015044bd101552240381df3a4ce1"},{"author":{"_account_id":1030,"name":"Chris Behrens","email":"cbehrens@codestud.com","username":"cbehrens"},"change_message_id":"ebe9e3fc76103b73f418bd49cbd73d37328231a2","unresolved":false,"context_lines":[{"line_number":1482,"context_line":"        Any errors raised by the plugin will in turn raise a RuntimeError here."},{"line_number":1483,"context_line":"        \"\"\""},{"line_number":1484,"context_line":"        instance_id \u003d vm.id"},{"line_number":1485,"context_line":"        instance_uuid \u003d vm.uuid"},{"line_number":1486,"context_line":"        vm_ref \u003d vm_ref or self._get_vm_opaque_ref(vm)"},{"line_number":1487,"context_line":"        vm_rec \u003d self._session.call_xenapi(\"VM.get_record\", vm_ref)"},{"line_number":1488,"context_line":"        args \u003d {\u0027dom_id\u0027: vm_rec[\u0027domid\u0027], \u0027path\u0027: path}"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAC3%2F%2F%2Fzg%3D","line":1485,"updated":"2011-12-01 06:31:01.000000000","message":"same.","commit_id":"821065e875cd015044bd101552240381df3a4ce1"}],"plugins/xenserver/xenapi/etc/xapi.d/plugins/migration":[{"author":{"_account_id":177,"name":"Alex Meade","email":"mr.alex.meade@gmail.com","username":"alex-meade"},"change_message_id":"18cf8b36f2f9b076b0cf70c8ad871ec47278fa57","unresolved":false,"context_lines":[{"line_number":48,"context_line":""},{"line_number":49,"context_line":"    # Discover the copied VHDs locally, and then set up paths to copy"},{"line_number":50,"context_line":"    # them to under the SR"},{"line_number":51,"context_line":"    source_image_path \u003d \"/images/instance%d\" % instance_uuid"},{"line_number":52,"context_line":"    source_base_copy_path \u003d \"%s/%s.vhd\" % (source_image_path,"},{"line_number":53,"context_line":"            old_base_copy_uuid)"},{"line_number":54,"context_line":"    source_cow_path \u003d \"%s/%s.vhd\" % (source_image_path, old_cow_uuid)"}],"source_content_type":"application/octet-stream","patch_set":2,"id":"AAAAC3%2F%2F%2Fpg%3D","line":51,"updated":"2011-12-02 00:16:03.000000000","message":"hey, %d is for integer values.","commit_id":"a286269c8521d58f427f8b0f0895abc32e099020"},{"author":{"_account_id":177,"name":"Alex Meade","email":"mr.alex.meade@gmail.com","username":"alex-meade"},"change_message_id":"18cf8b36f2f9b076b0cf70c8ad871ec47278fa57","unresolved":false,"context_lines":[{"line_number":53,"context_line":"            old_base_copy_uuid)"},{"line_number":54,"context_line":"    source_cow_path \u003d \"%s/%s.vhd\" % (source_image_path, old_cow_uuid)"},{"line_number":55,"context_line":""},{"line_number":56,"context_line":"    temp_vhd_path \u003d \"%s/instance%d/\" % (sr_temp_path, instance_uuid)"},{"line_number":57,"context_line":"    new_base_copy_path \u003d \"%s/%s.vhd\" % (temp_vhd_path, new_base_copy_uuid)"},{"line_number":58,"context_line":"    new_cow_path \u003d \"%s/%s.vhd\" % (temp_vhd_path, new_cow_uuid)"},{"line_number":59,"context_line":""}],"source_content_type":"application/octet-stream","patch_set":2,"id":"AAAAC3%2F%2F%2Fpc%3D","line":56,"updated":"2011-12-02 00:16:03.000000000","message":"same as above","commit_id":"a286269c8521d58f427f8b0f0895abc32e099020"},{"author":{"_account_id":177,"name":"Alex Meade","email":"mr.alex.meade@gmail.com","username":"alex-meade"},"change_message_id":"18cf8b36f2f9b076b0cf70c8ad871ec47278fa57","unresolved":false,"context_lines":[{"line_number":96,"context_line":"    vhd_path \u003d \"%s.vhd\" % vdi_uuid"},{"line_number":97,"context_line":""},{"line_number":98,"context_line":"    source_path \u003d \"%s/%s\" % (sr_path, vhd_path)"},{"line_number":99,"context_line":"    dest_path \u003d \u0027%s:/images/instance%d/\u0027 % (host, instance_uuid)"},{"line_number":100,"context_line":""},{"line_number":101,"context_line":"    logging.debug(\"Preparing to transmit %s to %s\" % (source_path,"},{"line_number":102,"context_line":"            dest_path))"}],"source_content_type":"application/octet-stream","patch_set":2,"id":"AAAAC3%2F%2F%2FpY%3D","line":99,"updated":"2011-12-02 00:16:03.000000000","message":"%d","commit_id":"a286269c8521d58f427f8b0f0895abc32e099020"}]}