)]}'
{"id":"openstack%2Fnova~1982","triplet_id":"openstack%2Fnova~master~I8402da86345e786a46a4d222ad4d8a4449d2bd3f","project":"openstack/nova","branch":"master","topic":"bug/898290","hashtags":[],"change_id":"I8402da86345e786a46a4d222ad4d8a4449d2bd3f","subject":"Bug #898290: iSCSI volume backend treats FLAGS.host as a hostname","status":"MERGED","created":"2011-11-30 18:55:46.000000000","updated":"2011-12-05 14:37:30.000000000","submitted":"2011-12-05 14:37:30.000000000","submitter":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"total_comment_count":1,"unresolved_comment_count":0,"has_review_started":true,"meta_rev_id":"96126f8e5f5315fa43e80d378bf8360928e4f6e0","_number":1982,"virtual_id_number":1982,"owner":{"_account_id":271,"name":"Ewan Mellor","email":"ewan.mellor@citrix.com","username":"ewanmellor"},"actions":{},"labels":{"Verified":{"recommended":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"all":[{"value":0,"_account_id":271,"name":"Ewan Mellor","email":"ewan.mellor@citrix.com","username":"ewanmellor"},{"value":0,"_account_id":335,"name":"Paul Voccio","email":"paul@substation9.com","username":"pvo"},{"value":0,"_account_id":100,"name":"Johannes Erdfelt","email":"johannes@erdfelt.com","username":"johannes.erdfelt"},{"value":0,"_account_id":838,"name":"Nirmal Ranganathan","email":"rnirmal@gmail.com","username":"rnirmal"},{"value":0,"_account_id":736,"name":"Vladimir Popovski","email":"vladimir@zadarastorage.com","username":"vladimir.p"},{"value":0,"_account_id":67,"name":"Vish Ishaya","email":"vishvananda@gmail.com","username":"vishvananda"},{"value":1,"date":"2011-12-05 14:37:25.000000000","_account_id":3,"name":"Jenkins","username":"jenkins"}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","value":1,"default_value":0,"optional":true},"Code-Review":{"approved":{"_account_id":335,"name":"Paul Voccio","email":"paul@substation9.com","username":"pvo"},"all":[{"value":0,"date":"2011-11-30 21:17:28.000000000","permitted_voting_range":{"min":0,"max":1},"_account_id":271,"name":"Ewan Mellor","email":"ewan.mellor@citrix.com","username":"ewanmellor"},{"value":2,"date":"2011-12-05 14:28:39.000000000","_account_id":335,"name":"Paul Voccio","email":"paul@substation9.com","username":"pvo"},{"value":1,"date":"2011-12-02 17:54:02.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":100,"name":"Johannes Erdfelt","email":"johannes@erdfelt.com","username":"johannes.erdfelt"},{"value":1,"date":"2011-12-02 20:46:37.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":838,"name":"Nirmal Ranganathan","email":"rnirmal@gmail.com","username":"rnirmal"},{"value":1,"date":"2011-12-01 18:30:10.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":736,"name":"Vladimir Popovski","email":"vladimir@zadarastorage.com","username":"vladimir.p"},{"value":0,"_account_id":67,"name":"Vish Ishaya","email":"vishvananda@gmail.com","username":"vishvananda"},{"value":0,"date":"2011-12-05 14:37:25.000000000","permitted_voting_range":{"min":0,"max":1},"_account_id":3,"name":"Jenkins","username":"jenkins"}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","default_value":0,"optional":true},"Workflow":{"all":[{"value":0,"_account_id":271,"name":"Ewan Mellor","email":"ewan.mellor@citrix.com","username":"ewanmellor"},{"value":0,"_account_id":335,"name":"Paul Voccio","email":"paul@substation9.com","username":"pvo"},{"value":0,"_account_id":100,"name":"Johannes Erdfelt","email":"johannes@erdfelt.com","username":"johannes.erdfelt"},{"value":0,"_account_id":838,"name":"Nirmal Ranganathan","email":"rnirmal@gmail.com","username":"rnirmal"},{"value":0,"_account_id":736,"name":"Vladimir Popovski","email":"vladimir@zadarastorage.com","username":"vladimir.p"},{"value":0,"_account_id":67,"name":"Vish Ishaya","email":"vishvananda@gmail.com","username":"vishvananda"},{"value":0,"_account_id":3,"name":"Jenkins","username":"jenkins"}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true},"Review-Priority":{"all":[{"value":0,"_account_id":271,"name":"Ewan Mellor","email":"ewan.mellor@citrix.com","username":"ewanmellor"},{"value":0,"_account_id":335,"name":"Paul Voccio","email":"paul@substation9.com","username":"pvo"},{"value":0,"_account_id":100,"name":"Johannes Erdfelt","email":"johannes@erdfelt.com","username":"johannes.erdfelt"},{"value":0,"_account_id":838,"name":"Nirmal Ranganathan","email":"rnirmal@gmail.com","username":"rnirmal"},{"value":0,"_account_id":736,"name":"Vladimir Popovski","email":"vladimir@zadarastorage.com","username":"vladimir.p"},{"value":0,"_account_id":67,"name":"Vish Ishaya","email":"vishvananda@gmail.com","username":"vishvananda"},{"value":0,"_account_id":3,"name":"Jenkins","username":"jenkins"}],"values":{" 0":"Default Priority","+1":"Contributor Review Promise","+2":"Core Review Promise"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":3,"name":"Jenkins","username":"jenkins"},{"_account_id":67,"name":"Vish Ishaya","email":"vishvananda@gmail.com","username":"vishvananda"},{"_account_id":100,"name":"Johannes Erdfelt","email":"johannes@erdfelt.com","username":"johannes.erdfelt"},{"_account_id":271,"name":"Ewan Mellor","email":"ewan.mellor@citrix.com","username":"ewanmellor"},{"_account_id":335,"name":"Paul Voccio","email":"paul@substation9.com","username":"pvo"},{"_account_id":736,"name":"Vladimir Popovski","email":"vladimir@zadarastorage.com","username":"vladimir.p"},{"_account_id":838,"name":"Nirmal Ranganathan","email":"rnirmal@gmail.com","username":"rnirmal"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2011-11-30 19:55:15.000000000","updated_by":{"_account_id":67,"name":"Vish Ishaya","email":"vishvananda@gmail.com","username":"vishvananda"},"reviewer":{"_account_id":67,"name":"Vish Ishaya","email":"vishvananda@gmail.com","username":"vishvananda"},"state":"REVIEWER"},{"updated":"2011-12-01 18:30:10.000000000","updated_by":{"_account_id":736,"name":"Vladimir Popovski","email":"vladimir@zadarastorage.com","username":"vladimir.p"},"reviewer":{"_account_id":736,"name":"Vladimir Popovski","email":"vladimir@zadarastorage.com","username":"vladimir.p"},"state":"REVIEWER"},{"updated":"2011-12-02 17:54:02.000000000","updated_by":{"_account_id":100,"name":"Johannes Erdfelt","email":"johannes@erdfelt.com","username":"johannes.erdfelt"},"reviewer":{"_account_id":100,"name":"Johannes Erdfelt","email":"johannes@erdfelt.com","username":"johannes.erdfelt"},"state":"REVIEWER"},{"updated":"2011-12-02 20:46:37.000000000","updated_by":{"_account_id":838,"name":"Nirmal Ranganathan","email":"rnirmal@gmail.com","username":"rnirmal"},"reviewer":{"_account_id":838,"name":"Nirmal Ranganathan","email":"rnirmal@gmail.com","username":"rnirmal"},"state":"REVIEWER"},{"updated":"2011-12-05 14:28:39.000000000","updated_by":{"_account_id":335,"name":"Paul Voccio","email":"paul@substation9.com","username":"pvo"},"reviewer":{"_account_id":335,"name":"Paul Voccio","email":"paul@substation9.com","username":"pvo"},"state":"REVIEWER"},{"updated":"2011-12-05 14:37:25.000000000","updated_by":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"reviewer":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"state":"REVIEWER"}],"messages":[{"id":"4442efdc70bb4e9a9c2cad6a73e7bb7e6f068a04","author":{"_account_id":271,"name":"Ewan Mellor","email":"ewan.mellor@citrix.com","username":"ewanmellor"},"date":"2011-11-30 19:10:13.000000000","message":"Uploaded patch set 2.","accounts_in_message":[],"_revision_number":2},{"id":"95edbb29a20aaaf4ea0f39eb8a0fd14be7ead703","author":{"_account_id":271,"name":"Ewan Mellor","email":"ewan.mellor@citrix.com","username":"ewanmellor"},"date":"2011-11-30 19:21:42.000000000","message":"Patch Set 2: Abandoned\n\nThis is not yet ready for review.  The change from Diablo to Essex of --iscsi_ip_prefix to --iscsi_ip_address needs discussing.","accounts_in_message":[],"_revision_number":2},{"id":"f99fa38c48e8c7e358057ba598ea51fe17bbf918","author":{"_account_id":271,"name":"Ewan Mellor","email":"ewan.mellor@citrix.com","username":"ewanmellor"},"date":"2011-11-30 19:43:55.000000000","message":"Patch Set 2: Restored\n\nDecided to use --iscsi_ip_address, which makes this changeset half the size.","accounts_in_message":[],"_revision_number":2},{"id":"281796af8a9700e6bbd29c10bb3d3698adf79568","author":{"_account_id":271,"name":"Ewan Mellor","email":"ewan.mellor@citrix.com","username":"ewanmellor"},"date":"2011-11-30 19:44:05.000000000","message":"Uploaded patch set 3.","accounts_in_message":[],"_revision_number":3},{"id":"830b1e99e10c2793ccbd811dac4b96619b1b5e25","author":{"_account_id":67,"name":"Vish Ishaya","email":"vishvananda@gmail.com","username":"vishvananda"},"date":"2011-11-30 19:55:15.000000000","message":"Patch Set 3: (1 inline comment)\n\nNice Fix!\n\nI thought a lot of the pre-work was already in.  Might be nice to have a subsequent patch that pulls out the discover volume code as i don\u0027t think we need it after the patch goes in.\n\nJust an inline question before I +1","accounts_in_message":[],"_revision_number":3},{"id":"26c60177ea2d073a93e8d8acea937d2154e5ea16","author":{"_account_id":271,"name":"Ewan Mellor","email":"ewan.mellor@citrix.com","username":"ewanmellor"},"date":"2011-11-30 21:15:57.000000000","message":"Uploaded patch set 4.","accounts_in_message":[],"_revision_number":4},{"id":"7384dd2d03e7ea5c7ee6a20b8a72a9f6c1ab003f","author":{"_account_id":271,"name":"Ewan Mellor","email":"ewan.mellor@citrix.com","username":"ewanmellor"},"date":"2011-11-30 21:17:28.000000000","message":"Patch Set 4:\n\nPatchset 4 has the iSCSI port as a flag, not a constant.  No other changes.\n\nI decided not to put this flag in iscsi.py after all, because there are lots of other iSCSI-specific flags in driver.py (notably --iscsi_ip_address).","accounts_in_message":[],"_revision_number":4},{"id":"1d4b8abcaae1430ce7fc63ddfb5362c739350be0","author":{"_account_id":736,"name":"Vladimir Popovski","email":"vladimir@zadarastorage.com","username":"vladimir.p"},"date":"2011-12-01 18:30:10.000000000","message":"Patch Set 4: Looks good to me, but someone else must approve\n\nfine with me","accounts_in_message":[],"_revision_number":4},{"id":"329759128897eedffada8ad5efe7bda4cb56ff1f","author":{"_account_id":100,"name":"Johannes Erdfelt","email":"johannes@erdfelt.com","username":"johannes.erdfelt"},"date":"2011-12-02 17:54:02.000000000","message":"Patch Set 4: Looks good to me, but someone else must approve\n\n","accounts_in_message":[],"_revision_number":4},{"id":"7036c27d0c564590682041f51c138d04baaca665","author":{"_account_id":838,"name":"Nirmal Ranganathan","email":"rnirmal@gmail.com","username":"rnirmal"},"date":"2011-12-02 20:46:37.000000000","message":"Patch Set 4: Looks good to me, but someone else must approve\n\n","accounts_in_message":[],"_revision_number":4},{"id":"73525097aecba068f5949fcbf134c20926a7c4c7","author":{"_account_id":335,"name":"Paul Voccio","email":"paul@substation9.com","username":"pvo"},"date":"2011-12-05 14:28:39.000000000","message":"Patch Set 4: Looks good to me, approved\n\n","accounts_in_message":[],"_revision_number":4},{"id":"7e8711aff1ad44c9e447b50e5fd307e62d2a4e9c","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2011-12-05 14:37:25.000000000","message":"Patch Set 4: Verified\n\nBuild Successful \n \nhttps://jenkins.openstack.org/job/gate-nova-unittests/146/ : SUCCESS \nhttps://jenkins.openstack.org/job/gate-nova-merge/541/ : SUCCESS \nhttps://jenkins.openstack.org/job/gate-nova-pep8/1916/ : SUCCESS","accounts_in_message":[],"_revision_number":4},{"id":"733e92a26c64f46c09245c70fb51103098750003","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2011-12-05 14:37:30.000000000","message":"Change has been successfully merged into the git repository.","accounts_in_message":[],"_revision_number":4}],"current_revision_number":4,"current_revision":"f6c74d6563e48df6a8a7ff09a27d812840f23d02","revisions":{"8c69bd1941d4c312ffb41ba926a54abbd901a4e4":{"kind":"REWORK","_number":1,"created":"2011-11-30 18:55:46.000000000","uploader":{"_account_id":271,"name":"Ewan Mellor","email":"ewan.mellor@citrix.com","username":"ewanmellor"},"ref":"refs/changes/82/1982/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/nova","ref":"refs/changes/82/1982/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/nova refs/changes/82/1982/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/nova refs/changes/82/1982/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/nova refs/changes/82/1982/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/nova refs/changes/82/1982/1"}}},"commit":{"parents":[{"commit":"b19b986a980304aa4cf9d916d81e0a2fff5007b3","subject":"Convert compute manager delete methods to objects","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/nova/commit/b19b986a980304aa4cf9d916d81e0a2fff5007b3"}]}],"author":{"name":"Ewan Mellor","email":"ewan.mellor@citrix.com","date":"2011-11-30 18:34:42.000000000","tz":-480},"committer":{"name":"Ewan Mellor","email":"ewan.mellor@citrix.com","date":"2011-11-30 18:38:21.000000000","tz":-480},"subject":"Bug #898290: iSCSI volume backend treats FLAGS.host as a hostname","message":"Bug #898290: iSCSI volume backend treats FLAGS.host as a hostname\n\nChange ISCSIDriver to set volume.provider_location during create_export.\nThis records the location of the LUN, so that nova-compute does not need\nto run the iSCSI discovery code itself.\n\nAs part of this, include the IP address of the target in the provider_location.\nThis IP address is carefully selected to be the one on the correct network,\ni.e. matching --iscsi_ip_prefix.  This means that we don\u0027t use volume\u0027s\nhost identifier (which could be an opaque ID) when trying to connect to the\niSCSI target -- we use the correct IP address instead.\n\nThe string-join to set provider_location is shared with ZadaraBEDriver,\nwhich was doing something similar.  I\u0027ve brought that into a helper function.\n\nThis change includes whataremyips(), taken from swift.common.utils.\nThis adds a dependency on netifaces.\n\nThe docstring for the --host flag has been clarified.\nChange-Id: I8402da86345e786a46a4d222ad4d8a4449d2bd3f\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/nova/commit/8c69bd1941d4c312ffb41ba926a54abbd901a4e4"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/nova/commit/8c69bd1941d4c312ffb41ba926a54abbd901a4e4"}]},"parents_data":[{"branch_name":"refs/heads/master","commit_id":"b19b986a980304aa4cf9d916d81e0a2fff5007b3","is_merged_in_target_branch":true,"change_id":"I781995b95fd3fb794ad5d775e1e5822a82db9fb1","change_number":1928,"patch_set_number":6,"change_status":"MERGED"}],"branch":"refs/heads/master"},"3e99f68aaab24285cd6b713f7534435c20ba4e91":{"kind":"REWORK","_number":2,"created":"2011-11-30 19:10:13.000000000","uploader":{"_account_id":271,"name":"Ewan Mellor","email":"ewan.mellor@citrix.com","username":"ewanmellor"},"ref":"refs/changes/82/1982/2","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/nova","ref":"refs/changes/82/1982/2","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/nova refs/changes/82/1982/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/nova refs/changes/82/1982/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/nova refs/changes/82/1982/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/nova refs/changes/82/1982/2"}}},"commit":{"parents":[{"commit":"b19b986a980304aa4cf9d916d81e0a2fff5007b3","subject":"Convert compute manager delete methods to objects","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/nova/commit/b19b986a980304aa4cf9d916d81e0a2fff5007b3"}]}],"author":{"name":"Ewan Mellor","email":"ewan.mellor@citrix.com","date":"2011-11-30 18:34:42.000000000","tz":-480},"committer":{"name":"Ewan Mellor","email":"ewan.mellor@citrix.com","date":"2011-11-30 19:15:25.000000000","tz":-480},"subject":"Bug #898290: iSCSI volume backend treats FLAGS.host as a hostname","message":"Bug #898290: iSCSI volume backend treats FLAGS.host as a hostname\n\nChange ISCSIDriver to set volume.provider_location during create_export.\nThis records the location of the LUN, so that nova-compute does not need\nto run the iSCSI discovery code itself.\n\nAs part of this, include the IP address of the target in the provider_location.\nThis IP address is carefully selected to be the one on the correct network,\ni.e. matching --iscsi_ip_prefix.  This means that we don\u0027t use volume\u0027s\nhost identifier (which could be an opaque ID) when trying to connect to the\niSCSI target -- we use the correct IP address instead.\n\nThe string-join to set provider_location is shared with ZadaraBEDriver,\nwhich was doing something similar.  I\u0027ve brought that into a helper function.\n\nThis change includes whataremyips(), taken from swift.common.utils.\nThis adds a dependency on netifaces.\n\nThe docstring for the --host flag has been clarified.\n\nChange-Id: I8402da86345e786a46a4d222ad4d8a4449d2bd3f\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/nova/commit/3e99f68aaab24285cd6b713f7534435c20ba4e91"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/nova/commit/3e99f68aaab24285cd6b713f7534435c20ba4e91"}]},"parents_data":[{"branch_name":"refs/heads/master","commit_id":"b19b986a980304aa4cf9d916d81e0a2fff5007b3","is_merged_in_target_branch":true,"change_id":"I781995b95fd3fb794ad5d775e1e5822a82db9fb1","change_number":1928,"patch_set_number":6,"change_status":"MERGED"}],"branch":"refs/heads/master"},"68dd9e959a052ba247fb88370334e2416d932cb2":{"kind":"REWORK","_number":3,"created":"2011-11-30 19:44:05.000000000","uploader":{"_account_id":271,"name":"Ewan Mellor","email":"ewan.mellor@citrix.com","username":"ewanmellor"},"ref":"refs/changes/82/1982/3","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/nova","ref":"refs/changes/82/1982/3","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/nova refs/changes/82/1982/3 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/nova refs/changes/82/1982/3 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/nova refs/changes/82/1982/3 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/nova refs/changes/82/1982/3"}}},"commit":{"parents":[{"commit":"b19b986a980304aa4cf9d916d81e0a2fff5007b3","subject":"Convert compute manager delete methods to objects","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/nova/commit/b19b986a980304aa4cf9d916d81e0a2fff5007b3"}]}],"author":{"name":"Ewan Mellor","email":"ewan.mellor@citrix.com","date":"2011-11-30 18:34:42.000000000","tz":-480},"committer":{"name":"Ewan Mellor","email":"ewan.mellor@citrix.com","date":"2011-11-30 19:45:57.000000000","tz":-480},"subject":"Bug #898290: iSCSI volume backend treats FLAGS.host as a hostname","message":"Bug #898290: iSCSI volume backend treats FLAGS.host as a hostname\n\nChange ISCSIDriver to set volume.provider_location during create_export.\nThis records the location of the LUN, so that nova-compute does not need\nto run the iSCSI discovery code itself.\n\nAs part of this, include the IP address of the target (--iscsi_ip_address) in\nthe provider_location.  This means that we don\u0027t use volume\u0027s host identifier\n(which could be an opaque ID) when trying to connect to the iSCSI target --\nwe use the admin-specified IP address instead.\n\nThe string-join to set provider_location is shared with ZadaraBEDriver,\nwhich was doing something similar.  I\u0027ve brought that into a helper function.\n\nThe docstring for the --host flag has been clarified.\n\nChange-Id: I8402da86345e786a46a4d222ad4d8a4449d2bd3f\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/nova/commit/68dd9e959a052ba247fb88370334e2416d932cb2"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/nova/commit/68dd9e959a052ba247fb88370334e2416d932cb2"}]},"parents_data":[{"branch_name":"refs/heads/master","commit_id":"b19b986a980304aa4cf9d916d81e0a2fff5007b3","is_merged_in_target_branch":true,"change_id":"I781995b95fd3fb794ad5d775e1e5822a82db9fb1","change_number":1928,"patch_set_number":6,"change_status":"MERGED"}],"branch":"refs/heads/master"},"f6c74d6563e48df6a8a7ff09a27d812840f23d02":{"kind":"REWORK","_number":4,"created":"2011-11-30 21:15:57.000000000","uploader":{"_account_id":271,"name":"Ewan Mellor","email":"ewan.mellor@citrix.com","username":"ewanmellor"},"ref":"refs/changes/82/1982/4","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/nova","ref":"refs/changes/82/1982/4","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/nova refs/changes/82/1982/4 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/nova refs/changes/82/1982/4 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/nova refs/changes/82/1982/4 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/nova refs/changes/82/1982/4"}}},"commit":{"parents":[{"commit":"486e6fb517a407d63bd1459518df92eb282fb733","subject":"Merge \"Fix typo: priviledges -\u003e privileges.\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/nova/commit/486e6fb517a407d63bd1459518df92eb282fb733"}]}],"author":{"name":"Ewan Mellor","email":"ewan.mellor@citrix.com","date":"2011-11-30 18:34:42.000000000","tz":-480},"committer":{"name":"Ewan Mellor","email":"ewan.mellor@citrix.com","date":"2011-11-30 21:21:22.000000000","tz":-480},"subject":"Bug #898290: iSCSI volume backend treats FLAGS.host as a hostname","message":"Bug #898290: iSCSI volume backend treats FLAGS.host as a hostname\n\nChange ISCSIDriver to set volume.provider_location during create_export.\nThis records the location of the LUN, so that nova-compute does not need\nto run the iSCSI discovery code itself.\n\nAs part of this, include the IP address of the target (--iscsi_ip_address) in\nthe provider_location.  This means that we don\u0027t use volume\u0027s host identifier\n(which could be an opaque ID) when trying to connect to the iSCSI target --\nwe use the admin-specified IP address instead.\n\nThe string-join to set provider_location is shared with ZadaraBEDriver,\nwhich was doing something similar.  I\u0027ve brought that into a helper function.\n\nThe docstring for the --host flag has been clarified.\n\nChange-Id: I8402da86345e786a46a4d222ad4d8a4449d2bd3f\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/nova/commit/f6c74d6563e48df6a8a7ff09a27d812840f23d02"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/nova/commit/f6c74d6563e48df6a8a7ff09a27d812840f23d02"}]},"parents_data":[{"branch_name":"refs/heads/master","commit_id":"486e6fb517a407d63bd1459518df92eb282fb733","is_merged_in_target_branch":true}],"branch":"refs/heads/master"}},"requirements":[],"submit_records":[],"submit_requirements":[]}