)]}'
{"nova/virt/libvirt/vif.py":[{"author":{"_account_id":447,"name":"dan wendlandt","email":"dan@nicira.com","username":"danwent"},"change_message_id":"3b9fcfc26529e38c36e75390367fe5a851ef262d","unresolved":false,"context_lines":[{"line_number":149,"context_line":""},{"line_number":150,"context_line":"    def get_bridge_name(self, network):"},{"line_number":151,"context_line":"        if \u0027bridge\u0027 in network:"},{"line_number":152,"context_line":"            return network[\u0027bridge\u0027]"},{"line_number":153,"context_line":"        return CONF.libvirt_ovs_bridge"},{"line_number":154,"context_line":""},{"line_number":155,"context_line":"    def get_config(self, instance, network, mapping):"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAM3%2F%2FiqU%3D","line":152,"updated":"2013-01-16 18:06:04.000000000","message":"it looks like https://review.openstack.org/#/c/19119/5/nova/network/quantumv2/api.py will also set the bridge kwarg to something (perhaps None).  Does this mean the \u0027bridge\u0027 key will always be present, though perhaps None?  Or is there some logic in how the models are passed down that would convert the None value to meaning that the key is not present?","commit_id":"5a4c96593067a375d0d92991ec0d6cf3eea8ec5f"},{"author":{"_account_id":1779,"name":"Daniel Berrange","email":"berrange@redhat.com","username":"berrange"},"change_message_id":"d37e816fff74c53db1f0e7fb3b8765eec6a6f979","unresolved":false,"context_lines":[{"line_number":149,"context_line":""},{"line_number":150,"context_line":"    def get_bridge_name(self, network):"},{"line_number":151,"context_line":"        if \u0027bridge\u0027 in network:"},{"line_number":152,"context_line":"            return network[\u0027bridge\u0027]"},{"line_number":153,"context_line":"        return CONF.libvirt_ovs_bridge"},{"line_number":154,"context_line":""},{"line_number":155,"context_line":"    def get_config(self, instance, network, mapping):"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAM3%2F%2Fipk%3D","line":152,"in_reply_to":"AAAAM3%2F%2FiqU%3D","updated":"2013-01-16 18:14:12.000000000","message":"Hmm, yes, I believe you are correct. We need to take that into account too","commit_id":"5a4c96593067a375d0d92991ec0d6cf3eea8ec5f"},{"author":{"_account_id":447,"name":"dan wendlandt","email":"dan@nicira.com","username":"danwent"},"change_message_id":"3b9fcfc26529e38c36e75390367fe5a851ef262d","unresolved":false,"context_lines":[{"line_number":231,"context_line":"    def get_bridge_name(self, network):"},{"line_number":232,"context_line":"        if \u0027bridge\u0027 in network:"},{"line_number":233,"context_line":"            return network[\u0027bridge\u0027]"},{"line_number":234,"context_line":"        return CONF.libvirt_ovs_bridge"},{"line_number":235,"context_line":""},{"line_number":236,"context_line":"    def get_config(self, instance, network, mapping):"},{"line_number":237,"context_line":"        br_name \u003d self.get_br_name(mapping[\u0027vif_uuid\u0027])"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAM3%2F%2FirA%3D","line":234,"updated":"2013-01-16 18:06:04.000000000","message":"is this duplicate, given that this class inherits from LibvirtOpenVswitchDriver?","commit_id":"5a4c96593067a375d0d92991ec0d6cf3eea8ec5f"},{"author":{"_account_id":447,"name":"dan wendlandt","email":"dan@nicira.com","username":"danwent"},"change_message_id":"c341abc425a425fb30dc4c86b7194a82fdffbe34","unresolved":false,"context_lines":[{"line_number":231,"context_line":"    def get_bridge_name(self, network):"},{"line_number":232,"context_line":"        if \u0027bridge\u0027 in network:"},{"line_number":233,"context_line":"            return network[\u0027bridge\u0027]"},{"line_number":234,"context_line":"        return CONF.libvirt_ovs_bridge"},{"line_number":235,"context_line":""},{"line_number":236,"context_line":"    def get_config(self, instance, network, mapping):"},{"line_number":237,"context_line":"        br_name \u003d self.get_br_name(mapping[\u0027vif_uuid\u0027])"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAM3%2F%2FinY%3D","line":234,"in_reply_to":"AAAAM3%2F%2Fipc%3D","updated":"2013-01-16 18:46:01.000000000","message":"fine by me.","commit_id":"5a4c96593067a375d0d92991ec0d6cf3eea8ec5f"},{"author":{"_account_id":1779,"name":"Daniel Berrange","email":"berrange@redhat.com","username":"berrange"},"change_message_id":"d37e816fff74c53db1f0e7fb3b8765eec6a6f979","unresolved":false,"context_lines":[{"line_number":231,"context_line":"    def get_bridge_name(self, network):"},{"line_number":232,"context_line":"        if \u0027bridge\u0027 in network:"},{"line_number":233,"context_line":"            return network[\u0027bridge\u0027]"},{"line_number":234,"context_line":"        return CONF.libvirt_ovs_bridge"},{"line_number":235,"context_line":""},{"line_number":236,"context_line":"    def get_config(self, instance, network, mapping):"},{"line_number":237,"context_line":"        br_name \u003d self.get_br_name(mapping[\u0027vif_uuid\u0027])"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAM3%2F%2Fipc%3D","line":234,"in_reply_to":"AAAAM3%2F%2FirA%3D","updated":"2013-01-16 18:14:12.000000000","message":"Yes, but that inheritance changes in another patch I have queued, so this is basically just future proofing","commit_id":"5a4c96593067a375d0d92991ec0d6cf3eea8ec5f"}]}