)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":7,"name":"Jay Pipes","email":"jaypipes@gmail.com","username":"jaypipes"},"change_message_id":"cae66b06cbe6450d5a7e700ca5622a85f603be5b","unresolved":false,"context_lines":[{"line_number":19,"context_line":""},{"line_number":20,"context_line":"the code was changed so that the desired thread count from the"},{"line_number":21,"context_line":"NUMA topology was passed in. Unfortunately the logic implemented"},{"line_number":22,"context_line":"was flawed because it while the cpu_threads preferred threads"},{"line_number":23,"context_line":"count was honour, it would not honour the cpu_max_threads"},{"line_number":24,"context_line":"value."},{"line_number":25,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"3a50d1a3_9f695a8e","line":22,"updated":"2015-07-20 11:15:17.000000000","message":"s/it while/while/","commit_id":"f396826314b9f37eb57151f0dd8a8e3b7d8a8a5c"},{"author":{"_account_id":7,"name":"Jay Pipes","email":"jaypipes@gmail.com","username":"jaypipes"},"change_message_id":"cae66b06cbe6450d5a7e700ca5622a85f603be5b","unresolved":false,"context_lines":[{"line_number":20,"context_line":"the code was changed so that the desired thread count from the"},{"line_number":21,"context_line":"NUMA topology was passed in. Unfortunately the logic implemented"},{"line_number":22,"context_line":"was flawed because it while the cpu_threads preferred threads"},{"line_number":23,"context_line":"count was honour, it would not honour the cpu_max_threads"},{"line_number":24,"context_line":"value."},{"line_number":25,"context_line":""},{"line_number":26,"context_line":"So if you have"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"3a50d1a3_ff0e5ee4","line":23,"updated":"2015-07-20 11:15:17.000000000","message":"s/was honour/was honoured/","commit_id":"f396826314b9f37eb57151f0dd8a8e3b7d8a8a5c"}],"nova/virt/hardware.py":[{"author":{"_account_id":5754,"name":"Alex Xu","email":"hejie.xu@intel.com","username":"xuhj"},"change_message_id":"c003f0ebaee2b1490045e1df9503585a434b3c2d","unresolved":false,"context_lines":[{"line_number":571,"context_line":""},{"line_number":572,"context_line":"    preferred, maximum \u003d _get_cpu_topology_constraints(flavor, image_meta)"},{"line_number":573,"context_line":"    LOG.debug(\"Topology preferred %(preferred)s, maximum %(maximum)s\" %"},{"line_number":574,"context_line":"              {\"preferred\": preferred, \"maximum\": maximum})"},{"line_number":575,"context_line":""},{"line_number":576,"context_line":"    possible \u003d _get_possible_cpu_topologies(flavor.vcpus,"},{"line_number":577,"context_line":"                                            maximum,"}],"source_content_type":"text/x-python","patch_set":1,"id":"ba3cc151_56fbc947","line":574,"updated":"2015-07-06 06:01:24.000000000","message":"All of the log should use \u0027LOG.debug(\"....\", {....})\u0027. \u0027,\u0027 is better than \u0027%\u0027.\n\nBecause if the log level won\u0027t be log, \u0027,\u0027 won\u0027t do that extra string replace.","commit_id":"f396826314b9f37eb57151f0dd8a8e3b7d8a8a5c"},{"author":{"_account_id":5754,"name":"Alex Xu","email":"hejie.xu@intel.com","username":"xuhj"},"change_message_id":"c003f0ebaee2b1490045e1df9503585a434b3c2d","unresolved":false,"context_lines":[{"line_number":584,"context_line":"                           if cell.cpu_topology]"},{"line_number":585,"context_line":"        if cell_topologies:"},{"line_number":586,"context_line":"            min_requested_threads \u003d min("},{"line_number":587,"context_line":"                    topo.threads for topo in cell_topologies)"},{"line_number":588,"context_line":""},{"line_number":589,"context_line":"        if min_requested_threads:"},{"line_number":590,"context_line":"            if preferred.threads !\u003d -1:"}],"source_content_type":"text/x-python","patch_set":1,"id":"ba3cc151_3c729cae","line":587,"updated":"2015-07-06 06:01:24.000000000","message":"One Question: When different cells have different topology,  why we choice the threads number is minimal one?","commit_id":"f396826314b9f37eb57151f0dd8a8e3b7d8a8a5c"},{"author":{"_account_id":5511,"name":"Nikola Dipanov","email":"ndipanov@redhat.com","username":"ndipanov"},"change_message_id":"4f27dd9a071169ba5e98f0747f227eb02a036c63","unresolved":false,"context_lines":[{"line_number":591,"context_line":"                min_requested_threads \u003d min(preferred.threads,"},{"line_number":592,"context_line":"                                            min_requested_threads)"},{"line_number":593,"context_line":""},{"line_number":594,"context_line":"            specified_threads \u003d max(1, min_requested_threads)"},{"line_number":595,"context_line":"            LOG.debug(\"Filtering topologies best for %d threads\" %"},{"line_number":596,"context_line":"                      specified_threads)"},{"line_number":597,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"ba3cc151_4bd57be2","line":594,"updated":"2015-07-03 12:56:29.000000000","message":"maybe rename this to NUMA_requested_threads?","commit_id":"f396826314b9f37eb57151f0dd8a8e3b7d8a8a5c"}]}