)]}'
{"nova/service.py":[{"author":{"_account_id":1561,"name":"Russell Bryant","email":"rbryant@redhat.com","username":"russellb"},"change_message_id":"903edc99dc4af4162c7ebf8e8d18446691dffa94","unresolved":false,"context_lines":[{"line_number":574,"context_line":"class WSGIService(object):"},{"line_number":575,"context_line":"    \"\"\"Provides ability to launch API from a \u0027paste\u0027 configuration.\"\"\""},{"line_number":576,"context_line":""},{"line_number":577,"context_line":"    def __init__(self, name, loader\u003dNone, use_ssl\u003dFalse, max_url_len\u003d8192):"},{"line_number":578,"context_line":"        \"\"\"Initialize, but do not start the WSGI server."},{"line_number":579,"context_line":""},{"line_number":580,"context_line":"        :param name: The name of the WSGI server given to the loader."}],"source_content_type":"text/x-python","patch_set":9,"id":"AAAAM3%2F%2FYl0%3D","line":577,"updated":"2013-01-24 16:52:12.000000000","message":"Why not use None in this patch instead of 8192 so that we only override it when needed?","commit_id":"e3cd3ed70993c1f2fb38453f4bbf433ebc0a2bed"},{"author":{"_account_id":6661,"name":"Burt Holzman","email":"holzman@gmail.com","username":"burt"},"change_message_id":"87709ecaf6b826a35ffa544dfd2644ddf5c2b176","unresolved":false,"context_lines":[{"line_number":574,"context_line":"class WSGIService(object):"},{"line_number":575,"context_line":"    \"\"\"Provides ability to launch API from a \u0027paste\u0027 configuration.\"\"\""},{"line_number":576,"context_line":""},{"line_number":577,"context_line":"    def __init__(self, name, loader\u003dNone, use_ssl\u003dFalse, max_url_len\u003d8192):"},{"line_number":578,"context_line":"        \"\"\"Initialize, but do not start the WSGI server."},{"line_number":579,"context_line":""},{"line_number":580,"context_line":"        :param name: The name of the WSGI server given to the loader."}],"source_content_type":"text/x-python","patch_set":9,"id":"AAAAM3%2F%2FYS0%3D","line":577,"in_reply_to":"AAAAM3%2F%2FYl0%3D","updated":"2013-01-24 19:14:09.000000000","message":"To avoid having to add a clunky if/then statement in wsgi.py that calls eventlet.wsgi.Server without the url_length_limit parameter when max_url_len is undefined.  But I can submit a patchset where I do that if you like.","commit_id":"e3cd3ed70993c1f2fb38453f4bbf433ebc0a2bed"}],"nova/tests/test_wsgi.py":[{"author":{"_account_id":2874,"name":"yong sheng gong","email":"gong.yongsheng@99cloud.net","username":"gongysh"},"change_message_id":"593271096d20c441194b1037cf5d394cac250bac","unresolved":false,"context_lines":[{"line_number":111,"context_line":"        uri \u003d \"http://127.0.0.1:%d/%s\" % (server.port, 60000 * \u0027x\u0027)"},{"line_number":112,"context_line":"        resp, _ \u003d httplib2.Http().request(uri)"},{"line_number":113,"context_line":"        eventlet.sleep(0)"},{"line_number":114,"context_line":"        self.assertNotEqual(resp.status, 414)"},{"line_number":115,"context_line":""},{"line_number":116,"context_line":"        uri \u003d \"http://127.0.0.1:%d/%s\" % (server.port, 120000 * \u0027x\u0027)"},{"line_number":117,"context_line":"        resp, _ \u003d httplib2.Http().request(uri)"}],"source_content_type":"text/x-python","patch_set":4,"id":"AAAAM3%2F%2FeUI%3D","line":114,"updated":"2013-01-21 02:07:46.000000000","message":"HTTPOk.code?","commit_id":"e9ba7bf4d8524ae8cd23a0e68f9861c8bfe578a8"},{"author":{"_account_id":6661,"name":"Burt Holzman","email":"holzman@gmail.com","username":"burt"},"change_message_id":"84a579fef18a9668901222118fb05c3529ad7ba9","unresolved":false,"context_lines":[{"line_number":111,"context_line":"        uri \u003d \"http://127.0.0.1:%d/%s\" % (server.port, 60000 * \u0027x\u0027)"},{"line_number":112,"context_line":"        resp, _ \u003d httplib2.Http().request(uri)"},{"line_number":113,"context_line":"        eventlet.sleep(0)"},{"line_number":114,"context_line":"        self.assertNotEqual(resp.status, 414)"},{"line_number":115,"context_line":""},{"line_number":116,"context_line":"        uri \u003d \"http://127.0.0.1:%d/%s\" % (server.port, 120000 * \u0027x\u0027)"},{"line_number":117,"context_line":"        resp, _ \u003d httplib2.Http().request(uri)"}],"source_content_type":"text/x-python","patch_set":4,"id":"AAAAM3%2F%2FeQo%3D","line":114,"in_reply_to":"AAAAM3%2F%2FeUI%3D","updated":"2013-01-21 05:29:44.000000000","message":"No -- this unit test is only to confirm that we do not get a 414 for a very long URI, not that we get an OK (we\u0027re not actually serving this URI, after all!)","commit_id":"e9ba7bf4d8524ae8cd23a0e68f9861c8bfe578a8"},{"author":{"_account_id":2874,"name":"yong sheng gong","email":"gong.yongsheng@99cloud.net","username":"gongysh"},"change_message_id":"593271096d20c441194b1037cf5d394cac250bac","unresolved":false,"context_lines":[{"line_number":116,"context_line":"        uri \u003d \"http://127.0.0.1:%d/%s\" % (server.port, 120000 * \u0027x\u0027)"},{"line_number":117,"context_line":"        resp, _ \u003d httplib2.Http().request(uri)"},{"line_number":118,"context_line":"        eventlet.sleep(0)"},{"line_number":119,"context_line":"        self.assertEqual(resp.status, 414)"},{"line_number":120,"context_line":""},{"line_number":121,"context_line":"        server.stop()"},{"line_number":122,"context_line":"        server.wait()"}],"source_content_type":"text/x-python","patch_set":4,"id":"AAAAM3%2F%2FeUE%3D","line":119,"updated":"2013-01-21 02:07:46.000000000","message":"HTTPRequestURITooLong.code?","commit_id":"e9ba7bf4d8524ae8cd23a0e68f9861c8bfe578a8"},{"author":{"_account_id":6661,"name":"Burt Holzman","email":"holzman@gmail.com","username":"burt"},"change_message_id":"84a579fef18a9668901222118fb05c3529ad7ba9","unresolved":false,"context_lines":[{"line_number":116,"context_line":"        uri \u003d \"http://127.0.0.1:%d/%s\" % (server.port, 120000 * \u0027x\u0027)"},{"line_number":117,"context_line":"        resp, _ \u003d httplib2.Http().request(uri)"},{"line_number":118,"context_line":"        eventlet.sleep(0)"},{"line_number":119,"context_line":"        self.assertEqual(resp.status, 414)"},{"line_number":120,"context_line":""},{"line_number":121,"context_line":"        server.stop()"},{"line_number":122,"context_line":"        server.wait()"}],"source_content_type":"text/x-python","patch_set":4,"id":"AAAAM3%2F%2FeQk%3D","line":119,"in_reply_to":"AAAAM3%2F%2FeUE%3D","updated":"2013-01-21 05:29:44.000000000","message":"I think bringing in paste.httpexceptions is a little overkill, but I\u0027ll do it.  Keep an eye out for the next patchset...","commit_id":"e9ba7bf4d8524ae8cd23a0e68f9861c8bfe578a8"},{"author":{"_account_id":679,"name":"Kevin L. Mitchell","email":"klmitch@mit.edu","username":"klmitch"},"change_message_id":"d35ac5fd385f66c3bc2f991644935e2b93df18bf","unresolved":false,"context_lines":[{"line_number":26,"context_line":"from nova import test"},{"line_number":27,"context_line":"import nova.wsgi"},{"line_number":28,"context_line":"import paste"},{"line_number":29,"context_line":"httplib2 \u003d eventlet.import_patched(\u0027httplib2\u0027)"},{"line_number":30,"context_line":""},{"line_number":31,"context_line":""},{"line_number":32,"context_line":"class TestLoaderNothingExists(test.TestCase):"}],"source_content_type":"text/x-python","patch_set":5,"id":"AAAAM3%2F%2FdO4%3D","line":29,"updated":"2013-01-21 21:30:10.000000000","message":"There are a couple of problems with these imports.  First, \"eventlet\" and \"paste\" are third-party imports, so they should go in a block of imports between these nova imports and the standard library imports.  Second, this is the only case in the entire code base where import_patched() is used; I don\u0027t think it\u0027s necessary, since elsewhere \"import httplib2\" seems to work just fine.  \"httplib2\" would be a third-party import, so it should go between \"import eventlet\" and \"import paste\".","commit_id":"66ad4994aec8b637b7b14f216ccd022c54d710e8"}]}