)]}'
{"nova/api/openstack/compute/plugins/v3/servers.py":[{"author":{"_account_id":6062,"name":"jichenjc","email":"jichenjc@cn.ibm.com","username":"jichenjc"},"change_message_id":"f0e1e60db5aabab7ada3a54bd426d7156c3535f3","unresolved":false,"context_lines":[{"line_number":538,"context_line":"        block_device_mapping \u003d create_kwargs.get(\"block_device_mapping\")"},{"line_number":539,"context_line":"        if block_device_mapping is not None:"},{"line_number":540,"context_line":"            nova_img.validate_volume_size_with_image_size(context,"},{"line_number":541,"context_line":"                                  block_device_mapping)"},{"line_number":542,"context_line":""},{"line_number":543,"context_line":"        # TODO(Shao He, Feng) move this policy check to os-block-device-mapping"},{"line_number":544,"context_line":"        # extension after refactor it."}],"source_content_type":"text/x-python","patch_set":2,"id":"ba3cc151_b4ceaab2","line":541,"updated":"2015-07-06 15:50:34.000000000","message":"I am wondering whether this is a backward incompatible change ...","commit_id":"6f8b07b8858020b91769f4480158b2e82a61e59d"},{"author":{"_account_id":16912,"name":"PrashantUpadhyay","email":"prashant.upadhyay709070@gmail.com","username":"prashup"},"change_message_id":"447c68011e04df3a7681121b0e2903f897a89357","unresolved":false,"context_lines":[{"line_number":538,"context_line":"        block_device_mapping \u003d create_kwargs.get(\"block_device_mapping\")"},{"line_number":539,"context_line":"        if block_device_mapping is not None:"},{"line_number":540,"context_line":"            nova_img.validate_volume_size_with_image_size(context,"},{"line_number":541,"context_line":"                                  block_device_mapping)"},{"line_number":542,"context_line":""},{"line_number":543,"context_line":"        # TODO(Shao He, Feng) move this policy check to os-block-device-mapping"},{"line_number":544,"context_line":"        # extension after refactor it."}],"source_content_type":"text/x-python","patch_set":2,"id":"ba3cc151_3474dafb","line":541,"in_reply_to":"ba3cc151_b4ceaab2","updated":"2015-07-07 05:35:50.000000000","message":"@jichenjc why do you think so ?\nplease can you explain ?","commit_id":"6f8b07b8858020b91769f4480158b2e82a61e59d"}],"nova/image/__init__.py":[{"author":{"_account_id":6062,"name":"jichenjc","email":"jichenjc@cn.ibm.com","username":"jichenjc"},"change_message_id":"f0e1e60db5aabab7ada3a54bd426d7156c3535f3","unresolved":false,"context_lines":[{"line_number":30,"context_line":"            image_uuid \u003d bdm.get(\u0027image_id\u0027)"},{"line_number":31,"context_line":"            if image_uuid is None:"},{"line_number":32,"context_line":"                return"},{"line_number":33,"context_line":"            image_api \u003d API()"},{"line_number":34,"context_line":"            image \u003d image_api.get(context, image_uuid)"},{"line_number":35,"context_line":"            size \u003d image.get(\"size\")"},{"line_number":36,"context_line":"            vol_size \u003d bdm.get(\u0027volume_size\u0027)"}],"source_content_type":"text/x-python","patch_set":2,"id":"ba3cc151_5125f0bf","line":33,"updated":"2015-07-06 15:50:34.000000000","message":"no need to create API for each bdm","commit_id":"6f8b07b8858020b91769f4480158b2e82a61e59d"},{"author":{"_account_id":16912,"name":"PrashantUpadhyay","email":"prashant.upadhyay709070@gmail.com","username":"prashup"},"change_message_id":"447c68011e04df3a7681121b0e2903f897a89357","unresolved":false,"context_lines":[{"line_number":30,"context_line":"            image_uuid \u003d bdm.get(\u0027image_id\u0027)"},{"line_number":31,"context_line":"            if image_uuid is None:"},{"line_number":32,"context_line":"                return"},{"line_number":33,"context_line":"            image_api \u003d API()"},{"line_number":34,"context_line":"            image \u003d image_api.get(context, image_uuid)"},{"line_number":35,"context_line":"            size \u003d image.get(\"size\")"},{"line_number":36,"context_line":"            vol_size \u003d bdm.get(\u0027volume_size\u0027)"}],"source_content_type":"text/x-python","patch_set":2,"id":"ba3cc151_f4c0b2e2","line":33,"in_reply_to":"ba3cc151_5125f0bf","updated":"2015-07-07 05:35:50.000000000","message":"yeah , comment well taken !!\n\ni ll change it in my next patch.","commit_id":"6f8b07b8858020b91769f4480158b2e82a61e59d"},{"author":{"_account_id":6062,"name":"jichenjc","email":"jichenjc@cn.ibm.com","username":"jichenjc"},"change_message_id":"f0e1e60db5aabab7ada3a54bd426d7156c3535f3","unresolved":false,"context_lines":[{"line_number":41,"context_line":"                raise exc.HTTPBadRequest(explanation \u003d ee.format_message())"},{"line_number":42,"context_line":"            if vol_size * units.Gi \u003c size:"},{"line_number":43,"context_line":"                msg \u003d _(\"Image size greater than volume size\")"},{"line_number":44,"context_line":"                raise exc.HTTPBadRequest(explanation\u003dmsg)"},{"line_number":45,"context_line":"        except (exception.NotFound, exception.InvalidImageRef):"},{"line_number":46,"context_line":"            explanation \u003d _(\"Image not found.\")"},{"line_number":47,"context_line":"            raise exc.HTTPNotFound(explanation\u003dexplanation)"}],"source_content_type":"text/x-python","patch_set":2,"id":"ba3cc151_b480ea47","line":44,"updated":"2015-07-06 15:50:34.000000000","message":"can we move this logic to some place around \nhttps://github.com/openstack/nova/blob/master/nova/compute/api.py#L1212 ?","commit_id":"6f8b07b8858020b91769f4480158b2e82a61e59d"},{"author":{"_account_id":16912,"name":"PrashantUpadhyay","email":"prashant.upadhyay709070@gmail.com","username":"prashup"},"change_message_id":"447c68011e04df3a7681121b0e2903f897a89357","unresolved":false,"context_lines":[{"line_number":41,"context_line":"                raise exc.HTTPBadRequest(explanation \u003d ee.format_message())"},{"line_number":42,"context_line":"            if vol_size * units.Gi \u003c size:"},{"line_number":43,"context_line":"                msg \u003d _(\"Image size greater than volume size\")"},{"line_number":44,"context_line":"                raise exc.HTTPBadRequest(explanation\u003dmsg)"},{"line_number":45,"context_line":"        except (exception.NotFound, exception.InvalidImageRef):"},{"line_number":46,"context_line":"            explanation \u003d _(\"Image not found.\")"},{"line_number":47,"context_line":"            raise exc.HTTPNotFound(explanation\u003dexplanation)"}],"source_content_type":"text/x-python","patch_set":2,"id":"ba3cc151_57964095","line":44,"in_reply_to":"ba3cc151_b480ea47","updated":"2015-07-07 05:35:50.000000000","message":"I believe the code pointer you have pasted above is for snapshot attaching. I may be wrong. \nAlso previous @John Garbutt advised me to move this to nova.image.","commit_id":"6f8b07b8858020b91769f4480158b2e82a61e59d"}]}