)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"change_message_id":"d607406a8d0fd87c77f6a1e6e2e1ee8d84374e57","unresolved":false,"context_lines":[{"line_number":8,"context_line":""},{"line_number":9,"context_line":"When the tree for all subobjects of objects is built, the desired"},{"line_number":10,"context_line":"subobject version should be retrieved from obj_relationships of the"},{"line_number":11,"context_line":"object. This should then be tested against the static tree to see if the"},{"line_number":12,"context_line":"versions in the objects matches the static tree."},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"Because some versioning got stale, objects (or the static tree) needed"},{"line_number":15,"context_line":"to be fixed up to reflect the correct versions of objects."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"ba3cc151_40004aab","line":12,"range":{"start_line":11,"start_character":8,"end_line":12,"end_character":48},"updated":"2015-07-08 15:11:39.000000000","message":"This is no longer true, right? I assume it\u0027s referring to the static tree in the test file, which you remove.","commit_id":"bd7d2dd4fcf2698a05bc705a88bc8e890a477814"}],"nova/objects/floating_ip.py":[{"author":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"change_message_id":"9459f924b564548f879bf5679bdc7006d9165f56","unresolved":false,"context_lines":[{"line_number":174,"context_line":"    # Version 1.6: FloatingIP 1.5"},{"line_number":175,"context_line":"    # Version 1.7: FloatingIP 1.6"},{"line_number":176,"context_line":"    # Version 1.8: FloatingIP 1.7"},{"line_number":177,"context_line":"    # Version 1.9: FloationIP 1.8"},{"line_number":178,"context_line":"    fields \u003d {"},{"line_number":179,"context_line":"        \u0027objects\u0027: fields.ListOfObjectsField(\u0027FloatingIP\u0027),"},{"line_number":180,"context_line":"        }"}],"source_content_type":"text/x-python","patch_set":10,"id":"1a4dcd0f_b4bf36a9","line":177,"range":{"start_line":177,"start_character":19,"end_line":177,"end_character":27},"updated":"2015-08-05 14:16:12.000000000","message":"Floatation? Should be floating.","commit_id":"be7f747f2b373a524b7b56952f8ec7e808da9477"},{"author":{"_account_id":11803,"name":"Ryan Rossiter","email":"rlrossit@us.ibm.com","username":"rlrossiter"},"change_message_id":"b2376c2025632b1d72577981f82c434b7471f2f0","unresolved":false,"context_lines":[{"line_number":174,"context_line":"    # Version 1.6: FloatingIP 1.5"},{"line_number":175,"context_line":"    # Version 1.7: FloatingIP 1.6"},{"line_number":176,"context_line":"    # Version 1.8: FloatingIP 1.7"},{"line_number":177,"context_line":"    # Version 1.9: FloationIP 1.8"},{"line_number":178,"context_line":"    fields \u003d {"},{"line_number":179,"context_line":"        \u0027objects\u0027: fields.ListOfObjectsField(\u0027FloatingIP\u0027),"},{"line_number":180,"context_line":"        }"}],"source_content_type":"text/x-python","patch_set":10,"id":"1a4dcd0f_da28e9e4","line":177,"range":{"start_line":177,"start_character":19,"end_line":177,"end_character":27},"in_reply_to":"1a4dcd0f_b4bf36a9","updated":"2015-08-05 14:52:19.000000000","message":"Oops. Fixed.","commit_id":"be7f747f2b373a524b7b56952f8ec7e808da9477"}],"nova/tests/unit/objects/test_objects.py":[{"author":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"change_message_id":"d9b7844d3953b47bb831ad0157cd8a0644b68963","unresolved":false,"context_lines":[{"line_number":1283,"context_line":"        for name, field in obj_class.fields.items():"},{"line_number":1284,"context_line":"            sub_obj_name \u003d self._get_object_field_name(field)"},{"line_number":1285,"context_line":"            if sub_obj_name:"},{"line_number":1286,"context_line":"                sub_obj_class \u003d obj_classes[sub_obj_name][0]"},{"line_number":1287,"context_line":"                tree.setdefault(obj_name, {})"},{"line_number":1288,"context_line":"                tree[obj_name][sub_obj_name] \u003d sub_obj_class.VERSION"},{"line_number":1289,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"ba3cc151_7b5e8dea","side":"PARENT","line":1286,"updated":"2015-07-07 19:51:46.000000000","message":"This is examining the actual object, which is what we want.","commit_id":"fac8d8fac2d5410c1355099e4ac63ee542aabbcd"},{"author":{"_account_id":11803,"name":"Ryan Rossiter","email":"rlrossit@us.ibm.com","username":"rlrossiter"},"change_message_id":"d17ab2ce9f29d15c72321b639a8fc15f65f57621","unresolved":false,"context_lines":[{"line_number":1159,"context_line":"    \u0027Instance\u0027: {\u0027InstanceFault\u0027: \u00271.2\u0027,"},{"line_number":1160,"context_line":"                 \u0027InstanceInfoCache\u0027: \u00271.5\u0027,"},{"line_number":1161,"context_line":"                 \u0027InstanceNUMATopology\u0027: \u00271.1\u0027,"},{"line_number":1162,"context_line":"                 \u0027PciDeviceList\u0027: \u00271.1\u0027,"},{"line_number":1163,"context_line":"                 \u0027TagList\u0027: \u00271.0\u0027,"},{"line_number":1164,"context_line":"                 \u0027SecurityGroupList\u0027: \u00271.0\u0027,"},{"line_number":1165,"context_line":"                 \u0027Flavor\u0027: \u00271.1\u0027,"}],"source_content_type":"text/x-python","patch_set":1,"id":"ba3cc151_7ac76b12","line":1162,"updated":"2015-07-07 18:46:43.000000000","message":"is this supposed to be updated in the tree here or in the Instance object?","commit_id":"ed03bb73cadd2efddce61a2897f6a7460c00d79f"},{"author":{"_account_id":11803,"name":"Ryan Rossiter","email":"rlrossit@us.ibm.com","username":"rlrossiter"},"change_message_id":"d17ab2ce9f29d15c72321b639a8fc15f65f57621","unresolved":false,"context_lines":[{"line_number":1174,"context_line":"    \u0027InstanceList\u0027: {\u0027Instance\u0027: \u00271.20\u0027},"},{"line_number":1175,"context_line":"    \u0027InstanceMappingList\u0027: {\u0027InstanceMapping\u0027: \u00271.0\u0027},"},{"line_number":1176,"context_line":"    \u0027InstanceNUMACell\u0027: {\u0027VirtCPUTopology\u0027: \u00271.0\u0027},"},{"line_number":1177,"context_line":"    \u0027InstanceNUMATopology\u0027: {\u0027InstanceNUMACell\u0027: \u00271.0\u0027},"},{"line_number":1178,"context_line":"    \u0027InstancePCIRequests\u0027: {\u0027InstancePCIRequest\u0027: \u00271.1\u0027},"},{"line_number":1179,"context_line":"    \u0027KeyPairList\u0027: {\u0027KeyPair\u0027: \u00271.3\u0027},"},{"line_number":1180,"context_line":"    \u0027MigrationList\u0027: {\u0027Migration\u0027: \u00271.2\u0027},"}],"source_content_type":"text/x-python","patch_set":1,"id":"ba3cc151_3ad1e3cd","line":1177,"updated":"2015-07-07 18:46:43.000000000","message":"same here as above.","commit_id":"ed03bb73cadd2efddce61a2897f6a7460c00d79f"},{"author":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"change_message_id":"d9b7844d3953b47bb831ad0157cd8a0644b68963","unresolved":false,"context_lines":[{"line_number":1284,"context_line":"            if sub_obj_name:"},{"line_number":1285,"context_line":"                tree.setdefault(obj_name, {})"},{"line_number":1286,"context_line":"                rels \u003d obj_class.obj_relationships[name]"},{"line_number":1287,"context_line":"                tree[obj_name][sub_obj_name] \u003d rels[-1][1]"},{"line_number":1288,"context_line":""},{"line_number":1289,"context_line":"    def test_relationships(self):"},{"line_number":1290,"context_line":"        tree \u003d {}"}],"source_content_type":"text/x-python","patch_set":1,"id":"ba3cc151_1be3c106","line":1287,"updated":"2015-07-07 19:51:46.000000000","message":"This is building the tree from the obj_relationships and comparing it to the static mapping above. That means I could change the version of some object, and as long as I didn\u0027t change the above mapping, or obj_relationships in the parent object, then the test would succeed.\n\nWhat we actually want is to examine the actual objects, and compare that to obj_relationships to make sure it\u0027s complete. If we do that, we should be able to remove the static mapping in this file (which you were pointing out on IRC would be a good goal).\n\nThe important thing we need to test here is that the actual version on the sub-object matches what is in obj_relationships on the parent. The test you can use to make sure this works is: increment the FixedIP.VERSION number and make sure this test fails complaining that FloatingIP doesn\u0027t specify an obj_relationship for that new version.\n\nThat scenario already exists with the Floating/Fixed relationship,which is what we\u0027re trying to detect. So you could also do it by incrementing InstanceFault to 1.3 and making sure this test fails complaining that Instance doesn\u0027t have an obj_relationship for InstanceFault at v1.3.","commit_id":"ed03bb73cadd2efddce61a2897f6a7460c00d79f"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"4d5b8f1cac17aea3f7f1bf57f28f3ce49eadd3d2","unresolved":false,"context_lines":[{"line_number":1313,"context_line":"                         \u0027the child object. The expected dict is the \u0027"},{"line_number":1314,"context_line":"                         \u0027current versions of all objects held by other \u0027"},{"line_number":1315,"context_line":"                         \u0027objects, and the actual dict is what is held \u0027"},{"line_number":1316,"context_line":"                         \u0027within obj_relationships on the given objects.\u0027)"},{"line_number":1317,"context_line":""},{"line_number":1318,"context_line":"    def test_obj_make_compatible(self):"},{"line_number":1319,"context_line":"        # Iterate all object classes and verify that we can run"}],"source_content_type":"text/x-python","patch_set":8,"id":"3a50d1a3_578a9965","line":1316,"updated":"2015-07-31 16:19:42.000000000","message":"confusing","commit_id":"847837f71e44400831192496661b5ba7d562923d"},{"author":{"_account_id":11803,"name":"Ryan Rossiter","email":"rlrossit@us.ibm.com","username":"rlrossiter"},"change_message_id":"67088bc214cdefc6584c387b7808b6c575bd78ca","unresolved":false,"context_lines":[{"line_number":1313,"context_line":"                         \u0027the child object. The expected dict is the \u0027"},{"line_number":1314,"context_line":"                         \u0027current versions of all objects held by other \u0027"},{"line_number":1315,"context_line":"                         \u0027objects, and the actual dict is what is held \u0027"},{"line_number":1316,"context_line":"                         \u0027within obj_relationships on the given objects.\u0027)"},{"line_number":1317,"context_line":""},{"line_number":1318,"context_line":"    def test_obj_make_compatible(self):"},{"line_number":1319,"context_line":"        # Iterate all object classes and verify that we can run"}],"source_content_type":"text/x-python","patch_set":8,"id":"1a4dcd0f_7a96f095","line":1316,"in_reply_to":"3a50d1a3_10dde66f","updated":"2015-08-03 16:21:36.000000000","message":"Added some comments to both the test itself, and also above the assertion for how to resolve assertion failures.","commit_id":"847837f71e44400831192496661b5ba7d562923d"},{"author":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"change_message_id":"df0299e225426d5195d3ef0ee6e70dec3a5645d9","unresolved":false,"context_lines":[{"line_number":1313,"context_line":"                         \u0027the child object. The expected dict is the \u0027"},{"line_number":1314,"context_line":"                         \u0027current versions of all objects held by other \u0027"},{"line_number":1315,"context_line":"                         \u0027objects, and the actual dict is what is held \u0027"},{"line_number":1316,"context_line":"                         \u0027within obj_relationships on the given objects.\u0027)"},{"line_number":1317,"context_line":""},{"line_number":1318,"context_line":"    def test_obj_make_compatible(self):"},{"line_number":1319,"context_line":"        # Iterate all object classes and verify that we can run"}],"source_content_type":"text/x-python","patch_set":8,"id":"3a50d1a3_b76bddf0","line":1316,"in_reply_to":"3a50d1a3_578a9965","updated":"2015-07-31 16:25:07.000000000","message":"I don\u0027t really have any suggestions for making it better. Perhaps we could augment this with comments above this line so that if people come here looking for the source there is a more verbose explanation of what they should do.","commit_id":"847837f71e44400831192496661b5ba7d562923d"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"db4be2971e6349162788e96f0212a52392a8b778","unresolved":false,"context_lines":[{"line_number":1313,"context_line":"                         \u0027the child object. The expected dict is the \u0027"},{"line_number":1314,"context_line":"                         \u0027current versions of all objects held by other \u0027"},{"line_number":1315,"context_line":"                         \u0027objects, and the actual dict is what is held \u0027"},{"line_number":1316,"context_line":"                         \u0027within obj_relationships on the given objects.\u0027)"},{"line_number":1317,"context_line":""},{"line_number":1318,"context_line":"    def test_obj_make_compatible(self):"},{"line_number":1319,"context_line":"        # Iterate all object classes and verify that we can run"}],"source_content_type":"text/x-python","patch_set":8,"id":"3a50d1a3_10dde66f","line":1316,"in_reply_to":"3a50d1a3_b76bddf0","updated":"2015-08-01 01:03:35.000000000","message":"+1 to adding comments in the test, I was thinking that when I first passed through this earlier today but then had to run.","commit_id":"847837f71e44400831192496661b5ba7d562923d"}]}
