)]}'
{"nova/compute/api.py":[{"author":{"_account_id":5511,"name":"Nikola Dipanov","email":"ndipanov@redhat.com","username":"ndipanov"},"change_message_id":"06182e746a13498cc6d0c67da61d298f1eac8289","unresolved":false,"context_lines":[{"line_number":2264,"context_line":"        return self.image_api.create(context, image_meta)"},{"line_number":2265,"context_line":""},{"line_number":2266,"context_line":"    def _initialize_instance_snapshot_metadata(self, instance, name,"},{"line_number":2267,"context_line":"                                               extra_properties\u003dNone):"},{"line_number":2268,"context_line":"        \"\"\"Initialize new metadata for a snapshot of the given instance."},{"line_number":2269,"context_line":""},{"line_number":2270,"context_line":"        :param instance: nova.objects.instance.Instance object"}],"source_content_type":"text/x-python","patch_set":4,"id":"1a4dcd0f_5bb1c845","line":2267,"updated":"2015-08-13 14:46:43.000000000","message":"I was expecting to see this patch move all the code to using objects.ImageMeta. Not saying that you have to do it that way for this to be acceptable, but it\u0027s a natural place to have this functionality (maybe). and we really should be using objects here if possible anyway/.","commit_id":"3f3958cda53f5119706d91a0e87bb052545658e7"},{"author":{"_account_id":10224,"name":"Feodor Tersin","email":"ftersin@hotmail.com","username":"ftersin"},"change_message_id":"be5ae86de60e68cded0e360a164927cf26274859","unresolved":false,"context_lines":[{"line_number":2264,"context_line":"        return self.image_api.create(context, image_meta)"},{"line_number":2265,"context_line":""},{"line_number":2266,"context_line":"    def _initialize_instance_snapshot_metadata(self, instance, name,"},{"line_number":2267,"context_line":"                                               extra_properties\u003dNone):"},{"line_number":2268,"context_line":"        \"\"\"Initialize new metadata for a snapshot of the given instance."},{"line_number":2269,"context_line":""},{"line_number":2270,"context_line":"        :param instance: nova.objects.instance.Instance object"}],"source_content_type":"text/x-python","patch_set":4,"id":"1a4dcd0f_9155f1c2","line":2267,"in_reply_to":"1a4dcd0f_5bb1c845","updated":"2015-08-13 15:20:18.000000000","message":"I\u0027m waiting for a finish of DanPB efforts (like https://review.openstack.org/#/c/190145/) to understand how this work with system metadata could be improved.\n\nNow i see a more important (than the placement of this function) problem with ImageMetadata. It has no method to convert it to a dict. But we need a dict to send it to Glance. Some times ago in one review (probably of Garry Kotton) i saw that DanPB rejected such method.\n\nSo.. i\u0027m waiting for Daniel, and then will ask him, how to improve this. Regardless of if this review will be merged or not.\n\nDo you have an idea how to manage this better?","commit_id":"3f3958cda53f5119706d91a0e87bb052545658e7"},{"author":{"_account_id":5511,"name":"Nikola Dipanov","email":"ndipanov@redhat.com","username":"ndipanov"},"change_message_id":"f427545cd32c189b4650d46909b4625dc45853dc","unresolved":false,"context_lines":[{"line_number":2306,"context_line":"        # the new image is simply a bucket of properties (particularly the"},{"line_number":2307,"context_line":"        # block device mapping, kernel and ramdisk IDs) with no image data,"},{"line_number":2308,"context_line":"        # hence the zero size"},{"line_number":2309,"context_line":"        image_meta[\u0027size\u0027] \u003d 0"},{"line_number":2310,"context_line":"        for attr in (\u0027container_format\u0027, \u0027disk_format\u0027):"},{"line_number":2311,"context_line":"            image_meta.pop(attr, None)"},{"line_number":2312,"context_line":"        properties \u003d image_meta[\u0027properties\u0027]"}],"source_content_type":"text/x-python","patch_set":5,"id":"fa1b9901_aa8d947d","line":2309,"updated":"2015-08-25 16:35:38.000000000","message":"Can we make this something we can pass into the method too?","commit_id":"6b93494bfda1385244fed3bbadbe2a26b38f9a09"},{"author":{"_account_id":10224,"name":"Feodor Tersin","email":"ftersin@hotmail.com","username":"ftersin"},"change_message_id":"5ecbf6c4e83e9c5e716b2c2827abfd41d4c23754","unresolved":false,"context_lines":[{"line_number":2306,"context_line":"        # the new image is simply a bucket of properties (particularly the"},{"line_number":2307,"context_line":"        # block device mapping, kernel and ramdisk IDs) with no image data,"},{"line_number":2308,"context_line":"        # hence the zero size"},{"line_number":2309,"context_line":"        image_meta[\u0027size\u0027] \u003d 0"},{"line_number":2310,"context_line":"        for attr in (\u0027container_format\u0027, \u0027disk_format\u0027):"},{"line_number":2311,"context_line":"            image_meta.pop(attr, None)"},{"line_number":2312,"context_line":"        properties \u003d image_meta[\u0027properties\u0027]"}],"source_content_type":"text/x-python","patch_set":5,"id":"fa1b9901_942687cc","line":2309,"in_reply_to":"fa1b9901_aa8d947d","updated":"2015-08-26 13:36:23.000000000","message":"As a separate parameter? Something like extra_attributes parameter? And also pass in name through it?","commit_id":"6b93494bfda1385244fed3bbadbe2a26b38f9a09"}]}