)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":1849,"name":"Joe Gordon","email":"joe.gordon0@gmail.com","username":"jogo"},"change_message_id":"847b0eb88e266859d78c02f58b43129e496b4301","unresolved":false,"context_lines":[{"line_number":8,"context_line":""},{"line_number":9,"context_line":"As in nova/availability_zones.py, the method def get_host_availability_zone()"},{"line_number":10,"context_line":"expect the first argument \"context\" is a module rathen a RequestContext object."},{"line_number":11,"context_line":"For our habbit, argument \"context\" is always a RequestContext object which"},{"line_number":12,"context_line":"contains the information of request user."},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"* Fix the usage of argument \"context\""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"AAAAM3%2F%2FhUU%3D","line":11,"updated":"2013-01-17 15:30:20.000000000","message":"Can you reword this a little. Also the bug report itself is a little confusing","commit_id":"1c12e35c8d3908de436608c0469f8dd6ddaaefe7"}],"nova/availability_zones.py":[{"author":{"_account_id":1561,"name":"Russell Bryant","email":"rbryant@redhat.com","username":"russellb"},"change_message_id":"77a69c5077013bfda87294063e3b24051e66910a","unresolved":false,"context_lines":[{"line_number":47,"context_line":"        if service[\u0027topic\u0027] \u003d\u003d \"compute\":"},{"line_number":48,"context_line":"            if metadata.get(service[\u0027host\u0027]):"},{"line_number":49,"context_line":"                # metadata is set()"},{"line_number":50,"context_line":"                az \u003d u\u0027,\u0027.join(list(metadata[service[\u0027host\u0027]]))"},{"line_number":51,"context_line":"            else:"},{"line_number":52,"context_line":"                az \u003d CONF.default_availability_zone"},{"line_number":53,"context_line":"        service[\u0027availability_zone\u0027] \u003d az"}],"source_content_type":"text/x-python","patch_set":5,"id":"AAAAM3%2F%2FfhU%3D","line":50,"updated":"2013-01-18 18:02:32.000000000","message":"This looks like an unrelated fix.  This should go in its own patch.","commit_id":"6ccd84ef6a7207ff749169a92ba946b1508dc02b"},{"author":{"_account_id":1678,"name":"Tiantian Gao","email":"gtt116@gmail.com","username":"gtt116"},"change_message_id":"7ecb82591cad7ebb4d943880a27d0e117d2ed1da","unresolved":false,"context_lines":[{"line_number":46,"context_line":"        az \u003d CONF.internal_service_availability_zone"},{"line_number":47,"context_line":"        if service[\u0027topic\u0027] \u003d\u003d \"compute\":"},{"line_number":48,"context_line":"            if metadata.get(service[\u0027host\u0027]):"},{"line_number":49,"context_line":"                az \u003d u\u0027,\u0027.join(list(metadata[service[\u0027host\u0027]]))"},{"line_number":50,"context_line":"            else:"},{"line_number":51,"context_line":"                az \u003d CONF.default_availability_zone"},{"line_number":52,"context_line":"        service[\u0027availability_zone\u0027] \u003d az"}],"source_content_type":"text/x-python","patch_set":6,"id":"AAAAM3%2F%2FegY%3D","line":49,"updated":"2013-01-20 11:58:26.000000000","message":"Thanks Russell.\n\nIf I do not modify this. the unittest will be failed.\nSo I think fixing this at the same time with adding unittests maybe ok.","commit_id":"2ff67470f577b3d7867bd36001ae55cdc321d521"},{"author":{"_account_id":1678,"name":"Tiantian Gao","email":"gtt116@gmail.com","username":"gtt116"},"change_message_id":"fc819a79bb725131f5fb4e2603e0b86d715602b9","unresolved":false,"context_lines":[{"line_number":46,"context_line":"        az \u003d CONF.internal_service_availability_zone"},{"line_number":47,"context_line":"        if service[\u0027topic\u0027] \u003d\u003d \"compute\":"},{"line_number":48,"context_line":"            if metadata.get(service[\u0027host\u0027]):"},{"line_number":49,"context_line":"                az \u003d u\u0027,\u0027.join(list(metadata[service[\u0027host\u0027]]))"},{"line_number":50,"context_line":"            else:"},{"line_number":51,"context_line":"                az \u003d CONF.default_availability_zone"},{"line_number":52,"context_line":"        service[\u0027availability_zone\u0027] \u003d az"}],"source_content_type":"text/x-python","patch_set":7,"id":"AAAAM3%2F%2Fefk%3D","line":49,"updated":"2013-01-20 13:34:53.000000000","message":"Thanks Russell.\n\nIf I do not modify this. the unittest will be failed. So I think fixing this at the same time with adding unittests maybe ok.","commit_id":"24b3f8da70c9d3295ae02e7d27b15c50a8f50ce9"}],"nova/tests/test_availability_zones.py":[{"author":{"_account_id":1849,"name":"Joe Gordon","email":"joe.gordon0@gmail.com","username":"jogo"},"change_message_id":"847b0eb88e266859d78c02f58b43129e496b4301","unresolved":false,"context_lines":[{"line_number":34,"context_line":"        self.host \u003d \u0027me\u0027"},{"line_number":35,"context_line":"        self.availability_zone \u003d \u0027nova-test\u0027"},{"line_number":36,"context_line":"        self.default_az \u003d \u0027nova\u0027"},{"line_number":37,"context_line":"        self.default_in_az \u003d \u0027internal\u0027"},{"line_number":38,"context_line":"        self.context \u003d context.get_admin_context()"},{"line_number":39,"context_line":""},{"line_number":40,"context_line":"        agg \u003d {\u0027name\u0027: \u0027agg1\u0027}"}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAAM3%2F%2FhVY%3D","line":37,"updated":"2013-01-17 15:30:20.000000000","message":"Instead of hard coding values here you should pull the values directly from the config options.","commit_id":"1c12e35c8d3908de436608c0469f8dd6ddaaefe7"},{"author":{"_account_id":1678,"name":"Tiantian Gao","email":"gtt116@gmail.com","username":"gtt116"},"change_message_id":"e4c99556df45cf502f2d4eca9268c4e6bcc5d6e6","unresolved":false,"context_lines":[{"line_number":34,"context_line":"        self.host \u003d \u0027me\u0027"},{"line_number":35,"context_line":"        self.availability_zone \u003d \u0027nova-test\u0027"},{"line_number":36,"context_line":"        self.default_az \u003d \u0027nova\u0027"},{"line_number":37,"context_line":"        self.default_in_az \u003d \u0027internal\u0027"},{"line_number":38,"context_line":"        self.context \u003d context.get_admin_context()"},{"line_number":39,"context_line":""},{"line_number":40,"context_line":"        agg \u003d {\u0027name\u0027: \u0027agg1\u0027}"}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAAM3%2F%2FgZA%3D","line":37,"in_reply_to":"AAAAM3%2F%2FhVY%3D","updated":"2013-01-18 01:39:31.000000000","message":"em.. \nI reset the configs in the end of \"setUp\" method. So I think this unittest can passwd even the default value of the config changed.","commit_id":"1c12e35c8d3908de436608c0469f8dd6ddaaefe7"},{"author":{"_account_id":1678,"name":"Tiantian Gao","email":"gtt116@gmail.com","username":"gtt116"},"change_message_id":"0bf7cdfad86db4877b62affa00692949144edc62","unresolved":false,"context_lines":[{"line_number":44,"context_line":"        db.aggregate_metadata_add(self.context, self.agg[\u0027id\u0027], metadata)"},{"line_number":45,"context_line":""},{"line_number":46,"context_line":"        self.flags(internal_service_availability_zone\u003dself.default_in_az,"},{"line_number":47,"context_line":"                   default_availability_zone\u003dself.default_az)"},{"line_number":48,"context_line":""},{"line_number":49,"context_line":"    def tearDown(self):"},{"line_number":50,"context_line":"        db.aggregate_delete(self.context, self.agg[\u0027id\u0027])"}],"source_content_type":"text/x-python","patch_set":4,"id":"AAAAM3%2F%2FgYs%3D","line":47,"updated":"2013-01-18 01:41:57.000000000","message":"To make this unittest passed, even if the default value of the config changed.\nSo I reset the value here.","commit_id":"6ba1c99fdf270f2c86068cf53f013b32ec8c361e"},{"author":{"_account_id":1849,"name":"Joe Gordon","email":"joe.gordon0@gmail.com","username":"jogo"},"change_message_id":"6e04efff5177073c150f68f9bd2acb93d1c0284f","unresolved":false,"context_lines":[{"line_number":43,"context_line":"        metadata \u003d {\u0027availability_zone\u0027: self.availability_zone}"},{"line_number":44,"context_line":"        db.aggregate_metadata_add(self.context, self.agg[\u0027id\u0027], metadata)"},{"line_number":45,"context_line":""},{"line_number":46,"context_line":"        self.flags(internal_service_availability_zone\u003dself.default_in_az,"},{"line_number":47,"context_line":"                   default_availability_zone\u003dself.default_az)"},{"line_number":48,"context_line":""},{"line_number":49,"context_line":"    def tearDown(self):"}],"source_content_type":"text/x-python","patch_set":5,"id":"AAAAM3%2F%2FfOs%3D","line":46,"updated":"2013-01-18 21:10:01.000000000","message":"Instead of changing the default values, I would prefer to just use them.","commit_id":"6ccd84ef6a7207ff749169a92ba946b1508dc02b"},{"author":{"_account_id":1678,"name":"Tiantian Gao","email":"gtt116@gmail.com","username":"gtt116"},"change_message_id":"7ecb82591cad7ebb4d943880a27d0e117d2ed1da","unresolved":false,"context_lines":[{"line_number":42,"context_line":"        self.host \u003d \u0027me\u0027"},{"line_number":43,"context_line":"        self.availability_zone \u003d \u0027nova-test\u0027"},{"line_number":44,"context_line":"        self.default_az \u003d CONF.default_availability_zone"},{"line_number":45,"context_line":"        self.default_in_az \u003d CONF.internal_service_availability_zone"},{"line_number":46,"context_line":"        self.context \u003d context.get_admin_context()"},{"line_number":47,"context_line":""},{"line_number":48,"context_line":"        agg \u003d {\u0027name\u0027: \u0027agg1\u0027}"}],"source_content_type":"text/x-python","patch_set":6,"id":"AAAAM3%2F%2FegU%3D","line":45,"updated":"2013-01-20 11:58:26.000000000","message":"Thanks Joe.\n\nI use the default config value now.","commit_id":"2ff67470f577b3d7867bd36001ae55cdc321d521"},{"author":{"_account_id":679,"name":"Kevin L. Mitchell","email":"klmitch@mit.edu","username":"klmitch"},"change_message_id":"87ed56adde69ba57a4683b6aa29738fd713d8059","unresolved":false,"context_lines":[{"line_number":1,"context_line":"# vim: tabstop\u003d4 shiftwidth\u003d4 softtabstop\u003d4"},{"line_number":2,"context_line":""},{"line_number":3,"context_line":"# All Rights Reserved."},{"line_number":4,"context_line":"#"},{"line_number":5,"context_line":"#    Licensed under the Apache License, Version 2.0 (the \"License\"); you may"},{"line_number":6,"context_line":"#    not use this file except in compliance with the License. You may obtain"}],"source_content_type":"text/x-python","patch_set":7,"id":"AAAAM3%2F%2FdPo%3D","line":3,"updated":"2013-01-21 21:24:44.000000000","message":"There should be some copyright attribution here, I believe…","commit_id":"24b3f8da70c9d3295ae02e7d27b15c50a8f50ce9"},{"author":{"_account_id":191,"name":"Trey Morris","email":"trey.morris@rackspace.com","username":"tr3buchet"},"change_message_id":"3544e72fe33145aabee65c595bf42be9e437ef8f","unresolved":false,"context_lines":[{"line_number":1,"context_line":"# vim: tabstop\u003d4 shiftwidth\u003d4 softtabstop\u003d4"},{"line_number":2,"context_line":""},{"line_number":3,"context_line":"# All Rights Reserved."},{"line_number":4,"context_line":"#"},{"line_number":5,"context_line":"#    Licensed under the Apache License, Version 2.0 (the \"License\"); you may"},{"line_number":6,"context_line":"#    not use this file except in compliance with the License. You may obtain"}],"source_content_type":"text/x-python","patch_set":7,"id":"AAAAM3%2F%2Fc4M%3D","line":3,"in_reply_to":"AAAAM3%2F%2FdPo%3D","updated":"2013-01-21 23:48:30.000000000","message":"yes, bad copy/paste. that has to go in.","commit_id":"24b3f8da70c9d3295ae02e7d27b15c50a8f50ce9"},{"author":{"_account_id":1678,"name":"Tiantian Gao","email":"gtt116@gmail.com","username":"gtt116"},"change_message_id":"fc819a79bb725131f5fb4e2603e0b86d715602b9","unresolved":false,"context_lines":[{"line_number":40,"context_line":"        self.host \u003d \u0027me\u0027"},{"line_number":41,"context_line":"        self.availability_zone \u003d \u0027nova-test\u0027"},{"line_number":42,"context_line":"        self.default_az \u003d CONF.default_availability_zone"},{"line_number":43,"context_line":"        self.default_in_az \u003d CONF.internal_service_availability_zone"},{"line_number":44,"context_line":"        self.context \u003d context.get_admin_context()"},{"line_number":45,"context_line":""},{"line_number":46,"context_line":"        agg \u003d {\u0027name\u0027: \u0027agg1\u0027}"}],"source_content_type":"text/x-python","patch_set":7,"id":"AAAAM3%2F%2Fefg%3D","line":43,"updated":"2013-01-20 13:34:53.000000000","message":"Thanks Joe.\n\nI use the default config value now.","commit_id":"24b3f8da70c9d3295ae02e7d27b15c50a8f50ce9"}]}