)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":1653,"name":"garyk","email":"gkotton@vmware.com","username":"garyk"},"change_message_id":"45e4c8fcb12ff808a0c529cca33a89d25d79b846","unresolved":false,"context_lines":[{"line_number":8,"context_line":""},{"line_number":9,"context_line":"There are two ways to give other greenthread chance to run:"},{"line_number":10,"context_line":"greenthread.sleep(0) or time.sleep(0). Add the second way in"},{"line_number":11,"context_line":"threading.rst and recommend the seconde way for contributors."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"Change-Id: I33dc73a0edfa5fde0e5fa8051a594874ab166970"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":7,"id":"7a740942_145f6a0f","line":11,"updated":"2015-12-10 07:00:08.000000000","message":"seconde \u003d\u003e second","commit_id":"cce559d98fea2153db318f54864ef9700e552f6c"},{"author":{"_account_id":9796,"name":"ChangBo Guo","email":"glongwave@gmail.com","username":"gcb"},"change_message_id":"43ecbc2f6f81193d2ea38beadbf6e7b682ed53dd","unresolved":false,"context_lines":[{"line_number":8,"context_line":""},{"line_number":9,"context_line":"There are two ways to give other greenthread chance to run:"},{"line_number":10,"context_line":"greenthread.sleep(0) or time.sleep(0). Add the second way in"},{"line_number":11,"context_line":"threading.rst and recommend the seconde way for contributors."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"Change-Id: I33dc73a0edfa5fde0e5fa8051a594874ab166970"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":7,"id":"7a740942_73550ff8","line":11,"in_reply_to":"7a740942_145f6a0f","updated":"2015-12-14 06:39:40.000000000","message":"Done","commit_id":"cce559d98fea2153db318f54864ef9700e552f6c"}],"doc/source/threading.rst":[{"author":{"_account_id":7730,"name":"Sahid Orentino Ferdjaoui","email":"sahid.ferdjaoui@industrialdiscipline.com","username":"sahid"},"change_message_id":"66c2609f1796d2e00829a249a6b4ea317ff0b535","unresolved":false,"context_lines":[{"line_number":32,"context_line":"\t..."},{"line_number":33,"context_line":"\tgreenthread.sleep(0)"},{"line_number":34,"context_line":""},{"line_number":35,"context_line":"Standard library time is monkey_patched, so there is another way::"},{"line_number":36,"context_line":"\timport time"},{"line_number":37,"context_line":"\t..."},{"line_number":38,"context_line":"\ttime.sleep(0)"}],"source_content_type":"text/x-rst","patch_set":1,"id":"ba3cc151_119501e3","line":35,"updated":"2015-07-07 10:03:37.000000000","message":"Don\u0027t we have to recommend one way than the other ?","commit_id":"2a0beae9c2d40d585028e9df0d8f2f166f384273"},{"author":{"_account_id":9107,"name":"Victor Stinner","email":"vstinner@redhat.com","username":"haypo"},"change_message_id":"ec2627f740e5891a74723ff4b6a9d68fcabc2eb6","unresolved":false,"context_lines":[{"line_number":32,"context_line":"\t..."},{"line_number":33,"context_line":"\tgreenthread.sleep(0)"},{"line_number":34,"context_line":""},{"line_number":35,"context_line":"Standard library time is monkey_patched, so there is another way::"},{"line_number":36,"context_line":"\timport time"},{"line_number":37,"context_line":"\t..."},{"line_number":38,"context_line":"\ttime.sleep(0)"}],"source_content_type":"text/x-rst","patch_set":1,"id":"ba3cc151_6b2dee8d","line":35,"in_reply_to":"ba3cc151_119501e3","updated":"2015-07-09 15:05:17.000000000","message":"\u003e Don\u0027t we have to recommend one way than the other ?\n\nIf we have to choose, I vote for greenthread.sleep(0). I hate monkey patching.","commit_id":"2a0beae9c2d40d585028e9df0d8f2f166f384273"},{"author":{"_account_id":9796,"name":"ChangBo Guo","email":"glongwave@gmail.com","username":"gcb"},"change_message_id":"518b68588762491ca756abcc58a83dfa54085eb4","unresolved":false,"context_lines":[{"line_number":32,"context_line":"\t..."},{"line_number":33,"context_line":"\tgreenthread.sleep(0)"},{"line_number":34,"context_line":""},{"line_number":35,"context_line":"Standard library time is monkey_patched, so there is another way::"},{"line_number":36,"context_line":"\timport time"},{"line_number":37,"context_line":"\t..."},{"line_number":38,"context_line":"\ttime.sleep(0)"}],"source_content_type":"text/x-rst","patch_set":1,"id":"ba3cc151_f65debec","line":35,"in_reply_to":"ba3cc151_119501e3","updated":"2015-07-07 12:23:25.000000000","message":"I would like to unify the way with time.sleep(0) ,  but not sure,  so change the doc :-),\n\nMaybe we really need use one way,   the similar is like: eventlet.spawn vs greenthread.spawn","commit_id":"2a0beae9c2d40d585028e9df0d8f2f166f384273"},{"author":{"_account_id":9796,"name":"ChangBo Guo","email":"glongwave@gmail.com","username":"gcb"},"change_message_id":"60b8e63435665e20ffd6d3d623a0e30598afc60d","unresolved":false,"context_lines":[{"line_number":31,"context_line":"\tfrom eventlet import greenthread"},{"line_number":32,"context_line":"\t..."},{"line_number":33,"context_line":"\tgreenthread.sleep(0)"},{"line_number":34,"context_line":"If time module is patched through evenlet.monkey_patch(), time.sleep(）does the"},{"line_number":35,"context_line":"same thing as greenthread.sleep."},{"line_number":36,"context_line":""},{"line_number":37,"context_line":"MySQL access and eventlet"}],"source_content_type":"text/x-rst","patch_set":2,"id":"fa80f949_66392f41","line":34,"updated":"2015-11-05 14:25:50.000000000","message":"s/evenlet/eventlet","commit_id":"840aeb295ca6c5e98a627b52e78d78e900570a94"},{"author":{"_account_id":7730,"name":"Sahid Orentino Ferdjaoui","email":"sahid.ferdjaoui@industrialdiscipline.com","username":"sahid"},"change_message_id":"1d17acf104bb39f3be18790fec643b63c5e591e5","unresolved":false,"context_lines":[{"line_number":31,"context_line":"\tfrom eventlet import greenthread"},{"line_number":32,"context_line":"\t..."},{"line_number":33,"context_line":"\tgreenthread.sleep(0)"},{"line_number":34,"context_line":"If time module is patched through eventlet.monkey_patch(), time.sleep(0）does"},{"line_number":35,"context_line":"the same thing as greenthread.sleep(0)."},{"line_number":36,"context_line":""},{"line_number":37,"context_line":"MySQL access and eventlet"}],"source_content_type":"text/x-rst","patch_set":5,"id":"9a8ffd7b_babafabe","line":34,"updated":"2015-12-01 11:44:30.000000000","message":"I do not see advantage of this, we should probably ask contributors to continue to use greenthread.sleep(0). Also we know that time\u0027s module is monkey patched.\n\n  Even if time\u0027s module is patched we recommend contributors to import and use \u0027greenthread.sleep(0)\u0027 instead of \u0027time.sleep(0)\u0027.","commit_id":"bb873c16b5ed66ebec930c20817d0bdc3742ee74"},{"author":{"_account_id":9796,"name":"ChangBo Guo","email":"glongwave@gmail.com","username":"gcb"},"change_message_id":"d47bceb19be8154328fa2e444b32a1eb3b671195","unresolved":false,"context_lines":[{"line_number":31,"context_line":"\tfrom eventlet import greenthread"},{"line_number":32,"context_line":"\t..."},{"line_number":33,"context_line":"\tgreenthread.sleep(0)"},{"line_number":34,"context_line":"If time module is patched through eventlet.monkey_patch(), time.sleep(0）does"},{"line_number":35,"context_line":"the same thing as greenthread.sleep(0)."},{"line_number":36,"context_line":""},{"line_number":37,"context_line":"MySQL access and eventlet"}],"source_content_type":"text/x-rst","patch_set":5,"id":"9a8ffd7b_8d0c9d43","line":34,"in_reply_to":"9a8ffd7b_babafabe","updated":"2015-12-01 13:19:13.000000000","message":"Here just describe two ways in our current code . And will recommend to use the first way in next patch. Is that ok ?","commit_id":"bb873c16b5ed66ebec930c20817d0bdc3742ee74"},{"author":{"_account_id":11564,"name":"Chris Dent","email":"cdent@anticdent.org","username":"chdent"},"change_message_id":"f26379d65f090c00ad92699a2def72c6d3e01827","unresolved":false,"context_lines":[{"line_number":33,"context_line":"\tgreenthread.sleep(0)"},{"line_number":34,"context_line":"In current code, time.sleep(0）does the same thing as greenthread.sleep(0) if"},{"line_number":35,"context_line":"time module is patched through eventlet.monkey_patch(). We recommend contributors"},{"line_number":36,"context_line":"to import and use \u0027greenthread.sleep(0)\u0027 instead of \u0027time.sleep(0)\u0027."},{"line_number":37,"context_line":""},{"line_number":38,"context_line":"MySQL access and eventlet"},{"line_number":39,"context_line":"-------------------------"}],"source_content_type":"text/x-rst","patch_set":6,"id":"7a740942_e53ddcdd","line":36,"updated":"2015-12-07 22:14:13.000000000","message":"This would be more correct as the more straightforward: \"To be explicit, we recommend contributors use ``greenthread.sleep()`` insted of ``time.sleep()``.\"","commit_id":"fcd78bcc72f526b4458740ba3ec28fbf29d9b6e6"},{"author":{"_account_id":9796,"name":"ChangBo Guo","email":"glongwave@gmail.com","username":"gcb"},"change_message_id":"ac9dd66fc049000cd1cbbdc01214e7867d966d13","unresolved":false,"context_lines":[{"line_number":33,"context_line":"\tgreenthread.sleep(0)"},{"line_number":34,"context_line":"In current code, time.sleep(0）does the same thing as greenthread.sleep(0) if"},{"line_number":35,"context_line":"time module is patched through eventlet.monkey_patch(). We recommend contributors"},{"line_number":36,"context_line":"to import and use \u0027greenthread.sleep(0)\u0027 instead of \u0027time.sleep(0)\u0027."},{"line_number":37,"context_line":""},{"line_number":38,"context_line":"MySQL access and eventlet"},{"line_number":39,"context_line":"-------------------------"}],"source_content_type":"text/x-rst","patch_set":6,"id":"7a740942_8356c204","line":36,"in_reply_to":"7a740942_0f98be69","updated":"2015-12-10 05:30:32.000000000","message":"The two ways did same thing,  but explicit way is better as other reviewers in previous patchsets.","commit_id":"fcd78bcc72f526b4458740ba3ec28fbf29d9b6e6"},{"author":{"_account_id":9796,"name":"ChangBo Guo","email":"glongwave@gmail.com","username":"gcb"},"change_message_id":"ac9dd66fc049000cd1cbbdc01214e7867d966d13","unresolved":false,"context_lines":[{"line_number":33,"context_line":"\tgreenthread.sleep(0)"},{"line_number":34,"context_line":"In current code, time.sleep(0）does the same thing as greenthread.sleep(0) if"},{"line_number":35,"context_line":"time module is patched through eventlet.monkey_patch(). We recommend contributors"},{"line_number":36,"context_line":"to import and use \u0027greenthread.sleep(0)\u0027 instead of \u0027time.sleep(0)\u0027."},{"line_number":37,"context_line":""},{"line_number":38,"context_line":"MySQL access and eventlet"},{"line_number":39,"context_line":"-------------------------"}],"source_content_type":"text/x-rst","patch_set":6,"id":"7a740942_e3d46648","line":36,"in_reply_to":"7a740942_e53ddcdd","updated":"2015-12-10 05:30:32.000000000","message":"Done","commit_id":"fcd78bcc72f526b4458740ba3ec28fbf29d9b6e6"},{"author":{"_account_id":2874,"name":"yong sheng gong","email":"gong.yongsheng@99cloud.net","username":"gongysh"},"change_message_id":"79a06a8f837b960992a6661bd07a3559ac815b95","unresolved":false,"context_lines":[{"line_number":33,"context_line":"\tgreenthread.sleep(0)"},{"line_number":34,"context_line":"In current code, time.sleep(0）does the same thing as greenthread.sleep(0) if"},{"line_number":35,"context_line":"time module is patched through eventlet.monkey_patch(). We recommend contributors"},{"line_number":36,"context_line":"to import and use \u0027greenthread.sleep(0)\u0027 instead of \u0027time.sleep(0)\u0027."},{"line_number":37,"context_line":""},{"line_number":38,"context_line":"MySQL access and eventlet"},{"line_number":39,"context_line":"-------------------------"}],"source_content_type":"text/x-rst","patch_set":6,"id":"7a740942_0f98be69","line":36,"in_reply_to":"7a740942_e53ddcdd","updated":"2015-12-10 01:31:31.000000000","message":"since we are patching, there is no different between time.sleep and greenthread.sleep.\n\nI don\u0027t care if we use which one.","commit_id":"fcd78bcc72f526b4458740ba3ec28fbf29d9b6e6"},{"author":{"_account_id":1653,"name":"garyk","email":"gkotton@vmware.com","username":"garyk"},"change_message_id":"45e4c8fcb12ff808a0c529cca33a89d25d79b846","unresolved":false,"context_lines":[{"line_number":33,"context_line":"\tgreenthread.sleep(0)"},{"line_number":34,"context_line":"In current code, time.sleep(0）does the same thing as greenthread.sleep(0) if"},{"line_number":35,"context_line":"time module is patched through eventlet.monkey_patch(). To be explicit, we recommend"},{"line_number":36,"context_line":"contributors use ``greenthread.sleep()`` instead of ``time.sleep()``."},{"line_number":37,"context_line":""},{"line_number":38,"context_line":"MySQL access and eventlet"},{"line_number":39,"context_line":"-------------------------"}],"source_content_type":"text/x-rst","patch_set":7,"id":"7a740942_74a4ae07","line":36,"updated":"2015-12-10 07:00:08.000000000","message":"it is worth considering adding a hacking check for this","commit_id":"cce559d98fea2153db318f54864ef9700e552f6c"},{"author":{"_account_id":9796,"name":"ChangBo Guo","email":"glongwave@gmail.com","username":"gcb"},"change_message_id":"43ecbc2f6f81193d2ea38beadbf6e7b682ed53dd","unresolved":false,"context_lines":[{"line_number":33,"context_line":"\tgreenthread.sleep(0)"},{"line_number":34,"context_line":"In current code, time.sleep(0）does the same thing as greenthread.sleep(0) if"},{"line_number":35,"context_line":"time module is patched through eventlet.monkey_patch(). To be explicit, we recommend"},{"line_number":36,"context_line":"contributors use ``greenthread.sleep()`` instead of ``time.sleep()``."},{"line_number":37,"context_line":""},{"line_number":38,"context_line":"MySQL access and eventlet"},{"line_number":39,"context_line":"-------------------------"}],"source_content_type":"text/x-rst","patch_set":7,"id":"7a740942_d3ee4321","line":36,"in_reply_to":"7a740942_74a4ae07","updated":"2015-12-14 06:39:40.000000000","message":"That will change lots of unit test, Maybe another commit is better.","commit_id":"cce559d98fea2153db318f54864ef9700e552f6c"}]}