)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":1653,"name":"garyk","email":"gkotton@vmware.com","username":"garyk"},"change_message_id":"560d1ee1c6a57c8b85e79c32d743babfa4bf8894","unresolved":false,"context_lines":[{"line_number":8,"context_line":""},{"line_number":9,"context_line":"This config option allow to specify a different script to be runned by the"},{"line_number":10,"context_line":"Xen toolstack than the default one."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"Change-Id: I2ab4525d63deda2a3e47ca5381f4e2c0ee5a79d7"},{"line_number":13,"context_line":"Partial-Bug: #1461642"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"3a50d1a3_197baabf","line":11,"updated":"2015-08-03 12:21:50.000000000","message":"Please add the DocImpact flag. This will help the guys doing the documentation to document the new configuration variable that you have added","commit_id":"2eed00838c608fee76100b3494b5ce8dffe4c13c"},{"author":{"_account_id":11303,"name":"Markus Zoeller (markus_z)","email":"mzoeller@linux.vnet.ibm.com","username":"mzoeller"},"change_message_id":"f8ca79f4867e51cae10c6426a5ad57742bb2ae1e","unresolved":false,"context_lines":[{"line_number":10,"context_line":"Xen toolstack than the default one."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"Change-Id: I2ab4525d63deda2a3e47ca5381f4e2c0ee5a79d7"},{"line_number":13,"context_line":"Partial-Bug: #1461642"},{"line_number":14,"context_line":"DocImpact"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":4,"id":"5a18252c_f2251309","line":13,"range":{"start_line":13,"start_character":0,"end_line":13,"end_character":7},"updated":"2016-04-14 12:06:35.000000000","message":"nit: Would be great if you could add a short notice what else (on a high-level) is needed to fix this bug completely.","commit_id":"8160d4d2f24dc6f73b8acefd1d3b7df6f118b8c8"},{"author":{"_account_id":11303,"name":"Markus Zoeller (markus_z)","email":"mzoeller@linux.vnet.ibm.com","username":"mzoeller"},"change_message_id":"b56152b445b2d436a21683fd091a72f6f7d4967b","unresolved":false,"context_lines":[{"line_number":10,"context_line":"Xen toolstack than the default one."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"Change-Id: I2ab4525d63deda2a3e47ca5381f4e2c0ee5a79d7"},{"line_number":13,"context_line":"Partial-Bug: #1461642"},{"line_number":14,"context_line":"DocImpact"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":4,"id":"1a122d0e_6e9365a4","line":13,"in_reply_to":"1a122d0e_659388a4","updated":"2016-04-15 15:31:44.000000000","message":"Does this mean the change [1] will fix the bug completely? If that\u0027s the case, [1] should use \"Closes-Bug: NNN\" in its commit message.\n\nMabe you can add before the change id something like:\n\n    \"A follow up patch needs to add a script to the\n    contrib directory to fix bug 1461642 completely.\"\n\nReferences:\n[1] https://review.openstack.org/#/c/201257/","commit_id":"8160d4d2f24dc6f73b8acefd1d3b7df6f118b8c8"},{"author":{"_account_id":14620,"name":"Anthony PERARD","email":"anthony.perard@citrix.com","username":"anthony-perard"},"change_message_id":"a0c18ed036ee4473a6e85460f7b5114d5d780423","unresolved":false,"context_lines":[{"line_number":10,"context_line":"Xen toolstack than the default one."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"Change-Id: I2ab4525d63deda2a3e47ca5381f4e2c0ee5a79d7"},{"line_number":13,"context_line":"Partial-Bug: #1461642"},{"line_number":14,"context_line":"DocImpact"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":4,"id":"1a122d0e_4e44a973","line":13,"in_reply_to":"1a122d0e_6e9365a4","updated":"2016-04-15 15:51:56.000000000","message":"Well, to fix the bug, a user would need to setup Nova to use the script. But yes, from Nova point of view the follow up patch will fix the bug. I\u0027ll close the bug with the follow up patch. (I left it as open as I thought of closing the bug with a update of the documentation.)","commit_id":"8160d4d2f24dc6f73b8acefd1d3b7df6f118b8c8"},{"author":{"_account_id":14620,"name":"Anthony PERARD","email":"anthony.perard@citrix.com","username":"anthony-perard"},"change_message_id":"210c4dd1b2ff8441c34dcbb9a67d2f9d5b4a4652","unresolved":false,"context_lines":[{"line_number":10,"context_line":"Xen toolstack than the default one."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"Change-Id: I2ab4525d63deda2a3e47ca5381f4e2c0ee5a79d7"},{"line_number":13,"context_line":"Partial-Bug: #1461642"},{"line_number":14,"context_line":"DocImpact"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":4,"id":"1a122d0e_659388a4","line":13,"in_reply_to":"5a18252c_f2251309","updated":"2016-04-15 14:52:03.000000000","message":"There is a description about what the issue is and what needs to be done in the following patch (https://review.openstack.org/201257). But I\u0027m not sure how I could bring that here.","commit_id":"8160d4d2f24dc6f73b8acefd1d3b7df6f118b8c8"},{"author":{"_account_id":11303,"name":"Markus Zoeller (markus_z)","email":"mzoeller@linux.vnet.ibm.com","username":"mzoeller"},"change_message_id":"f8ca79f4867e51cae10c6426a5ad57742bb2ae1e","unresolved":false,"context_lines":[{"line_number":11,"context_line":""},{"line_number":12,"context_line":"Change-Id: I2ab4525d63deda2a3e47ca5381f4e2c0ee5a79d7"},{"line_number":13,"context_line":"Partial-Bug: #1461642"},{"line_number":14,"context_line":"DocImpact"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":4,"id":"5a18252c_f2d073f8","line":14,"range":{"start_line":14,"start_character":0,"end_line":14,"end_character":9},"updated":"2016-04-14 12:06:35.000000000","message":"The process got changed since your first patch set. Using \"DocImpact\" in the commit message means that one of the manuals have to be updated [1]. I don\u0027t think that\u0027s the case here, which means I suggest to remove this flag.\n\nYou\u0027re introducing a new config option and usually we notify the ops with a \"reno\" file about this [2][3]. I suggest to use the section \"features\" as the new option seem to have no upgrade impact. Under [4] is an explanation how to create a \"reno\" file. That file should then be part of your patch.\n\n[1] http://lists.openstack.org/pipermail/openstack-dev/2016-March/088382.html\n[2] http://docs.openstack.org/developer/nova/code-review.html#when-a-release-note-is-needed\n[3] http://docs.openstack.org/releasenotes/nova/unreleased.html\n[4] http://docs.openstack.org/developer/reno/usage.html#creating-new-release-notes","commit_id":"8160d4d2f24dc6f73b8acefd1d3b7df6f118b8c8"},{"author":{"_account_id":14620,"name":"Anthony PERARD","email":"anthony.perard@citrix.com","username":"anthony-perard"},"change_message_id":"210c4dd1b2ff8441c34dcbb9a67d2f9d5b4a4652","unresolved":false,"context_lines":[{"line_number":11,"context_line":""},{"line_number":12,"context_line":"Change-Id: I2ab4525d63deda2a3e47ca5381f4e2c0ee5a79d7"},{"line_number":13,"context_line":"Partial-Bug: #1461642"},{"line_number":14,"context_line":"DocImpact"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":4,"id":"1a122d0e_25f870e5","line":14,"in_reply_to":"5a18252c_f2d073f8","updated":"2016-04-15 14:52:03.000000000","message":"Will do.","commit_id":"8160d4d2f24dc6f73b8acefd1d3b7df6f118b8c8"}],"nova/tests/unit/virt/libvirt/test_vif.py":[{"author":{"_account_id":14620,"name":"Anthony PERARD","email":"anthony.perard@citrix.com","username":"anthony-perard"},"change_message_id":"58eca537a922b955fc4ae82ec999fbcdcba22172","unresolved":false,"context_lines":[{"line_number":568,"context_line":"        self._assertModel(xml)"},{"line_number":569,"context_line":"        node \u003d self._get_node(xml)"},{"line_number":570,"context_line":"        script \u003d node.find(\"script\").get(\"path\")"},{"line_number":571,"context_line":"        self.assertEqual(script, \"new-default-script\")"},{"line_number":572,"context_line":""},{"line_number":573,"context_line":"    def test_generic_driver_none(self):"},{"line_number":574,"context_line":"        d \u003d vif.LibvirtGenericVIFDriver()"}],"source_content_type":"text/x-python","patch_set":2,"id":"ba15a1d1_b0d39a03","line":571,"updated":"2015-09-17 11:12:59.000000000","message":"Most of the other assertEqual in this file are in (actual, expected) order.","commit_id":"f878c8a04dc513343bf34a07e0b47aca986fddd7"},{"author":{"_account_id":8213,"name":"Claudiu Belu","email":"cbelu@cloudbasesolutions.com","username":"claudiub"},"change_message_id":"e69f814c8845b417e0f1caa19dfb5e3cec205088","unresolved":false,"context_lines":[{"line_number":568,"context_line":"        self._assertModel(xml)"},{"line_number":569,"context_line":"        node \u003d self._get_node(xml)"},{"line_number":570,"context_line":"        script \u003d node.find(\"script\").get(\"path\")"},{"line_number":571,"context_line":"        self.assertEqual(script, \"new-default-script\")"},{"line_number":572,"context_line":""},{"line_number":573,"context_line":"    def test_generic_driver_none(self):"},{"line_number":574,"context_line":"        d \u003d vif.LibvirtGenericVIFDriver()"}],"source_content_type":"text/x-python","patch_set":2,"id":"ba15a1d1_00addfe8","line":571,"updated":"2015-09-14 18:02:41.000000000","message":"usually, it\u0027s assertEqual(expected, actual). It is switched here.","commit_id":"f878c8a04dc513343bf34a07e0b47aca986fddd7"},{"author":{"_account_id":8213,"name":"Claudiu Belu","email":"cbelu@cloudbasesolutions.com","username":"claudiub"},"change_message_id":"e13750ebf35230f2f3cff1bd6962aa0770f276f0","unresolved":false,"context_lines":[{"line_number":568,"context_line":"        self._assertModel(xml)"},{"line_number":569,"context_line":"        node \u003d self._get_node(xml)"},{"line_number":570,"context_line":"        script \u003d node.find(\"script\").get(\"path\")"},{"line_number":571,"context_line":"        self.assertEqual(script, \"new-default-script\")"},{"line_number":572,"context_line":""},{"line_number":573,"context_line":"    def test_generic_driver_none(self):"},{"line_number":574,"context_line":"        d \u003d vif.LibvirtGenericVIFDriver()"}],"source_content_type":"text/x-python","patch_set":2,"id":"ba15a1d1_2beb9f14","line":571,"in_reply_to":"ba15a1d1_b0d39a03","updated":"2015-09-17 11:24:16.000000000","message":"there are a lot of patches waiting that are just changing the order of assertEqual from (actual, expected) to (expected, actual). no need to make their work harder, IMO.","commit_id":"f878c8a04dc513343bf34a07e0b47aca986fddd7"}],"nova/virt/libvirt/driver.py":[{"author":{"_account_id":1653,"name":"garyk","email":"gkotton@vmware.com","username":"garyk"},"change_message_id":"560d1ee1c6a57c8b85e79c32d743babfa4bf8894","unresolved":false,"context_lines":[{"line_number":190,"context_line":"                default\u003d\u0027/usr/lib/xen/boot/hvmloader\u0027,"},{"line_number":191,"context_line":"                help\u003d\u0027Location where the Xen hvmloader is kept\u0027),"},{"line_number":192,"context_line":"    cfg.StrOpt(\u0027xen_vif_bridge_script_path\u0027,"},{"line_number":193,"context_line":"                default\u003dNone,"},{"line_number":194,"context_line":"                help\u003d\u0027Replace the default executed vif-bridge script for \u0027"},{"line_number":195,"context_line":"                      \u0027Xen guests\u0027),"},{"line_number":196,"context_line":"    cfg.ListOpt(\u0027disk_cachemodes\u0027,"}],"source_content_type":"text/x-python","patch_set":1,"id":"3a50d1a3_79b2ee97","line":193,"updated":"2015-08-03 12:21:50.000000000","message":"by default the default value is None. You do not need to explicitly set this","commit_id":"2eed00838c608fee76100b3494b5ce8dffe4c13c"},{"author":{"_account_id":8213,"name":"Claudiu Belu","email":"cbelu@cloudbasesolutions.com","username":"claudiub"},"change_message_id":"e69f814c8845b417e0f1caa19dfb5e3cec205088","unresolved":false,"context_lines":[{"line_number":191,"context_line":"                help\u003d\u0027Location where the Xen hvmloader is kept\u0027),"},{"line_number":192,"context_line":"    cfg.StrOpt(\u0027xen_vif_bridge_script_path\u0027,"},{"line_number":193,"context_line":"                help\u003d\u0027Replace the default executed vif-bridge script for \u0027"},{"line_number":194,"context_line":"                      \u0027Xen guests\u0027),"},{"line_number":195,"context_line":"    cfg.ListOpt(\u0027disk_cachemodes\u0027,"},{"line_number":196,"context_line":"                 default\u003d[],"},{"line_number":197,"context_line":"                 help\u003d\u0027Specific cachemodes to use for different disk types \u0027"}],"source_content_type":"text/x-python","patch_set":2,"id":"ba15a1d1_e068ebbc","line":194,"updated":"2015-09-14 18:02:41.000000000","message":"there\u0027s one too many spaces here.","commit_id":"f878c8a04dc513343bf34a07e0b47aca986fddd7"},{"author":{"_account_id":14620,"name":"Anthony PERARD","email":"anthony.perard@citrix.com","username":"anthony-perard"},"change_message_id":"58eca537a922b955fc4ae82ec999fbcdcba22172","unresolved":false,"context_lines":[{"line_number":191,"context_line":"                help\u003d\u0027Location where the Xen hvmloader is kept\u0027),"},{"line_number":192,"context_line":"    cfg.StrOpt(\u0027xen_vif_bridge_script_path\u0027,"},{"line_number":193,"context_line":"                help\u003d\u0027Replace the default executed vif-bridge script for \u0027"},{"line_number":194,"context_line":"                      \u0027Xen guests\u0027),"},{"line_number":195,"context_line":"    cfg.ListOpt(\u0027disk_cachemodes\u0027,"},{"line_number":196,"context_line":"                 default\u003d[],"},{"line_number":197,"context_line":"                 help\u003d\u0027Specific cachemodes to use for different disk types \u0027"}],"source_content_type":"text/x-python","patch_set":2,"id":"ba15a1d1_b0287ae3","line":194,"in_reply_to":"ba15a1d1_e068ebbc","updated":"2015-09-17 11:12:59.000000000","message":"Done","commit_id":"f878c8a04dc513343bf34a07e0b47aca986fddd7"},{"author":{"_account_id":11303,"name":"Markus Zoeller (markus_z)","email":"mzoeller@linux.vnet.ibm.com","username":"mzoeller"},"change_message_id":"688b7f10a73af760aed6ef0ccd28b97d39aca46b","unresolved":false,"context_lines":[{"line_number":237,"context_line":"                help\u003d\u0027Location where the Xen hvmloader is kept\u0027),"},{"line_number":238,"context_line":"    cfg.StrOpt(\u0027xen_vif_bridge_script_path\u0027,"},{"line_number":239,"context_line":"                help\u003d\u0027Replace the default executed vif-bridge script for \u0027"},{"line_number":240,"context_line":"                     \u0027Xen guests\u0027),"},{"line_number":241,"context_line":"    cfg.ListOpt(\u0027disk_cachemodes\u0027,"},{"line_number":242,"context_line":"                 default\u003d[],"},{"line_number":243,"context_line":"                 help\u003d\u0027Specific cachemodes to use for different disk types \u0027"}],"source_content_type":"text/x-python","patch_set":3,"id":"5a2ca52d_61705473","line":240,"updated":"2015-10-14 08:30:45.000000000","message":"I\u0027d really like to have more information on this config option. We have a few points in the (new) code review guide which could be checked here: http://docs.openstack.org/developer/nova/code-review.html#config-options","commit_id":"7b070850b68f345b5abd1fb071abebc0e961a6c1"},{"author":{"_account_id":2750,"name":"Sean Dague","email":"sean@dague.net","username":"sdague"},"change_message_id":"d9896af64c336e41d72b4aba55ef22d3ce2ef2ed","unresolved":false,"context_lines":[{"line_number":237,"context_line":"                help\u003d\u0027Location where the Xen hvmloader is kept\u0027),"},{"line_number":238,"context_line":"    cfg.StrOpt(\u0027xen_vif_bridge_script_path\u0027,"},{"line_number":239,"context_line":"                help\u003d\u0027Replace the default executed vif-bridge script for \u0027"},{"line_number":240,"context_line":"                     \u0027Xen guests\u0027),"},{"line_number":241,"context_line":"    cfg.ListOpt(\u0027disk_cachemodes\u0027,"},{"line_number":242,"context_line":"                 default\u003d[],"},{"line_number":243,"context_line":"                 help\u003d\u0027Specific cachemodes to use for different disk types \u0027"}],"source_content_type":"text/x-python","patch_set":3,"id":"3a7e1126_135f6ee6","line":240,"in_reply_to":"5a2ca52d_61705473","updated":"2015-12-17 14:30:06.000000000","message":"Agreed, this needs a lot more explanation about why this is needed.","commit_id":"7b070850b68f345b5abd1fb071abebc0e961a6c1"},{"author":{"_account_id":11303,"name":"Markus Zoeller (markus_z)","email":"mzoeller@linux.vnet.ibm.com","username":"mzoeller"},"change_message_id":"f8ca79f4867e51cae10c6426a5ad57742bb2ae1e","unresolved":false,"context_lines":[{"line_number":267,"context_line":"    cfg.StrOpt(\u0027xen_hvmloader_path\u0027,"},{"line_number":268,"context_line":"                default\u003d\u0027/usr/lib/xen/boot/hvmloader\u0027,"},{"line_number":269,"context_line":"                help\u003d\u0027Location where the Xen hvmloader is kept\u0027),"},{"line_number":270,"context_line":"    cfg.StrOpt(\u0027xen_vif_bridge_script_path\u0027,"},{"line_number":271,"context_line":"               help\u003d\"\"\""},{"line_number":272,"context_line":"Replace the default executed vif-bridge script for Xen guests."},{"line_number":273,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"5a18252c_b55b85f5","line":270,"range":{"start_line":270,"start_character":38,"end_line":270,"end_character":42},"updated":"2016-04-14 12:06:35.000000000","message":"That\u0027s a fully qualified path or is a base directory assumed?","commit_id":"8160d4d2f24dc6f73b8acefd1d3b7df6f118b8c8"},{"author":{"_account_id":14620,"name":"Anthony PERARD","email":"anthony.perard@citrix.com","username":"anthony-perard"},"change_message_id":"a0c18ed036ee4473a6e85460f7b5114d5d780423","unresolved":false,"context_lines":[{"line_number":267,"context_line":"    cfg.StrOpt(\u0027xen_hvmloader_path\u0027,"},{"line_number":268,"context_line":"                default\u003d\u0027/usr/lib/xen/boot/hvmloader\u0027,"},{"line_number":269,"context_line":"                help\u003d\u0027Location where the Xen hvmloader is kept\u0027),"},{"line_number":270,"context_line":"    cfg.StrOpt(\u0027xen_vif_bridge_script_path\u0027,"},{"line_number":271,"context_line":"               help\u003d\"\"\""},{"line_number":272,"context_line":"Replace the default executed vif-bridge script for Xen guests."},{"line_number":273,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"1a122d0e_b962e5d6","line":270,"in_reply_to":"1a122d0e_ab90cfed","updated":"2016-04-15 15:51:56.000000000","message":"Done","commit_id":"8160d4d2f24dc6f73b8acefd1d3b7df6f118b8c8"},{"author":{"_account_id":14620,"name":"Anthony PERARD","email":"anthony.perard@citrix.com","username":"anthony-perard"},"change_message_id":"210c4dd1b2ff8441c34dcbb9a67d2f9d5b4a4652","unresolved":false,"context_lines":[{"line_number":267,"context_line":"    cfg.StrOpt(\u0027xen_hvmloader_path\u0027,"},{"line_number":268,"context_line":"                default\u003d\u0027/usr/lib/xen/boot/hvmloader\u0027,"},{"line_number":269,"context_line":"                help\u003d\u0027Location where the Xen hvmloader is kept\u0027),"},{"line_number":270,"context_line":"    cfg.StrOpt(\u0027xen_vif_bridge_script_path\u0027,"},{"line_number":271,"context_line":"               help\u003d\"\"\""},{"line_number":272,"context_line":"Replace the default executed vif-bridge script for Xen guests."},{"line_number":273,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"5a18252c_f7184ed5","line":270,"in_reply_to":"5a18252c_b55b85f5","updated":"2016-04-15 14:52:03.000000000","message":"Both. If it is not a full path, the base directory would be /etc/xen/scripts.","commit_id":"8160d4d2f24dc6f73b8acefd1d3b7df6f118b8c8"},{"author":{"_account_id":11303,"name":"Markus Zoeller (markus_z)","email":"mzoeller@linux.vnet.ibm.com","username":"mzoeller"},"change_message_id":"b56152b445b2d436a21683fd091a72f6f7d4967b","unresolved":false,"context_lines":[{"line_number":267,"context_line":"    cfg.StrOpt(\u0027xen_hvmloader_path\u0027,"},{"line_number":268,"context_line":"                default\u003d\u0027/usr/lib/xen/boot/hvmloader\u0027,"},{"line_number":269,"context_line":"                help\u003d\u0027Location where the Xen hvmloader is kept\u0027),"},{"line_number":270,"context_line":"    cfg.StrOpt(\u0027xen_vif_bridge_script_path\u0027,"},{"line_number":271,"context_line":"               help\u003d\"\"\""},{"line_number":272,"context_line":"Replace the default executed vif-bridge script for Xen guests."},{"line_number":273,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"1a122d0e_ab90cfed","line":270,"in_reply_to":"5a18252c_f7184ed5","updated":"2016-04-15 15:31:44.000000000","message":"Ah, OK, I didn\u0027t find that path in the Nova code. Maybe it\u0027s worth pointing out that there is a default path were XEN looks for this script if it\u0027s only a filename.","commit_id":"8160d4d2f24dc6f73b8acefd1d3b7df6f118b8c8"},{"author":{"_account_id":11303,"name":"Markus Zoeller (markus_z)","email":"mzoeller@linux.vnet.ibm.com","username":"mzoeller"},"change_message_id":"f8ca79f4867e51cae10c6426a5ad57742bb2ae1e","unresolved":false,"context_lines":[{"line_number":269,"context_line":"                help\u003d\u0027Location where the Xen hvmloader is kept\u0027),"},{"line_number":270,"context_line":"    cfg.StrOpt(\u0027xen_vif_bridge_script_path\u0027,"},{"line_number":271,"context_line":"               help\u003d\"\"\""},{"line_number":272,"context_line":"Replace the default executed vif-bridge script for Xen guests."},{"line_number":273,"context_line":""},{"line_number":274,"context_line":"The Xen toolstack (libxl via libvirt-xen) will execute a script to setup a"},{"line_number":275,"context_line":"vif."}],"source_content_type":"text/x-python","patch_set":4,"id":"5a18252c_15987977","line":272,"range":{"start_line":272,"start_character":40,"end_line":272,"end_character":46},"updated":"2016-04-14 12:06:35.000000000","message":"nit: I assume that only shell scripts are valid? Maybe specifying this would be useful.","commit_id":"8160d4d2f24dc6f73b8acefd1d3b7df6f118b8c8"},{"author":{"_account_id":14620,"name":"Anthony PERARD","email":"anthony.perard@citrix.com","username":"anthony-perard"},"change_message_id":"210c4dd1b2ff8441c34dcbb9a67d2f9d5b4a4652","unresolved":false,"context_lines":[{"line_number":269,"context_line":"                help\u003d\u0027Location where the Xen hvmloader is kept\u0027),"},{"line_number":270,"context_line":"    cfg.StrOpt(\u0027xen_vif_bridge_script_path\u0027,"},{"line_number":271,"context_line":"               help\u003d\"\"\""},{"line_number":272,"context_line":"Replace the default executed vif-bridge script for Xen guests."},{"line_number":273,"context_line":""},{"line_number":274,"context_line":"The Xen toolstack (libxl via libvirt-xen) will execute a script to setup a"},{"line_number":275,"context_line":"vif."}],"source_content_type":"text/x-python","patch_set":4,"id":"5a18252c_1797caec","line":272,"in_reply_to":"5a18252c_15987977","updated":"2016-04-15 14:52:03.000000000","message":"No, anything that is executable can work.","commit_id":"8160d4d2f24dc6f73b8acefd1d3b7df6f118b8c8"},{"author":{"_account_id":11303,"name":"Markus Zoeller (markus_z)","email":"mzoeller@linux.vnet.ibm.com","username":"mzoeller"},"change_message_id":"f8ca79f4867e51cae10c6426a5ad57742bb2ae1e","unresolved":false,"context_lines":[{"line_number":271,"context_line":"               help\u003d\"\"\""},{"line_number":272,"context_line":"Replace the default executed vif-bridge script for Xen guests."},{"line_number":273,"context_line":""},{"line_number":274,"context_line":"The Xen toolstack (libxl via libvirt-xen) will execute a script to setup a"},{"line_number":275,"context_line":"vif."},{"line_number":276,"context_line":""},{"line_number":277,"context_line":"The default script run by the Xen toolstack may race with Nova to update"}],"source_content_type":"text/x-python","patch_set":4,"id":"5a18252c_5575d12f","line":274,"range":{"start_line":274,"start_character":47,"end_line":274,"end_character":54},"updated":"2016-04-14 12:06:35.000000000","message":"nit: Is there a special point in time when this script gets executed? Maybe something like: \"After event X but before event Y\"","commit_id":"8160d4d2f24dc6f73b8acefd1d3b7df6f118b8c8"},{"author":{"_account_id":14620,"name":"Anthony PERARD","email":"anthony.perard@citrix.com","username":"anthony-perard"},"change_message_id":"210c4dd1b2ff8441c34dcbb9a67d2f9d5b4a4652","unresolved":false,"context_lines":[{"line_number":271,"context_line":"               help\u003d\"\"\""},{"line_number":272,"context_line":"Replace the default executed vif-bridge script for Xen guests."},{"line_number":273,"context_line":""},{"line_number":274,"context_line":"The Xen toolstack (libxl via libvirt-xen) will execute a script to setup a"},{"line_number":275,"context_line":"vif."},{"line_number":276,"context_line":""},{"line_number":277,"context_line":"The default script run by the Xen toolstack may race with Nova to update"}],"source_content_type":"text/x-python","patch_set":4,"id":"5a18252c_b7a53648","line":274,"in_reply_to":"5a18252c_5575d12f","updated":"2016-04-15 14:52:03.000000000","message":"Yes, at guest creation time. I\u0027ll add this to the description.","commit_id":"8160d4d2f24dc6f73b8acefd1d3b7df6f118b8c8"},{"author":{"_account_id":11303,"name":"Markus Zoeller (markus_z)","email":"mzoeller@linux.vnet.ibm.com","username":"mzoeller"},"change_message_id":"f8ca79f4867e51cae10c6426a5ad57742bb2ae1e","unresolved":false,"context_lines":[{"line_number":280,"context_line":""},{"line_number":281,"context_line":"An example script that do everything that the default vif-bridge script"},{"line_number":282,"context_line":"does except the iptables update can be found in contrib directory."},{"line_number":283,"context_line":"            \"\"\"),"},{"line_number":284,"context_line":"    cfg.ListOpt(\u0027disk_cachemodes\u0027,"},{"line_number":285,"context_line":"                 default\u003d[],"},{"line_number":286,"context_line":"                 help\u003d\u0027Specific cachemodes to use for different disk types \u0027"}],"source_content_type":"text/x-python","patch_set":4,"id":"5a18252c_95d2c95a","line":283,"updated":"2016-04-14 12:06:35.000000000","message":"Please add also:\n\n  Services that use this:\n\n  * ``nova-compute``\n\n  Related options:\n\n  * None\n\nI assume this option has no relation to other config options, what why I suggested to use \"None\" here. If you know otherwise, add the related config options here please.","commit_id":"8160d4d2f24dc6f73b8acefd1d3b7df6f118b8c8"},{"author":{"_account_id":14620,"name":"Anthony PERARD","email":"anthony.perard@citrix.com","username":"anthony-perard"},"change_message_id":"210c4dd1b2ff8441c34dcbb9a67d2f9d5b4a4652","unresolved":false,"context_lines":[{"line_number":280,"context_line":""},{"line_number":281,"context_line":"An example script that do everything that the default vif-bridge script"},{"line_number":282,"context_line":"does except the iptables update can be found in contrib directory."},{"line_number":283,"context_line":"            \"\"\"),"},{"line_number":284,"context_line":"    cfg.ListOpt(\u0027disk_cachemodes\u0027,"},{"line_number":285,"context_line":"                 default\u003d[],"},{"line_number":286,"context_line":"                 help\u003d\u0027Specific cachemodes to use for different disk types \u0027"}],"source_content_type":"text/x-python","patch_set":4,"id":"5a18252c_f7c04e52","line":283,"in_reply_to":"5a18252c_95d2c95a","updated":"2016-04-15 14:52:03.000000000","message":"Done","commit_id":"8160d4d2f24dc6f73b8acefd1d3b7df6f118b8c8"}],"nova/virt/libvirt/vif.py":[{"author":{"_account_id":8213,"name":"Claudiu Belu","email":"cbelu@cloudbasesolutions.com","username":"claudiub"},"change_message_id":"e69f814c8845b417e0f1caa19dfb5e3cec205088","unresolved":false,"context_lines":[{"line_number":162,"context_line":"        designer.set_vif_host_backend_bridge_config("},{"line_number":163,"context_line":"            conf, self.get_bridge_name(vif),"},{"line_number":164,"context_line":"            self.get_vif_devname(vif))"},{"line_number":165,"context_line":"        if virt_type in (\u0027xen\u0027):"},{"line_number":166,"context_line":"            conf.script \u003d CONF.libvirt.xen_vif_bridge_script_path"},{"line_number":167,"context_line":""},{"line_number":168,"context_line":"        mac_id \u003d vif[\u0027address\u0027].replace(\u0027:\u0027, \u0027\u0027)"}],"source_content_type":"text/x-python","patch_set":2,"id":"ba15a1d1_40819749","line":165,"updated":"2015-09-14 18:02:41.000000000","message":"why not\n\n    if virt_type \u003d\u003d \u0027xen\u0027:\n\n?\nit looks strange to have it this way.","commit_id":"f878c8a04dc513343bf34a07e0b47aca986fddd7"},{"author":{"_account_id":14620,"name":"Anthony PERARD","email":"anthony.perard@citrix.com","username":"anthony-perard"},"change_message_id":"58eca537a922b955fc4ae82ec999fbcdcba22172","unresolved":false,"context_lines":[{"line_number":162,"context_line":"        designer.set_vif_host_backend_bridge_config("},{"line_number":163,"context_line":"            conf, self.get_bridge_name(vif),"},{"line_number":164,"context_line":"            self.get_vif_devname(vif))"},{"line_number":165,"context_line":"        if virt_type in (\u0027xen\u0027):"},{"line_number":166,"context_line":"            conf.script \u003d CONF.libvirt.xen_vif_bridge_script_path"},{"line_number":167,"context_line":""},{"line_number":168,"context_line":"        mac_id \u003d vif[\u0027address\u0027].replace(\u0027:\u0027, \u0027\u0027)"}],"source_content_type":"text/x-python","patch_set":2,"id":"ba15a1d1_704c22c8","line":165,"in_reply_to":"ba15a1d1_40819749","updated":"2015-09-17 11:12:59.000000000","message":"Done","commit_id":"f878c8a04dc513343bf34a07e0b47aca986fddd7"}]}