)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":7,"name":"Jay Pipes","email":"jaypipes@gmail.com","username":"jaypipes"},"change_message_id":"df37471813dcf8df98d7f17cace027a83274325a","unresolved":false,"context_lines":[{"line_number":31,"context_line":"  }"},{"line_number":32,"context_line":"}"},{"line_number":33,"context_line":""},{"line_number":34,"context_line":"Partially Implements: blueprint vmware-webmks-console"},{"line_number":35,"context_line":""},{"line_number":36,"context_line":"Change-Id: I7217b999fb8d64a5646d8f20d7426c26553871d7"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"ba3cc151_3b9254a0","line":34,"updated":"2015-07-07 14:52:49.000000000","message":"APIImpact please! :)","commit_id":"181fe32652eb97777e13cc8e7cb3eb52884e6997"}],"nova/api/openstack/compute/schemas/v3/remote_consoles.py":[{"author":{"_account_id":782,"name":"John Garbutt","email":"john@johngarbutt.com","username":"johngarbutt"},"change_message_id":"e60ad60872b941b93bb0c24e1e091c3c77afbe5a","unresolved":false,"context_lines":[{"line_number":117,"context_line":"            \u0027type\u0027: \u0027object\u0027,"},{"line_number":118,"context_line":"            \u0027properties\u0027: {"},{"line_number":119,"context_line":"                \u0027protocol\u0027: {"},{"line_number":120,"context_line":"                    \u0027enum\u0027: [\u0027vnc\u0027, \u0027spice\u0027, \u0027rdp\u0027, \u0027serial\u0027, \u0027mks\u0027],"},{"line_number":121,"context_line":"                },"},{"line_number":122,"context_line":"                \u0027type\u0027: {"},{"line_number":123,"context_line":"                    \u0027enum\u0027: [\u0027novnc\u0027, \u0027xvpvnc\u0027, \u0027rdp-html5\u0027,"}],"source_content_type":"text/x-python","patch_set":9,"id":"3a50d1a3_07f37c9f","line":120,"updated":"2015-07-27 10:35:32.000000000","message":"I do hate this cut and paste, but this is consistent, so lets keep this for now, and fix them all in a consistent way.","commit_id":"14ca7c37baeb46bc277f5e4e0cfec704b5174d7f"}],"nova/compute/api.py":[{"author":{"_account_id":7,"name":"Jay Pipes","email":"jaypipes@gmail.com","username":"jaypipes"},"change_message_id":"df37471813dcf8df98d7f17cace027a83274325a","unresolved":false,"context_lines":[{"line_number":2946,"context_line":"    def get_mks_console(self, context, instance, console_type):"},{"line_number":2947,"context_line":"        \"\"\"Get a url to an instance Console.\"\"\""},{"line_number":2948,"context_line":"        #TODO(rgerganov) will be implemented in a subsequent patch"},{"line_number":2949,"context_line":"        return {\u0027url\u0027: \u0027http://todo\u0027}"},{"line_number":2950,"context_line":""},{"line_number":2951,"context_line":"    @wrap_check_policy"},{"line_number":2952,"context_line":"    @check_instance_host"}],"source_content_type":"text/x-python","patch_set":1,"id":"ba3cc151_7be0dcfa","line":2949,"updated":"2015-07-07 14:52:49.000000000","message":"Hmm, the problem with not doing the implementation patch *first* is that now you are adding 2.7 microversion API in this patch, which returns a placeholder response as above. You would need to add an *additional* 2.8 microversion API when you actually add the implementation, since clients of the Compute API would have no way to determine whether the response for the get mks console would return the real thing, or the above placeholder :)","commit_id":"181fe32652eb97777e13cc8e7cb3eb52884e6997"}],"nova/tests/functional/v3/test_remote_consoles.py":[{"author":{"_account_id":5754,"name":"Alex Xu","email":"hejie.xu@intel.com","username":"xuhj"},"change_message_id":"3a3d790ad66d129cf81e2f062640198c8ff96428","unresolved":false,"context_lines":[{"line_number":111,"context_line":""},{"line_number":112,"context_line":"class ConsolesV27SampleJsonTests(test_servers.ServersSampleBase):"},{"line_number":113,"context_line":"    extension_name \u003d \"os-remote-consoles\""},{"line_number":114,"context_line":"    _api_version \u003d \u0027v3\u0027"},{"line_number":115,"context_line":""},{"line_number":116,"context_line":"    def setUp(self):"},{"line_number":117,"context_line":"        super(ConsolesV27SampleJsonTests, self).setUp()"}],"source_content_type":"text/x-python","patch_set":4,"id":"3a50d1a3_2237d8b1","line":114,"updated":"2015-07-20 06:41:13.000000000","message":"we will get rid of v3. So you can write like this https://github.com/openstack/nova/blob/master/nova/tests/functional/v3/test_keypairs.py#L119","commit_id":"d7bbdf4b942199f6a1377b5507050e9f4c44f57c"},{"author":{"_account_id":9172,"name":"Radoslav Gerganov","email":"rgerganov@vmware.com","username":"rgerganov"},"change_message_id":"f3be94d4e140ddd35e4aecab2cbd71640cd6453f","unresolved":false,"context_lines":[{"line_number":111,"context_line":""},{"line_number":112,"context_line":"class ConsolesV27SampleJsonTests(test_servers.ServersSampleBase):"},{"line_number":113,"context_line":"    extension_name \u003d \"os-remote-consoles\""},{"line_number":114,"context_line":"    _api_version \u003d \u0027v3\u0027"},{"line_number":115,"context_line":""},{"line_number":116,"context_line":"    def setUp(self):"},{"line_number":117,"context_line":"        super(ConsolesV27SampleJsonTests, self).setUp()"}],"source_content_type":"text/x-python","patch_set":4,"id":"3a50d1a3_5b819849","line":114,"in_reply_to":"3a50d1a3_2237d8b1","updated":"2015-07-20 15:12:19.000000000","message":"I tried but _post_server() doesn\u0027t work in this case; I prefer to keep it that way for now","commit_id":"d7bbdf4b942199f6a1377b5507050e9f4c44f57c"},{"author":{"_account_id":782,"name":"John Garbutt","email":"john@johngarbutt.com","username":"johngarbutt"},"change_message_id":"e60ad60872b941b93bb0c24e1e091c3c77afbe5a","unresolved":false,"context_lines":[{"line_number":109,"context_line":"        self._verify_response(\u0027create-vnc-console-resp\u0027, subs, response, 200)"},{"line_number":110,"context_line":""},{"line_number":111,"context_line":""},{"line_number":112,"context_line":"class ConsolesV28SampleJsonTests(test_servers.ServersSampleBase):"},{"line_number":113,"context_line":"    extension_name \u003d \"os-remote-consoles\""},{"line_number":114,"context_line":"    _api_version \u003d \u0027v3\u0027"},{"line_number":115,"context_line":""}],"source_content_type":"text/x-python","patch_set":9,"id":"3a50d1a3_c77914fe","line":112,"updated":"2015-07-27 10:35:32.000000000","message":"I thought we would extend ConsolesV26SampleJsonTests here, but I guess this is consistent for now.","commit_id":"14ca7c37baeb46bc277f5e4e0cfec704b5174d7f"}],"nova/tests/unit/api/openstack/compute/contrib/test_consoles.py":[{"author":{"_account_id":5754,"name":"Alex Xu","email":"hejie.xu@intel.com","username":"xuhj"},"change_message_id":"3a3d790ad66d129cf81e2f062640198c8ff96428","unresolved":false,"context_lines":[{"line_number":573,"context_line":"                          self.req, fakes.FAKE_UUID, body\u003dbody)"},{"line_number":574,"context_line":""},{"line_number":575,"context_line":""},{"line_number":576,"context_line":"class ConsolesExtensionTestV27(test.NoDBTestCase):"},{"line_number":577,"context_line":"    def setUp(self):"},{"line_number":578,"context_line":"        super(ConsolesExtensionTestV27, self).setUp()"},{"line_number":579,"context_line":"        self.req \u003d fakes.HTTPRequest.blank(\u0027\u0027)"}],"source_content_type":"text/x-python","patch_set":4,"id":"3a50d1a3_42eea423","line":576,"updated":"2015-07-20 06:41:13.000000000","message":"how about based on ConsolesExtensionTestV26.\n\nThen we can ensure the old version still works","commit_id":"d7bbdf4b942199f6a1377b5507050e9f4c44f57c"},{"author":{"_account_id":9172,"name":"Radoslav Gerganov","email":"rgerganov@vmware.com","username":"rgerganov"},"change_message_id":"f3be94d4e140ddd35e4aecab2cbd71640cd6453f","unresolved":false,"context_lines":[{"line_number":573,"context_line":"                          self.req, fakes.FAKE_UUID, body\u003dbody)"},{"line_number":574,"context_line":""},{"line_number":575,"context_line":""},{"line_number":576,"context_line":"class ConsolesExtensionTestV27(test.NoDBTestCase):"},{"line_number":577,"context_line":"    def setUp(self):"},{"line_number":578,"context_line":"        super(ConsolesExtensionTestV27, self).setUp()"},{"line_number":579,"context_line":"        self.req \u003d fakes.HTTPRequest.blank(\u0027\u0027)"}],"source_content_type":"text/x-python","patch_set":4,"id":"3a50d1a3_1b11d052","line":576,"in_reply_to":"3a50d1a3_42eea423","updated":"2015-07-20 15:12:19.000000000","message":"Done","commit_id":"d7bbdf4b942199f6a1377b5507050e9f4c44f57c"}]}