)]}'
{"nova/virt/vmwareapi/vif.py":[{"author":{"_account_id":7730,"name":"Sahid Orentino Ferdjaoui","email":"sahid.ferdjaoui@industrialdiscipline.com","username":"sahid"},"change_message_id":"d44eadc9541a0cb743bd7b25feb26744c8c84c1d","unresolved":false,"context_lines":[{"line_number":145,"context_line":"        bridge \u003d network_name"},{"line_number":146,"context_line":"        network_ref \u003d network_util.get_network_with_the_name("},{"line_number":147,"context_line":"                session, network_name, cluster)"},{"line_number":148,"context_line":"        if not network_ref:"},{"line_number":149,"context_line":"            network_ref \u003d network_util.get_network_with_the_name("},{"line_number":150,"context_line":"                    session, vif[\u0027network\u0027][\u0027label\u0027], cluster)"},{"line_number":151,"context_line":"    if not network_ref:"}],"source_content_type":"text/x-python","patch_set":1,"id":"ba3cc151_c6c1994f","line":148,"updated":"2015-07-09 12:55:11.000000000","message":"So you will go through every networks 2 times which is O(2n). What about to update the method \u0027get_network_with_the_name\u0027 to accept a string or a list/tuple as network_name. By this way we can keep a 0(n) complexity.","commit_id":"cd1612da66e8140c43e605177ed7c904929d38cd"},{"author":{"_account_id":1653,"name":"garyk","email":"gkotton@vmware.com","username":"garyk"},"change_message_id":"f3211078a74f2122bf312017f65061c23b522d88","unresolved":false,"context_lines":[{"line_number":145,"context_line":"        bridge \u003d network_name"},{"line_number":146,"context_line":"        network_ref \u003d network_util.get_network_with_the_name("},{"line_number":147,"context_line":"                session, network_name, cluster)"},{"line_number":148,"context_line":"        if not network_ref:"},{"line_number":149,"context_line":"            network_ref \u003d network_util.get_network_with_the_name("},{"line_number":150,"context_line":"                    session, vif[\u0027network\u0027][\u0027label\u0027], cluster)"},{"line_number":151,"context_line":"    if not network_ref:"}],"source_content_type":"text/x-python","patch_set":1,"id":"ba3cc151_6791a8f0","line":148,"in_reply_to":"ba3cc151_c6c1994f","updated":"2015-07-09 13:32:33.000000000","message":"The problem is that we first need to check that the network_name is matched and only once all of the networks read from the VC are not matched then we can check for the network name.\nIf there is a False positive the correct networking will not be done and that will be catostrophic","commit_id":"cd1612da66e8140c43e605177ed7c904929d38cd"},{"author":{"_account_id":7730,"name":"Sahid Orentino Ferdjaoui","email":"sahid.ferdjaoui@industrialdiscipline.com","username":"sahid"},"change_message_id":"c78e0bfbaa58038cae78da797cccbf279542301e","unresolved":false,"context_lines":[{"line_number":153,"context_line":"            # predefined \u0027portgroup\u0027. The name of the port group"},{"line_number":154,"context_line":"            # is the name of the neutron network."},{"line_number":155,"context_line":"            network_ref \u003d network_util.get_network_with_the_name("},{"line_number":156,"context_line":"                    session, vif[\u0027network\u0027][\u0027label\u0027], cluster)"},{"line_number":157,"context_line":"    if not network_ref:"},{"line_number":158,"context_line":"        raise exception.NetworkNotFoundForBridge(bridge\u003dbridge)"},{"line_number":159,"context_line":"    return network_ref"}],"source_content_type":"text/x-python","patch_set":2,"id":"9a41bdd9_571f9e6b","line":156,"updated":"2015-07-15 10:55:16.000000000","message":"By introducing the new argument you insure that the name of the network is an exact match. Should be great to have a docstring for this new param \u0027\u0027full_match\" and actually with a note of why we can want it or not.","commit_id":"e7d67b566e4b1dac04d59bcef57e2051553b13c5"}]}