)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":1653,"name":"garyk","email":"gkotton@vmware.com","username":"garyk"},"change_message_id":"7783ab2b87c73624f7551c60b033f2e33c904de7","unresolved":false,"context_lines":[{"line_number":20,"context_line":"  With the above, the instances with m1.medium flavor will have"},{"line_number":21,"context_line":"  an average total I/O write limit of 10MB/s, with the ability"},{"line_number":22,"context_line":"  to burst to 20MB/s periodically."},{"line_number":23,"context_line":""},{"line_number":24,"context_line":"Change-Id: I287ae84490e648062958856b7e45b5b1ec47b0b2"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"ba3cc151_e93dd88f","line":23,"updated":"2015-07-08 12:06:04.000000000","message":"Please add a DocImpact flag here. This is something that needs to be documented.\n\nWhat if the flavor has disk_total_bytes_sec set greater than the max value. Will this casue an exception in libvirt?","commit_id":"61b0a62a5b064452016619c0c457c72711909dac"},{"author":{"_account_id":1004,"name":"Mohammed Naser","email":"mnaser@vexxhost.com","username":"mnaser"},"change_message_id":"bd6b08c0dff65df67602493edf85ff14839f715b","unresolved":false,"context_lines":[{"line_number":20,"context_line":"  With the above, the instances with m1.medium flavor will have"},{"line_number":21,"context_line":"  an average total I/O write limit of 10MB/s, with the ability"},{"line_number":22,"context_line":"  to burst to 20MB/s periodically."},{"line_number":23,"context_line":""},{"line_number":24,"context_line":"Change-Id: I287ae84490e648062958856b7e45b5b1ec47b0b2"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"ba3cc151_cc7a62f1","line":23,"in_reply_to":"ba3cc151_e93dd88f","updated":"2015-07-08 12:26:03.000000000","message":"I believe that it would be unsupported behaviour and likely cause an exception, however, how would you suggest handling something like this?  It\u0027s hard to let the user know that their limits were not applied (and falling back to setting them to None is not ideal either)\n\nPerhaps, this is something that is best solved by writing it as a note in the Documentation?  I\u0027ll resubmit with DocImpact now.","commit_id":"61b0a62a5b064452016619c0c457c72711909dac"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"4aac320a2a6a8043c153fd609de85335582e93e1","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Add support for burstable disk IO control"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"This commit extends the existing instance disk IO controls to"},{"line_number":10,"context_line":"include 6 more parameters: disk_{read,write}_{disk,iops}_max."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"These parameters can be used in combination with the existing"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"3a50d1a3_eef01d69","line":9,"updated":"2015-07-23 16:00:08.000000000","message":"I would reference blueprint quota-instance-resource somewhere in here for context.\n\nI think we should have a blueprint for this change also, maybe not a spec, but at least a blueprint since this is a feature to advertise on the roadmap.  You could bring it up in the nova meeting open discussoin for review as a specless blueprint.","commit_id":"cd966299b61a14b67980b21f2f49836475364e96"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"4aac320a2a6a8043c153fd609de85335582e93e1","unresolved":false,"context_lines":[{"line_number":21,"context_line":"  an average total I/O write limit of 10MB/s, with the ability"},{"line_number":22,"context_line":"  to burst to 20MB/s periodically."},{"line_number":23,"context_line":""},{"line_number":24,"context_line":"DocImpact"},{"line_number":25,"context_line":""},{"line_number":26,"context_line":"Change-Id: I287ae84490e648062958856b7e45b5b1ec47b0b2"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"3a50d1a3_6eeacddc","line":24,"updated":"2015-07-23 16:00:08.000000000","message":"There is supposed to be some description of the actual doc impact for the doc writers, they aren\u0027t nova developers and don\u0027t know anything about this code.  Is the existing instance disk IO control feature already documented somewhere?  If so, you could link to that and mention that it needs to be updated for this.","commit_id":"cd966299b61a14b67980b21f2f49836475364e96"}]}