)]}'
{"nova/network/api.py":[{"author":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"change_message_id":"eaf26daf854028e3d5072fff12d4678a71328e2c","unresolved":false,"context_lines":[{"line_number":111,"context_line":"    @wrap_check_policy"},{"line_number":112,"context_line":"    def get_all(self, context):"},{"line_number":113,"context_line":"        try:"},{"line_number":114,"context_line":"            return self.db.network_get_all(context)"},{"line_number":115,"context_line":"        except exception.NoNetworksFound:"},{"line_number":116,"context_line":"            return []"},{"line_number":117,"context_line":""}],"source_content_type":"text/x-python","patch_set":8,"id":"AAAAM3%2F%2FOpI%3D","line":114,"updated":"2013-02-01 05:28:05.000000000","message":"This and all the other ones in this file are a little scary, from a no-db-compute perspective. However, it looks to me like none of these that now use direct db calls are actually used from compute/manager. I guess the point is that people should be using quantum now which makes this irrelevant...","commit_id":"45e92d47038514fc05ae17a8a38dae1b337c15fe"}],"nova/network/api_deprecated.py":[{"author":{"_account_id":1849,"name":"Joe Gordon","email":"joe.gordon0@gmail.com","username":"jogo"},"change_message_id":"572016bcf62b4b73186b7d2a94882d1a9da1a1f9","unresolved":false,"context_lines":[{"line_number":17,"context_line":"#    License for the specific language governing permissions and limitations"},{"line_number":18,"context_line":"#    under the License."},{"line_number":19,"context_line":"\"\"\""},{"line_number":20,"context_line":"This version of the api is deprecated."},{"line_number":21,"context_line":""},{"line_number":22,"context_line":"It is provided just in case a third party manager is in use."},{"line_number":23,"context_line":"\"\"\""}],"source_content_type":"text/x-python","patch_set":4,"id":"AAAAM3%2F%2FWuI%3D","line":20,"updated":"2013-01-25 20:18:35.000000000","message":"How about adding what release this is deprecated in, to make it easier to remove in \u0027H\u0027","commit_id":"f8e35d7e7c1fe2ffa6888ee5e31031fb8e0870ba"},{"author":{"_account_id":1561,"name":"Russell Bryant","email":"rbryant@redhat.com","username":"russellb"},"change_message_id":"b7657f8cb86c92a411647817feb23c1e7fb289f0","unresolved":false,"context_lines":[{"line_number":19,"context_line":"\"\"\""},{"line_number":20,"context_line":"This version of the api is deprecated."},{"line_number":21,"context_line":""},{"line_number":22,"context_line":"It is provided just in case a third party manager is in use."},{"line_number":23,"context_line":"\"\"\""},{"line_number":24,"context_line":""},{"line_number":25,"context_line":"import functools"}],"source_content_type":"text/x-python","patch_set":7,"id":"AAAAM3%2F%2FQcw%3D","line":22,"updated":"2013-01-31 05:06:40.000000000","message":"How real of a concern is this?  This is sure a lot of extra code to and maintain.  IMO, having an out of tree manager isn\u0027t a stable API that we should be worrying about a deprecation path for.","commit_id":"f48ca36c7df408b6c3bcead497621920e7e6603b"},{"author":{"_account_id":1849,"name":"Joe Gordon","email":"joe.gordon0@gmail.com","username":"jogo"},"change_message_id":"4be9fc27b71d0d2195c56370a7148b29b17acf3f","unresolved":false,"context_lines":[{"line_number":19,"context_line":"\"\"\""},{"line_number":20,"context_line":"This version of the api is deprecated."},{"line_number":21,"context_line":""},{"line_number":22,"context_line":"It is provided just in case a third party manager is in use."},{"line_number":23,"context_line":"\"\"\""},{"line_number":24,"context_line":""},{"line_number":25,"context_line":"import functools"}],"source_content_type":"text/x-python","patch_set":7,"id":"AAAAM3%2F%2FO%2Bw%3D","line":22,"in_reply_to":"AAAAM3%2F%2FQa8%3D","updated":"2013-01-31 23:30:01.000000000","message":"Lets put a comment in saying Deprecated in Grizzly, so we know to remove it in Havana.","commit_id":"f48ca36c7df408b6c3bcead497621920e7e6603b"},{"author":{"_account_id":67,"name":"Vish Ishaya","email":"vishvananda@gmail.com","username":"vishvananda"},"change_message_id":"dc9004adfe34362941057a1f9f0fead7dabde89f","unresolved":false,"context_lines":[{"line_number":19,"context_line":"\"\"\""},{"line_number":20,"context_line":"This version of the api is deprecated."},{"line_number":21,"context_line":""},{"line_number":22,"context_line":"It is provided just in case a third party manager is in use."},{"line_number":23,"context_line":"\"\"\""},{"line_number":24,"context_line":""},{"line_number":25,"context_line":"import functools"}],"source_content_type":"text/x-python","patch_set":7,"id":"AAAAM3%2F%2FQa8%3D","line":22,"in_reply_to":"AAAAM3%2F%2FQcw%3D","updated":"2013-01-31 05:50:45.000000000","message":"This was a specific request from RAX who is still using a third party manager. They plan on moving to quantum v2 but don\u0027t have the changes in place yet. We can pull this out as soon as we cut grizzly.","commit_id":"f48ca36c7df408b6c3bcead497621920e7e6603b"}],"nova/network/manager.py":[{"author":{"_account_id":1849,"name":"Joe Gordon","email":"joe.gordon0@gmail.com","username":"jogo"},"change_message_id":"4be9fc27b71d0d2195c56370a7148b29b17acf3f","unresolved":false,"context_lines":[{"line_number":674,"context_line":"    @rpc_common.client_exceptions(exception.FloatingIpNotFound)"},{"line_number":675,"context_line":"    def get_floating_ip(self, context, id):"},{"line_number":676,"context_line":"        \"\"\"Returns a floating IP as a dict.\"\"\""},{"line_number":677,"context_line":"        # NOTE(vish): This is no longer used but can\u0027t be removed until"},{"line_number":678,"context_line":"        #             we major version the network_rpcapi."},{"line_number":679,"context_line":"        return dict(self.db.floating_ip_get(context, id).iteritems())"},{"line_number":680,"context_line":""}],"source_content_type":"text/x-python","patch_set":7,"id":"AAAAM3%2F%2FO%2Bo%3D","line":677,"updated":"2013-01-31 23:30:01.000000000","message":"Can we add a note saying what version of RPC this is no longer used in, to make it easier to remove.","commit_id":"f48ca36c7df408b6c3bcead497621920e7e6603b"}]}
