)]}'
{"nova/network/neutronv2/api.py":[{"author":{"_account_id":8688,"name":"Alexis Lee","email":"openstack@lxsli.co.uk","username":"lxsli"},"change_message_id":"eb9bf8152f927fdb03aba71598753442dc5143a3","unresolved":false,"context_lines":[{"line_number":1052,"context_line":"                                           neutron_client\u003dneutron)"},{"line_number":1053,"context_line":"                    if port.get(\u0027device_id\u0027, None):"},{"line_number":1054,"context_line":"                        raise exception.PortInUse(port_id\u003drequest.port_id)"},{"line_number":1055,"context_line":"                    if (port.get(\u0027port_security_enabled\u0027, True)"},{"line_number":1056,"context_line":"                            and not port.get(\u0027fixed_ips\u0027)):"},{"line_number":1057,"context_line":"                        raise exception.PortRequiresFixedIP("},{"line_number":1058,"context_line":"                            port_id\u003drequest.port_id)"}],"source_content_type":"text/x-python","patch_set":3,"id":"ba15a1d1_47f74659","line":1055,"range":{"start_line":1055,"start_character":58,"end_line":1055,"end_character":62},"updated":"2015-09-22 10:11:48.000000000","message":"It\u0027s unfortunate that we\u0027re having to duplicate the default value here and below. I can\u0027t easily offer a solution though :S","commit_id":"311968e41e633ee2b57c37d9862e077d0c8f7e2d"}],"nova/tests/unit/network/test_neutronv2.py":[{"author":{"_account_id":8688,"name":"Alexis Lee","email":"openstack@lxsli.co.uk","username":"lxsli"},"change_message_id":"eb9bf8152f927fdb03aba71598753442dc5143a3","unresolved":false,"context_lines":[{"line_number":1851,"context_line":"        self.moxed_client.list_networks("},{"line_number":1852,"context_line":"            id\u003dmox.SameElementsAs(ids)).AndReturn("},{"line_number":1853,"context_line":"                {\u0027networks\u0027: nets})"},{"line_number":1854,"context_line":"        self.mox.ReplayAll()"},{"line_number":1855,"context_line":"        api \u003d neutronapi.API()"},{"line_number":1856,"context_line":"        self.assertRaises(exception.NetworkRequiresSubnet,"},{"line_number":1857,"context_line":"                          api.validate_networks,"}],"source_content_type":"text/x-python","patch_set":3,"id":"ba15a1d1_87079e1c","line":1854,"updated":"2015-09-22 10:11:48.000000000","message":"New testcases should be written using mock: http://docs.openstack.org/infra/manual/developers.html#peer-review point 4","commit_id":"311968e41e633ee2b57c37d9862e077d0c8f7e2d"},{"author":{"_account_id":5511,"name":"Nikola Dipanov","email":"ndipanov@redhat.com","username":"ndipanov"},"change_message_id":"07ed47d756598748a4fe786bbe7514220c51b3d7","unresolved":false,"context_lines":[{"line_number":1851,"context_line":"        self.moxed_client.list_networks("},{"line_number":1852,"context_line":"            id\u003dmox.SameElementsAs(ids)).AndReturn("},{"line_number":1853,"context_line":"                {\u0027networks\u0027: nets})"},{"line_number":1854,"context_line":"        self.mox.ReplayAll()"},{"line_number":1855,"context_line":"        api \u003d neutronapi.API()"},{"line_number":1856,"context_line":"        self.assertRaises(exception.NetworkRequiresSubnet,"},{"line_number":1857,"context_line":"                          api.validate_networks,"}],"source_content_type":"text/x-python","patch_set":3,"id":"da85f559_f4ea00ac","line":1854,"in_reply_to":"ba15a1d1_87079e1c","updated":"2015-11-13 07:36:36.000000000","message":"While this is true - I don\u0027t think this is grounds for -1ing an otherwise useful fix TBH - this basically makes sure other people don\u0027t review it for reasons that have nothing to do with the actual logic of the patch.","commit_id":"311968e41e633ee2b57c37d9862e077d0c8f7e2d"}]}