)]}'
{"nova/compute/manager.py":[{"author":{"_account_id":1030,"name":"Chris Behrens","email":"cbehrens@codestud.com","username":"cbehrens"},"change_message_id":"ad71e9a9828b83daa84e8460760ef06a47cda800","unresolved":false,"context_lines":[{"line_number":1100,"context_line":"        try:"},{"line_number":1101,"context_line":"            disk_info \u003d self.driver.migrate_disk_and_power_off("},{"line_number":1102,"context_line":"                    context, instance_ref, migration_ref[\u0027dest_host\u0027],"},{"line_number":1103,"context_line":"                    migration_ref[\u0027new_instance_type_id\u0027])"},{"line_number":1104,"context_line":"        except exception.MigrationError, error:"},{"line_number":1105,"context_line":"            LOG.error(_(\u0027%s. Setting instance vm_state to ERROR\u0027) % (error,))"},{"line_number":1106,"context_line":"            self._instance_update(context,"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAAC3%2F%2F%2Frw%3D","line":1103,"updated":"2011-12-01 21:06:23.000000000","message":"Would it be dumb to pull in the instance_type record right here and pass the model down through the driver, so the driver layers don\u0027t need to do the DB lookups?   This would simplify things for future no-db-messaging work.  (It\u0027s probably not dumb, but would you be willing to do it right now?)","commit_id":"61d84b29d337dda1785831f8581815e80279eb6c"}],"nova/virt/xenapi/vmops.py":[{"author":{"_account_id":1030,"name":"Chris Behrens","email":"cbehrens@codestud.com","username":"cbehrens"},"change_message_id":"ad71e9a9828b83daa84e8460760ef06a47cda800","unresolved":false,"context_lines":[{"line_number":44,"context_line":"from nova.virt.xenapi.volume_utils import VolumeHelper"},{"line_number":45,"context_line":"from nova.virt.xenapi.network_utils import NetworkHelper"},{"line_number":46,"context_line":"from nova.virt.xenapi.vm_utils import VMHelper"},{"line_number":47,"context_line":"from nova.virt.xenapi.vm_utils import ImageType"},{"line_number":48,"context_line":""},{"line_number":49,"context_line":"XenAPI \u003d None"},{"line_number":50,"context_line":"LOG \u003d logging.getLogger(\"nova.virt.xenapi.vmops\")"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAAC3%2F%2F%2FsI%3D","side":"PARENT","line":47,"updated":"2011-12-01 21:06:23.000000000","message":"This whole list of imports violates HACKING, even though you attempt to put your new import in the correct spot.  Mind fixing?  At the top, 3rd party needs separated and these last 2 blocks should be combined and ordered properly.","commit_id":"b44dc5cb34806157ab1e3e3389ddc79594a90e75"}]}
