)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"change_message_id":"7279f38e23caa5bb99639bf44428eebe64ce0b37","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     Nikola Dipanov \u003cndipanov@redhat.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2015-07-14 16:27:09 +0100"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Fix the incorect PciDeviceList version number"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"The following commit missed to bump the related list when bumping the"},{"line_number":10,"context_line":"object version."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"9a41bdd9_29e511db","line":7,"range":{"start_line":7,"start_character":8,"end_line":7,"end_character":16},"updated":"2015-07-14 15:29:46.000000000","message":"incorrect is incorrectly spelled","commit_id":"209fb93e16f274b67c4084c4cd6224a20fb5f891"},{"author":{"_account_id":5511,"name":"Nikola Dipanov","email":"ndipanov@redhat.com","username":"ndipanov"},"change_message_id":"0ea25c8b1c7c9a42db70e0994be515aefe1b1476","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     Nikola Dipanov \u003cndipanov@redhat.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2015-07-14 16:27:09 +0100"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Fix the incorect PciDeviceList version number"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"The following commit missed to bump the related list when bumping the"},{"line_number":10,"context_line":"object version."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"9a41bdd9_69331915","line":7,"in_reply_to":"9a41bdd9_29e511db","updated":"2015-07-14 15:48:38.000000000","message":"correct","commit_id":"209fb93e16f274b67c4084c4cd6224a20fb5f891"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"71f8f35ef5fc9700717d8e5acc2ef064388f620d","unresolved":false,"context_lines":[{"line_number":29,"context_line":"start requesting the latest version of PciDevice through PciDeviceList."},{"line_number":30,"context_line":""},{"line_number":31,"context_line":"We can\u0027t send 1.2 PciDeviceList to Kilo nodes yet because of"},{"line_number":32,"context_line":"related-bug 1475254 , so we have to backport this to Kilo first before"},{"line_number":33,"context_line":"we can start sending the 1.2 to Kilo nodes."},{"line_number":34,"context_line":""},{"line_number":35,"context_line":"Related-bug: #1474074"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":9,"id":"9a41bdd9_9d02c4b3","line":32,"updated":"2015-07-16 23:11:21.000000000","message":"I\u0027m not sure how this bug is related.  Sounds like we really can\u0027t send 1.2 to kilo because PciDeviceList isn\u0027t in kilo, so that\u0027s why the mapping is Instance 1.20 since that\u0027s not in kilo (Instance is 1.19).  Anyway, it\u0027s just a bit confusing trying to sort this out, but I think I\u0027ve got it now.","commit_id":"80c109f85a9e8b182e918027731760e91026cb81"}],"nova/conductor/manager.py":[{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"71d333571d084c23fa481aaefa49220d65974171","unresolved":false,"context_lines":[{"line_number":478,"context_line":"                   \u0027target_version\u0027: target_version})"},{"line_number":479,"context_line":""},{"line_number":480,"context_line":"        backported \u003d objinst.obj_to_primitive(target_version\u003dtarget_version)"},{"line_number":481,"context_line":"        LOG.debug(\"Backported version looks like: %s\" % backported)"},{"line_number":482,"context_line":"        return backported"},{"line_number":483,"context_line":""},{"line_number":484,"context_line":""}],"source_content_type":"text/x-python","patch_set":6,"id":"9a41bdd9_1c104956","line":481,"updated":"2015-07-15 15:40:17.000000000","message":"Use this instead to avoid actually using the % if debug logging isn\u0027t enabled:\n\nLOG.debug(\"Backported version looks like: %s\", backported)","commit_id":"e7828d94697f5869cb35aee5eff37ac7c7704e76"},{"author":{"_account_id":5511,"name":"Nikola Dipanov","email":"ndipanov@redhat.com","username":"ndipanov"},"change_message_id":"e3f3e334f1076ca39d64b95da8b8b1bd492030a0","unresolved":false,"context_lines":[{"line_number":478,"context_line":"                   \u0027target_version\u0027: target_version})"},{"line_number":479,"context_line":""},{"line_number":480,"context_line":"        backported \u003d objinst.obj_to_primitive(target_version\u003dtarget_version)"},{"line_number":481,"context_line":"        LOG.debug(\"Backported version looks like: %s\" % backported)"},{"line_number":482,"context_line":"        return backported"},{"line_number":483,"context_line":""},{"line_number":484,"context_line":""}],"source_content_type":"text/x-python","patch_set":6,"id":"9a41bdd9_a5e8af17","line":481,"in_reply_to":"9a41bdd9_05177f48","updated":"2015-07-17 14:29:21.000000000","message":"Sorry about this comment - it was uncalled for :(.\n\nWas really frustrated with this bug as it kept escalating - not an excuse thought.","commit_id":"e7828d94697f5869cb35aee5eff37ac7c7704e76"},{"author":{"_account_id":5511,"name":"Nikola Dipanov","email":"ndipanov@redhat.com","username":"ndipanov"},"change_message_id":"5b572d3638bb80823c182cb4355a2425973c0cc9","unresolved":false,"context_lines":[{"line_number":478,"context_line":"                   \u0027target_version\u0027: target_version})"},{"line_number":479,"context_line":""},{"line_number":480,"context_line":"        backported \u003d objinst.obj_to_primitive(target_version\u003dtarget_version)"},{"line_number":481,"context_line":"        LOG.debug(\"Backported version looks like: %s\" % backported)"},{"line_number":482,"context_line":"        return backported"},{"line_number":483,"context_line":""},{"line_number":484,"context_line":""}],"source_content_type":"text/x-python","patch_set":6,"id":"9a41bdd9_f0da6916","line":481,"in_reply_to":"9a41bdd9_1c104956","updated":"2015-07-15 15:49:27.000000000","message":"yeah man this is just to try to figure out what\u0027s happening if I end up leaving it in it will go into a separate patch.\n\nBut I am glad we have a vigilant eye on critical performance bits. \u003c/sarcasam\u003e /me rolls eyes","commit_id":"e7828d94697f5869cb35aee5eff37ac7c7704e76"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"ac389c45f860977d580b870be4e56ba1bc8a6936","unresolved":false,"context_lines":[{"line_number":478,"context_line":"                   \u0027target_version\u0027: target_version})"},{"line_number":479,"context_line":""},{"line_number":480,"context_line":"        backported \u003d objinst.obj_to_primitive(target_version\u003dtarget_version)"},{"line_number":481,"context_line":"        LOG.debug(\"Backported version looks like: %s\" % backported)"},{"line_number":482,"context_line":"        return backported"},{"line_number":483,"context_line":""},{"line_number":484,"context_line":""}],"source_content_type":"text/x-python","patch_set":6,"id":"9a41bdd9_05177f48","line":481,"in_reply_to":"9a41bdd9_f0da6916","updated":"2015-07-15 21:28:10.000000000","message":"Cool, sorry for reviewing your code.  I\u0027ll make a note of that for the future.","commit_id":"e7828d94697f5869cb35aee5eff37ac7c7704e76"}],"nova/objects/instance.py":[{"author":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"change_message_id":"7279f38e23caa5bb99639bf44428eebe64ce0b37","unresolved":false,"context_lines":[{"line_number":118,"context_line":"    # Version 1.16: Added pci_requests"},{"line_number":119,"context_line":"    # Version 1.17: Added tags"},{"line_number":120,"context_line":"    # Version 1.18: Added flavor, old_flavor, new_flavor, will use"},{"line_number":121,"context_line":"    #               PciDeviceList version 1.2"},{"line_number":122,"context_line":"    # Version 1.19: Added vcpu_model"},{"line_number":123,"context_line":"    # Version 1.20: Added ec2_ids"},{"line_number":124,"context_line":"    # Version 1.21: TagList 1.1"}],"source_content_type":"text/x-python","patch_set":3,"id":"9a41bdd9_c9ed85b8","line":121,"updated":"2015-07-14 15:29:46.000000000","message":"This should be on 1.19, no? Or did you determine this is closer?","commit_id":"209fb93e16f274b67c4084c4cd6224a20fb5f891"},{"author":{"_account_id":5511,"name":"Nikola Dipanov","email":"ndipanov@redhat.com","username":"ndipanov"},"change_message_id":"0ea25c8b1c7c9a42db70e0994be515aefe1b1476","unresolved":false,"context_lines":[{"line_number":118,"context_line":"    # Version 1.16: Added pci_requests"},{"line_number":119,"context_line":"    # Version 1.17: Added tags"},{"line_number":120,"context_line":"    # Version 1.18: Added flavor, old_flavor, new_flavor, will use"},{"line_number":121,"context_line":"    #               PciDeviceList version 1.2"},{"line_number":122,"context_line":"    # Version 1.19: Added vcpu_model"},{"line_number":123,"context_line":"    # Version 1.20: Added ec2_ids"},{"line_number":124,"context_line":"    # Version 1.21: TagList 1.1"}],"source_content_type":"text/x-python","patch_set":3,"id":"9a41bdd9_2942f168","line":121,"in_reply_to":"9a41bdd9_c9ed85b8","updated":"2015-07-14 15:48:38.000000000","message":"This is the version bump that should have happened (Instance was at 1.17 when the numa_node was added to PciDevice) so yeah - this is the first one we could reuse.","commit_id":"209fb93e16f274b67c4084c4cd6224a20fb5f891"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"321f98fc94f9bb86abea62e1c95f63c0efcbd53a","unresolved":false,"context_lines":[{"line_number":230,"context_line":"                        # FIXME(ndipanov): Currently we don\u0027t want to send 1.2"},{"line_number":231,"context_line":"                        # to Kilo nodes - they can\u0027t handle it and will fail"},{"line_number":232,"context_line":"                        # due to"},{"line_number":233,"context_line":"                        # https://bugzilla.redhat.com/show_bug.cgi?id\u003d1242502"},{"line_number":234,"context_line":"                        # Kilo Instance is at 1.19"},{"line_number":235,"context_line":"                        (\u00271.20\u0027, \u00271.2\u0027)],"},{"line_number":236,"context_line":"        \u0027numa_topology\u0027: [(\u00271.14\u0027, \u00271.0\u0027), (\u00271.16\u0027, \u00271.1\u0027)],"}],"source_content_type":"text/x-python","patch_set":8,"id":"9a41bdd9_5abbe275","line":233,"updated":"2015-07-16 22:51:31.000000000","message":"I can\u0027t access this, did you mean to link one of the launchpad bugs referenced in the commit message?","commit_id":"79f05c897d96d79343bf5feb5f71beae3adf32d2"},{"author":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"change_message_id":"9412ac914f31efc320f260105d3ba70e8fd5264e","unresolved":false,"context_lines":[{"line_number":230,"context_line":"                        # FIXME(ndipanov): Currently we don\u0027t want to send 1.2"},{"line_number":231,"context_line":"                        # to Kilo nodes - they can\u0027t handle it and will fail"},{"line_number":232,"context_line":"                        # due to"},{"line_number":233,"context_line":"                        # https://bugzilla.redhat.com/show_bug.cgi?id\u003d1242502"},{"line_number":234,"context_line":"                        # Kilo Instance is at 1.19"},{"line_number":235,"context_line":"                        (\u00271.20\u0027, \u00271.2\u0027)],"},{"line_number":236,"context_line":"        \u0027numa_topology\u0027: [(\u00271.14\u0027, \u00271.0\u0027), (\u00271.16\u0027, \u00271.1\u0027)],"}],"source_content_type":"text/x-python","patch_set":8,"id":"9a41bdd9_5d4c3c76","line":233,"in_reply_to":"9a41bdd9_5abbe275","updated":"2015-07-16 22:56:55.000000000","message":"Ah, I didn\u0027t notice this was private because I can get to it. But yeah, good call. The bugzilla has a link to this LP bug:\n\nhttps://bugs.launchpad.net/nova/+bug/1474074","commit_id":"79f05c897d96d79343bf5feb5f71beae3adf32d2"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"321f98fc94f9bb86abea62e1c95f63c0efcbd53a","unresolved":false,"context_lines":[{"line_number":231,"context_line":"                        # to Kilo nodes - they can\u0027t handle it and will fail"},{"line_number":232,"context_line":"                        # due to"},{"line_number":233,"context_line":"                        # https://bugzilla.redhat.com/show_bug.cgi?id\u003d1242502"},{"line_number":234,"context_line":"                        # Kilo Instance is at 1.19"},{"line_number":235,"context_line":"                        (\u00271.20\u0027, \u00271.2\u0027)],"},{"line_number":236,"context_line":"        \u0027numa_topology\u0027: [(\u00271.14\u0027, \u00271.0\u0027), (\u00271.16\u0027, \u00271.1\u0027)],"},{"line_number":237,"context_line":"        \u0027pci_requests\u0027: [(\u00271.16\u0027, \u00271.1\u0027)],"}],"source_content_type":"text/x-python","patch_set":8,"id":"9a41bdd9_ba7d4eb3","line":234,"updated":"2015-07-16 22:51:31.000000000","message":"Confirmed:\n\nhttp://git.openstack.org/cgit/openstack/nova/tree/nova/objects/instance.py?h\u003dstable/kilo#n133","commit_id":"79f05c897d96d79343bf5feb5f71beae3adf32d2"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"71f8f35ef5fc9700717d8e5acc2ef064388f620d","unresolved":false,"context_lines":[{"line_number":118,"context_line":"    # Version 1.16: Added pci_requests"},{"line_number":119,"context_line":"    # Version 1.17: Added tags"},{"line_number":120,"context_line":"    # Version 1.18: Added flavor, old_flavor, new_flavor, will use"},{"line_number":121,"context_line":"    #               PciDeviceList version 1.2"},{"line_number":122,"context_line":"    # Version 1.19: Added vcpu_model"},{"line_number":123,"context_line":"    # Version 1.20: Added ec2_ids"},{"line_number":124,"context_line":"    # Version 1.21: TagList 1.1"}],"source_content_type":"text/x-python","patch_set":9,"id":"9a41bdd9_fde3d003","line":121,"updated":"2015-07-16 23:11:21.000000000","message":"I\u0027m a bit confused why this is added to 1.18 rather than 1.19, but Dan said it\u0027s because Instance was 1.18 when PciDeviceList was bumped to 1.2, so OK - could have been a bit more explicit in the comment here.","commit_id":"80c109f85a9e8b182e918027731760e91026cb81"}],"nova/objects/pci_device.py":[{"author":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"change_message_id":"f7d13fc592a20599c193ba653a5a382006c3acb8","unresolved":false,"context_lines":[{"line_number":206,"context_line":"    # Version 1.0: Initial version"},{"line_number":207,"context_line":"    #              PciDevice \u003c\u003d 1.1"},{"line_number":208,"context_line":"    # Version 1.1: PciDevice 1.2"},{"line_number":209,"context_line":"    VERSION \u003d \u00271.2\u0027"},{"line_number":210,"context_line":""},{"line_number":211,"context_line":"    fields \u003d {"},{"line_number":212,"context_line":"        \u0027objects\u0027: fields.ListOfObjectsField(\u0027PciDevice\u0027),"}],"source_content_type":"text/x-python","patch_set":5,"id":"9a41bdd9_d54c2aca","line":209,"updated":"2015-07-14 19:47:49.000000000","message":"Just noticed that you didn\u0027t add the version in the history on the line above.","commit_id":"d571afec5ca93dd12757b1a6973c94d184996467"}]}