)]}'
{"nova/compute/manager.py":[{"author":{"_account_id":6062,"name":"jichenjc","email":"jichenjc@cn.ibm.com","username":"jichenjc"},"change_message_id":"78c7a60071d23bf72b1fcae268f7975fa8c8917b","unresolved":false,"context_lines":[{"line_number":162,"context_line":"    cfg.IntOpt(\u0027shelved_offload_time\u0027,"},{"line_number":163,"context_line":"               default\u003d0,"},{"line_number":164,"context_line":"               help\u003d\u0027Time in seconds before a shelved instance is eligible \u0027"},{"line_number":165,"context_line":"                    \u0027for removing from a host.  -1 never offload, 0 offload \u0027"},{"line_number":166,"context_line":"                    \u0027when shelved\u0027),"},{"line_number":167,"context_line":"    cfg.IntOpt(\u0027instance_delete_interval\u0027,"},{"line_number":168,"context_line":"               default\u003d300,"}],"source_content_type":"text/x-python","patch_set":1,"id":"9a41bdd9_54eb5cb0","line":165,"updated":"2015-07-14 10:35:02.000000000","message":"I suggest to change this also","commit_id":"45c18da3797d90eb91de69940d3fd98dc9d0bf4a"},{"author":{"_account_id":10795,"name":"Rajesh Tailor","email":"tailor.rajesh88@gmail.com","username":"rajeshtailor"},"change_message_id":"ff1a257daefaa72ffff520447ba54e40d2b2e50f","unresolved":false,"context_lines":[{"line_number":162,"context_line":"    cfg.IntOpt(\u0027shelved_offload_time\u0027,"},{"line_number":163,"context_line":"               default\u003d0,"},{"line_number":164,"context_line":"               help\u003d\u0027Time in seconds before a shelved instance is eligible \u0027"},{"line_number":165,"context_line":"                    \u0027for removing from a host.  -1 never offload, 0 offload \u0027"},{"line_number":166,"context_line":"                    \u0027when shelved\u0027),"},{"line_number":167,"context_line":"    cfg.IntOpt(\u0027instance_delete_interval\u0027,"},{"line_number":168,"context_line":"               default\u003d300,"}],"source_content_type":"text/x-python","patch_set":1,"id":"9a41bdd9_ea1e166f","line":165,"in_reply_to":"9a41bdd9_54eb5cb0","updated":"2015-07-15 07:04:05.000000000","message":"Done","commit_id":"45c18da3797d90eb91de69940d3fd98dc9d0bf4a"},{"author":{"_account_id":6062,"name":"jichenjc","email":"jichenjc@cn.ibm.com","username":"jichenjc"},"change_message_id":"78c7a60071d23bf72b1fcae268f7975fa8c8917b","unresolved":false,"context_lines":[{"line_number":5428,"context_line":"    def _poll_shelved_instances(self, context):"},{"line_number":5429,"context_line":""},{"line_number":5430,"context_line":"        if CONF.shelved_offload_time \u003c\u003d 0:"},{"line_number":5431,"context_line":"            return"},{"line_number":5432,"context_line":""},{"line_number":5433,"context_line":"        filters \u003d {\u0027vm_state\u0027: vm_states.SHELVED,"},{"line_number":5434,"context_line":"                   \u0027host\u0027: self.host}"}],"source_content_type":"text/x-python","patch_set":1,"id":"9a41bdd9_74bd4067","line":5431,"updated":"2015-07-14 10:35:02.000000000","message":"https://github.com/openstack/nova/blob/master/nova/openstack/common/periodic_task.py#L109\n\nI think new lines are useless","commit_id":"45c18da3797d90eb91de69940d3fd98dc9d0bf4a"},{"author":{"_account_id":6062,"name":"jichenjc","email":"jichenjc@cn.ibm.com","username":"jichenjc"},"change_message_id":"8d0a08f7186eb49bffe1618d4eb65180b73469e5","unresolved":false,"context_lines":[{"line_number":5428,"context_line":"    def _poll_shelved_instances(self, context):"},{"line_number":5429,"context_line":""},{"line_number":5430,"context_line":"        if CONF.shelved_offload_time \u003c\u003d 0:"},{"line_number":5431,"context_line":"            return"},{"line_number":5432,"context_line":""},{"line_number":5433,"context_line":"        filters \u003d {\u0027vm_state\u0027: vm_states.SHELVED,"},{"line_number":5434,"context_line":"                   \u0027host\u0027: self.host}"}],"source_content_type":"text/x-python","patch_set":1,"id":"9a41bdd9_8d7f6416","line":5431,"in_reply_to":"9a41bdd9_6adc4673","updated":"2015-07-15 07:18:04.000000000","message":"ok, my fault, I missed it\u0027s different\nCONF.shelved_poll_interval\nCONF.shelved_offload_time","commit_id":"45c18da3797d90eb91de69940d3fd98dc9d0bf4a"},{"author":{"_account_id":10795,"name":"Rajesh Tailor","email":"tailor.rajesh88@gmail.com","username":"rajeshtailor"},"change_message_id":"ff1a257daefaa72ffff520447ba54e40d2b2e50f","unresolved":false,"context_lines":[{"line_number":5428,"context_line":"    def _poll_shelved_instances(self, context):"},{"line_number":5429,"context_line":""},{"line_number":5430,"context_line":"        if CONF.shelved_offload_time \u003c\u003d 0:"},{"line_number":5431,"context_line":"            return"},{"line_number":5432,"context_line":""},{"line_number":5433,"context_line":"        filters \u003d {\u0027vm_state\u0027: vm_states.SHELVED,"},{"line_number":5434,"context_line":"                   \u0027host\u0027: self.host}"}],"source_content_type":"text/x-python","patch_set":1,"id":"9a41bdd9_6adc4673","line":5431,"in_reply_to":"9a41bdd9_74bd4067","updated":"2015-07-15 07:04:05.000000000","message":"The newline after return statement is added for code readability. It\u0027s done in othere periodic tasks as well. \n\nPlease check _poll_shelved_instances periodic task.\n\nCould you please explain what is the purpose of above link ?","commit_id":"45c18da3797d90eb91de69940d3fd98dc9d0bf4a"},{"author":{"_account_id":5441,"name":"Andrew Laski","email":"andrew@lascii.com","username":"alaski"},"change_message_id":"c3a3f8b5b782a5cc6a883b9156985e931e939dee","unresolved":false,"context_lines":[{"line_number":163,"context_line":"               default\u003d0,"},{"line_number":164,"context_line":"               help\u003d\u0027Time in seconds before a shelved instance is eligible \u0027"},{"line_number":165,"context_line":"                    \u0027for removing from a host.  -1 never offload, 0 or \u003e 0 \u0027"},{"line_number":166,"context_line":"                    \u0027offload when shelved\u0027),"},{"line_number":167,"context_line":"    cfg.IntOpt(\u0027instance_delete_interval\u0027,"},{"line_number":168,"context_line":"               default\u003d300,"},{"line_number":169,"context_line":"               help\u003d\u0027Interval in seconds for retrying failed instance file \u0027"}],"source_content_type":"text/x-python","patch_set":2,"id":"3a50d1a3_9701a808","line":166,"updated":"2015-07-22 18:35:00.000000000","message":"This change makes the help just as accurate as it was before instead of clarifying.  Perhaps change it to \"0 offload immediately when shelved\".  It should already be clear what it means when the value \u003e 0.","commit_id":"3694989d725ad889994f0308f48a3284e7633f20"},{"author":{"_account_id":9303,"name":"Abhishek Kekane","email":"akekane@redhat.com","username":"abhishekkekane"},"change_message_id":"6a2da040a69de4c5146f16b245533f02e34222f4","unresolved":false,"context_lines":[{"line_number":163,"context_line":"               default\u003d0,"},{"line_number":164,"context_line":"               help\u003d\u0027Time in seconds before a shelved instance is eligible \u0027"},{"line_number":165,"context_line":"                    \u0027for removing from a host.  -1 never offload, 0 or \u003e 0 \u0027"},{"line_number":166,"context_line":"                    \u0027offload when shelved\u0027),"},{"line_number":167,"context_line":"    cfg.IntOpt(\u0027instance_delete_interval\u0027,"},{"line_number":168,"context_line":"               default\u003d300,"},{"line_number":169,"context_line":"               help\u003d\u0027Interval in seconds for retrying failed instance file \u0027"}],"source_content_type":"text/x-python","patch_set":2,"id":"3a50d1a3_b0eccebb","line":166,"in_reply_to":"3a50d1a3_9701a808","updated":"2015-07-23 08:11:40.000000000","message":"Done","commit_id":"3694989d725ad889994f0308f48a3284e7633f20"}]}