)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":6167,"name":"Ken\u0027ichi Ohmichi","email":"ken1ohmichi@gmail.com","username":"oomichi"},"change_message_id":"456f7e4a8b36eec81925393b5ebb76281ba6d69f","unresolved":false,"context_lines":[{"line_number":11,"context_line":"there is overhead to maintain two set of functional tests and sample files."},{"line_number":12,"context_line":"We can have one set of tests which can run for both v2 and v2.1."},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"This commit merges \"versions\" functional tests."},{"line_number":15,"context_line":"There were no v2.1 tests for \"versions\""},{"line_number":16,"context_line":""},{"line_number":17,"context_line":"Also adding tests for specific version request like /v2 \u0026 /v2.1."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":4,"id":"3a50d1a3_51ed1eb6","line":14,"updated":"2015-07-30 02:45:05.000000000","message":"\"list versions\" API is implemented on \"/\" without \"v2\" or \"v2.1\".\nSo the API is independent from the versions.\n\nI guess \"list versions\" API is tested at once always, so this description seems misleading.\nMaybe this patch just moves the test code under /v3, right?","commit_id":"a289168092034d8a9608a1a4cd2da26a76117369"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"936a56e8bec6ff1eae6aa80de84b68b6b5d2ef31","unresolved":false,"context_lines":[{"line_number":11,"context_line":"there is overhead to maintain two set of functional tests and sample files."},{"line_number":12,"context_line":"We can have one set of tests which can run for both v2 and v2.1."},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"This commit merges \"versions\" functional tests."},{"line_number":15,"context_line":"There were no v2.1 tests for \"versions\""},{"line_number":16,"context_line":""},{"line_number":17,"context_line":"Also adding tests for specific version request like /v2 \u0026 /v2.1."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":4,"id":"3a50d1a3_2302890a","line":14,"in_reply_to":"3a50d1a3_51ed1eb6","updated":"2015-07-30 02:52:37.000000000","message":"Yes, That\u0027s right. It is independent of version. I will update commit msg.","commit_id":"a289168092034d8a9608a1a4cd2da26a76117369"},{"author":{"_account_id":6062,"name":"jichenjc","email":"jichenjc@cn.ibm.com","username":"jichenjc"},"change_message_id":"8a4ffd98527b9a2b33331d596f55afcecf679e5d","unresolved":false,"context_lines":[{"line_number":7,"context_line":"Moves \"versions\" functional tests in v2.1 tests"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"This commit moves \"versions\" functional tests in v2.1 tests which are"},{"line_number":10,"context_line":"under /v3 directory and run those for v2 and v2.1."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"There was no tests for v2.1 version so this patch adds"},{"line_number":13,"context_line":"tests for v2.1 version request."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":11,"id":"3a50d1a3_43067886","line":10,"updated":"2015-07-31 08:16:35.000000000","message":"sorry, but why we need to move a v2 test into v3 folder? \nI am curious on that ... thanks\n\ndoc/v3/api_samples/versions/v2-version-get-resp.json","commit_id":"c395709c817c7cad71fbc2d5a872be8345a48690"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"2262c33f8f4e7103059e84570a50c8d5660f9f08","unresolved":false,"context_lines":[{"line_number":7,"context_line":"Moves \"versions\" functional tests in v2.1 tests"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"This commit moves \"versions\" functional tests in v2.1 tests which are"},{"line_number":10,"context_line":"under /v3 directory and run those for v2 and v2.1."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"There was no tests for v2.1 version so this patch adds"},{"line_number":13,"context_line":"tests for v2.1 version request."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":11,"id":"3a50d1a3_be2b8781","line":10,"in_reply_to":"3a50d1a3_43067886","updated":"2015-08-03 06:46:04.000000000","message":"Actually current v2.1 tests and sample files are under /v3 which going to be cleaned up under https://review.openstack.org/#/c/189218/\n\nAfter that there will not be any confusion of \"v3\".","commit_id":"c395709c817c7cad71fbc2d5a872be8345a48690"}],"nova/tests/functional/api_sample_tests/api_samples/versions/v21-version-get-resp.json.tpl":[{"author":{"_account_id":782,"name":"John Garbutt","email":"john@johngarbutt.com","username":"johngarbutt"},"change_message_id":"f5efe68ff633980329da00a6fee3b1249eaf9a24","unresolved":false,"context_lines":[{"line_number":1,"context_line":"{"},{"line_number":2,"context_line":"    \"version\": {"},{"line_number":3,"context_line":"        \"id\": \"v2.1\","},{"line_number":4,"context_line":"        \"links\": ["},{"line_number":5,"context_line":"            {"},{"line_number":6,"context_line":"                \"href\": \"http://openstack.example.com/v2.1/\","}],"source_content_type":"text/x-smarty","patch_set":15,"id":"fa1b9901_7c05a743","line":3,"updated":"2015-08-21 11:20:36.000000000","message":"How do we not have something for v2.0 in here? bit confused.","commit_id":"7b9e0f39130eec805fc8e6c7f911674cf6c34c05"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"14ea312664f0792f572ffce0fc842806c63a73b4","unresolved":false,"context_lines":[{"line_number":1,"context_line":"{"},{"line_number":2,"context_line":"    \"version\": {"},{"line_number":3,"context_line":"        \"id\": \"v2.1\","},{"line_number":4,"context_line":"        \"links\": ["},{"line_number":5,"context_line":"            {"},{"line_number":6,"context_line":"                \"href\": \"http://openstack.example.com/v2.1/\","}],"source_content_type":"text/x-smarty","patch_set":15,"id":"fa1b9901_a280b78c","line":3,"in_reply_to":"fa1b9901_7c05a743","updated":"2015-08-24 03:09:53.000000000","message":"Actually this sample file is for \"/v2.1\" v2.1 version only. \n\nv2-version-get-resp.json.tpl - \"/v2\"  v2 version\nversions-get-resp.json.tpl - \"/\" all available version","commit_id":"7b9e0f39130eec805fc8e6c7f911674cf6c34c05"},{"author":{"_account_id":782,"name":"John Garbutt","email":"john@johngarbutt.com","username":"johngarbutt"},"change_message_id":"26bffcdd0b32cc453a08c7d98849dcf012abe7eb","unresolved":false,"context_lines":[{"line_number":1,"context_line":"{"},{"line_number":2,"context_line":"    \"version\": {"},{"line_number":3,"context_line":"        \"id\": \"v2.1\","},{"line_number":4,"context_line":"        \"links\": ["},{"line_number":5,"context_line":"            {"},{"line_number":6,"context_line":"                \"href\": \"http://openstack.example.com/v2.1/\","}],"source_content_type":"text/x-smarty","patch_set":15,"id":"fa1b9901_725d4e78","line":3,"in_reply_to":"fa1b9901_a280b78c","updated":"2015-08-25 09:21:15.000000000","message":"Oh, ok, not sure I realised that existed.","commit_id":"7b9e0f39130eec805fc8e6c7f911674cf6c34c05"}],"nova/tests/functional/v3/test_versions.py":[{"author":{"_account_id":5754,"name":"Alex Xu","email":"hejie.xu@intel.com","username":"xuhj"},"change_message_id":"323dcb5a050f0e3410412bdc2f010af7e4ab7f8a","unresolved":false,"context_lines":[{"line_number":24,"context_line":"    _api_version \u003d \u0027v2\u0027"},{"line_number":25,"context_line":""},{"line_number":26,"context_line":"    def test_versions_get(self):"},{"line_number":27,"context_line":"        response \u003d self._do_get(\u0027\u0027, strip_version\u003dTrue)"},{"line_number":28,"context_line":"        subs \u003d self._get_regexes()"},{"line_number":29,"context_line":"        self._verify_response(\u0027versions-get-resp\u0027, subs, response, 200)"}],"source_content_type":"text/x-python","patch_set":3,"id":"9a41bdd9_1f0cdfeb","line":27,"updated":"2015-07-15 02:45:47.000000000","message":"we\u0027d better have test for strip_version\u003dFalse.","commit_id":"fd5cb5b5d39dd0c1984c835cd8ba23b221ed84a3"},{"author":{"_account_id":5754,"name":"Alex Xu","email":"hejie.xu@intel.com","username":"xuhj"},"change_message_id":"f891a662c279f172a63c5735fea7bc68d01898db","unresolved":false,"context_lines":[{"line_number":24,"context_line":"    _api_version \u003d \u0027v2\u0027"},{"line_number":25,"context_line":""},{"line_number":26,"context_line":"    def test_versions_get(self):"},{"line_number":27,"context_line":"        response \u003d self._do_get(\u0027\u0027, strip_version\u003dTrue)"},{"line_number":28,"context_line":"        subs \u003d self._get_regexes()"},{"line_number":29,"context_line":"        self._verify_response(\u0027versions-get-resp\u0027, subs, response, 200)"}],"source_content_type":"text/x-python","patch_set":3,"id":"9a41bdd9_e07e3c69","line":27,"in_reply_to":"9a41bdd9_05c9f225","updated":"2015-07-15 04:38:43.000000000","message":"oops, I mean for the \u0027/2.1\u0027 or \u0027/2\u0027, they can just get v2.1 or v2 version info. \u0027/\u0027 is used to get all the version info.","commit_id":"fd5cb5b5d39dd0c1984c835cd8ba23b221ed84a3"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"e6d8fc809743d89581e13bfe59fc232e100966fc","unresolved":false,"context_lines":[{"line_number":24,"context_line":"    _api_version \u003d \u0027v2\u0027"},{"line_number":25,"context_line":""},{"line_number":26,"context_line":"    def test_versions_get(self):"},{"line_number":27,"context_line":"        response \u003d self._do_get(\u0027\u0027, strip_version\u003dTrue)"},{"line_number":28,"context_line":"        subs \u003d self._get_regexes()"},{"line_number":29,"context_line":"        self._verify_response(\u0027versions-get-resp\u0027, subs, response, 200)"}],"source_content_type":"text/x-python","patch_set":3,"id":"9a41bdd9_05c9f225","line":27,"in_reply_to":"9a41bdd9_1f0cdfeb","updated":"2015-07-15 04:20:19.000000000","message":"you means negative tests, because strip_version\u003dFalse will through 404.","commit_id":"fd5cb5b5d39dd0c1984c835cd8ba23b221ed84a3"},{"author":{"_account_id":5754,"name":"Alex Xu","email":"hejie.xu@intel.com","username":"xuhj"},"change_message_id":"e89abfa535a996c2b09672da725eb5fc5122d4be","unresolved":false,"context_lines":[{"line_number":21,"context_line":"    # TODO(gmann): Overriding \u0027_api_version\u0027 till all functional tests"},{"line_number":22,"context_line":"    # are merged between v2 and v2.1. After that base class variable"},{"line_number":23,"context_line":"    # itself can be changed to \u0027v2\u0027"},{"line_number":24,"context_line":"    _api_version \u003d \u0027v2\u0027"},{"line_number":25,"context_line":""},{"line_number":26,"context_line":"    def test_versions_get(self):"},{"line_number":27,"context_line":"        response \u003d self._do_get(\u0027\u0027, strip_version\u003dTrue)"}],"source_content_type":"text/x-python","patch_set":7,"id":"3a50d1a3_d47a4477","line":24,"updated":"2015-07-31 05:28:51.000000000","message":"Exactly to say the versions api isn\u0027t belong to v2 or v2.1. We can just run it with one time","commit_id":"1b7c3a8b6d1f0227b20f8c8eea5bf282cf90da94"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"1638a4ea4b494992b723bccfcd7be0a6398ea1da","unresolved":false,"context_lines":[{"line_number":21,"context_line":"    # TODO(gmann): Overriding \u0027_api_version\u0027 till all functional tests"},{"line_number":22,"context_line":"    # are merged between v2 and v2.1. After that base class variable"},{"line_number":23,"context_line":"    # itself can be changed to \u0027v2\u0027"},{"line_number":24,"context_line":"    _api_version \u003d \u0027v2\u0027"},{"line_number":25,"context_line":""},{"line_number":26,"context_line":"    def test_versions_get(self):"},{"line_number":27,"context_line":"        response \u003d self._do_get(\u0027\u0027, strip_version\u003dTrue)"}],"source_content_type":"text/x-python","patch_set":7,"id":"3a50d1a3_7adf99d6","line":24,"in_reply_to":"3a50d1a3_d47a4477","updated":"2015-07-31 06:52:38.000000000","message":"Done.","commit_id":"1b7c3a8b6d1f0227b20f8c8eea5bf282cf90da94"}]}