)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":5174,"name":"Mauro Sergio Martins Rodrigues","email":"maurosr@linux.vnet.ibm.com","username":"maurosr"},"change_message_id":"0724fe9e10b2622e753abca9a448a00c9914e71f","unresolved":false,"context_lines":[{"line_number":18,"context_line":""},{"line_number":19,"context_line":"Valid bus values vary per the libvirt_type setting:"},{"line_number":20,"context_line":""},{"line_number":21,"context_line":" qemu/kvm: \u0027virtio\u0027, \u0027scsi\u0027, \u0027ide\u0027, \u0027virtio\u0027"},{"line_number":22,"context_line":" xen: \u0027xen\u0027, \u0027ide\u0027"},{"line_number":23,"context_line":" uml: \u0027uml\u0027"},{"line_number":24,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"AAAAM3%2F%2FVow%3D","line":21,"updated":"2013-01-28 13:17:26.000000000","message":"you mentioned virtio twice and forgot usb","commit_id":"3ba0288f90c1d88e33a4776e69fd9c069f31cf41"}],"nova/virt/libvirt/blockinfo.py":[{"author":{"_account_id":5174,"name":"Mauro Sergio Martins Rodrigues","email":"maurosr@linux.vnet.ibm.com","username":"maurosr"},"change_message_id":"0724fe9e10b2622e753abca9a448a00c9914e71f","unresolved":false,"context_lines":[{"line_number":175,"context_line":"            }"},{"line_number":176,"context_line":""},{"line_number":177,"context_line":"        if not virt_type in valid_bus:"},{"line_number":178,"context_line":"            raise exception.NovaException("},{"line_number":179,"context_line":"                _(\"Unsupported virt type %s\") % virt_type)"},{"line_number":180,"context_line":""},{"line_number":181,"context_line":"        return disk_bus in valid_bus[virt_type]"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAAM3%2F%2FVoo%3D","line":178,"updated":"2013-01-28 13:17:26.000000000","message":"I\u0027m not sure that use NovaException is a good idea, I know that it\u0027s in other places on the file, but NovaException is supposed to be a generic exception","commit_id":"3ba0288f90c1d88e33a4776e69fd9c069f31cf41"},{"author":{"_account_id":1812,"name":"p-draigbrady","email":"P@draigBrady.com","username":"p-draigbrady"},"change_message_id":"e9269a8f694f9ca5e42526c9f70d3bc39106db97","unresolved":false,"context_lines":[{"line_number":202,"context_line":"            if not is_disk_bus_valid_for_virt(virt_type, disk_bus):"},{"line_number":203,"context_line":"                raise exception.NovaException("},{"line_number":204,"context_line":"                    _(\"Disk bus %(disk_bus)s is not valid for %(virt)s\") %"},{"line_number":205,"context_line":"                    {\u0027disk_bus\u0027: disk_bus, \u0027virt\u0027: virt_type})"},{"line_number":206,"context_line":"            return disk_bus"},{"line_number":207,"context_line":""},{"line_number":208,"context_line":"    # Otherwise pick a hypervisor default disk bus"}],"source_content_type":"text/x-python","patch_set":10,"id":"AAAAM3%2F%2FH84%3D","line":205,"updated":"2013-02-06 14:05:17.000000000","message":"The commit message says the tagged property is a \"desired ... bus type\",\nwhereas the raise here implies it a \"required ... bus type\".\nShould we fall through to the default selection below?","commit_id":"fbde8c0b0e3a47444bd8299a60900e0cdc7bd0c7"},{"author":{"_account_id":1779,"name":"Daniel Berrange","email":"berrange@redhat.com","username":"berrange"},"change_message_id":"d5ab1744a3464573e03872775c125b140b25bb36","unresolved":false,"context_lines":[{"line_number":202,"context_line":"            if not is_disk_bus_valid_for_virt(virt_type, disk_bus):"},{"line_number":203,"context_line":"                raise exception.NovaException("},{"line_number":204,"context_line":"                    _(\"Disk bus %(disk_bus)s is not valid for %(virt)s\") %"},{"line_number":205,"context_line":"                    {\u0027disk_bus\u0027: disk_bus, \u0027virt\u0027: virt_type})"},{"line_number":206,"context_line":"            return disk_bus"},{"line_number":207,"context_line":""},{"line_number":208,"context_line":"    # Otherwise pick a hypervisor default disk bus"}],"source_content_type":"text/x-python","patch_set":10,"id":"AAAAM3%2F%2FH8Y%3D","line":205,"in_reply_to":"AAAAM3%2F%2FH84%3D","updated":"2013-02-06 14:13:31.000000000","message":"No, if the user requests an invalid bus, we should explicitly error - we shouldn\u0027t assume that their disk image will work correctly with a different bus. I\u0027ll clarify the commit message","commit_id":"fbde8c0b0e3a47444bd8299a60900e0cdc7bd0c7"}]}