)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"change_message_id":"373521d2d34488496b1393d39bb1c5950fd952cc","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     Sean Dague \u003csean@dague.net\u003e"},{"line_number":5,"context_line":"CommitDate: 2015-07-14 14:51:12 -0400"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"make test_save_updates_numa_topology stable accross python versions"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"test_save_updates_numa_topology has a rather complex nova object to"},{"line_number":10,"context_line":"represent numa. This includes items which are sets, but must be"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"9a41bdd9_27e0d028","line":7,"range":{"start_line":7,"start_character":44,"end_line":7,"end_character":51},"updated":"2015-07-14 18:57:05.000000000","message":"Should be \"across\"","commit_id":"d6f3181aecbac62a914ea55904f14019c4ee5c39"},{"author":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"change_message_id":"373521d2d34488496b1393d39bb1c5950fd952cc","unresolved":false,"context_lines":[{"line_number":9,"context_line":"test_save_updates_numa_topology has a rather complex nova object to"},{"line_number":10,"context_line":"represent numa. This includes items which are sets, but must be"},{"line_number":11,"context_line":"converted to lists for json. This is not a stable output operation"},{"line_number":12,"context_line":"across all space and time. The mock comparitor was failing here some"},{"line_number":13,"context_line":"times because of it."},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"Instead, we can manually inspect the parameter in question with our"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"9a41bdd9_87cd1cb9","line":12,"range":{"start_line":12,"start_character":36,"end_line":12,"end_character":46},"updated":"2015-07-14 18:57:05.000000000","message":"Should be comparator","commit_id":"d6f3181aecbac62a914ea55904f14019c4ee5c39"},{"author":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"change_message_id":"373521d2d34488496b1393d39bb1c5950fd952cc","unresolved":false,"context_lines":[{"line_number":13,"context_line":"times because of it."},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"Instead, we can manually inspect the parameter in question with our"},{"line_number":16,"context_line":"json comparitor to ensure that it is correct."},{"line_number":17,"context_line":""},{"line_number":18,"context_line":"Change-Id: Ibfa441356d10417e2b1e092826562ad03d8cfd02"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"9a41bdd9_27c77097","line":16,"range":{"start_line":16,"start_character":5,"end_line":16,"end_character":15},"updated":"2015-07-14 18:57:05.000000000","message":"This too.","commit_id":"d6f3181aecbac62a914ea55904f14019c4ee5c39"}],"nova/tests/unit/objects/test_instance.py":[{"author":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"change_message_id":"373521d2d34488496b1393d39bb1c5950fd952cc","unresolved":false,"context_lines":[{"line_number":456,"context_line":"        inst.numa_topology \u003d fake_obj_numa_topology"},{"line_number":457,"context_line":"        inst.save()"},{"line_number":458,"context_line":""},{"line_number":459,"context_line":"        # NOTE(sdague): the nova object for NUMA isn\u0027t a stable"},{"line_number":460,"context_line":"        # datastructure (it has sets that have been converted to lists"},{"line_number":461,"context_line":"        # for json), so we can\u0027t have mock do the comparison. Instead"},{"line_number":462,"context_line":"        # manually compare the final parameter using our json equality"}],"source_content_type":"text/x-python","patch_set":1,"id":"9a41bdd9_875bdcf5","line":459,"range":{"start_line":459,"start_character":24,"end_line":459,"end_character":48},"updated":"2015-07-14 18:57:05.000000000","message":"The thing that isn\u0027t \"stable\" is just the serialized object representation (or rather the jsonification of it). It has nothing to do with the NUMA object itself.","commit_id":"d6f3181aecbac62a914ea55904f14019c4ee5c39"}]}
