)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":1653,"name":"garyk","email":"gkotton@vmware.com","username":"garyk"},"change_message_id":"827091cbc253b42cbe472b0d07b031d1900600b6","unresolved":false,"context_lines":[{"line_number":10,"context_line":"an instance for triggering a special funciton such as the kernel crash dump"},{"line_number":11,"context_line":"mechanism."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"This patch implements the new API on the libvirt driver."},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"Change-Id: Iaf63352139c466430d3304a87a66398133541fac"},{"line_number":16,"context_line":"Implements: blueprint inject-nmi"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"9a41bdd9_383ad999","line":13,"updated":"2015-07-16 06:09:26.000000000","message":"I think that you need to break this into smaller reviews.","commit_id":"cc56d32718d2c589460acb79ef32339b78e2464e"},{"author":{"_account_id":1653,"name":"garyk","email":"gkotton@vmware.com","username":"garyk"},"change_message_id":"ca1f006e983ff0e561cf24db1bfdfa2757cc0fbc","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     Hironori Shiina \u003cshiina.hironori@jp.fujitsu.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2015-07-16 13:35:04 +0000"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Add a dirver API to inject an NMI"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"This patch adds a new driver API to inject an NMI to an instance."},{"line_number":10,"context_line":"This API is implemented by libvirt driver."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"9a41bdd9_01636f1b","line":7,"updated":"2015-07-18 12:42:58.000000000","message":"pleas prefix with libvirt\n\ndirver \u003d\u003e driver","commit_id":"0bb7d9b33cbafbded885ba67e68cdba7c2b567b4"},{"author":{"_account_id":13689,"name":"Hironori Shiina","email":"Hironori.Shiina@fujitsu.com","username":"shiina"},"change_message_id":"7b796dcc0e2f1a33df5fc9a01bc9fa536e50e6b3","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     Hironori Shiina \u003cshiina.hironori@jp.fujitsu.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2015-07-16 13:35:04 +0000"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Add a dirver API to inject an NMI"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"This patch adds a new driver API to inject an NMI to an instance."},{"line_number":10,"context_line":"This API is implemented by libvirt driver."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"3a50d1a3_ca96144c","line":7,"in_reply_to":"9a41bdd9_01636f1b","updated":"2015-07-21 05:49:10.000000000","message":"Done","commit_id":"0bb7d9b33cbafbded885ba67e68cdba7c2b567b4"},{"author":{"_account_id":1653,"name":"garyk","email":"gkotton@vmware.com","username":"garyk"},"change_message_id":"306c7af3bd544ed487ee6cee32591a06b1d41bbb","unresolved":false,"context_lines":[{"line_number":9,"context_line":"This patch adds a new driver API to inject an NMI to an instance."},{"line_number":10,"context_line":"This API is implemented by libvirt driver."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"NMI (Non-maskable Interruption) is used to trigger a special funciton such as"},{"line_number":13,"context_line":"the kernel crash dump mechanism."},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"DocImpact"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":6,"id":"3a50d1a3_618b5769","line":12,"updated":"2015-07-27 06:54:01.000000000","message":"funciton \u003d\u003e function","commit_id":"b6ac7fdd3f5d6925690d506fcfd8df77af515617"},{"author":{"_account_id":13689,"name":"Hironori Shiina","email":"Hironori.Shiina@fujitsu.com","username":"shiina"},"change_message_id":"8636d7e69823431cf36603631d98d4c6e193dea4","unresolved":false,"context_lines":[{"line_number":9,"context_line":"This patch adds a new driver API to inject an NMI to an instance."},{"line_number":10,"context_line":"This API is implemented by libvirt driver."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"NMI (Non-maskable Interruption) is used to trigger a special funciton such as"},{"line_number":13,"context_line":"the kernel crash dump mechanism."},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"DocImpact"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":6,"id":"3a50d1a3_b29e8b05","line":12,"in_reply_to":"3a50d1a3_618b5769","updated":"2015-07-27 08:46:41.000000000","message":"Thank you.","commit_id":"b6ac7fdd3f5d6925690d506fcfd8df77af515617"}],"etc/nova/policy.json":[{"author":{"_account_id":1653,"name":"garyk","email":"gkotton@vmware.com","username":"garyk"},"change_message_id":"827091cbc253b42cbe472b0d07b031d1900600b6","unresolved":false,"context_lines":[{"line_number":190,"context_line":"    \"os_compute_api:servers:create_image:allow_volume_backed\": \"\","},{"line_number":191,"context_line":"    \"os_compute_api:servers:start\": \"rule:admin_or_owner\","},{"line_number":192,"context_line":"    \"os_compute_api:servers:stop\": \"rule:admin_or_owner\","},{"line_number":193,"context_line":"    \"os_compute_api:servers:inject_nmi\": \"rule:admin_or_owner\","},{"line_number":194,"context_line":"    \"os_compute_api:os-access-ips:discoverable\": \"\","},{"line_number":195,"context_line":"    \"os_compute_api:os-access-ips\": \"\","},{"line_number":196,"context_line":"    \"os_compute_api:os-admin-actions\": \"rule:admin_api\","}],"source_content_type":"application/json","patch_set":1,"id":"9a41bdd9_b84ee938","line":193,"updated":"2015-07-16 06:09:26.000000000","message":"this is an API change so this will require a api version bump. As far as I know that may require a spec.","commit_id":"cc56d32718d2c589460acb79ef32339b78e2464e"}],"nova/api/openstack/api_version_request.py":[{"author":{"_account_id":1653,"name":"garyk","email":"gkotton@vmware.com","username":"garyk"},"change_message_id":"827091cbc253b42cbe472b0d07b031d1900600b6","unresolved":false,"context_lines":[{"line_number":45,"context_line":"    * 2.4 - Exposes reserved field in os-fixed-ips."},{"line_number":46,"context_line":"    * 2.5 - Allow server search option ip6 for non-admin"},{"line_number":47,"context_line":"    * 2.6 - Consolidate the APIs for getting remote consoles"},{"line_number":48,"context_line":"    * 2.7 - Adds inject-nmi to servr actions"},{"line_number":49,"context_line":"\"\"\""},{"line_number":50,"context_line":""},{"line_number":51,"context_line":"# The minimum and maximum versions of the API supported"}],"source_content_type":"text/x-python","patch_set":1,"id":"9a41bdd9_7854e1c8","line":48,"updated":"2015-07-16 06:09:26.000000000","message":"servr \u003d\u003e server","commit_id":"cc56d32718d2c589460acb79ef32339b78e2464e"}],"nova/api/openstack/compute/plugins/v3/servers.py":[{"author":{"_account_id":1653,"name":"garyk","email":"gkotton@vmware.com","username":"garyk"},"change_message_id":"827091cbc253b42cbe472b0d07b031d1900600b6","unresolved":false,"context_lines":[{"line_number":1145,"context_line":"        except exception.InstanceInvalidState as state_error:"},{"line_number":1146,"context_line":"            common.raise_http_conflict_for_instance_invalid_state(state_error,"},{"line_number":1147,"context_line":"                \u0027inject_nmi\u0027, id)"},{"line_number":1148,"context_line":"        except (exception.InstanceNotReady, exception.InstanceIsLocked) as e:"},{"line_number":1149,"context_line":"            raise webob.exc.HTTPConflict(explanation\u003de.format_message())"},{"line_number":1150,"context_line":""},{"line_number":1151,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"9a41bdd9_986685b9","line":1148,"updated":"2015-07-16 06:09:26.000000000","message":"what if the instance does not exist?","commit_id":"cc56d32718d2c589460acb79ef32339b78e2464e"}],"nova/virt/driver.py":[{"author":{"_account_id":1653,"name":"garyk","email":"gkotton@vmware.com","username":"garyk"},"change_message_id":"827091cbc253b42cbe472b0d07b031d1900600b6","unresolved":false,"context_lines":[{"line_number":663,"context_line":"        \"\"\""},{"line_number":664,"context_line":"        raise NotImplementedError()"},{"line_number":665,"context_line":""},{"line_number":666,"context_line":"    def inject_nmi(self, instance):"},{"line_number":667,"context_line":"        \"\"\"Inject an NMI to the specified instance."},{"line_number":668,"context_line":""},{"line_number":669,"context_line":"        :param instance: nova objects.instance.Instance"}],"source_content_type":"text/x-python","patch_set":1,"id":"9a41bdd9_18283532","line":666,"updated":"2015-07-16 06:09:26.000000000","message":"please add a DocImpact to the commit message. In the past I have been asked to do this for all virt driver additions","commit_id":"cc56d32718d2c589460acb79ef32339b78e2464e"}],"nova/virt/libvirt/driver.py":[{"author":{"_account_id":1653,"name":"garyk","email":"gkotton@vmware.com","username":"garyk"},"change_message_id":"827091cbc253b42cbe472b0d07b031d1900600b6","unresolved":false,"context_lines":[{"line_number":2278,"context_line":"            msg \u003d (_(\u0027Error from libvirt while injecting an NMI to \u0027"},{"line_number":2279,"context_line":"                     \u0027%(instance_name)s: \u0027"},{"line_number":2280,"context_line":"                     \u0027[Error Code %(error_code)s] %(ex)s\u0027)"},{"line_number":2281,"context_line":"                   % {\u0027instance_name\u0027: instance.name,"},{"line_number":2282,"context_line":"                      \u0027error_code\u0027: error_code, \u0027ex\u0027: ex})"},{"line_number":2283,"context_line":"            raise exception.NovaException(msg)"},{"line_number":2284,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"9a41bdd9_f8db114d","line":2281,"updated":"2015-07-16 06:09:26.000000000","message":"can you please use instance.uuid. The instance name is not unique","commit_id":"cc56d32718d2c589460acb79ef32339b78e2464e"},{"author":{"_account_id":6167,"name":"Ken\u0027ichi Ohmichi","email":"ken1ohmichi@gmail.com","username":"oomichi"},"change_message_id":"acdeeb4d84f2539cd06f5d1b714861366b3d601f","unresolved":false,"context_lines":[{"line_number":2238,"context_line":"        \"\"\"Inject an NMI to the specified instance.\"\"\""},{"line_number":2239,"context_line":"        try:"},{"line_number":2240,"context_line":"            self._host.get_guest(instance).inject_nmi()"},{"line_number":2241,"context_line":"        except libvirt.libvirtError as ex:"},{"line_number":2242,"context_line":"            error_code \u003d ex.get_error_code()"},{"line_number":2243,"context_line":"            msg \u003d (_(\u0027Error from libvirt while injecting an NMI to \u0027"},{"line_number":2244,"context_line":"                     \u0027%(instance_uuid)s: \u0027"}],"source_content_type":"text/x-python","patch_set":8,"id":"3a50d1a3_f685400a","line":2241,"updated":"2015-07-30 01:56:19.000000000","message":"nit: Ideally, I prefer to see the corresponding test for here.","commit_id":"d0ee3ab01dccebdf78fc7cb71ed92f617d596540"}]}