)]}'
{"id":"openstack%2Fnova~20262","triplet_id":"openstack%2Fnova~master~Ida94148fcb870830ae675839ab4f900ad798d9bb","project":"openstack/nova","branch":"master","topic":"bug/1103086","hashtags":[],"change_id":"Ida94148fcb870830ae675839ab4f900ad798d9bb","subject":"Change to support custom nw filters.","status":"MERGED","created":"2013-01-22 18:14:41.000000000","updated":"2013-02-10 16:55:52.000000000","submitted":"2013-02-10 16:55:50.000000000","submitter":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"total_comment_count":4,"unresolved_comment_count":0,"has_review_started":true,"meta_rev_id":"f431e1c2423dc51865f3841b4cd0df71050fa3bb","_number":20262,"virtual_id_number":20262,"owner":{"_account_id":5209,"name":"Ed Bak","email":"ed.bak2@hpe.com","username":"ed-bak2"},"actions":{},"labels":{"Verified":{"approved":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"recommended":{"_account_id":2166,"name":"SmokeStack CI","username":"smokestack","tags":["SERVICE_USER"]},"all":[{"value":0,"_account_id":5292,"name":"Christopher Yeoh","email":"cbkyeoh@gmail.com","username":"cyeoh-0"},{"value":0,"_account_id":1501,"name":"Phil Day","email":"philip.day@hp.com","username":"philip-day"},{"value":0,"_account_id":2750,"name":"Sean Dague","email":"sean@dague.net","username":"sdague"},{"value":0,"_account_id":24,"name":"Chuck Short","email":"charles.short@windriver.com","username":"zulcss"},{"value":0,"_account_id":1561,"name":"Russell Bryant","email":"rbryant@redhat.com","username":"russellb"},{"value":0,"_account_id":5209,"name":"Ed Bak","email":"ed.bak2@hpe.com","username":"ed-bak2"},{"value":0,"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},{"value":1,"date":"2013-02-07 23:49:50.000000000","_account_id":2166,"name":"SmokeStack CI","username":"smokestack","tags":["SERVICE_USER"]},{"value":0,"_account_id":5174,"name":"Mauro Sergio Martins Rodrigues","email":"maurosr@linux.vnet.ibm.com","username":"maurosr"},{"value":0,"_account_id":1779,"name":"Daniel Berrange","email":"berrange@redhat.com","username":"berrange"},{"value":2,"date":"2013-02-10 16:55:50.000000000","_account_id":3,"name":"Jenkins","username":"jenkins"}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","value":1,"default_value":0,"optional":true},"Code-Review":{"approved":{"_account_id":2750,"name":"Sean Dague","email":"sean@dague.net","username":"sdague"},"recommended":{"_account_id":5292,"name":"Christopher Yeoh","email":"cbkyeoh@gmail.com","username":"cyeoh-0"},"all":[{"value":1,"date":"2013-02-10 01:16:06.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":5292,"name":"Christopher Yeoh","email":"cbkyeoh@gmail.com","username":"cyeoh-0"},{"value":0,"_account_id":1501,"name":"Phil Day","email":"philip.day@hp.com","username":"philip-day"},{"value":2,"date":"2013-02-09 23:59:33.000000000","_account_id":2750,"name":"Sean Dague","email":"sean@dague.net","username":"sdague"},{"value":0,"_account_id":24,"name":"Chuck Short","email":"charles.short@windriver.com","username":"zulcss"},{"value":2,"date":"2013-02-10 14:10:54.000000000","_account_id":1561,"name":"Russell Bryant","email":"rbryant@redhat.com","username":"russellb"},{"value":0,"_account_id":5209,"name":"Ed Bak","email":"ed.bak2@hpe.com","username":"ed-bak2"},{"value":0,"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},{"value":0,"_account_id":2166,"name":"SmokeStack CI","username":"smokestack","tags":["SERVICE_USER"]},{"value":0,"_account_id":5174,"name":"Mauro Sergio Martins Rodrigues","email":"maurosr@linux.vnet.ibm.com","username":"maurosr"},{"value":1,"date":"2013-02-07 21:02:37.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":1779,"name":"Daniel Berrange","email":"berrange@redhat.com","username":"berrange"},{"value":0,"_account_id":3,"name":"Jenkins","username":"jenkins"}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","value":1,"default_value":0,"optional":true},"Workflow":{"approved":{"_account_id":1561,"name":"Russell Bryant","email":"rbryant@redhat.com","username":"russellb"},"all":[{"value":0,"_account_id":5292,"name":"Christopher Yeoh","email":"cbkyeoh@gmail.com","username":"cyeoh-0"},{"value":0,"_account_id":1501,"name":"Phil Day","email":"philip.day@hp.com","username":"philip-day"},{"value":0,"date":"2013-02-09 23:59:33.000000000","_account_id":2750,"name":"Sean Dague","email":"sean@dague.net","username":"sdague"},{"value":0,"_account_id":24,"name":"Chuck Short","email":"charles.short@windriver.com","username":"zulcss"},{"value":1,"date":"2013-02-10 14:10:54.000000000","_account_id":1561,"name":"Russell Bryant","email":"rbryant@redhat.com","username":"russellb"},{"value":0,"_account_id":5209,"name":"Ed Bak","email":"ed.bak2@hpe.com","username":"ed-bak2"},{"value":0,"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},{"value":0,"_account_id":2166,"name":"SmokeStack CI","username":"smokestack","tags":["SERVICE_USER"]},{"value":0,"_account_id":5174,"name":"Mauro Sergio Martins Rodrigues","email":"maurosr@linux.vnet.ibm.com","username":"maurosr"},{"value":0,"_account_id":1779,"name":"Daniel Berrange","email":"berrange@redhat.com","username":"berrange"},{"value":0,"_account_id":3,"name":"Jenkins","username":"jenkins"}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true},"Review-Priority":{"all":[{"value":0,"_account_id":5292,"name":"Christopher Yeoh","email":"cbkyeoh@gmail.com","username":"cyeoh-0"},{"value":0,"_account_id":1501,"name":"Phil Day","email":"philip.day@hp.com","username":"philip-day"},{"value":0,"_account_id":2750,"name":"Sean Dague","email":"sean@dague.net","username":"sdague"},{"value":0,"_account_id":24,"name":"Chuck Short","email":"charles.short@windriver.com","username":"zulcss"},{"value":0,"_account_id":1561,"name":"Russell Bryant","email":"rbryant@redhat.com","username":"russellb"},{"value":0,"_account_id":5209,"name":"Ed Bak","email":"ed.bak2@hpe.com","username":"ed-bak2"},{"value":0,"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},{"value":0,"_account_id":2166,"name":"SmokeStack CI","username":"smokestack","tags":["SERVICE_USER"]},{"value":0,"_account_id":5174,"name":"Mauro Sergio Martins Rodrigues","email":"maurosr@linux.vnet.ibm.com","username":"maurosr"},{"value":0,"_account_id":1779,"name":"Daniel Berrange","email":"berrange@redhat.com","username":"berrange"},{"value":0,"_account_id":3,"name":"Jenkins","username":"jenkins"}],"values":{" 0":"Default Priority","+1":"Contributor Review Promise","+2":"Core Review Promise"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":3,"name":"Jenkins","username":"jenkins"},{"_account_id":24,"name":"Chuck Short","email":"charles.short@windriver.com","username":"zulcss"},{"_account_id":1501,"name":"Phil Day","email":"philip.day@hp.com","username":"philip-day"},{"_account_id":1561,"name":"Russell Bryant","email":"rbryant@redhat.com","username":"russellb"},{"_account_id":1779,"name":"Daniel Berrange","email":"berrange@redhat.com","username":"berrange"},{"_account_id":2166,"name":"SmokeStack CI","username":"smokestack","tags":["SERVICE_USER"]},{"_account_id":2750,"name":"Sean Dague","email":"sean@dague.net","username":"sdague"},{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},{"_account_id":5174,"name":"Mauro Sergio Martins Rodrigues","email":"maurosr@linux.vnet.ibm.com","username":"maurosr"},{"_account_id":5209,"name":"Ed Bak","email":"ed.bak2@hpe.com","username":"ed-bak2"},{"_account_id":5292,"name":"Christopher Yeoh","email":"cbkyeoh@gmail.com","username":"cyeoh-0"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2013-01-22 18:22:52.000000000","updated_by":{"_account_id":24,"name":"Chuck Short","email":"charles.short@windriver.com","username":"zulcss"},"reviewer":{"_account_id":24,"name":"Chuck Short","email":"charles.short@windriver.com","username":"zulcss"},"state":"REVIEWER"},{"updated":"2013-01-25 03:27:48.000000000","updated_by":{"_account_id":5174,"name":"Mauro Sergio Martins Rodrigues","email":"maurosr@linux.vnet.ibm.com","username":"maurosr"},"reviewer":{"_account_id":5174,"name":"Mauro Sergio Martins Rodrigues","email":"maurosr@linux.vnet.ibm.com","username":"maurosr"},"state":"REVIEWER"},{"updated":"2013-01-31 18:11:53.000000000","updated_by":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"reviewer":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"state":"REVIEWER"},{"updated":"2013-02-06 12:40:53.000000000","updated_by":{"_account_id":1501,"name":"Phil Day","email":"philip.day@hp.com","username":"philip-day"},"reviewer":{"_account_id":1501,"name":"Phil Day","email":"philip.day@hp.com","username":"philip-day"},"state":"REVIEWER"},{"updated":"2013-02-07 21:02:37.000000000","updated_by":{"_account_id":1779,"name":"Daniel Berrange","email":"berrange@redhat.com","username":"berrange"},"reviewer":{"_account_id":1779,"name":"Daniel Berrange","email":"berrange@redhat.com","username":"berrange"},"state":"REVIEWER"},{"updated":"2013-02-07 23:49:50.000000000","updated_by":{"_account_id":2166,"name":"SmokeStack CI","username":"smokestack","tags":["SERVICE_USER"]},"reviewer":{"_account_id":2166,"name":"SmokeStack CI","username":"smokestack","tags":["SERVICE_USER"]},"state":"REVIEWER"},{"updated":"2013-02-09 23:59:33.000000000","updated_by":{"_account_id":2750,"name":"Sean Dague","email":"sean@dague.net","username":"sdague"},"reviewer":{"_account_id":2750,"name":"Sean Dague","email":"sean@dague.net","username":"sdague"},"state":"REVIEWER"},{"updated":"2013-02-10 01:16:06.000000000","updated_by":{"_account_id":5292,"name":"Christopher Yeoh","email":"cbkyeoh@gmail.com","username":"cyeoh-0"},"reviewer":{"_account_id":5292,"name":"Christopher Yeoh","email":"cbkyeoh@gmail.com","username":"cyeoh-0"},"state":"REVIEWER"},{"updated":"2013-02-10 14:10:54.000000000","updated_by":{"_account_id":1561,"name":"Russell Bryant","email":"rbryant@redhat.com","username":"russellb"},"reviewer":{"_account_id":1561,"name":"Russell Bryant","email":"rbryant@redhat.com","username":"russellb"},"state":"REVIEWER"},{"updated":"2013-02-10 16:55:50.000000000","updated_by":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"reviewer":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"state":"REVIEWER"}],"messages":[{"id":"a4a93449fe514b73d0d0303d13eb4a761af8eb94","author":{"_account_id":24,"name":"Chuck Short","email":"charles.short@windriver.com","username":"zulcss"},"date":"2013-01-22 18:22:52.000000000","message":"Patch Set 1: I would prefer that you didn\u0027t merge this\n\nI would like to see a testcase for this if possible","accounts_in_message":[],"_revision_number":1},{"id":"3d31ff52feeef5d59e38fb73017bbd34a728d3bf","author":{"_account_id":2166,"name":"SmokeStack CI","username":"smokestack","tags":["SERVICE_USER"]},"date":"2013-01-22 18:39:20.000000000","message":"Patch Set 1: Works for me\n\nSmokeStack Results (patch set 1):\n\tLibvirt (Fedora 17) Success: http://smokestack.openstack.org/?go\u003d/jobs/66247\n\tXenServer 5.6 (F17 domU) Success: http://smokestack.openstack.org/?go\u003d/jobs/66248\n","accounts_in_message":[],"_revision_number":1},{"id":"802302a8f08081d069f1c2d6c8792e7a8c0301fa","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2013-01-22 18:48:12.000000000","message":"Patch Set 1: Doesn\u0027t seem to work\n\nBuild failed.  For information on how to proceed, see http://wiki.openstack.org/GerritJenkinsGithub#Test_Failures\n\n- http://logs.openstack.org/20262/1/check/gate-nova-docs/12957 : SUCCESS\n- http://logs.openstack.org/20262/1/check/gate-nova-pep8/18263 : FAILURE\n- http://logs.openstack.org/20262/1/check/gate-nova-python26/14421 : SUCCESS\n- http://logs.openstack.org/20262/1/check/gate-nova-python27/14471 : SUCCESS\n- http://logs.openstack.org/20262/1/check/gate-tempest-devstack-vm/27821 : SUCCESS\n- http://logs.openstack.org/20262/1/check/gate-tempest-devstack-vm-quantum/2194 : SUCCESS\n- http://logs.openstack.org/20262/1/check/gate-nova-pylint/6759 : SUCCESS (non-voting)\n","accounts_in_message":[],"_revision_number":1},{"id":"4690d6fece0ba3002bc48836773a607a0726de88","author":{"_account_id":5209,"name":"Ed Bak","email":"ed.bak2@hpe.com","username":"ed-bak2"},"date":"2013-01-24 22:30:07.000000000","message":"Uploaded patch set 2.","accounts_in_message":[],"_revision_number":2},{"id":"b262d22fbfd5a3c4d0c9931567dfd91ef0065098","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2013-01-24 22:52:53.000000000","message":"Patch Set 2: Works for me\n\nBuild succeeded.\n\n- http://logs.openstack.org/20262/2/check/gate-nova-docs/13176 : SUCCESS\n- http://logs.openstack.org/20262/2/check/gate-nova-pep8/18482 : SUCCESS\n- http://logs.openstack.org/20262/2/check/gate-nova-python26/14640 : SUCCESS\n- http://logs.openstack.org/20262/2/check/gate-nova-python27/14690 : SUCCESS\n- http://logs.openstack.org/20262/2/check/gate-tempest-devstack-vm/28225 : SUCCESS\n- http://logs.openstack.org/20262/2/check/gate-tempest-devstack-vm-quantum/2727 : SUCCESS\n- http://logs.openstack.org/20262/2/check/gate-nova-pylint/6922 : SUCCESS (non-voting)\n","accounts_in_message":[],"_revision_number":2},{"id":"ee3855091ed3262028e37671d6b026e8e33f0248","author":{"_account_id":2166,"name":"SmokeStack CI","username":"smokestack","tags":["SERVICE_USER"]},"date":"2013-01-24 23:15:59.000000000","message":"Patch Set 2: Works for me\n\nSmokeStack Results (patch set 2):\n\tLibvirt (Fedora 17) Success: http://smokestack.openstack.org/?go\u003d/jobs/66977\n\tXenServer 5.6 (F17 domU) Success: http://smokestack.openstack.org/?go\u003d/jobs/66978\n","accounts_in_message":[],"_revision_number":2},{"id":"ec6520ad632eba48373ba65e38d41dc00e7d4aaf","author":{"_account_id":5174,"name":"Mauro Sergio Martins Rodrigues","email":"maurosr@linux.vnet.ibm.com","username":"maurosr"},"date":"2013-01-25 03:27:48.000000000","message":"Patch Set 2: Looks good to me, but someone else must approve\n\n","accounts_in_message":[],"_revision_number":2},{"id":"ea2d69b67869c9927e710c95e55c8abbe02b6d16","author":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"date":"2013-01-31 18:11:53.000000000","message":"Patch Set 2: I would prefer that you didn\u0027t merge this\n\n(2 inline comments)\n\nA couple minor things inline.","accounts_in_message":[],"_revision_number":2},{"id":"8768a224a3524d623006aaf9c719b0b7de15d708","author":{"_account_id":5209,"name":"Ed Bak","email":"ed.bak2@hpe.com","username":"ed-bak2"},"date":"2013-01-31 18:30:43.000000000","message":"Uploaded patch set 3.","accounts_in_message":[],"_revision_number":3},{"id":"8c485cab53245091065d6ca30335d171b2e9ec8e","author":{"_account_id":2166,"name":"SmokeStack CI","username":"smokestack","tags":["SERVICE_USER"]},"date":"2013-01-31 18:54:22.000000000","message":"Patch Set 3: Works for me\n\nSmokeStack Results (patch set 3):\n\tLibvirt (Fedora 17) Success: http://smokestack.openstack.org/?go\u003d/jobs/68619\n\tXenServer 5.6 (F17 domU) Success: http://smokestack.openstack.org/?go\u003d/jobs/68620\n","accounts_in_message":[],"_revision_number":3},{"id":"402a5c8c7e875443ed237049e721dafc6d0e2cb5","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2013-01-31 18:59:55.000000000","message":"Patch Set 3: Doesn\u0027t seem to work\n\nBuild failed.  For information on how to proceed, see http://wiki.openstack.org/GerritJenkinsGithub#Test_Failures\n\n- http://logs.openstack.org/20262/3/check/gate-nova-docs/13747 : SUCCESS\n- http://logs.openstack.org/20262/3/check/gate-nova-pep8/19053 : SUCCESS\n- http://logs.openstack.org/20262/3/check/gate-nova-python26/15198 : SUCCESS\n- http://logs.openstack.org/20262/3/check/gate-nova-python27/15255 : SUCCESS\n- http://logs.openstack.org/20262/3/check/gate-tempest-devstack-vm/29300 : SUCCESS\n- http://logs.openstack.org/20262/3/check/gate-tempest-devstack-vm-quantum/4010 : FAILURE\n- http://logs.openstack.org/20262/3/check/gate-nova-pylint/7339 : SUCCESS (non-voting)\n","accounts_in_message":[],"_revision_number":3},{"id":"c42823e220c8637e170c5c5d9a62e0ee9917352b","author":{"_account_id":2750,"name":"Sean Dague","email":"sean@dague.net","username":"sdague"},"date":"2013-02-05 00:51:12.000000000","message":"Patch Set 3: I would prefer that you didn\u0027t merge this\n\nIt\u0027s really unclear to me that we want this as an external plug point with a contract. I think the general approach is to not do that unless the team is really confident in the extension point.\n\nI don\u0027t think libvirt internal filter layer counts as that. If there is another filter type you\u0027d like included in upstream, please submit that.","accounts_in_message":[],"_revision_number":3},{"id":"d947c14f520d8f6f65398e4a4a5fe6f54f4ce5e6","author":{"_account_id":1501,"name":"Phil Day","email":"philip.day@hp.com","username":"philip-day"},"date":"2013-02-06 12:40:53.000000000","message":"Patch Set 3:\n\nHi Sean,\n\nNot really sure that I follow your comment - Ed did post the description of this initially to openstack.dev and got approval from Vish for the approach.  \n\nGiven that the use case here is to filter traffic from specific instances (for example to allow only certain instances access to a license key server) its hard to see where else in the code you could do this. \n\nAny such filters are likely to be quite service provider specific, so hard to see the filters themselves being a good candidate for the core product.","accounts_in_message":[],"_revision_number":3},{"id":"6836d55051db5482f3676fde7d3acb9d19aeeb9a","author":{"_account_id":1779,"name":"Daniel Berrange","email":"berrange@redhat.com","username":"berrange"},"date":"2013-02-06 12:47:58.000000000","message":"Patch Set 3: I would prefer that you didn\u0027t merge this\n\nI don\u0027t think think this is the right way to go about this. If the config parameter was merely a list of libvirt nwfilter names, then I can see the value in the new config parameter.\n\nThis proposed config parameter though, requires the user to create new python classes.  This is just inventing a 2nd way to do something that is already possible. If people are going to be required to write code to create custom filters, then they can just use the existing \"firewall_driver\" config parameter to plug in their custom code. So I don\u0027t really see any need for this new config parameter.","accounts_in_message":[],"_revision_number":3},{"id":"e048afb5ec18d17e887c47517c4315d595c5b11b","author":{"_account_id":1779,"name":"Daniel Berrange","email":"berrange@redhat.com","username":"berrange"},"date":"2013-02-06 13:40:09.000000000","message":"Patch Set 3:\n\nWhat would help people wishing to subclass is to re-factor the existing libvirt firewall.py driver a little bit. eg move the list of default separate (easily custommizable) method\n\n  def get_base_filter_list(instance):\n        if pipelib.is_vpn_image(instance[\u0027image_ref\u0027]):\n            base_filter \u003d \u0027nova-vpn\u0027\n        elif allow_dhcp:\n            base_filter \u003d \u0027nova-base\u0027\n        else:\n            base_filter \u003d \u0027nova-nodhcp\u0027\n        return [base_filter]\n\nThen people only need subclass the driver, this is base class \u0026 then add in their own extra filters","accounts_in_message":[],"_revision_number":3},{"id":"e36c5f12b7182644fbd754e29c6055390eb4b13a","author":{"_account_id":5209,"name":"Ed Bak","email":"ed.bak2@hpe.com","username":"ed-bak2"},"date":"2013-02-07 17:03:37.000000000","message":"Uploaded patch set 4.","accounts_in_message":[],"_revision_number":4},{"id":"b11ff962ba6d49d5e916302fb4b902fec51cd544","author":{"_account_id":1779,"name":"Daniel Berrange","email":"berrange@redhat.com","username":"berrange"},"date":"2013-02-07 17:16:38.000000000","message":"Patch Set 4: (2 inline comments)\n\nThanks for changing this - I think this approach is much nicer.","accounts_in_message":[],"_revision_number":4},{"id":"5caa5ec195d60a94c68041b5e86ddedf4a1367aa","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2013-02-07 18:43:14.000000000","message":"Patch Set 4: Works for me\n\nBuild succeeded.\n\n- http://logs.openstack.org/20262/4/check/gate-nova-docs/14361 : SUCCESS\n- http://logs.openstack.org/20262/4/check/gate-nova-pep8/19665 : SUCCESS\n- http://logs.openstack.org/20262/4/check/gate-nova-python26/15809 : SUCCESS\n- http://logs.openstack.org/20262/4/check/gate-nova-python27/15868 : SUCCESS\n- http://logs.openstack.org/20262/4/check/gate-tempest-devstack-vm-full/1453 : SUCCESS\n- http://logs.openstack.org/20262/4/check/gate-tempest-devstack-vm-postgres-full/1179 : SUCCESS\n- http://logs.openstack.org/20262/4/check/gate-tempest-devstack-vm-quantum/5483 : SUCCESS\n- http://logs.openstack.org/20262/4/check/gate-nova-pylint/7793 : SUCCESS (non-voting)\n","accounts_in_message":[],"_revision_number":4},{"id":"b1e19412d9871f6e32ffbee6f7bc65b3c2e64ded","author":{"_account_id":5209,"name":"Ed Bak","email":"ed.bak2@hpe.com","username":"ed-bak2"},"date":"2013-02-07 20:03:46.000000000","message":"Uploaded patch set 5.","accounts_in_message":[],"_revision_number":5},{"id":"ecd0300ff8606d2d168bfb0eda77419c433aff8e","author":{"_account_id":1779,"name":"Daniel Berrange","email":"berrange@redhat.com","username":"berrange"},"date":"2013-02-07 21:02:37.000000000","message":"Patch Set 5: Looks good to me, but someone else must approve\n\n","accounts_in_message":[],"_revision_number":5},{"id":"a3b157add13788b6f620b8f8ed72a8b52fea3da3","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2013-02-07 21:10:14.000000000","message":"Patch Set 5: Works for me\n\nBuild succeeded.\n\n- http://logs.openstack.org/20262/5/check/gate-nova-docs/14402 : SUCCESS\n- http://logs.openstack.org/20262/5/check/gate-nova-pep8/19706 : SUCCESS\n- http://logs.openstack.org/20262/5/check/gate-nova-python26/15850 : SUCCESS\n- http://logs.openstack.org/20262/5/check/gate-nova-python27/15909 : SUCCESS\n- http://logs.openstack.org/20262/5/check/gate-tempest-devstack-vm-full/1518 : SUCCESS\n- http://logs.openstack.org/20262/5/check/gate-tempest-devstack-vm-postgres-full/1244 : SUCCESS\n- http://logs.openstack.org/20262/5/check/gate-tempest-devstack-vm-quantum/5555 : SUCCESS\n- http://logs.openstack.org/20262/5/check/gate-nova-pylint/7820 : SUCCESS (non-voting)\n","accounts_in_message":[],"_revision_number":5},{"id":"c1e50af50c2a9acde26c09ca1581952c7c3af1b7","author":{"_account_id":2166,"name":"SmokeStack CI","username":"smokestack","tags":["SERVICE_USER"]},"date":"2013-02-07 23:49:50.000000000","message":"Patch Set 5: Works for me\n\nSmokeStack Results (patch set 5):\n\tLibvirt (Fedora 17) Success: http://smokestack.openstack.org/?go\u003d/jobs/70323\n\tXenServer 5.6 (F17 domU) Success: http://smokestack.openstack.org/?go\u003d/jobs/70324\n","accounts_in_message":[],"_revision_number":5},{"id":"ec828d17c2569703429d5acac1a68be86cb4cd44","author":{"_account_id":2750,"name":"Sean Dague","email":"sean@dague.net","username":"sdague"},"date":"2013-02-09 23:59:33.000000000","message":"Patch Set 5: Looks good to me (core reviewer)\n\n","accounts_in_message":[],"_revision_number":5},{"id":"b7f9d979902c5b527f59bfd1416a11d230ead65c","author":{"_account_id":5292,"name":"Christopher Yeoh","email":"cbkyeoh@gmail.com","username":"cyeoh-0"},"date":"2013-02-10 01:16:12.000000000","message":"Patch Set 5: Looks good to me, but someone else must approve\n\n","accounts_in_message":[],"_revision_number":5},{"id":"642be38c279b94b85de3468cd35a45c6f0612b16","author":{"_account_id":1561,"name":"Russell Bryant","email":"rbryant@redhat.com","username":"russellb"},"date":"2013-02-10 14:10:54.000000000","message":"Patch Set 5: Looks good to me (core reviewer); Approved\n\n","accounts_in_message":[],"_revision_number":5},{"id":"532b5d04e06ec0edc8764e1225a79ca3992bf716","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2013-02-10 14:10:55.000000000","message":"Patch Set 5: No score\n\nStarting gate jobs.\nhttp://status.openstack.org/zuul/","accounts_in_message":[],"_revision_number":5},{"id":"9c565ef36b5e58e204da5bcb5b266c2d305dedf0","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2013-02-10 16:55:50.000000000","message":"Patch Set 5: Verified\n\nBuild succeeded.\n\n- http://logs.openstack.org/20262/5/gate/gate-nova-docs/14561 : SUCCESS\n- http://logs.openstack.org/20262/5/gate/gate-nova-pep8/19865 : SUCCESS\n- http://logs.openstack.org/20262/5/gate/gate-nova-python26/16009 : SUCCESS\n- http://logs.openstack.org/20262/5/gate/gate-nova-python27/16068 : SUCCESS\n- http://logs.openstack.org/20262/5/gate/gate-tempest-devstack-vm-full/1893 : SUCCESS\n- http://logs.openstack.org/20262/5/gate/gate-tempest-devstack-vm-postgres-full/1619 : SUCCESS\n- http://logs.openstack.org/20262/5/gate/gate-tempest-devstack-vm-quantum/5992 : SUCCESS\n","accounts_in_message":[],"_revision_number":5},{"id":"eb2997a8217d3e7da092005eef325f30a4fb20cb","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2013-02-10 16:55:52.000000000","message":"Change has been successfully merged into the git repository.","accounts_in_message":[],"_revision_number":5}],"current_revision_number":5,"current_revision":"beb9292eb13f357d9ff321f1eb7e6a49e7704d14","revisions":{"fce0064105c739a7ed39f2689d76561de5620132":{"kind":"REWORK","_number":1,"created":"2013-01-22 18:14:41.000000000","uploader":{"_account_id":5209,"name":"Ed Bak","email":"ed.bak2@hpe.com","username":"ed-bak2"},"ref":"refs/changes/62/20262/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/nova","ref":"refs/changes/62/20262/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/nova refs/changes/62/20262/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/nova refs/changes/62/20262/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/nova refs/changes/62/20262/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/nova refs/changes/62/20262/1"}}},"commit":{"parents":[{"commit":"2a284ea97b4c778e15916a7544395cafa761ec89","subject":"Merge \"fix floating ip test that wasn\u0027t running\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/nova/commit/2a284ea97b4c778e15916a7544395cafa761ec89"}]}],"author":{"name":"Ed Bak","email":"ed.bak2@hp.com","date":"2013-01-22 17:50:24.000000000","tz":0},"committer":{"name":"Ed Bak","email":"ed.bak2@hp.com","date":"2013-01-22 17:50:24.000000000","tz":0},"subject":"Change to support custom nw filters.","message":"Change to support custom nw filters.\n\nThis change adds a mechanism to provide additional nw filters per\ninstance which can be dynamically added using nova.conf.  Each\ncustom filter must provide three functions:\nget_filter() returns the xml definition of the nw filter\nget_filter_name() returns the string name of the filter\napply_filter(instance) returns true/false indicating whether the\n    filter should be applied to the given instance\n\nThe implementation of the custom filters can be defined as needed\nas long as the three above required functions are provided.\n\nThe filters can then be added by specifying them in a list using\nnova.conf.  For example...\n\ncustom_nwfilters \u003d nova.virt.libvirt.my_filter1\n\nChange-Id: Ida94148fcb870830ae675839ab4f900ad798d9bb\nFixes: bug #1103086\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/nova/commit/fce0064105c739a7ed39f2689d76561de5620132"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/nova/commit/fce0064105c739a7ed39f2689d76561de5620132"}]},"parents_data":[{"branch_name":"refs/heads/master","commit_id":"2a284ea97b4c778e15916a7544395cafa761ec89","is_merged_in_target_branch":true}],"branch":"refs/heads/master"},"9b3178a027b52e2a398c79db21be053a7ef96972":{"kind":"REWORK","_number":2,"created":"2013-01-24 22:30:07.000000000","uploader":{"_account_id":5209,"name":"Ed Bak","email":"ed.bak2@hpe.com","username":"ed-bak2"},"ref":"refs/changes/62/20262/2","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/nova","ref":"refs/changes/62/20262/2","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/nova refs/changes/62/20262/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/nova refs/changes/62/20262/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/nova refs/changes/62/20262/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/nova refs/changes/62/20262/2"}}},"commit":{"parents":[{"commit":"2a284ea97b4c778e15916a7544395cafa761ec89","subject":"Merge \"fix floating ip test that wasn\u0027t running\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/nova/commit/2a284ea97b4c778e15916a7544395cafa761ec89"}]}],"author":{"name":"Ed Bak","email":"ed.bak2@hp.com","date":"2013-01-22 17:50:24.000000000","tz":0},"committer":{"name":"Ed Bak","email":"ed.bak2@hp.com","date":"2013-01-24 22:24:04.000000000","tz":0},"subject":"Change to support custom nw filters.","message":"Change to support custom nw filters.\n\nThis change adds a mechanism to provide additional nw filters per\ninstance which can be dynamically added using nova.conf.  Each\ncustom filter must provide three functions:\nget_filter() returns the xml definition of the nw filter\nget_filter_name() returns the string name of the filter\napply_filter(instance) returns true/false indicating whether the\n    filter should be applied to the given instance\n\nThe implementation of the custom filters can be defined as needed\nas long as the three above required functions are provided.\n\nThe filters can then be added by specifying them in a list using\nnova.conf.  For example...\n\ncustom_nwfilters \u003d nova.virt.libvirt.my_filter1\n\nAlso added test_custom_nwfilter to test_libvirt.py to\nexercise this functionality and to provide an example of\nits usage.\n\nChange-Id: Ida94148fcb870830ae675839ab4f900ad798d9bb\nFixes: bug #1103086\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/nova/commit/9b3178a027b52e2a398c79db21be053a7ef96972"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/nova/commit/9b3178a027b52e2a398c79db21be053a7ef96972"}]},"parents_data":[{"branch_name":"refs/heads/master","commit_id":"2a284ea97b4c778e15916a7544395cafa761ec89","is_merged_in_target_branch":true}],"branch":"refs/heads/master"},"d3e3d3b7a51d5b46c5271e79d40bfb514f1df70b":{"kind":"REWORK","_number":3,"created":"2013-01-31 18:30:43.000000000","uploader":{"_account_id":5209,"name":"Ed Bak","email":"ed.bak2@hpe.com","username":"ed-bak2"},"ref":"refs/changes/62/20262/3","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/nova","ref":"refs/changes/62/20262/3","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/nova refs/changes/62/20262/3 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/nova refs/changes/62/20262/3 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/nova refs/changes/62/20262/3 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/nova refs/changes/62/20262/3"}}},"commit":{"parents":[{"commit":"2a284ea97b4c778e15916a7544395cafa761ec89","subject":"Merge \"fix floating ip test that wasn\u0027t running\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/nova/commit/2a284ea97b4c778e15916a7544395cafa761ec89"}]}],"author":{"name":"Ed Bak","email":"ed.bak2@hp.com","date":"2013-01-22 17:50:24.000000000","tz":0},"committer":{"name":"Ed Bak","email":"ed.bak2@hp.com","date":"2013-01-31 18:26:02.000000000","tz":0},"subject":"Change to support custom nw filters.","message":"Change to support custom nw filters.\n\nThis change adds a mechanism to provide additional nw filters per\ninstance which can be dynamically added using nova.conf.  Each\ncustom filter must provide three functions:\nget_filter() returns the xml definition of the nw filter\nget_filter_name() returns the string name of the filter\napply_filter(instance) returns true/false indicating whether the\n    filter should be applied to the given instance\n\nThe implementation of the custom filters can be defined as needed\nas long as the three above required functions are provided.\n\nThe filters can then be added by specifying them in a list using\nnova.conf.  For example...\n\ncustom_nwfilters \u003d nova.virt.libvirt.my_filter1\n\nAlso added test_custom_nwfilter to test_libvirt.py to\nexercise this functionality and to provide an example of\nits usage.\n\nChange-Id: Ida94148fcb870830ae675839ab4f900ad798d9bb\nFixes: bug #1103086\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/nova/commit/d3e3d3b7a51d5b46c5271e79d40bfb514f1df70b"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/nova/commit/d3e3d3b7a51d5b46c5271e79d40bfb514f1df70b"}]},"parents_data":[{"branch_name":"refs/heads/master","commit_id":"2a284ea97b4c778e15916a7544395cafa761ec89","is_merged_in_target_branch":true}],"branch":"refs/heads/master"},"80661b8b606b947ea7ec045985465b8d5fd68837":{"kind":"REWORK","_number":4,"created":"2013-02-07 17:03:37.000000000","uploader":{"_account_id":5209,"name":"Ed Bak","email":"ed.bak2@hpe.com","username":"ed-bak2"},"ref":"refs/changes/62/20262/4","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/nova","ref":"refs/changes/62/20262/4","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/nova refs/changes/62/20262/4 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/nova refs/changes/62/20262/4 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/nova refs/changes/62/20262/4 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/nova refs/changes/62/20262/4"}}},"commit":{"parents":[{"commit":"2a284ea97b4c778e15916a7544395cafa761ec89","subject":"Merge \"fix floating ip test that wasn\u0027t running\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/nova/commit/2a284ea97b4c778e15916a7544395cafa761ec89"}]}],"author":{"name":"Ed Bak","email":"ed.bak2@hp.com","date":"2013-01-22 17:50:24.000000000","tz":0},"committer":{"name":"Ed Bak","email":"ed.bak2@hp.com","date":"2013-02-07 16:53:09.000000000","tz":0},"subject":"Change to support custom nw filters.","message":"Change to support custom nw filters.\n\nThis change is a refactoring of NWFilterFirewall to\ncreate a distinct function to define base nw filters.\nThe new function is called get_base_filter_list.  This\nprovides a convenient way to subclass NWFilterFirewall\nand redefine get_base_filter_list to add your own custom\nbase filters.\n\nChange-Id: Ida94148fcb870830ae675839ab4f900ad798d9bb\nFixes: bug #1103086\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/nova/commit/80661b8b606b947ea7ec045985465b8d5fd68837"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/nova/commit/80661b8b606b947ea7ec045985465b8d5fd68837"}]},"parents_data":[{"branch_name":"refs/heads/master","commit_id":"2a284ea97b4c778e15916a7544395cafa761ec89","is_merged_in_target_branch":true}],"branch":"refs/heads/master"},"beb9292eb13f357d9ff321f1eb7e6a49e7704d14":{"kind":"REWORK","_number":5,"created":"2013-02-07 20:03:46.000000000","uploader":{"_account_id":5209,"name":"Ed Bak","email":"ed.bak2@hpe.com","username":"ed-bak2"},"ref":"refs/changes/62/20262/5","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/nova","ref":"refs/changes/62/20262/5","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/nova refs/changes/62/20262/5 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/nova refs/changes/62/20262/5 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/nova refs/changes/62/20262/5 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/nova refs/changes/62/20262/5"}}},"commit":{"parents":[{"commit":"2a284ea97b4c778e15916a7544395cafa761ec89","subject":"Merge \"fix floating ip test that wasn\u0027t running\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/nova/commit/2a284ea97b4c778e15916a7544395cafa761ec89"}]}],"author":{"name":"Ed Bak","email":"ed.bak2@hp.com","date":"2013-01-22 17:50:24.000000000","tz":0},"committer":{"name":"Ed Bak","email":"ed.bak2@hp.com","date":"2013-02-07 19:59:05.000000000","tz":0},"subject":"Change to support custom nw filters.","message":"Change to support custom nw filters.\n\nThis change is a refactoring of NWFilterFirewall to\ncreate a distinct function to define base nw filters.\nThe new function is called get_base_filter_list.  This\nprovides a convenient way to subclass NWFilterFirewall\nand redefine get_base_filter_list to add your own custom\nbase filters.\n\nChange-Id: Ida94148fcb870830ae675839ab4f900ad798d9bb\nFixes: bug #1103086\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/nova/commit/beb9292eb13f357d9ff321f1eb7e6a49e7704d14"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/nova/commit/beb9292eb13f357d9ff321f1eb7e6a49e7704d14"}]},"parents_data":[{"branch_name":"refs/heads/master","commit_id":"2a284ea97b4c778e15916a7544395cafa761ec89","is_merged_in_target_branch":true}],"branch":"refs/heads/master"}},"requirements":[],"submit_records":[],"submit_requirements":[]}