)]}'
{"nova/compute/monitors/base.py":[{"author":{"_account_id":7,"name":"Jay Pipes","email":"jaypipes@gmail.com","username":"jaypipes"},"change_message_id":"bd0e113bf4124e9ce3bfe44f68f4fe1946cd0bf8","unresolved":false,"context_lines":[{"line_number":89,"context_line":"        return set(["},{"line_number":90,"context_line":"            fields.MonitorMetricType.MEM_BW_CURRENT,"},{"line_number":91,"context_line":"            fields.MonitorMetricType.MEM_BW_MAX,"},{"line_number":92,"context_line":"        ])"}],"source_content_type":"text/x-python","patch_set":1,"id":"3a50d1a3_61c73b96","line":92,"updated":"2015-07-23 16:55:14.000000000","message":"Please add this piece in a followup patch that adds the first concrete implementation class for a memory bandwidth monitor.","commit_id":"f01fee0712e070affb14de91d3ecd0f4ea2eedc3"}],"nova/virt/driver.py":[{"author":{"_account_id":7,"name":"Jay Pipes","email":"jaypipes@gmail.com","username":"jaypipes"},"change_message_id":"bd0e113bf4124e9ce3bfe44f68f4fe1946cd0bf8","unresolved":false,"context_lines":[{"line_number":1112,"context_line":"            \u0027max\u0027: \u003cMAX_BW\u003e,"},{"line_number":1113,"context_line":"             },"},{"line_number":1114,"context_line":"            \u00271\u0027: {"},{"line_number":1115,"context_line":"            \u0027max\u0027: \u003cMAX_BW\u003e,"},{"line_number":1116,"context_line":"             },"},{"line_number":1117,"context_line":"             ..."},{"line_number":1118,"context_line":"             }"}],"source_content_type":"text/x-python","patch_set":1,"id":"3a50d1a3_614e5b3c","line":1115,"updated":"2015-07-23 16:55:14.000000000","message":"Please indent the nested dicts above for easier readability...","commit_id":"f01fee0712e070affb14de91d3ecd0f4ea2eedc3"},{"author":{"_account_id":7,"name":"Jay Pipes","email":"jaypipes@gmail.com","username":"jaypipes"},"change_message_id":"bd0e113bf4124e9ce3bfe44f68f4fe1946cd0bf8","unresolved":false,"context_lines":[{"line_number":1119,"context_line":"             }"},{"line_number":1120,"context_line":"             }"},{"line_number":1121,"context_line":"             }"},{"line_number":1122,"context_line":"             Here the memory bandwidth is expected for each NUMA node."},{"line_number":1123,"context_line":""},{"line_number":1124,"context_line":"        \"\"\""},{"line_number":1125,"context_line":"        raise NotImplementedError()"}],"source_content_type":"text/x-python","patch_set":1,"id":"3a50d1a3_216b7386","line":1122,"updated":"2015-07-23 16:55:14.000000000","message":"I don\u0027t think this last line of the docstring is useful... :)","commit_id":"f01fee0712e070affb14de91d3ecd0f4ea2eedc3"},{"author":{"_account_id":7,"name":"Jay Pipes","email":"jaypipes@gmail.com","username":"jaypipes"},"change_message_id":"bd0e113bf4124e9ce3bfe44f68f4fe1946cd0bf8","unresolved":false,"context_lines":[{"line_number":1150,"context_line":"             }"},{"line_number":1151,"context_line":"             }"},{"line_number":1152,"context_line":"             }"},{"line_number":1153,"context_line":"             Here the memory count is expected for each NUMA node."},{"line_number":1154,"context_line":""},{"line_number":1155,"context_line":"        \"\"\""},{"line_number":1156,"context_line":"        raise NotImplementedError()"}],"source_content_type":"text/x-python","patch_set":1,"id":"3a50d1a3_e107cbc7","line":1153,"updated":"2015-07-23 16:55:14.000000000","message":"Ditto comments from above.","commit_id":"f01fee0712e070affb14de91d3ecd0f4ea2eedc3"},{"author":{"_account_id":1779,"name":"Daniel Berrange","email":"berrange@redhat.com","username":"berrange"},"change_message_id":"d9ab693cd75b5fa32c7ff81b6c322fd6ff2cbb98","unresolved":false,"context_lines":[{"line_number":1102,"context_line":"        This method is expected to be called only once during"},{"line_number":1103,"context_line":"        the lifecycle of the compute process."},{"line_number":1104,"context_line":""},{"line_number":1105,"context_line":"        :returns: a dict containing memory bandwidth information:"},{"line_number":1106,"context_line":""},{"line_number":1107,"context_line":"        {"},{"line_number":1108,"context_line":"           \u0027memory\u0027:{"}],"source_content_type":"text/x-python","patch_set":3,"id":"3a50d1a3_c99a9f62","line":1105,"updated":"2015-07-31 12:39:28.000000000","message":"Please lets not add yet more methods which return massive nested dicts. We should have either Nova versioned objects, or at least a regular python class, to define structure data","commit_id":"f8dd6c2ded4ca5c2eeeed502a317ec96fa2c2c39"}]}