)]}'
{"nova/context.py":[{"author":{"_account_id":1561,"name":"Russell Bryant","email":"rbryant@redhat.com","username":"russellb"},"change_message_id":"0043f6c0f86d4d4ab64fda10b05f6665fff6c6a4","unresolved":false,"context_lines":[{"line_number":84,"context_line":"            self.service_catalog \u003d service_catalog"},{"line_number":85,"context_line":"        else:"},{"line_number":86,"context_line":"            self.service_catalog \u003d [s for s in service_catalog"},{"line_number":87,"context_line":"                    if s.get(\u0027name\u0027) in (\u0027cinder\u0027)]"},{"line_number":88,"context_line":"        self.instance_lock_checked \u003d instance_lock_checked"},{"line_number":89,"context_line":""},{"line_number":90,"context_line":"        # NOTE(markmc): this attribute is currently only used by the"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAM3%2F%2FbNI%3D","line":87,"updated":"2013-01-23 00:53:36.000000000","message":"I wonder if it would be more \"correct\" to check for \u0027type\u0027 being \u0027volume\u0027 here?","commit_id":"fbd67134d1716c645d8c8daac36e378ee2cf2056"},{"author":{"_account_id":1561,"name":"Russell Bryant","email":"rbryant@redhat.com","username":"russellb"},"change_message_id":"6ddca4750a4400a69908d54f8edc1fa8be822dae","unresolved":false,"context_lines":[{"line_number":84,"context_line":"            self.service_catalog \u003d service_catalog"},{"line_number":85,"context_line":"        else:"},{"line_number":86,"context_line":"            self.service_catalog \u003d [s for s in service_catalog"},{"line_number":87,"context_line":"                    if s.get(\u0027type\u0027) in (\u0027volume\u0027)]"},{"line_number":88,"context_line":"        self.instance_lock_checked \u003d instance_lock_checked"},{"line_number":89,"context_line":""},{"line_number":90,"context_line":"        # NOTE(markmc): this attribute is currently only used by the"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAAM3%2F%2FWhI%3D","line":87,"updated":"2013-01-25 22:53:12.000000000","message":"This part seems kinda odd:\n\n    if service_catalog is None:\n        self.service_catalog \u003d service_catalog\n\nCould simplify by setting the default for the service_catalog kwarg to [] and only have the list comprehension.","commit_id":"527dcee3c3465ea38bb2342be884154c59d0b64c"}],"nova/volume/cinder.py":[{"author":{"_account_id":1561,"name":"Russell Bryant","email":"rbryant@redhat.com","username":"russellb"},"change_message_id":"0043f6c0f86d4d4ab64fda10b05f6665fff6c6a4","unresolved":false,"context_lines":[{"line_number":63,"context_line":"    # Only needed parts of the service catalog are passed in, see"},{"line_number":64,"context_line":"    # nova/context.py."},{"line_number":65,"context_line":"    compat_catalog \u003d {"},{"line_number":66,"context_line":"        \u0027access\u0027: {\u0027serviceCatalog\u0027: context.service_catalog or {}}"},{"line_number":67,"context_line":"    }"},{"line_number":68,"context_line":"    sc \u003d service_catalog.ServiceCatalog(compat_catalog)"},{"line_number":69,"context_line":"    if CONF.cinder_endpoint_template:"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAM3%2F%2FbNE%3D","line":66,"updated":"2013-01-23 00:53:36.000000000","message":"Your code sets context.service_catalog as a list, but the default value here is a dict.  Which type is correct?","commit_id":"fbd67134d1716c645d8c8daac36e378ee2cf2056"},{"author":{"_account_id":1849,"name":"Joe Gordon","email":"joe.gordon0@gmail.com","username":"jogo"},"change_message_id":"20844a2012fd880861fb23de83eddff3886bf599","unresolved":false,"context_lines":[{"line_number":63,"context_line":"    # Only needed parts of the service catalog are passed in, see"},{"line_number":64,"context_line":"    # nova/context.py."},{"line_number":65,"context_line":"    compat_catalog \u003d {"},{"line_number":66,"context_line":"        \u0027access\u0027: {\u0027serviceCatalog\u0027: context.service_catalog or {}}"},{"line_number":67,"context_line":"    }"},{"line_number":68,"context_line":"    sc \u003d service_catalog.ServiceCatalog(compat_catalog)"},{"line_number":69,"context_line":"    if CONF.cinder_endpoint_template:"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAM3%2F%2FaZk%3D","line":66,"in_reply_to":"AAAAM3%2F%2FbNE%3D","updated":"2013-01-23 15:53:22.000000000","message":"Sample outputs (http://logs.openstack.org/periodic/periodic-tempest-devstack-vm-check-hourly/1677/logs/screen-n-cond.txt) show its a list","commit_id":"fbd67134d1716c645d8c8daac36e378ee2cf2056"}]}