)]}'
{"nova/scheduler/filters/numa_topology_filter.py":[{"author":{"_account_id":7166,"name":"Sylvain Bauza","email":"sbauza@redhat.com","username":"sbauza"},"change_message_id":"16a088210cadd68e18d6088a1dd92b095a332039","unresolved":false,"context_lines":[{"line_number":85,"context_line":"            if not instance_topology:"},{"line_number":86,"context_line":"                LOG.debug(\"%(host_state)s fails NUMA topology requirements. \""},{"line_number":87,"context_line":"                          \"It is not possible to fit the instance on this \""},{"line_number":88,"context_line":"                          \"host\", {\u0027host_state\u0027: host_state})"},{"line_number":89,"context_line":"                return False"},{"line_number":90,"context_line":"            host_state.limits[\u0027numa_topology\u0027] \u003d limits"},{"line_number":91,"context_line":"            return True"}],"source_content_type":"text/x-python","patch_set":6,"id":"3a50d1a3_ca1638f1","line":88,"updated":"2015-07-24 14:13:26.000000000","message":"instead of using the str() method for the HostState, could you please just give the (host, node) tuple ?\n\nAlso, I don\u0027t think it\u0027s necessary to mention the second sentence here.","commit_id":"2841c7453c7aa61daf4a0f5a95248faf7eb6201b"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"732095cc920a74652d91769dcdadbcaf212fa6d2","unresolved":false,"context_lines":[{"line_number":85,"context_line":"            if not instance_topology:"},{"line_number":86,"context_line":"                LOG.debug(\"%(host_state)s fails NUMA topology requirements. \""},{"line_number":87,"context_line":"                          \"It is not possible to fit the instance on this \""},{"line_number":88,"context_line":"                          \"host\", {\u0027host_state\u0027: host_state})"},{"line_number":89,"context_line":"                return False"},{"line_number":90,"context_line":"            host_state.limits[\u0027numa_topology\u0027] \u003d limits"},{"line_number":91,"context_line":"            return True"}],"source_content_type":"text/x-python","patch_set":6,"id":"3a50d1a3_ddafe029","line":88,"in_reply_to":"3a50d1a3_ca1638f1","updated":"2015-07-24 14:30:51.000000000","message":"Agree on first count. Done.\n\nI think the second sentence helps to give a good reason for why it failed NUMA topology requirements (there are theoretically many, though we only account for two). If you don\u0027t have a hard reason why it should be removed, I\u0027d like to keep it :)","commit_id":"2841c7453c7aa61daf4a0f5a95248faf7eb6201b"},{"author":{"_account_id":7166,"name":"Sylvain Bauza","email":"sbauza@redhat.com","username":"sbauza"},"change_message_id":"16a088210cadd68e18d6088a1dd92b095a332039","unresolved":false,"context_lines":[{"line_number":92,"context_line":"        elif requested_topology:"},{"line_number":93,"context_line":"            LOG.debug(\"%(host_state)s fails NUMA topology requirements. Host \""},{"line_number":94,"context_line":"                      \"has no NUMA topology but the guest specified one.\","},{"line_number":95,"context_line":"                      {\u0027host_state\u0027: host_state})"},{"line_number":96,"context_line":"            return False"},{"line_number":97,"context_line":"        else:"},{"line_number":98,"context_line":"            return True"}],"source_content_type":"text/x-python","patch_set":6,"id":"3a50d1a3_caa9587d","line":95,"updated":"2015-07-24 14:13:26.000000000","message":"same comment as above. I\u0027d also summarize it as \"No Host NUMA topology while the user specified one.\"","commit_id":"2841c7453c7aa61daf4a0f5a95248faf7eb6201b"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"732095cc920a74652d91769dcdadbcaf212fa6d2","unresolved":false,"context_lines":[{"line_number":92,"context_line":"        elif requested_topology:"},{"line_number":93,"context_line":"            LOG.debug(\"%(host_state)s fails NUMA topology requirements. Host \""},{"line_number":94,"context_line":"                      \"has no NUMA topology but the guest specified one.\","},{"line_number":95,"context_line":"                      {\u0027host_state\u0027: host_state})"},{"line_number":96,"context_line":"            return False"},{"line_number":97,"context_line":"        else:"},{"line_number":98,"context_line":"            return True"}],"source_content_type":"text/x-python","patch_set":6,"id":"3a50d1a3_5d62f017","line":95,"in_reply_to":"3a50d1a3_caa9587d","updated":"2015-07-24 14:30:51.000000000","message":"Done","commit_id":"2841c7453c7aa61daf4a0f5a95248faf7eb6201b"},{"author":{"_account_id":7166,"name":"Sylvain Bauza","email":"sbauza@redhat.com","username":"sbauza"},"change_message_id":"c38dcef5dc979a405770813a306e40f6c585a53d","unresolved":false,"context_lines":[{"line_number":84,"context_line":"                        pci_stats\u003dhost_state.pci_stats))"},{"line_number":85,"context_line":"            if not instance_topology:"},{"line_number":86,"context_line":"                LOG.debug(\"%(host)s fails NUMA topology requirements. \""},{"line_number":87,"context_line":"                          \"It is not possible to fit the instance on this \""},{"line_number":88,"context_line":"                          \"host\", {\u0027host\u0027: host_state.host})"},{"line_number":89,"context_line":"                return False"},{"line_number":90,"context_line":"            host_state.limits[\u0027numa_topology\u0027] \u003d limits"}],"source_content_type":"text/x-python","patch_set":7,"id":"3a50d1a3_76b909ec","line":87,"updated":"2015-07-24 15:18:40.000000000","message":"\"It is not possible to fit\". Well, you just said in the previous sentence that the host failed the requirement, so how could the instance be able to be fitted within the host ?","commit_id":"c036a89ec9f49a0df284fe47c57964803edd428c"},{"author":{"_account_id":7166,"name":"Sylvain Bauza","email":"sbauza@redhat.com","username":"sbauza"},"change_message_id":"c38dcef5dc979a405770813a306e40f6c585a53d","unresolved":false,"context_lines":[{"line_number":85,"context_line":"            if not instance_topology:"},{"line_number":86,"context_line":"                LOG.debug(\"%(host)s fails NUMA topology requirements. \""},{"line_number":87,"context_line":"                          \"It is not possible to fit the instance on this \""},{"line_number":88,"context_line":"                          \"host\", {\u0027host\u0027: host_state.host})"},{"line_number":89,"context_line":"                return False"},{"line_number":90,"context_line":"            host_state.limits[\u0027numa_topology\u0027] \u003d limits"},{"line_number":91,"context_line":"            return True"}],"source_content_type":"text/x-python","patch_set":7,"id":"3a50d1a3_16f685d7","line":88,"updated":"2015-07-24 15:18:40.000000000","message":"Unfortunatly, we need to carry also the nodename information because 2 compute nodes can be having the same service name.\n\nSo, please provide an (host, nodename) information.","commit_id":"c036a89ec9f49a0df284fe47c57964803edd428c"},{"author":{"_account_id":7166,"name":"Sylvain Bauza","email":"sbauza@redhat.com","username":"sbauza"},"change_message_id":"55039bc993e817ae549f8983d194f6acf29980f9","unresolved":false,"context_lines":[{"line_number":85,"context_line":"            if not instance_topology:"},{"line_number":86,"context_line":"                LOG.debug(\"%(host)s fails NUMA topology requirements. \""},{"line_number":87,"context_line":"                          \"The instance does not fit on this host.\","},{"line_number":88,"context_line":"                          {\u0027host\u0027: (host_state.host, host_state.nodename)})"},{"line_number":89,"context_line":"                return False"},{"line_number":90,"context_line":"            host_state.limits[\u0027numa_topology\u0027] \u003d limits"},{"line_number":91,"context_line":"            return True"}],"source_content_type":"text/x-python","patch_set":9,"id":"3a50d1a3_477d041b","line":88,"updated":"2015-07-27 10:30:09.000000000","message":"Well, the syntax is a bit ugly since you\u0027re stringify a tuple directly... I\u0027d rather prefer a \" %(host)s, %(node)s \" log with a dict keying host and node","commit_id":"e5ab34892866a4669dd80720aa6f55d6b789ab28"},{"author":{"_account_id":1653,"name":"garyk","email":"gkotton@vmware.com","username":"garyk"},"change_message_id":"3b474610992bfabb29b2f8305f5904615425f663","unresolved":false,"context_lines":[{"line_number":45,"context_line":"                        pci_stats\u003dhost_state.pci_stats))"},{"line_number":46,"context_line":"            if not instance_topology:"},{"line_number":47,"context_line":"                LOG.debug(\"%(host)s, %(node)s fails NUMA topology \""},{"line_number":48,"context_line":"                          \"requirements. The instance does not fit on this\""},{"line_number":49,"context_line":"                          \"host.\", {\u0027host\u0027: host_state.host,"},{"line_number":50,"context_line":"                                    \u0027node\u0027: host_state.nodename})"},{"line_number":51,"context_line":"                return False"}],"source_content_type":"text/x-python","patch_set":19,"id":"9a8ffd7b_b55f5b40","line":48,"updated":"2015-11-25 14:35:53.000000000","message":"this is missing a space at the end of the line","commit_id":"477181b00f5102af63e42fc4b052f38605c71e92"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"ecbeb17865d3f2a53e8b2c83c0ca4f512b194dd1","unresolved":false,"context_lines":[{"line_number":45,"context_line":"                        pci_stats\u003dhost_state.pci_stats))"},{"line_number":46,"context_line":"            if not instance_topology:"},{"line_number":47,"context_line":"                LOG.debug(\"%(host)s, %(node)s fails NUMA topology \""},{"line_number":48,"context_line":"                          \"requirements. The instance does not fit on this\""},{"line_number":49,"context_line":"                          \"host.\", {\u0027host\u0027: host_state.host,"},{"line_number":50,"context_line":"                                    \u0027node\u0027: host_state.nodename})"},{"line_number":51,"context_line":"                return False"}],"source_content_type":"text/x-python","patch_set":19,"id":"9a8ffd7b_93f34a0a","line":48,"in_reply_to":"9a8ffd7b_b55f5b40","updated":"2015-11-25 16:33:40.000000000","message":"drat","commit_id":"477181b00f5102af63e42fc4b052f38605c71e92"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"28101d008a7390bb5706dd5cccd13992c5b09dc5","unresolved":false,"context_lines":[{"line_number":47,"context_line":"                LOG.debug(\"%(host)s, %(node)s fails NUMA topology \""},{"line_number":48,"context_line":"                          \"requirements. The instance does not fit on this\""},{"line_number":49,"context_line":"                          \"host.\", {\u0027host\u0027: host_state.host,"},{"line_number":50,"context_line":"                                    \u0027node\u0027: host_state.nodename})"},{"line_number":51,"context_line":"                return False"},{"line_number":52,"context_line":"            host_state.limits[\u0027numa_topology\u0027] \u003d limits"},{"line_number":53,"context_line":"            return True"}],"source_content_type":"text/x-python","patch_set":19,"id":"9a8ffd7b_cb1dd1be","line":50,"updated":"2015-11-24 19:28:39.000000000","message":"Is the request_spec in scope a RequestSpec object? Because if it is, we could pass the instance_uuid kwarg in with the logging method, which would make this easier to trace:\n\nhttps://github.com/openstack/nova/blob/master/nova/objects/request_spec.py#L54\n\nMaybe we could just add to LOG.debug(..., instance_uuid\u003drequest_spec.get(\u0027instance_uuid\u0027))\n\nAlthough it looks like the RequestSpec object doesn\u0027t have dict compat.","commit_id":"477181b00f5102af63e42fc4b052f38605c71e92"},{"author":{"_account_id":7166,"name":"Sylvain Bauza","email":"sbauza@redhat.com","username":"sbauza"},"change_message_id":"316b041c4303b8db126143fff813fbeb7dd41d40","unresolved":false,"context_lines":[{"line_number":47,"context_line":"                LOG.debug(\"%(host)s, %(node)s fails NUMA topology \""},{"line_number":48,"context_line":"                          \"requirements. The instance does not fit on this\""},{"line_number":49,"context_line":"                          \"host.\", {\u0027host\u0027: host_state.host,"},{"line_number":50,"context_line":"                                    \u0027node\u0027: host_state.nodename})"},{"line_number":51,"context_line":"                return False"},{"line_number":52,"context_line":"            host_state.limits[\u0027numa_topology\u0027] \u003d limits"},{"line_number":53,"context_line":"            return True"}],"source_content_type":"text/x-python","patch_set":19,"id":"9a8ffd7b_42ed12ee","line":50,"in_reply_to":"9a8ffd7b_cb1dd1be","updated":"2015-11-25 15:18:04.000000000","message":"Yeah the Spec object embeds the instance_uuid that is found in the legacy dict request_spec.get(\u0027instance_properties\u0027).get(\u0027instance_uuid\u0027)\n\nThere is no DictCompatMixin in the sense of what we have with old objects that required a compatiblity layer, but we are still playing with a legacy dict here because of the compat_legacy_props() deco.","commit_id":"477181b00f5102af63e42fc4b052f38605c71e92"},{"author":{"_account_id":1653,"name":"garyk","email":"gkotton@vmware.com","username":"garyk"},"change_message_id":"3b474610992bfabb29b2f8305f5904615425f663","unresolved":false,"context_lines":[{"line_number":52,"context_line":"            host_state.limits[\u0027numa_topology\u0027] \u003d limits"},{"line_number":53,"context_line":"            return True"},{"line_number":54,"context_line":"        elif requested_topology:"},{"line_number":55,"context_line":"            LOG.debug(\"%(host)s, %(node)s fails NUMA topology requirements. No\""},{"line_number":56,"context_line":"                      \" host NUMA topology while the instance specified one.\","},{"line_number":57,"context_line":"                      {\u0027host\u0027: host_state.host, \u0027node\u0027: host_state.nodename})"},{"line_number":58,"context_line":"            return False"}],"source_content_type":"text/x-python","patch_set":19,"id":"9a8ffd7b_952b3794","line":55,"updated":"2015-11-25 14:35:53.000000000","message":"i prefer a space at the end of the line","commit_id":"477181b00f5102af63e42fc4b052f38605c71e92"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"ecbeb17865d3f2a53e8b2c83c0ca4f512b194dd1","unresolved":false,"context_lines":[{"line_number":52,"context_line":"            host_state.limits[\u0027numa_topology\u0027] \u003d limits"},{"line_number":53,"context_line":"            return True"},{"line_number":54,"context_line":"        elif requested_topology:"},{"line_number":55,"context_line":"            LOG.debug(\"%(host)s, %(node)s fails NUMA topology requirements. No\""},{"line_number":56,"context_line":"                      \" host NUMA topology while the instance specified one.\","},{"line_number":57,"context_line":"                      {\u0027host\u0027: host_state.host, \u0027node\u0027: host_state.nodename})"},{"line_number":58,"context_line":"            return False"}],"source_content_type":"text/x-python","patch_set":19,"id":"9a8ffd7b_937caa73","line":55,"in_reply_to":"9a8ffd7b_952b3794","updated":"2015-11-25 16:33:40.000000000","message":"So do I, but I chose this option to avoid adding an extra line :) I\u0027ve changed it anyway - you decide.","commit_id":"477181b00f5102af63e42fc4b052f38605c71e92"},{"author":{"_account_id":1653,"name":"garyk","email":"gkotton@vmware.com","username":"garyk"},"change_message_id":"19be9e8af0fe0ca6d8630e47cc357e9a3d6ab176","unresolved":false,"context_lines":[{"line_number":44,"context_line":"                        pci_requests\u003dpci_requests,"},{"line_number":45,"context_line":"                        pci_stats\u003dhost_state.pci_stats))"},{"line_number":46,"context_line":"            if not instance_topology:"},{"line_number":47,"context_line":"                LOG.debug(\"%(host)s, %(node)s fails NUMA topology\""},{"line_number":48,"context_line":"                          \"requirements. The instance does not fit on this \""},{"line_number":49,"context_line":"                          \"host.\", {\u0027host\u0027: host_state.host,"},{"line_number":50,"context_line":"                                    \u0027node\u0027: host_state.nodename})"}],"source_content_type":"text/x-python","patch_set":22,"id":"9a8ffd7b_67e484e0","line":47,"updated":"2015-11-27 10:49:30.000000000","message":"missing space at the end of the line.","commit_id":"ffd8e31dd614bd47a490680ba1c432040c1e001b"},{"author":{"_account_id":7730,"name":"Sahid Orentino Ferdjaoui","email":"sahid.ferdjaoui@industrialdiscipline.com","username":"sahid"},"change_message_id":"2791c3aa241d7301d2e6c3c953854393e6b7c592","unresolved":false,"context_lines":[{"line_number":44,"context_line":"                        pci_requests\u003dpci_requests,"},{"line_number":45,"context_line":"                        pci_stats\u003dhost_state.pci_stats))"},{"line_number":46,"context_line":"            if not instance_topology:"},{"line_number":47,"context_line":"                LOG.debug(\"%(host)s, %(node)s fails NUMA topology\""},{"line_number":48,"context_line":"                          \"requirements. The instance does not fit on this \""},{"line_number":49,"context_line":"                          \"host.\", {\u0027host\u0027: host_state.host,"},{"line_number":50,"context_line":"                                    \u0027node\u0027: host_state.nodename})"}],"source_content_type":"text/x-python","patch_set":22,"id":"9a8ffd7b_c0d66c4e","line":47,"in_reply_to":"9a8ffd7b_67e484e0","updated":"2015-11-27 14:16:32.000000000","message":"oh yes","commit_id":"ffd8e31dd614bd47a490680ba1c432040c1e001b"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"06a8dde52db19378a9bbfa64ee004a8f720a9c21","unresolved":false,"context_lines":[{"line_number":44,"context_line":"                        pci_requests\u003dpci_requests,"},{"line_number":45,"context_line":"                        pci_stats\u003dhost_state.pci_stats))"},{"line_number":46,"context_line":"            if not instance_topology:"},{"line_number":47,"context_line":"                LOG.debug(\"%(host)s, %(node)s fails NUMA topology \""},{"line_number":48,"context_line":"                          \"requirements. The instance does not fit on this \""},{"line_number":49,"context_line":"                          \"host.\", {\u0027host\u0027: host_state.host,"},{"line_number":50,"context_line":"                                    \u0027node\u0027: host_state.nodename})"}],"source_content_type":"text/x-python","patch_set":23,"id":"9a8ffd7b_84ce5d2b","line":47,"updated":"2015-12-02 18:51:29.000000000","message":"I would still like to see the instance_uuid in here which we should be able to get from the request_spec.","commit_id":"8c87044dde93f4f55874756eb52176f56f94e338"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"491bcc36d065515f5a11885aa9d9aa26d591d29d","unresolved":false,"context_lines":[{"line_number":44,"context_line":"                        pci_requests\u003dpci_requests,"},{"line_number":45,"context_line":"                        pci_stats\u003dhost_state.pci_stats))"},{"line_number":46,"context_line":"            if not instance_topology:"},{"line_number":47,"context_line":"                LOG.debug(\"%(host)s, %(node)s fails NUMA topology \""},{"line_number":48,"context_line":"                          \"requirements. The instance \u0027%(instance)s\u0027 does \""},{"line_number":49,"context_line":"                          \"not fit on this host.\", {"},{"line_number":50,"context_line":"                              \u0027host\u0027: host_state.host,"}],"source_content_type":"text/x-python","patch_set":24,"id":"9a8ffd7b_af24950c","line":47,"updated":"2015-12-02 20:39:54.000000000","message":"For the highlighting in the logs, you actually want to pass a kwarg:\n\nLOG.debug(\"%(host)s, %(node)s fails NUMA topology \"\n          \"requirements. The instance does not fit on \"\n          \"this host.\", {...},\n          instance_uuid\u003dinstance.get(\u0027instance_uuid\u0027))","commit_id":"5ecdb57b94210f8527e9e8cfd7574fc8acbb72ef"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"5555167221d596b18020acf2d009d6d83649aab8","unresolved":false,"context_lines":[{"line_number":44,"context_line":"                        pci_requests\u003dpci_requests,"},{"line_number":45,"context_line":"                        pci_stats\u003dhost_state.pci_stats))"},{"line_number":46,"context_line":"            if not instance_topology:"},{"line_number":47,"context_line":"                LOG.debug(\"%(host)s, %(node)s fails NUMA topology \""},{"line_number":48,"context_line":"                          \"requirements. The instance \u0027%(instance)s\u0027 does \""},{"line_number":49,"context_line":"                          \"not fit on this host.\", {"},{"line_number":50,"context_line":"                              \u0027host\u0027: host_state.host,"}],"source_content_type":"text/x-python","patch_set":24,"id":"9a8ffd7b_0ac82f21","line":47,"in_reply_to":"9a8ffd7b_af24950c","updated":"2015-12-02 21:02:32.000000000","message":"I didn\u0027t know you could do that. Good to know.\n\nDone.","commit_id":"5ecdb57b94210f8527e9e8cfd7574fc8acbb72ef"},{"author":{"_account_id":14131,"name":"shaohef","email":"shaohe.feng@intel.com","username":"shaohefeng"},"change_message_id":"6b1d58545df46666e10560af9459f8458aeeee6f","unresolved":false,"context_lines":[{"line_number":47,"context_line":"                LOG.debug(\"%(host)s, %(node)s fails NUMA topology \""},{"line_number":48,"context_line":"                          \"requirements. The instance does not fit on this \""},{"line_number":49,"context_line":"                          \"host.\", {\u0027host\u0027: host_state.host,"},{"line_number":50,"context_line":"                                    \u0027node\u0027: host_state.nodename},"},{"line_number":51,"context_line":"                          instance_uuid\u003dinstance.get(\u0027instance_uuid\u0027))"},{"line_number":52,"context_line":"                return False"},{"line_number":53,"context_line":"            host_state.limits[\u0027numa_topology\u0027] \u003d limits"}],"source_content_type":"text/x-python","patch_set":25,"id":"9a8ffd7b_f9533414","line":50,"updated":"2015-12-03 06:25:01.000000000","message":"nit: you can keep the same style as the follow log.","commit_id":"889e2b88045b1bac4b462a35d0bd51d7486b452c"},{"author":{"_account_id":782,"name":"John Garbutt","email":"john@johngarbutt.com","username":"johngarbutt"},"change_message_id":"2de4ca7238d9219a37b2f722b23db1e9a91747f0","unresolved":false,"context_lines":[{"line_number":48,"context_line":"                          \"requirements. The instance does not fit on this \""},{"line_number":49,"context_line":"                          \"host.\", {\u0027host\u0027: host_state.host,"},{"line_number":50,"context_line":"                                    \u0027node\u0027: host_state.nodename},"},{"line_number":51,"context_line":"                          instance_uuid\u003dinstance.get(\u0027instance_uuid\u0027))"},{"line_number":52,"context_line":"                return False"},{"line_number":53,"context_line":"            host_state.limits[\u0027numa_topology\u0027] \u003d limits"},{"line_number":54,"context_line":"            return True"}],"source_content_type":"text/x-python","patch_set":25,"id":"9a8ffd7b_8fb2c804","line":51,"updated":"2015-12-03 12:51:37.000000000","message":"Nit, I think you can just pass in the instance here.","commit_id":"889e2b88045b1bac4b462a35d0bd51d7486b452c"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"325e5803981dba2a67834b88d23677a9037ebdcc","unresolved":false,"context_lines":[{"line_number":48,"context_line":"                          \"requirements. The instance does not fit on this \""},{"line_number":49,"context_line":"                          \"host.\", {\u0027host\u0027: host_state.host,"},{"line_number":50,"context_line":"                                    \u0027node\u0027: host_state.nodename},"},{"line_number":51,"context_line":"                          instance_uuid\u003dinstance.get(\u0027instance_uuid\u0027))"},{"line_number":52,"context_line":"                return False"},{"line_number":53,"context_line":"            host_state.limits[\u0027numa_topology\u0027] \u003d limits"},{"line_number":54,"context_line":"            return True"}],"source_content_type":"text/x-python","patch_set":25,"id":"7a740942_65036f43","line":51,"in_reply_to":"9a8ffd7b_8fb2c804","updated":"2015-12-05 16:31:55.000000000","message":"@John, the instance var here is not a nova objects Instance, it\u0027s a request_spec thing.","commit_id":"889e2b88045b1bac4b462a35d0bd51d7486b452c"}]}