)]}'
{"nova/scheduler/filters/core_filter.py":[{"author":{"_account_id":5754,"name":"Alex Xu","email":"hejie.xu@intel.com","username":"xuhj"},"change_message_id":"919691473730075a90836716a27393cc7f829809","unresolved":false,"context_lines":[{"line_number":31,"context_line":""},{"line_number":32,"context_line":"    def host_passes(self, host_state, spec_obj):"},{"line_number":33,"context_line":"        \"\"\"Return True if host has sufficient CPU cores.\"\"\""},{"line_number":34,"context_line":"        if not spec_obj.obj_attr_is_set(\u0027flavor\u0027):"},{"line_number":35,"context_line":"            return True"},{"line_number":36,"context_line":""},{"line_number":37,"context_line":"        if not host_state.vcpus_total:"}],"source_content_type":"text/x-python","patch_set":24,"id":"da20952f_a3296a39","line":34,"updated":"2015-09-03 07:04:17.000000000","message":"looks like we will have flavor any time.","commit_id":"8fd93156a2108b04ee3a525897f58532b116f0a4"},{"author":{"_account_id":7166,"name":"Sylvain Bauza","email":"sbauza@redhat.com","username":"sbauza"},"change_message_id":"e13fda81154d066692437e8585921e4666e76c81","unresolved":false,"context_lines":[{"line_number":31,"context_line":""},{"line_number":32,"context_line":"    def host_passes(self, host_state, spec_obj):"},{"line_number":33,"context_line":"        \"\"\"Return True if host has sufficient CPU cores.\"\"\""},{"line_number":34,"context_line":"        if not spec_obj.obj_attr_is_set(\u0027flavor\u0027):"},{"line_number":35,"context_line":"            return True"},{"line_number":36,"context_line":""},{"line_number":37,"context_line":"        if not host_state.vcpus_total:"}],"source_content_type":"text/x-python","patch_set":24,"id":"da20952f_e6768b3d","line":34,"in_reply_to":"da20952f_a3296a39","updated":"2015-09-03 09:55:54.000000000","message":"Agreed, we can fix that up later","commit_id":"8fd93156a2108b04ee3a525897f58532b116f0a4"},{"author":{"_account_id":7,"name":"Jay Pipes","email":"jaypipes@gmail.com","username":"jaypipes"},"change_message_id":"26a8e081e04d15fb3190b423bf45be392cdba8f2","unresolved":false,"context_lines":[{"line_number":32,"context_line":"    def host_passes(self, host_state, spec_obj):"},{"line_number":33,"context_line":"        \"\"\"Return True if host has sufficient CPU cores.\"\"\""},{"line_number":34,"context_line":"        if not spec_obj.obj_attr_is_set(\u0027flavor\u0027):"},{"line_number":35,"context_line":"            return True"},{"line_number":36,"context_line":""},{"line_number":37,"context_line":"        if not host_state.vcpus_total:"},{"line_number":38,"context_line":"            # Fail safe"}],"source_content_type":"text/x-python","patch_set":28,"id":"1a26ad4f_4828afe2","line":35,"updated":"2015-10-30 02:14:10.000000000","message":"When do we ever pass a request spec that does not have flavor/instance_type information in it?","commit_id":"b091211c5a87b87098966584a76953e4f8f620f8"}],"nova/scheduler/filters/disk_filter.py":[{"author":{"_account_id":7,"name":"Jay Pipes","email":"jaypipes@gmail.com","username":"jaypipes"},"change_message_id":"26a8e081e04d15fb3190b423bf45be392cdba8f2","unresolved":false,"context_lines":[{"line_number":36,"context_line":"        return CONF.disk_allocation_ratio"},{"line_number":37,"context_line":""},{"line_number":38,"context_line":"    def host_passes(self, host_state, spec_obj):"},{"line_number":39,"context_line":"        \"\"\"Filter based on disk usage.\"\"\""},{"line_number":40,"context_line":"        requested_disk \u003d (1024 * (spec_obj.root_gb +"},{"line_number":41,"context_line":"                                  spec_obj.ephemeral_gb) +"},{"line_number":42,"context_line":"                          spec_obj.swap)"}],"source_content_type":"text/x-python","patch_set":28,"id":"1a26ad4f_48042f49","line":39,"updated":"2015-10-30 02:14:10.000000000","message":"Yeah, so we don\u0027t have the same check for whether the request spec has a flavor attribute set here, which makes me sure that it should be removed in the vcpus filter one.","commit_id":"b091211c5a87b87098966584a76953e4f8f620f8"}],"nova/scheduler/filters/exact_core_filter.py":[{"author":{"_account_id":5754,"name":"Alex Xu","email":"hejie.xu@intel.com","username":"xuhj"},"change_message_id":"919691473730075a90836716a27393cc7f829809","unresolved":false,"context_lines":[{"line_number":27,"context_line":""},{"line_number":28,"context_line":"    def host_passes(self, host_state, spec_obj):"},{"line_number":29,"context_line":"        \"\"\"Return True if host has the exact number of CPU cores.\"\"\""},{"line_number":30,"context_line":"        if not spec_obj.obj_attr_is_set(\u0027flavor\u0027):"},{"line_number":31,"context_line":"            return True"},{"line_number":32,"context_line":""},{"line_number":33,"context_line":"        if not host_state.vcpus_total:"}],"source_content_type":"text/x-python","patch_set":24,"id":"da20952f_a39c0a5e","line":30,"updated":"2015-09-03 07:04:17.000000000","message":"this looks like useless also","commit_id":"8fd93156a2108b04ee3a525897f58532b116f0a4"},{"author":{"_account_id":7,"name":"Jay Pipes","email":"jaypipes@gmail.com","username":"jaypipes"},"change_message_id":"26a8e081e04d15fb3190b423bf45be392cdba8f2","unresolved":false,"context_lines":[{"line_number":27,"context_line":""},{"line_number":28,"context_line":"    def host_passes(self, host_state, spec_obj):"},{"line_number":29,"context_line":"        \"\"\"Return True if host has the exact number of CPU cores.\"\"\""},{"line_number":30,"context_line":"        if not spec_obj.obj_attr_is_set(\u0027flavor\u0027):"},{"line_number":31,"context_line":"            return True"},{"line_number":32,"context_line":""},{"line_number":33,"context_line":"        if not host_state.vcpus_total:"}],"source_content_type":"text/x-python","patch_set":28,"id":"1a26ad4f_c896ffef","line":30,"updated":"2015-10-30 02:14:10.000000000","message":"Kill this.","commit_id":"b091211c5a87b87098966584a76953e4f8f620f8"}],"nova/tests/unit/scheduler/filters/test_exact_core_filter.py":[{"author":{"_account_id":7,"name":"Jay Pipes","email":"jaypipes@gmail.com","username":"jaypipes"},"change_message_id":"26a8e081e04d15fb3190b423bf45be392cdba8f2","unresolved":false,"context_lines":[{"line_number":20,"context_line":""},{"line_number":21,"context_line":"    def setUp(self):"},{"line_number":22,"context_line":"        super(TestExactCoreFilter, self).setUp()"},{"line_number":23,"context_line":"        self.filt_cls \u003d exact_core_filter.ExactCoreFilter()"},{"line_number":24,"context_line":""},{"line_number":25,"context_line":"    def test_exact_core_filter_passes(self):"},{"line_number":26,"context_line":"        spec_obj \u003d objects.RequestSpec("}],"source_content_type":"text/x-python","patch_set":28,"id":"1a26ad4f_88b7a785","line":23,"updated":"2015-10-30 02:14:10.000000000","message":"And furthermore, there\u0027s no unit test for the case when the request spec does not have a flavor attribute set, so yeah, definitely should remove that conditional from the filter.","commit_id":"b091211c5a87b87098966584a76953e4f8f620f8"}]}