)]}'
{"nova/virt/libvirt/volume/fs.py":[{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"b24a9c6b48edfb80c01ddb3c74c0a0d979ab1193","unresolved":false,"context_lines":[{"line_number":82,"context_line":""},{"line_number":83,"context_line":"          connection_info \u003d {"},{"line_number":84,"context_line":"              \u0027data\u0027: {"},{"line_number":85,"context_line":"                  \u0027export\u0027: the file system share"},{"line_number":86,"context_line":"                  ..."},{"line_number":87,"context_line":"              }"},{"line_number":88,"context_line":"              ..."}],"source_content_type":"text/x-python","patch_set":2,"id":"9a41bdd9_64d72924","line":85,"updated":"2015-07-17 02:00:59.000000000","message":"Need to add \u0027name\u0027 here.","commit_id":"0788ef70269f2650de5dd506b60ffa05e1e06b7b"},{"author":{"_account_id":1779,"name":"Daniel Berrange","email":"berrange@redhat.com","username":"berrange"},"change_message_id":"3af5982120975aa566bc0b7d2f2c5bedb6bafb1b","unresolved":false,"context_lines":[{"line_number":31,"context_line":"              self).__init__(connection, is_block_dev\u003dFalse)"},{"line_number":32,"context_line":""},{"line_number":33,"context_line":"    @abc.abstractmethod"},{"line_number":34,"context_line":"    def get_mount_point_base(self):"},{"line_number":35,"context_line":"        \"\"\"Return the mount point path prefix."},{"line_number":36,"context_line":""},{"line_number":37,"context_line":"        This is used to build the device path."}],"source_content_type":"text/x-python","patch_set":9,"id":"3a50d1a3_dfd2fbd0","line":34,"updated":"2015-07-28 12:46:36.000000000","message":"I think this method, and all the ones below should probably have a leading \u0027_\u0027\n\nPublic methods are those which are intended for use by code outside this class hierarchy, which is just the methods in LibvirtBaseVolumeDriver.  These methods you are adding are not intended for public use - just for use by subclasses in their impls, so should still have an underscore to indicate they are private.","commit_id":"27f3e0608619eb33bb7e5e7a0397b6d40e92aaa0"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"4de26d2f9b4e6e40edf650647bd2888ab5b5c192","unresolved":false,"context_lines":[{"line_number":31,"context_line":"              self).__init__(connection, is_block_dev\u003dFalse)"},{"line_number":32,"context_line":""},{"line_number":33,"context_line":"    @abc.abstractmethod"},{"line_number":34,"context_line":"    def get_mount_point_base(self):"},{"line_number":35,"context_line":"        \"\"\"Return the mount point path prefix."},{"line_number":36,"context_line":""},{"line_number":37,"context_line":"        This is used to build the device path."}],"source_content_type":"text/x-python","patch_set":9,"id":"3a50d1a3_ebc28f84","line":34,"in_reply_to":"3a50d1a3_dfd2fbd0","updated":"2015-07-28 16:24:01.000000000","message":"Sure, that\u0027s fine to change.","commit_id":"27f3e0608619eb33bb7e5e7a0397b6d40e92aaa0"}]}