)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":1653,"name":"garyk","email":"gkotton@vmware.com","username":"garyk"},"change_message_id":"c2aaec98f662db12332b1ec9047c1376e40fc5e8","unresolved":false,"context_lines":[{"line_number":7,"context_line":"Add MKS console support"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"MKS is the native protocol for VMware consoles."},{"line_number":10,"context_line":""},{"line_number":11,"context_line":"Implements: blueprint vmware-webmks-console"},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"Change-Id: Ia494ce050bd4dc58e5947e7f07cc3c815a257004"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":4,"id":"3a50d1a3_bcc9d6ae","line":10,"updated":"2015-07-19 16:33:52.000000000","message":"Can you please add DocImpact and list the new configuration variables","commit_id":"e73b6b2f7f9c626ec297fa06c3327e052e1f1713"}],"nova/compute/manager.py":[{"author":{"_account_id":782,"name":"John Garbutt","email":"john@johngarbutt.com","username":"johngarbutt"},"change_message_id":"be6c3cd59adf753640d556b714b1d8370b388c56","unresolved":false,"context_lines":[{"line_number":4334,"context_line":"        \"\"\"Return connection information for a MKS console.\"\"\""},{"line_number":4335,"context_line":"        context \u003d context.elevated()"},{"line_number":4336,"context_line":"        LOG.debug(\"Getting MKS console\", instance\u003dinstance)"},{"line_number":4337,"context_line":"        token \u003d str(uuid.uuid4())"},{"line_number":4338,"context_line":""},{"line_number":4339,"context_line":"        if not CONF.mks.enabled:"},{"line_number":4340,"context_line":"            raise exception.ConsoleTypeUnavailable(console_type\u003dconsole_type)"}],"source_content_type":"text/x-python","patch_set":9,"id":"3a50d1a3_07561cd2","line":4337,"updated":"2015-07-27 10:30:00.000000000","message":"Nit, I would move all of this after the config check, but its a minor thing.","commit_id":"50c8f93e51fba12a154975d3d82c9cd34bc3b752"}],"nova/tests/unit/compute/test_compute.py":[{"author":{"_account_id":7,"name":"Jay Pipes","email":"jaypipes@gmail.com","username":"jaypipes"},"change_message_id":"86aba08a57fc4f4706b2a7147a74d9709b7ee19b","unresolved":false,"context_lines":[{"line_number":9199,"context_line":"                                                          fake_console_type)"},{"line_number":9200,"context_line":"            self.assertEqual(console, {\u0027url\u0027: \u0027fake_access_url\u0027})"},{"line_number":9201,"context_line":""},{"line_number":9202,"context_line":"    def test_get_serial_console_no_host(self):"},{"line_number":9203,"context_line":"        # Make sure an exception is raised when instance is not Active."},{"line_number":9204,"context_line":"        instance \u003d self._create_fake_instance_obj(params\u003d{\u0027host\u0027: \u0027\u0027})"},{"line_number":9205,"context_line":""}],"source_content_type":"text/x-python","patch_set":6,"id":"3a50d1a3_0b33f0f6","side":"PARENT","line":9202,"updated":"2015-07-23 18:55:03.000000000","message":"Why did you remove this test?","commit_id":"4454cf1d268b12d3c3552b374ca46b0c6ef47bbc"},{"author":{"_account_id":9172,"name":"Radoslav Gerganov","email":"rgerganov@vmware.com","username":"rgerganov"},"change_message_id":"43b57349813003d212026a582f255030db1c462c","unresolved":false,"context_lines":[{"line_number":9199,"context_line":"                                                          fake_console_type)"},{"line_number":9200,"context_line":"            self.assertEqual(console, {\u0027url\u0027: \u0027fake_access_url\u0027})"},{"line_number":9201,"context_line":""},{"line_number":9202,"context_line":"    def test_get_serial_console_no_host(self):"},{"line_number":9203,"context_line":"        # Make sure an exception is raised when instance is not Active."},{"line_number":9204,"context_line":"        instance \u003d self._create_fake_instance_obj(params\u003d{\u0027host\u0027: \u0027\u0027})"},{"line_number":9205,"context_line":""}],"source_content_type":"text/x-python","patch_set":6,"id":"3a50d1a3_44878912","side":"PARENT","line":9202,"in_reply_to":"3a50d1a3_0b33f0f6","updated":"2015-07-24 10:31:22.000000000","message":"oops :)","commit_id":"4454cf1d268b12d3c3552b374ca46b0c6ef47bbc"},{"author":{"_account_id":7,"name":"Jay Pipes","email":"jaypipes@gmail.com","username":"jaypipes"},"change_message_id":"86aba08a57fc4f4706b2a7147a74d9709b7ee19b","unresolved":false,"context_lines":[{"line_number":3344,"context_line":""},{"line_number":3345,"context_line":"        self.assertTrue(self.compute.validate_console_port("},{"line_number":3346,"context_line":"            context\u003dself.context, instance\u003dinstance, port\u003d5900,"},{"line_number":3347,"context_line":"            console_type\u003d\"webmks\"))"},{"line_number":3348,"context_line":""},{"line_number":3349,"context_line":"    def test_validate_console_port_wrong_port(self):"},{"line_number":3350,"context_line":"        self.flags(enabled\u003dTrue, group\u003d\u0027vnc\u0027)"}],"source_content_type":"text/x-python","patch_set":6,"id":"3a50d1a3_cb018806","line":3347,"updated":"2015-07-23 18:55:03.000000000","message":"Please use mock for new unit tests. The test would actually be simpler and shorter:\n\n def test_validate_console_port_mks(self):\n     self.flags(enabled\u003dTrue, group\u003d\u0027mks\u0027)\n     instance \u003d self._create_fake_instance_obj()\n\n     with mock.patch.object(self.compute.driver, \u0027get_mks_console\u0027) as mock_getmks:\n         mock_getmks.return_value \u003d ctype.ConsoleMKS(host\u003d\u0027fake_host\u0027, port\u003d5900)\n         result \u003d self.compute.validate_console_port(context\u003dself.context,\n                                         instance\u003dinstance, port\u003d5900,\n                                         console_type\u003d\"webmks\")\n         self.assertTrue(result)","commit_id":"36e46df0f7c4237182a3d751725641a7d794dcc1"},{"author":{"_account_id":9172,"name":"Radoslav Gerganov","email":"rgerganov@vmware.com","username":"rgerganov"},"change_message_id":"43b57349813003d212026a582f255030db1c462c","unresolved":false,"context_lines":[{"line_number":3344,"context_line":""},{"line_number":3345,"context_line":"        self.assertTrue(self.compute.validate_console_port("},{"line_number":3346,"context_line":"            context\u003dself.context, instance\u003dinstance, port\u003d5900,"},{"line_number":3347,"context_line":"            console_type\u003d\"webmks\"))"},{"line_number":3348,"context_line":""},{"line_number":3349,"context_line":"    def test_validate_console_port_wrong_port(self):"},{"line_number":3350,"context_line":"        self.flags(enabled\u003dTrue, group\u003d\u0027vnc\u0027)"}],"source_content_type":"text/x-python","patch_set":6,"id":"3a50d1a3_44c6a917","line":3347,"in_reply_to":"3a50d1a3_cb018806","updated":"2015-07-24 10:31:22.000000000","message":"Done","commit_id":"36e46df0f7c4237182a3d751725641a7d794dcc1"}],"nova/tests/unit/virt/test_virt_drivers.py":[{"author":{"_account_id":7,"name":"Jay Pipes","email":"jaypipes@gmail.com","username":"jaypipes"},"change_message_id":"86aba08a57fc4f4706b2a7147a74d9709b7ee19b","unresolved":false,"context_lines":[{"line_number":585,"context_line":"    def test_get_mks_console(self):"},{"line_number":586,"context_line":"        instance_ref, network_info \u003d self._get_running_instance()"},{"line_number":587,"context_line":"        mks_console \u003d self.connection.get_mks_console(self.ctxt,"},{"line_number":588,"context_line":"                                                         instance_ref)"},{"line_number":589,"context_line":"        self.assertIsInstance(mks_console, ctype.ConsoleMKS)"},{"line_number":590,"context_line":""},{"line_number":591,"context_line":"    @catch_notimplementederror"}],"source_content_type":"text/x-python","patch_set":6,"id":"3a50d1a3_6b3f14b4","line":588,"updated":"2015-07-23 18:55:03.000000000","message":"nit: alignment...","commit_id":"36e46df0f7c4237182a3d751725641a7d794dcc1"},{"author":{"_account_id":9172,"name":"Radoslav Gerganov","email":"rgerganov@vmware.com","username":"rgerganov"},"change_message_id":"43b57349813003d212026a582f255030db1c462c","unresolved":false,"context_lines":[{"line_number":585,"context_line":"    def test_get_mks_console(self):"},{"line_number":586,"context_line":"        instance_ref, network_info \u003d self._get_running_instance()"},{"line_number":587,"context_line":"        mks_console \u003d self.connection.get_mks_console(self.ctxt,"},{"line_number":588,"context_line":"                                                         instance_ref)"},{"line_number":589,"context_line":"        self.assertIsInstance(mks_console, ctype.ConsoleMKS)"},{"line_number":590,"context_line":""},{"line_number":591,"context_line":"    @catch_notimplementederror"}],"source_content_type":"text/x-python","patch_set":6,"id":"3a50d1a3_e4e33504","line":588,"in_reply_to":"3a50d1a3_6b3f14b4","updated":"2015-07-24 10:31:22.000000000","message":"Done","commit_id":"36e46df0f7c4237182a3d751725641a7d794dcc1"}]}