)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":8768,"name":"Chris Friesen","email":"chris.friesen@windriver.com","username":"cbf123"},"change_message_id":"f3c44cb42c457b24f8d3aeabb2cd1fcbcb3efd0d","unresolved":false,"context_lines":[{"line_number":10,"context_line":"functions per PCI device to be configured. This limit (MAX_FUNC)"},{"line_number":11,"context_line":"is currently hardcoded to 7, which is less than what many newer"},{"line_number":12,"context_line":"NICs are able to support."},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"Change-Id: Idff176d33583b8054dfd0c6334c002656f422914"},{"line_number":15,"context_line":"Closes-Bug: #1471997"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"9a41bdd9_dbbd9003","line":13,"updated":"2015-07-17 15:09:02.000000000","message":"Do we need a DocImpact flag here?","commit_id":"a63477b000d1e51b7f60da0aae8d2c44d574d090"},{"author":{"_account_id":7166,"name":"Sylvain Bauza","email":"sbauza@redhat.com","username":"sbauza"},"change_message_id":"ecec24a93c0b94fa3c9fdee8faa5f1e839e690c5","unresolved":false,"context_lines":[{"line_number":10,"context_line":"functions per PCI device to be configured. This limit (MAX_FUNC)"},{"line_number":11,"context_line":"is currently hardcoded to 7, which is less than what many newer"},{"line_number":12,"context_line":"NICs are able to support."},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"Change-Id: Idff176d33583b8054dfd0c6334c002656f422914"},{"line_number":15,"context_line":"Closes-Bug: #1471997"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"fa1b9901_478834c5","line":13,"in_reply_to":"9a41bdd9_9b62a815","updated":"2015-08-20 17:56:00.000000000","message":"If you\u0027re wondering if by adding a conf flag, we need to add a DocImpact flag, I would tend to say no because there are no actionable items for the docs team IMHO","commit_id":"a63477b000d1e51b7f60da0aae8d2c44d574d090"},{"author":{"_account_id":14174,"name":"Bart Wensley","email":"bartwensley@hotmail.com","username":"bartwensley"},"change_message_id":"51d6d810d065b6c7fcd3843e64eab824d2463dbd","unresolved":false,"context_lines":[{"line_number":10,"context_line":"functions per PCI device to be configured. This limit (MAX_FUNC)"},{"line_number":11,"context_line":"is currently hardcoded to 7, which is less than what many newer"},{"line_number":12,"context_line":"NICs are able to support."},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"Change-Id: Idff176d33583b8054dfd0c6334c002656f422914"},{"line_number":15,"context_line":"Closes-Bug: #1471997"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"9a41bdd9_9b62a815","line":13,"in_reply_to":"9a41bdd9_dbbd9003","updated":"2015-07-17 15:19:13.000000000","message":"That\u0027s a good question. I see that the OpenStack Configuration Reference manual has a list of all the config options (e.g. http://docs.openstack.org/kilo/config-reference/content/list-of-compute-config-options.html). I was assuming that was auto-generated at the end of the release. Does anyone know whether that is the case?","commit_id":"a63477b000d1e51b7f60da0aae8d2c44d574d090"}],"nova/pci/devspec.py":[{"author":{"_account_id":5754,"name":"Alex Xu","email":"hejie.xu@intel.com","username":"xuhj"},"change_message_id":"356a0e7678d92c7d94fd3aaf3384ac61eea55483","unresolved":false,"context_lines":[{"line_number":91,"context_line":"                except SyntaxError:"},{"line_number":92,"context_line":"                    raise exception.PciDeviceWrongAddressFormat("},{"line_number":93,"context_line":"                        address\u003dpci_addr)"},{"line_number":94,"context_line":"                if f \u003e CONF.pci_max_virtual_functions:"},{"line_number":95,"context_line":"                    raise exception.PciDeviceInvalidAddressField("},{"line_number":96,"context_line":"                        address\u003dpci_addr, field\u003d\"function\")"},{"line_number":97,"context_line":"                self.func \u003d \"%1x\" % f"}],"source_content_type":"text/x-python","patch_set":1,"id":"9a41bdd9_c86daccd","line":94,"updated":"2015-07-18 07:33:17.000000000","message":"why need such limit?","commit_id":"a63477b000d1e51b7f60da0aae8d2c44d574d090"},{"author":{"_account_id":14174,"name":"Bart Wensley","email":"bartwensley@hotmail.com","username":"bartwensley"},"change_message_id":"0e3de8bc5e8b8ca51900a949620253231a6893d9","unresolved":false,"context_lines":[{"line_number":91,"context_line":"                except SyntaxError:"},{"line_number":92,"context_line":"                    raise exception.PciDeviceWrongAddressFormat("},{"line_number":93,"context_line":"                        address\u003dpci_addr)"},{"line_number":94,"context_line":"                if f \u003e CONF.pci_max_virtual_functions:"},{"line_number":95,"context_line":"                    raise exception.PciDeviceInvalidAddressField("},{"line_number":96,"context_line":"                        address\u003dpci_addr, field\u003d\"function\")"},{"line_number":97,"context_line":"                self.func \u003d \"%1x\" % f"}],"source_content_type":"text/x-python","patch_set":1,"id":"3a50d1a3_e673364c","line":94,"in_reply_to":"9a41bdd9_c86daccd","updated":"2015-07-20 14:07:29.000000000","message":"I didn\u0027t write the original code, but since this object is used for the PCI passthrough whitelist I assume the range checking is being done to verify the entries in the whitelist make sense.","commit_id":"a63477b000d1e51b7f60da0aae8d2c44d574d090"}],"nova/pci/opts.py":[{"author":{"_account_id":7166,"name":"Sylvain Bauza","email":"sbauza@redhat.com","username":"sbauza"},"change_message_id":"ecec24a93c0b94fa3c9fdee8faa5f1e839e690c5","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"fa1b9901_475d9445","line":1,"updated":"2015-08-20 17:56:00.000000000","message":"here you need to add an opts.py like for https://github.com/openstack/nova/blob/master/nova/compute/opts.py IMHO","commit_id":"a63477b000d1e51b7f60da0aae8d2c44d574d090"}]}