)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":8119,"name":"Eric Brown","email":"eric_wade_brown@yahoo.com","username":"ericwb"},"change_message_id":"feaff394f18c84ca9f8efa6c1e6c936f14779d7f","unresolved":false,"context_lines":[{"line_number":13,"context_line":"can be enabled by setting the enable_vnc_password in nova.conf"},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"Change-Id: I5a875d9921edff6c85ccb5a27c8a28e6bf3432d5"},{"line_number":16,"context_line":"Closes-Bug: 1450294"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"9a41bdd9_526ceb9b","line":16,"updated":"2015-07-18 04:59:58.000000000","message":"This a blueprint is more appropriate","commit_id":"1839a122c7f3c8814f576ec86bf1b217806c1ab2"},{"author":{"_account_id":1653,"name":"garyk","email":"gkotton@vmware.com","username":"garyk"},"change_message_id":"1bf5a581efc20f194f89177bd2fe45775f35b4db","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     Zhang Hua \u003cjoshua.zhang@canonical.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2015-07-18 18:20:57 +0800"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Enable password support for vnc session"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Enable password support for vnc session. This is to avoid"},{"line_number":10,"context_line":"allowing an attacker to connect to the remote host as no"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"9a41bdd9_a18403b1","line":7,"updated":"2015-07-18 12:41:39.000000000","message":"pleas prefix this with libvirt:","commit_id":"b619505657f20b129e66d66c810c631d20a8c6e9"},{"author":{"_account_id":1653,"name":"garyk","email":"gkotton@vmware.com","username":"garyk"},"change_message_id":"1bf5a581efc20f194f89177bd2fe45775f35b4db","unresolved":false,"context_lines":[{"line_number":11,"context_line":"authentication is required to access this service. The"},{"line_number":12,"context_line":"default vnc password is uuid of the instance, and this feature"},{"line_number":13,"context_line":"can be enabled by setting the enable_vnc_password in nova.conf"},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"Change-Id: I5a875d9921edff6c85ccb5a27c8a28e6bf3432d5"},{"line_number":16,"context_line":"Closes-Bug: 1450294"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"9a41bdd9_8189bfcc","line":14,"updated":"2015-07-18 12:41:39.000000000","message":"please add DocImpact","commit_id":"b619505657f20b129e66d66c810c631d20a8c6e9"},{"author":{"_account_id":1653,"name":"garyk","email":"gkotton@vmware.com","username":"garyk"},"change_message_id":"1bf5a581efc20f194f89177bd2fe45775f35b4db","unresolved":false,"context_lines":[{"line_number":13,"context_line":"can be enabled by setting the enable_vnc_password in nova.conf"},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"Change-Id: I5a875d9921edff6c85ccb5a27c8a28e6bf3432d5"},{"line_number":16,"context_line":"Closes-Bug: 1450294"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"9a41bdd9_618efbd1","line":16,"updated":"2015-07-18 12:41:39.000000000","message":"I think that this should be a BP and that when the instance is created the user should be able to set the default password...","commit_id":"b619505657f20b129e66d66c810c631d20a8c6e9"}],"nova/tests/unit/virt/libvirt/test_config.py":[{"author":{"_account_id":8119,"name":"Eric Brown","email":"eric_wade_brown@yahoo.com","username":"ericwb"},"change_message_id":"feaff394f18c84ca9f8efa6c1e6c936f14779d7f","unresolved":false,"context_lines":[{"line_number":990,"context_line":"        obj.password \u003d \"pass\""},{"line_number":991,"context_line":""},{"line_number":992,"context_line":"        xml \u003d obj.to_xml()"},{"line_number":993,"context_line":"        self.assertXmlEqual(xml, \"\"\"\u003cgraphics type\u003d\"vnc\" autoport\u003d\"yes\" \\"},{"line_number":994,"context_line":"        keymap\u003d\"en_US\" listen\u003d\"127.0.0.1\" passwd\u003d\"pass\"/\u003e"},{"line_number":995,"context_line":"                            \"\"\")"},{"line_number":996,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"9a41bdd9_326127a9","line":993,"updated":"2015-07-18 04:59:58.000000000","message":"assertEqual(expected, actual)\n\navoid using \\","commit_id":"1839a122c7f3c8814f576ec86bf1b217806c1ab2"},{"author":{"_account_id":2711,"name":"Zhang Hua","display_name":"Zhang Hua","email":"joshua.zhang@canonical.com","username":"zhhuabj"},"change_message_id":"5d7e428f054df2d3de10dff542e3ca6273282776","unresolved":false,"context_lines":[{"line_number":990,"context_line":"        obj.password \u003d \"pass\""},{"line_number":991,"context_line":""},{"line_number":992,"context_line":"        xml \u003d obj.to_xml()"},{"line_number":993,"context_line":"        self.assertXmlEqual(xml, \"\"\"\u003cgraphics type\u003d\"vnc\" autoport\u003d\"yes\" \\"},{"line_number":994,"context_line":"        keymap\u003d\"en_US\" listen\u003d\"127.0.0.1\" passwd\u003d\"pass\"/\u003e"},{"line_number":995,"context_line":"                            \"\"\")"},{"line_number":996,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"9a41bdd9_6b49fab6","line":993,"in_reply_to":"9a41bdd9_326127a9","updated":"2015-07-18 10:24:44.000000000","message":"Done","commit_id":"1839a122c7f3c8814f576ec86bf1b217806c1ab2"}],"nova/tests/unit/virt/libvirt/test_driver.py":[{"author":{"_account_id":8119,"name":"Eric Brown","email":"eric_wade_brown@yahoo.com","username":"ericwb"},"change_message_id":"feaff394f18c84ca9f8efa6c1e6c936f14779d7f","unresolved":false,"context_lines":[{"line_number":2323,"context_line":"                                            instance_ref,"},{"line_number":2324,"context_line":"                                            image_meta)"},{"line_number":2325,"context_line":"        cfg \u003d drvr._get_guest_config(instance_ref, [], {}, disk_info)"},{"line_number":2326,"context_line":"        self.assertEqual(len(cfg.devices), 8)"},{"line_number":2327,"context_line":"        self.assertIsInstance(cfg.devices[0],"},{"line_number":2328,"context_line":"                              vconfig.LibvirtConfigGuestDisk)"},{"line_number":2329,"context_line":"        self.assertIsInstance(cfg.devices[1],"}],"source_content_type":"text/x-python","patch_set":1,"id":"9a41bdd9_b246971f","line":2326,"updated":"2015-07-18 04:59:58.000000000","message":"assertEqual(expected, actual)","commit_id":"1839a122c7f3c8814f576ec86bf1b217806c1ab2"},{"author":{"_account_id":8119,"name":"Eric Brown","email":"eric_wade_brown@yahoo.com","username":"ericwb"},"change_message_id":"feaff394f18c84ca9f8efa6c1e6c936f14779d7f","unresolved":false,"context_lines":[{"line_number":2341,"context_line":"        self.assertIsInstance(cfg.devices[7],"},{"line_number":2342,"context_line":"                              vconfig.LibvirtConfigMemoryBalloon)"},{"line_number":2343,"context_line":""},{"line_number":2344,"context_line":"        self.assertEqual(cfg.devices[4].type, \"tablet\")"},{"line_number":2345,"context_line":"        self.assertEqual(cfg.devices[5].type, \"vnc\")"},{"line_number":2346,"context_line":"        self.assertEqual(cfg.devices[5].password, self.test_instance[\"uuid\"])"},{"line_number":2347,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"9a41bdd9_5255cbc3","line":2344,"updated":"2015-07-18 04:59:58.000000000","message":"assertEqual(expected, actual)","commit_id":"1839a122c7f3c8814f576ec86bf1b217806c1ab2"},{"author":{"_account_id":2711,"name":"Zhang Hua","display_name":"Zhang Hua","email":"joshua.zhang@canonical.com","username":"zhhuabj"},"change_message_id":"5d7e428f054df2d3de10dff542e3ca6273282776","unresolved":false,"context_lines":[{"line_number":2341,"context_line":"        self.assertIsInstance(cfg.devices[7],"},{"line_number":2342,"context_line":"                              vconfig.LibvirtConfigMemoryBalloon)"},{"line_number":2343,"context_line":""},{"line_number":2344,"context_line":"        self.assertEqual(cfg.devices[4].type, \"tablet\")"},{"line_number":2345,"context_line":"        self.assertEqual(cfg.devices[5].type, \"vnc\")"},{"line_number":2346,"context_line":"        self.assertEqual(cfg.devices[5].password, self.test_instance[\"uuid\"])"},{"line_number":2347,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"9a41bdd9_8b547e54","line":2344,"in_reply_to":"9a41bdd9_5255cbc3","updated":"2015-07-18 10:24:44.000000000","message":"Done","commit_id":"1839a122c7f3c8814f576ec86bf1b217806c1ab2"},{"author":{"_account_id":8119,"name":"Eric Brown","email":"eric_wade_brown@yahoo.com","username":"ericwb"},"change_message_id":"feaff394f18c84ca9f8efa6c1e6c936f14779d7f","unresolved":false,"context_lines":[{"line_number":2342,"context_line":"                              vconfig.LibvirtConfigMemoryBalloon)"},{"line_number":2343,"context_line":""},{"line_number":2344,"context_line":"        self.assertEqual(cfg.devices[4].type, \"tablet\")"},{"line_number":2345,"context_line":"        self.assertEqual(cfg.devices[5].type, \"vnc\")"},{"line_number":2346,"context_line":"        self.assertEqual(cfg.devices[5].password, self.test_instance[\"uuid\"])"},{"line_number":2347,"context_line":""},{"line_number":2348,"context_line":"    def test_get_guest_config_with_spice_and_tablet(self):"}],"source_content_type":"text/x-python","patch_set":1,"id":"9a41bdd9_125e63e9","line":2345,"updated":"2015-07-18 04:59:58.000000000","message":"assertEqual(expected, actual)","commit_id":"1839a122c7f3c8814f576ec86bf1b217806c1ab2"},{"author":{"_account_id":2711,"name":"Zhang Hua","display_name":"Zhang Hua","email":"joshua.zhang@canonical.com","username":"zhhuabj"},"change_message_id":"5d7e428f054df2d3de10dff542e3ca6273282776","unresolved":false,"context_lines":[{"line_number":2342,"context_line":"                              vconfig.LibvirtConfigMemoryBalloon)"},{"line_number":2343,"context_line":""},{"line_number":2344,"context_line":"        self.assertEqual(cfg.devices[4].type, \"tablet\")"},{"line_number":2345,"context_line":"        self.assertEqual(cfg.devices[5].type, \"vnc\")"},{"line_number":2346,"context_line":"        self.assertEqual(cfg.devices[5].password, self.test_instance[\"uuid\"])"},{"line_number":2347,"context_line":""},{"line_number":2348,"context_line":"    def test_get_guest_config_with_spice_and_tablet(self):"}],"source_content_type":"text/x-python","patch_set":1,"id":"9a41bdd9_ab4f02bd","line":2345,"in_reply_to":"9a41bdd9_125e63e9","updated":"2015-07-18 10:24:44.000000000","message":"Done","commit_id":"1839a122c7f3c8814f576ec86bf1b217806c1ab2"},{"author":{"_account_id":8119,"name":"Eric Brown","email":"eric_wade_brown@yahoo.com","username":"ericwb"},"change_message_id":"feaff394f18c84ca9f8efa6c1e6c936f14779d7f","unresolved":false,"context_lines":[{"line_number":2343,"context_line":""},{"line_number":2344,"context_line":"        self.assertEqual(cfg.devices[4].type, \"tablet\")"},{"line_number":2345,"context_line":"        self.assertEqual(cfg.devices[5].type, \"vnc\")"},{"line_number":2346,"context_line":"        self.assertEqual(cfg.devices[5].password, self.test_instance[\"uuid\"])"},{"line_number":2347,"context_line":""},{"line_number":2348,"context_line":"    def test_get_guest_config_with_spice_and_tablet(self):"},{"line_number":2349,"context_line":"        self.flags(enabled\u003dFalse, group\u003d\u0027vnc\u0027)"}],"source_content_type":"text/x-python","patch_set":1,"id":"9a41bdd9_72500fd5","line":2346,"updated":"2015-07-18 04:59:58.000000000","message":"assertEqual(expected, actual)","commit_id":"1839a122c7f3c8814f576ec86bf1b217806c1ab2"},{"author":{"_account_id":2711,"name":"Zhang Hua","display_name":"Zhang Hua","email":"joshua.zhang@canonical.com","username":"zhhuabj"},"change_message_id":"5d7e428f054df2d3de10dff542e3ca6273282776","unresolved":false,"context_lines":[{"line_number":2343,"context_line":""},{"line_number":2344,"context_line":"        self.assertEqual(cfg.devices[4].type, \"tablet\")"},{"line_number":2345,"context_line":"        self.assertEqual(cfg.devices[5].type, \"vnc\")"},{"line_number":2346,"context_line":"        self.assertEqual(cfg.devices[5].password, self.test_instance[\"uuid\"])"},{"line_number":2347,"context_line":""},{"line_number":2348,"context_line":"    def test_get_guest_config_with_spice_and_tablet(self):"},{"line_number":2349,"context_line":"        self.flags(enabled\u003dFalse, group\u003d\u0027vnc\u0027)"}],"source_content_type":"text/x-python","patch_set":1,"id":"9a41bdd9_4b4e76c2","line":2346,"in_reply_to":"9a41bdd9_72500fd5","updated":"2015-07-18 10:24:44.000000000","message":"Done","commit_id":"1839a122c7f3c8814f576ec86bf1b217806c1ab2"}],"nova/virt/libvirt/driver.py":[{"author":{"_account_id":8119,"name":"Eric Brown","email":"eric_wade_brown@yahoo.com","username":"ericwb"},"change_message_id":"feaff394f18c84ca9f8efa6c1e6c936f14779d7f","unresolved":false,"context_lines":[{"line_number":4122,"context_line":"            graphics.keymap \u003d CONF.vnc.keymap"},{"line_number":4123,"context_line":"            graphics.listen \u003d CONF.vnc.vncserver_listen"},{"line_number":4124,"context_line":"            if CONF.vnc.enable_vnc_password:"},{"line_number":4125,"context_line":"                graphics.password \u003d instance[\"uuid\"]"},{"line_number":4126,"context_line":"            guest.add_device(graphics)"},{"line_number":4127,"context_line":"            add_video_driver \u003d True"},{"line_number":4128,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"9a41bdd9_323a8799","line":4125,"updated":"2015-07-18 04:59:58.000000000","message":"Not sure about this.  Does a user have to type in formated uuid like de305d54-75b4-431b-adb2-eb6b9e546014?  What if hyphens are missing? \n\nIn any case this can be a ton to type.  I\u0027d rather see a way a password is generated and given to the user.","commit_id":"1839a122c7f3c8814f576ec86bf1b217806c1ab2"},{"author":{"_account_id":2711,"name":"Zhang Hua","display_name":"Zhang Hua","email":"joshua.zhang@canonical.com","username":"zhhuabj"},"change_message_id":"5d7e428f054df2d3de10dff542e3ca6273282776","unresolved":false,"context_lines":[{"line_number":4122,"context_line":"            graphics.keymap \u003d CONF.vnc.keymap"},{"line_number":4123,"context_line":"            graphics.listen \u003d CONF.vnc.vncserver_listen"},{"line_number":4124,"context_line":"            if CONF.vnc.enable_vnc_password:"},{"line_number":4125,"context_line":"                graphics.password \u003d instance[\"uuid\"]"},{"line_number":4126,"context_line":"            guest.add_device(graphics)"},{"line_number":4127,"context_line":"            add_video_driver \u003d True"},{"line_number":4128,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"9a41bdd9_4baaf61a","line":4125,"in_reply_to":"9a41bdd9_323a8799","updated":"2015-07-18 10:24:44.000000000","message":"Eric, \nthanks for your review, \nuuid should not be empty,  in contrast, other fields like name may be missing.\nuuid is not hard to type, just some letters. use other generated password will require adding db field to store it. \nso I select uuid as default initial password.","commit_id":"1839a122c7f3c8814f576ec86bf1b217806c1ab2"},{"author":{"_account_id":1653,"name":"garyk","email":"gkotton@vmware.com","username":"garyk"},"change_message_id":"1bf5a581efc20f194f89177bd2fe45775f35b4db","unresolved":false,"context_lines":[{"line_number":4122,"context_line":"            graphics.keymap \u003d CONF.vnc.keymap"},{"line_number":4123,"context_line":"            graphics.listen \u003d CONF.vnc.vncserver_listen"},{"line_number":4124,"context_line":"            if CONF.vnc.enable_vnc_password:"},{"line_number":4125,"context_line":"                graphics.password \u003d instance[\"uuid\"]"},{"line_number":4126,"context_line":"            guest.add_device(graphics)"},{"line_number":4127,"context_line":"            add_video_driver \u003d True"},{"line_number":4128,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"9a41bdd9_41fc173e","line":4125,"updated":"2015-07-18 12:41:39.000000000","message":"instance should be a object. please use instance.uuid","commit_id":"b619505657f20b129e66d66c810c631d20a8c6e9"}],"nova/vnc/__init__.py":[{"author":{"_account_id":8119,"name":"Eric Brown","email":"eric_wade_brown@yahoo.com","username":"ericwb"},"change_message_id":"feaff394f18c84ca9f8efa6c1e6c936f14779d7f","unresolved":false,"context_lines":[{"line_number":55,"context_line":"               deprecated_name\u003d\u0027vnc_keymap\u0027),"},{"line_number":56,"context_line":"    cfg.BoolOpt(\u0027enable_vnc_password\u0027,"},{"line_number":57,"context_line":"                default\u003dFalse,"},{"line_number":58,"context_line":"                help\u003d\u0027Enable VNC password or not\u0027),"},{"line_number":59,"context_line":"    ]"},{"line_number":60,"context_line":""},{"line_number":61,"context_line":"CONF \u003d cfg.CONF"}],"source_content_type":"text/x-python","patch_set":1,"id":"9a41bdd9_52be2b00","line":58,"updated":"2015-07-18 04:59:58.000000000","message":"since you default to uuid, this has to be documented somewhere.  Here would be one good place and in the nova docs the other.","commit_id":"1839a122c7f3c8814f576ec86bf1b217806c1ab2"},{"author":{"_account_id":2711,"name":"Zhang Hua","display_name":"Zhang Hua","email":"joshua.zhang@canonical.com","username":"zhhuabj"},"change_message_id":"5d7e428f054df2d3de10dff542e3ca6273282776","unresolved":false,"context_lines":[{"line_number":55,"context_line":"               deprecated_name\u003d\u0027vnc_keymap\u0027),"},{"line_number":56,"context_line":"    cfg.BoolOpt(\u0027enable_vnc_password\u0027,"},{"line_number":57,"context_line":"                default\u003dFalse,"},{"line_number":58,"context_line":"                help\u003d\u0027Enable VNC password or not\u0027),"},{"line_number":59,"context_line":"    ]"},{"line_number":60,"context_line":""},{"line_number":61,"context_line":"CONF \u003d cfg.CONF"}],"source_content_type":"text/x-python","patch_set":1,"id":"9a41bdd9_cb592690","line":58,"in_reply_to":"9a41bdd9_52be2b00","updated":"2015-07-18 10:24:44.000000000","message":"Done","commit_id":"1839a122c7f3c8814f576ec86bf1b217806c1ab2"},{"author":{"_account_id":1653,"name":"garyk","email":"gkotton@vmware.com","username":"garyk"},"change_message_id":"1bf5a581efc20f194f89177bd2fe45775f35b4db","unresolved":false,"context_lines":[{"line_number":56,"context_line":"    cfg.BoolOpt(\u0027enable_vnc_password\u0027,"},{"line_number":57,"context_line":"                default\u003dFalse,"},{"line_number":58,"context_line":"                help\u003d\u0027Enable VNC password or not, the default \u0027"},{"line_number":59,"context_line":"                     \u0027is the instance uuid\u0027),"},{"line_number":60,"context_line":"    ]"},{"line_number":61,"context_line":""},{"line_number":62,"context_line":"CONF \u003d cfg.CONF"}],"source_content_type":"text/x-python","patch_set":2,"id":"9a41bdd9_c1b5877e","line":59,"updated":"2015-07-18 12:41:39.000000000","message":"The comment here is a little misleading - if enabled the password will be the instance uuid","commit_id":"b619505657f20b129e66d66c810c631d20a8c6e9"}]}