)]}'
{"nova/conductor/manager.py":[{"author":{"_account_id":5511,"name":"Nikola Dipanov","email":"ndipanov@redhat.com","username":"ndipanov"},"change_message_id":"9c3723fffbd55139a7c3206c165f09fbdfe4ec50","unresolved":false,"context_lines":[{"line_number":751,"context_line":"    def _schedule_instances(self, context, image, filter_properties,"},{"line_number":752,"context_line":"            *instances):"},{"line_number":753,"context_line":"        request_spec \u003d scheduler_utils.build_request_spec(context, image,"},{"line_number":754,"context_line":"                instances)"},{"line_number":755,"context_line":"        scheduler_utils.setup_instance_group(context, request_spec,"},{"line_number":756,"context_line":"                                             filter_properties)"},{"line_number":757,"context_line":"        # TODO(sbauza): Hydrate here the object until we modify the"}],"source_content_type":"text/x-python","patch_set":11,"id":"3a50d1a3_b9234404","line":754,"updated":"2015-07-29 16:43:47.000000000","message":"This is kind of ugly - why don\u0027t we get rid of this crap now we don\u0027t need it here anymore. We should in theory be able to kill build_request_spec now as we have that logic encapsulated in the backporting code.\n\nAnd also we can get rid of from_primitives really and just leave the backporting code in the object.","commit_id":"a42d71ea16716bbc33fc08e49ee7f1702ef1b649"},{"author":{"_account_id":7166,"name":"Sylvain Bauza","email":"sbauza@redhat.com","username":"sbauza"},"change_message_id":"83bb5372226707e2d51f89cb094da26d58b7fc29","unresolved":false,"context_lines":[{"line_number":751,"context_line":"    def _schedule_instances(self, context, image, filter_properties,"},{"line_number":752,"context_line":"            *instances):"},{"line_number":753,"context_line":"        request_spec \u003d scheduler_utils.build_request_spec(context, image,"},{"line_number":754,"context_line":"                instances)"},{"line_number":755,"context_line":"        scheduler_utils.setup_instance_group(context, request_spec,"},{"line_number":756,"context_line":"                                             filter_properties)"},{"line_number":757,"context_line":"        # TODO(sbauza): Hydrate here the object until we modify the"}],"source_content_type":"text/x-python","patch_set":11,"id":"3a50d1a3_af074180","line":754,"in_reply_to":"3a50d1a3_b9234404","updated":"2015-07-30 15:15:47.000000000","message":"Agreed, I was seeing this change as a way to use the RequestSpec object in the conductor without too much changing the code at once.\n\nFor sure, the next patch will remove the now unnecessary build_request_spec() and either adapt or remove setup_instance_group and populate_retry()","commit_id":"a42d71ea16716bbc33fc08e49ee7f1702ef1b649"},{"author":{"_account_id":782,"name":"John Garbutt","email":"john@johngarbutt.com","username":"johngarbutt"},"change_message_id":"2da22db98b6d6ee67c19758a4e69119616bdba63","unresolved":false,"context_lines":[{"line_number":393,"context_line":"        scheduler_utils.setup_instance_group(context, request_spec,"},{"line_number":394,"context_line":"                                             filter_properties)"},{"line_number":395,"context_line":"        # TODO(sbauza): Hydrate here the object until we modify the"},{"line_number":396,"context_line":"        # scheduler.utils methods to directly use the RequestSpec object"},{"line_number":397,"context_line":"        spec_obj \u003d objects.RequestSpec.from_primitives("},{"line_number":398,"context_line":"            context, request_spec, filter_properties)"},{"line_number":399,"context_line":"        hosts \u003d self.scheduler_client.select_destinations(context, spec_obj)"}],"source_content_type":"text/x-python","patch_set":34,"id":"9a8ffd7b_e68f0873","line":396,"updated":"2015-11-27 16:37:31.000000000","message":"I don\u0027t see a patch up for that change?","commit_id":"98dff9918155799f2f49d09ef2f14e699a814b1d"},{"author":{"_account_id":782,"name":"John Garbutt","email":"john@johngarbutt.com","username":"johngarbutt"},"change_message_id":"cb26419a27a5787146188cb84b42011ff29e45d2","unresolved":false,"context_lines":[{"line_number":393,"context_line":"        scheduler_utils.setup_instance_group(context, request_spec,"},{"line_number":394,"context_line":"                                             filter_properties)"},{"line_number":395,"context_line":"        # TODO(sbauza): Hydrate here the object until we modify the"},{"line_number":396,"context_line":"        # scheduler.utils methods to directly use the RequestSpec object"},{"line_number":397,"context_line":"        spec_obj \u003d objects.RequestSpec.from_primitives("},{"line_number":398,"context_line":"            context, request_spec, filter_properties)"},{"line_number":399,"context_line":"        hosts \u003d self.scheduler_client.select_destinations(context, spec_obj)"}],"source_content_type":"text/x-python","patch_set":35,"id":"7a740942_04e84db3","line":396,"updated":"2015-12-07 11:44:38.000000000","message":"Nit: I would like to see this done in scheduler.utils as well really.","commit_id":"ded0de217964bd5247b44a2469b810ab246b8a18"},{"author":{"_account_id":5511,"name":"Nikola Dipanov","email":"ndipanov@redhat.com","username":"ndipanov"},"change_message_id":"5c1cea4273c4c2fcc2d8c7ee8c6200f1418585fd","unresolved":false,"context_lines":[{"line_number":399,"context_line":"                                             filter_properties)"},{"line_number":400,"context_line":"        # TODO(sbauza): Hydrate here the object until we modify the"},{"line_number":401,"context_line":"        # scheduler.utils methods to directly use the RequestSpec object"},{"line_number":402,"context_line":"        spec_obj \u003d objects.RequestSpec.from_primitives("},{"line_number":403,"context_line":"            context, request_spec, filter_properties)"},{"line_number":404,"context_line":"        hosts \u003d self.scheduler_client.select_destinations(context, spec_obj)"},{"line_number":405,"context_line":"        return hosts"},{"line_number":406,"context_line":""}],"source_content_type":"text/x-python","patch_set":37,"id":"5a710552_d7820b94","line":403,"range":{"start_line":402,"start_character":9,"end_line":403,"end_character":53},"updated":"2015-12-16 11:55:11.000000000","message":"This is useless - we undo this literally in the next line!","commit_id":"f32377bcdf672b0ba2aa69985171fc1ff4246b0f"},{"author":{"_account_id":5511,"name":"Nikola Dipanov","email":"ndipanov@redhat.com","username":"ndipanov"},"change_message_id":"92197fb1f98a94399687b09778c90595473e6548","unresolved":false,"context_lines":[{"line_number":399,"context_line":"                                             filter_properties)"},{"line_number":400,"context_line":"        # TODO(sbauza): Hydrate here the object until we modify the"},{"line_number":401,"context_line":"        # scheduler.utils methods to directly use the RequestSpec object"},{"line_number":402,"context_line":"        spec_obj \u003d objects.RequestSpec.from_primitives("},{"line_number":403,"context_line":"            context, request_spec, filter_properties)"},{"line_number":404,"context_line":"        hosts \u003d self.scheduler_client.select_destinations(context, spec_obj)"},{"line_number":405,"context_line":"        return hosts"},{"line_number":406,"context_line":""}],"source_content_type":"text/x-python","patch_set":37,"id":"3a7e1126_915d4c7b","line":403,"range":{"start_line":402,"start_character":9,"end_line":403,"end_character":53},"in_reply_to":"5a710552_d7820b94","updated":"2015-12-18 17:06:06.000000000","message":"on second thought, even thought it\u0027s useless, it goes away in the next patch so we don\u0027t need to block on this.","commit_id":"f32377bcdf672b0ba2aa69985171fc1ff4246b0f"}],"nova/conductor/tasks/migrate.py":[{"author":{"_account_id":782,"name":"John Garbutt","email":"john@johngarbutt.com","username":"johngarbutt"},"change_message_id":"2da22db98b6d6ee67c19758a4e69119616bdba63","unresolved":false,"context_lines":[{"line_number":39,"context_line":"                                             self.filter_properties)"},{"line_number":40,"context_line":"        scheduler_utils.populate_retry(self.filter_properties,"},{"line_number":41,"context_line":"                                       self.instance.uuid)"},{"line_number":42,"context_line":"        # TODO(sbauza): Hydrate here the object until we modify the"},{"line_number":43,"context_line":"        # scheduler.utils methods to directly use the RequestSpec object"},{"line_number":44,"context_line":"        spec_obj \u003d objects.RequestSpec.from_primitives("},{"line_number":45,"context_line":"            self.context, self.request_spec, self.filter_properties)"}],"source_content_type":"text/x-python","patch_set":34,"id":"9a8ffd7b_06500cd3","line":42,"updated":"2015-11-27 16:37:31.000000000","message":"same nit.","commit_id":"98dff9918155799f2f49d09ef2f14e699a814b1d"}],"nova/scheduler/rpcapi.py":[{"author":{"_account_id":782,"name":"John Garbutt","email":"john@johngarbutt.com","username":"johngarbutt"},"change_message_id":"d817aca8340407eaa6797d477d98e1ad29a8ca1a","unresolved":false,"context_lines":[{"line_number":105,"context_line":"        self.client \u003d rpc.get_client(target, version_cap\u003dversion_cap,"},{"line_number":106,"context_line":"                                     serializer\u003dserializer)"},{"line_number":107,"context_line":""},{"line_number":108,"context_line":"    def select_destinations(self, ctxt, spec_obj):"},{"line_number":109,"context_line":"        cctxt \u003d self.client.prepare(version\u003d\u00274.0\u0027)"},{"line_number":110,"context_line":"        # TODO(sbauza): Provide directly the RequestSpec object as an arg"},{"line_number":111,"context_line":"        # once the RPC API is modified for that."}],"source_content_type":"text/x-python","patch_set":36,"id":"7a740942_153d7d2a","line":108,"updated":"2015-12-14 13:52:47.000000000","message":"I am not sure I like modifying this separate to changing the interface, but it does help stage this.","commit_id":"8b8742b1cda9a6c70f1611945f4994db3a3d6ad7"},{"author":{"_account_id":7166,"name":"Sylvain Bauza","email":"sbauza@redhat.com","username":"sbauza"},"change_message_id":"60f6bf9e69203a9e0971f72b959e70a396f8a707","unresolved":false,"context_lines":[{"line_number":105,"context_line":"        self.client \u003d rpc.get_client(target, version_cap\u003dversion_cap,"},{"line_number":106,"context_line":"                                     serializer\u003dserializer)"},{"line_number":107,"context_line":""},{"line_number":108,"context_line":"    def select_destinations(self, ctxt, spec_obj):"},{"line_number":109,"context_line":"        cctxt \u003d self.client.prepare(version\u003d\u00274.0\u0027)"},{"line_number":110,"context_line":"        # TODO(sbauza): Provide directly the RequestSpec object as an arg"},{"line_number":111,"context_line":"        # once the RPC API is modified for that."}],"source_content_type":"text/x-python","patch_set":36,"id":"5a710552_c4b6173d","line":108,"in_reply_to":"7a740942_153d7d2a","updated":"2015-12-15 11:30:13.000000000","message":"Sure, I can respin","commit_id":"8b8742b1cda9a6c70f1611945f4994db3a3d6ad7"}]}