)]}'
{"nova/network/linux_net.py":[{"author":{"_account_id":4190,"name":"lifeless","email":"robertc@robertcollins.net","username":"lifeless"},"change_message_id":"fea2c387892bd65400557fa65c92b230f98c5b70","unresolved":false,"context_lines":[{"line_number":409,"context_line":"            fake_table \u003d [\u0027#Generated by nova\u0027,"},{"line_number":410,"context_line":"                          \u0027*\u0027 + table_name, \u0027COMMIT\u0027,"},{"line_number":411,"context_line":"                          \u0027#Completed by nova\u0027]"},{"line_number":412,"context_line":"            current_lines \u003d fake_table"},{"line_number":413,"context_line":""},{"line_number":414,"context_line":"        # Remove any trace of our rules"},{"line_number":415,"context_line":"        new_filter \u003d filter(lambda line: binary_name not in line,"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAAM3%2F%2FYlE%3D","line":412,"updated":"2013-01-24 16:56:58.000000000","message":"This will do the wrong thing if \u0027not current_lines\u0027 and \u0027table_name is None\u0027 - it should raise in that case.\n\nseparately, shouldn\u0027t the lines for the table go *between* the * tablename \u0026 the COMMIT? I\u0027d like to see a test that confirms that the actual output is fully correct.","commit_id":"030fdd1a55bbd9056fbaeb3145461ad3000b9282"},{"author":{"_account_id":1726,"name":"Ghe Rivero","email":"ghe.rivero@gmail.com","username":"ghe.rivero"},"change_message_id":"c5081ba60d334613ec8db8adcd2aec14d210ec34","unresolved":false,"context_lines":[{"line_number":409,"context_line":"            fake_table \u003d [\u0027#Generated by nova\u0027,"},{"line_number":410,"context_line":"                          \u0027*\u0027 + table_name, \u0027COMMIT\u0027,"},{"line_number":411,"context_line":"                          \u0027#Completed by nova\u0027]"},{"line_number":412,"context_line":"            current_lines \u003d fake_table"},{"line_number":413,"context_line":""},{"line_number":414,"context_line":"        # Remove any trace of our rules"},{"line_number":415,"context_line":"        new_filter \u003d filter(lambda line: binary_name not in line,"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAAM3%2F%2FYik%3D","line":412,"in_reply_to":"AAAAM3%2F%2FYlE%3D","updated":"2013-01-24 17:11:46.000000000","message":"1.- Yes. But since _modify_rules is a \"private\" method, table_name will always have a value (unless someone use None as a key for a dict). Could include it anyway.\n\n2.- Agree. This should be added, but not just for this bug, but for all cases, and also that the rules created are valid. Will create another bug/patch for that case.","commit_id":"030fdd1a55bbd9056fbaeb3145461ad3000b9282"}]}