)]}'
{"nova/objects/base.py":[{"author":{"_account_id":5754,"name":"Alex Xu","email":"hejie.xu@intel.com","username":"xuhj"},"change_message_id":"4b913ed64d060cc3429a837a42a8451ac27ec37f","unresolved":false,"context_lines":[{"line_number":30,"context_line":"from nova import objects"},{"line_number":31,"context_line":"from nova.objects import fields as obj_fields"},{"line_number":32,"context_line":"from nova import utils"},{"line_number":33,"context_line":""},{"line_number":34,"context_line":""},{"line_number":35,"context_line":"LOG \u003d logging.getLogger(\u0027object\u0027)"},{"line_number":36,"context_line":""}],"source_content_type":"text/x-python","patch_set":24,"id":"9a8ffd7b_1638ba9f","side":"PARENT","line":33,"updated":"2015-11-25 12:23:24.000000000","message":"This is unrelated change.","commit_id":"0140dbe3897e6fffbf649ae3eb39274ff4da6044"},{"author":{"_account_id":9796,"name":"ChangBo Guo","email":"glongwave@gmail.com","username":"gcb"},"change_message_id":"32b6649457032eaa46bf3e2795626155ecea2030","unresolved":false,"context_lines":[{"line_number":30,"context_line":"from nova import objects"},{"line_number":31,"context_line":"from nova.objects import fields as obj_fields"},{"line_number":32,"context_line":"from nova import utils"},{"line_number":33,"context_line":""},{"line_number":34,"context_line":""},{"line_number":35,"context_line":"LOG \u003d logging.getLogger(\u0027object\u0027)"},{"line_number":36,"context_line":""}],"source_content_type":"text/x-python","patch_set":24,"id":"9a8ffd7b_81ed46f1","side":"PARENT","line":33,"in_reply_to":"9a8ffd7b_1638ba9f","updated":"2015-11-25 12:26:21.000000000","message":"Done","commit_id":"0140dbe3897e6fffbf649ae3eb39274ff4da6044"}],"nova/scheduler/filters/image_props_filter.py":[{"author":{"_account_id":5754,"name":"Alex Xu","email":"hejie.xu@intel.com","username":"xuhj"},"change_message_id":"1fc6db283ca338c228f5e087dd37fed78e02a526","unresolved":false,"context_lines":[{"line_number":78,"context_line":"                return True"},{"line_number":79,"context_line":"            img_prop_predicate \u003d versionpredicate.VersionPredicate("},{"line_number":80,"context_line":"                \u0027image_prop (%s)\u0027 % version_required)"},{"line_number":81,"context_line":"            hyper_ver_str \u003d versionutils.convert_version_to_str(hyper_version)"},{"line_number":82,"context_line":"            return img_prop_predicate.satisfied_by(hyper_ver_str)"},{"line_number":83,"context_line":""},{"line_number":84,"context_line":"        for supp_inst in supp_instances:"}],"source_content_type":"text/x-python","patch_set":10,"id":"ba15a1d1_a1d0e4ca","line":81,"updated":"2015-09-12 06:41:53.000000000","message":"This isn\u0027t object version. So oslo.versionedobject for other thing., so I don\u0027t think we should change this.","commit_id":"13ab641bc96db324a70f8ccebea1ebf1061ac64f"}],"nova/tests/unit/objects/test_objects.py":[{"author":{"_account_id":7166,"name":"Sylvain Bauza","email":"sbauza@redhat.com","username":"sbauza"},"change_message_id":"77754f03d14487f8355ece808e7c52113abfdcf1","unresolved":false,"context_lines":[{"line_number":1698,"context_line":"                curr_child_ver \u003d child_class.VERSION"},{"line_number":1699,"context_line":"                tup_curr_child_ver \u003d utils.convert_version_to_tuple("},{"line_number":1700,"context_line":"                                        curr_child_ver)"},{"line_number":1701,"context_line":""},{"line_number":1702,"context_line":"                for parent_ver, child_ver in versions:"},{"line_number":1703,"context_line":"                    tup_version \u003d utils.convert_version_to_tuple(child_ver)"},{"line_number":1704,"context_line":"                    self.assertTrue(tup_version \u003c\u003d tup_curr_child_ver,"}],"source_content_type":"text/x-python","patch_set":10,"id":"ba15a1d1_9ad9de58","side":"PARENT","line":1701,"updated":"2015-09-23 21:23:51.000000000","message":"nit: the line removal isn\u0027t necessary","commit_id":"9e180b2df4ce4bab7729c377c6bbf64190a9626e"},{"author":{"_account_id":9796,"name":"ChangBo Guo","email":"glongwave@gmail.com","username":"gcb"},"change_message_id":"de9ba59fddf2f31b2747e98dda529cac04cab7d6","unresolved":false,"context_lines":[{"line_number":1698,"context_line":"                curr_child_ver \u003d child_class.VERSION"},{"line_number":1699,"context_line":"                tup_curr_child_ver \u003d utils.convert_version_to_tuple("},{"line_number":1700,"context_line":"                                        curr_child_ver)"},{"line_number":1701,"context_line":""},{"line_number":1702,"context_line":"                for parent_ver, child_ver in versions:"},{"line_number":1703,"context_line":"                    tup_version \u003d utils.convert_version_to_tuple(child_ver)"},{"line_number":1704,"context_line":"                    self.assertTrue(tup_version \u003c\u003d tup_curr_child_ver,"}],"source_content_type":"text/x-python","patch_set":10,"id":"9a1a9d01_52a8ff1f","side":"PARENT","line":1701,"in_reply_to":"ba15a1d1_9ad9de58","updated":"2015-09-30 02:23:12.000000000","message":"will  fix this in next patch.","commit_id":"9e180b2df4ce4bab7729c377c6bbf64190a9626e"}],"nova/utils.py":[{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"6474be3edabf2d1a771fa8c6e97b87481ceb029c","unresolved":false,"context_lines":[{"line_number":1219,"context_line":"        if isinstance(version, tuple):"},{"line_number":1220,"context_line":"            return six.moves.reduce(lambda x, y: (x * 1000) + y, version)"},{"line_number":1221,"context_line":"    except Exception:"},{"line_number":1222,"context_line":"        msg \u003d _(\"Hypervisor version %s is invalid.\") % version"},{"line_number":1223,"context_line":"        raise exception.NovaException(msg)"},{"line_number":1224,"context_line":""},{"line_number":1225,"context_line":""}],"source_content_type":"text/x-python","patch_set":15,"id":"3a29b11f_69043f17","side":"PARENT","line":1222,"updated":"2015-10-21 20:20:29.000000000","message":"The only complaints here are that we lose the \u0027Hypervisor\u0027 prefix...","commit_id":"542552754d8da0a97cde32f07a777179c4be608f"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"6474be3edabf2d1a771fa8c6e97b87481ceb029c","unresolved":false,"context_lines":[{"line_number":1220,"context_line":"            return six.moves.reduce(lambda x, y: (x * 1000) + y, version)"},{"line_number":1221,"context_line":"    except Exception:"},{"line_number":1222,"context_line":"        msg \u003d _(\"Hypervisor version %s is invalid.\") % version"},{"line_number":1223,"context_line":"        raise exception.NovaException(msg)"},{"line_number":1224,"context_line":""},{"line_number":1225,"context_line":""},{"line_number":1226,"context_line":"def convert_version_to_str(version_int):"}],"source_content_type":"text/x-python","patch_set":15,"id":"3a29b11f_542d5693","side":"PARENT","line":1223,"updated":"2015-10-21 20:20:29.000000000","message":"...and that the exception type changes from \u0027exception.NovaException\u0027 to \u0027ValueError\u0027. The former change probably doesn\u0027t matter while I see no code that should be affected by the latter.","commit_id":"542552754d8da0a97cde32f07a777179c4be608f"}],"nova/virt/vmwareapi/driver.py":[{"author":{"_account_id":1653,"name":"garyk","email":"gkotton@vmware.com","username":"garyk"},"change_message_id":"2a35e901b345e7cc9e3909fa8d6e5c6706529092","unresolved":false,"context_lines":[{"line_number":25,"context_line":"from oslo_log import log as logging"},{"line_number":26,"context_line":"from oslo_serialization import jsonutils"},{"line_number":27,"context_line":"from oslo_utils import excutils"},{"line_number":28,"context_line":"from oslo_utils import versionutils"},{"line_number":29,"context_line":"from oslo_vmware import api"},{"line_number":30,"context_line":"from oslo_vmware import exceptions as vexc"},{"line_number":31,"context_line":"from oslo_vmware import pbm"}],"source_content_type":"text/x-python","patch_set":20,"id":"ba8a016a_9741063c","line":28,"updated":"2015-11-23 09:13:08.000000000","message":"consider v_utils then the lines below will not need to be changed\n\nfrom oslo_utils import versionutils as v_utils\n\nthen:\n\nmin_version \u003d v_utils.convert_version_to_int(                                                   constants.MIN_VC_VERSION)","commit_id":"e3afbb81c2cc7896f2f2f0a419f9ec0cad4ac402"},{"author":{"_account_id":9796,"name":"ChangBo Guo","email":"glongwave@gmail.com","username":"gcb"},"change_message_id":"8ea0132b1b618d690af0958eb553e702b392953f","unresolved":false,"context_lines":[{"line_number":25,"context_line":"from oslo_log import log as logging"},{"line_number":26,"context_line":"from oslo_serialization import jsonutils"},{"line_number":27,"context_line":"from oslo_utils import excutils"},{"line_number":28,"context_line":"from oslo_utils import versionutils"},{"line_number":29,"context_line":"from oslo_vmware import api"},{"line_number":30,"context_line":"from oslo_vmware import exceptions as vexc"},{"line_number":31,"context_line":"from oslo_vmware import pbm"}],"source_content_type":"text/x-python","patch_set":20,"id":"ba8a016a_efdcfde5","line":28,"in_reply_to":"ba8a016a_9741063c","updated":"2015-11-24 09:51:12.000000000","message":"will update in next patch set","commit_id":"e3afbb81c2cc7896f2f2f0a419f9ec0cad4ac402"}]}