)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":1653,"name":"garyk","email":"gkotton@vmware.com","username":"garyk"},"change_message_id":"6a2e7d82b9ba9eb34561438326e61db7fcab07f1","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     Jeffrey Zhang \u003czhang.lei.fly@gmail.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2015-07-20 14:37:22 +0800"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Add total_vms filed in API"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"* bump the api version to 2.7"},{"line_number":10,"context_line":"* add the total_vms to api"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"3a50d1a3_c1c90bae","line":7,"range":{"start_line":7,"start_character":14,"end_line":7,"end_character":19},"updated":"2015-07-27 06:55:46.000000000","message":"filed \u003d\u003e field","commit_id":"8da7c49dd960d92022c83016987a25b07f3a808c"},{"author":{"_account_id":7488,"name":"Jeffrey Zhang","email":"zhang.lei.fly@gmail.com","username":"Jeffrey4l"},"change_message_id":"3cf955fa5b5b78b5898f7ea738d026df42942d4a","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     Jeffrey Zhang \u003czhang.lei.fly@gmail.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2015-07-20 14:37:22 +0800"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Add total_vms filed in API"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"* bump the api version to 2.7"},{"line_number":10,"context_line":"* add the total_vms to api"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"3a50d1a3_32e59ba7","line":7,"in_reply_to":"3a50d1a3_c1c90bae","updated":"2015-07-27 10:58:32.000000000","message":"Done. thanks.","commit_id":"8da7c49dd960d92022c83016987a25b07f3a808c"}],"nova/api/openstack/api_version_request.py":[{"author":{"_account_id":6062,"name":"jichenjc","email":"jichenjc@cn.ibm.com","username":"jichenjc"},"change_message_id":"e9a696384f870ee2b13fe77ba379da63886ab5a7","unresolved":false,"context_lines":[{"line_number":54,"context_line":"# Note(cyeoh): This only applies for the v2.1 API once microversions"},{"line_number":55,"context_line":"# support is fully merged. It does not affect the V2 API."},{"line_number":56,"context_line":"_MIN_API_VERSION \u003d \"2.1\""},{"line_number":57,"context_line":"_MAX_API_VERSION \u003d \"2.7\""},{"line_number":58,"context_line":"DEFAULT_API_VERSION \u003d _MIN_API_VERSION"},{"line_number":59,"context_line":""},{"line_number":60,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"3a50d1a3_88c5ad5c","line":57,"updated":"2015-07-20 08:06:36.000000000","message":"this is not enough... you need to change other \n\nrefer to source/api_microversion_dev.rst","commit_id":"8da7c49dd960d92022c83016987a25b07f3a808c"},{"author":{"_account_id":7488,"name":"Jeffrey Zhang","email":"zhang.lei.fly@gmail.com","username":"Jeffrey4l"},"change_message_id":"cddff14465f75494f097c090dc6f8f3a50c41b71","unresolved":false,"context_lines":[{"line_number":54,"context_line":"# Note(cyeoh): This only applies for the v2.1 API once microversions"},{"line_number":55,"context_line":"# support is fully merged. It does not affect the V2 API."},{"line_number":56,"context_line":"_MIN_API_VERSION \u003d \"2.1\""},{"line_number":57,"context_line":"_MAX_API_VERSION \u003d \"2.7\""},{"line_number":58,"context_line":"DEFAULT_API_VERSION \u003d _MIN_API_VERSION"},{"line_number":59,"context_line":""},{"line_number":60,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"3a50d1a3_b5eebdea","line":57,"in_reply_to":"3a50d1a3_88c5ad5c","updated":"2015-07-21 00:08:09.000000000","message":"thanks. \nI will add that.","commit_id":"8da7c49dd960d92022c83016987a25b07f3a808c"}],"nova/api/openstack/compute/contrib/hypervisors.py":[{"author":{"_account_id":6062,"name":"jichenjc","email":"jichenjc@cn.ibm.com","username":"jichenjc"},"change_message_id":"f29d1739c2dac8f9e71faade88073e9f54ce12f5","unresolved":false,"context_lines":[{"line_number":95,"context_line":"        compute_nodes \u003d self.host_api.compute_node_get_all(context)"},{"line_number":96,"context_line":"        req.cache_db_compute_nodes(compute_nodes)"},{"line_number":97,"context_line":"        return dict(hypervisors\u003d[self._view_hypervisor("},{"line_number":98,"context_line":"                                 req,"},{"line_number":99,"context_line":"                                 hyp,"},{"line_number":100,"context_line":"                                 self.host_api.service_get_by_compute_host("},{"line_number":101,"context_line":"                                     context, hyp.host),"}],"source_content_type":"text/x-python","patch_set":2,"id":"3a50d1a3_488d6530","line":98,"updated":"2015-07-20 08:07:19.000000000","message":"should we change v2?","commit_id":"8da7c49dd960d92022c83016987a25b07f3a808c"},{"author":{"_account_id":7488,"name":"Jeffrey Zhang","email":"zhang.lei.fly@gmail.com","username":"Jeffrey4l"},"change_message_id":"cddff14465f75494f097c090dc6f8f3a50c41b71","unresolved":false,"context_lines":[{"line_number":95,"context_line":"        compute_nodes \u003d self.host_api.compute_node_get_all(context)"},{"line_number":96,"context_line":"        req.cache_db_compute_nodes(compute_nodes)"},{"line_number":97,"context_line":"        return dict(hypervisors\u003d[self._view_hypervisor("},{"line_number":98,"context_line":"                                 req,"},{"line_number":99,"context_line":"                                 hyp,"},{"line_number":100,"context_line":"                                 self.host_api.service_get_by_compute_host("},{"line_number":101,"context_line":"                                     context, hyp.host),"}],"source_content_type":"text/x-python","patch_set":2,"id":"3a50d1a3_b569dd8d","line":98,"in_reply_to":"3a50d1a3_488d6530","updated":"2015-07-21 00:08:09.000000000","message":"The v2 and v2.1/v3 unittest use the same function signature[0][1]. So this is needed for that. Event though, it is no use in the v2\u0027s code.\n\n[0] https://github.com/openstack/nova/blob/76a97a8d7a04d5e425012ded5ec69cc05765588f/nova/tests/unit/api/openstack/compute/contrib/test_extended_hypervisors.py#L83\n[1] https://github.com/openstack/nova/blob/76a97a8d7a04d5e425012ded5ec69cc05765588f/nova/tests/unit/api/openstack/compute/contrib/test_extended_hypervisors.py#L103","commit_id":"8da7c49dd960d92022c83016987a25b07f3a808c"}],"nova/compute/stats.py":[{"author":{"_account_id":6062,"name":"jichenjc","email":"jichenjc@cn.ibm.com","username":"jichenjc"},"change_message_id":"e9a696384f870ee2b13fe77ba379da63886ab5a7","unresolved":false,"context_lines":[{"line_number":93,"context_line":""},{"line_number":94,"context_line":"    @property"},{"line_number":95,"context_line":"    def num_running_vms(self):"},{"line_number":96,"context_line":"        key \u003d \"num_vm_%s\" % vm_states.ACTIVE"},{"line_number":97,"context_line":"        return self.get(key, 0)"},{"line_number":98,"context_line":""},{"line_number":99,"context_line":"    def update_stats_for_instance(self, instance):"}],"source_content_type":"text/x-python","patch_set":2,"id":"3a50d1a3_28d3393a","line":96,"updated":"2015-07-20 08:06:36.000000000","message":"this will ignore the rescued and resized instance which is also running ....\n\nmaybe this \u0027running\u0027 is confusing?","commit_id":"8da7c49dd960d92022c83016987a25b07f3a808c"},{"author":{"_account_id":7488,"name":"Jeffrey Zhang","email":"zhang.lei.fly@gmail.com","username":"Jeffrey4l"},"change_message_id":"cddff14465f75494f097c090dc6f8f3a50c41b71","unresolved":false,"context_lines":[{"line_number":93,"context_line":""},{"line_number":94,"context_line":"    @property"},{"line_number":95,"context_line":"    def num_running_vms(self):"},{"line_number":96,"context_line":"        key \u003d \"num_vm_%s\" % vm_states.ACTIVE"},{"line_number":97,"context_line":"        return self.get(key, 0)"},{"line_number":98,"context_line":""},{"line_number":99,"context_line":"    def update_stats_for_instance(self, instance):"}],"source_content_type":"text/x-python","patch_set":2,"id":"3a50d1a3_881c9fc2","line":96,"in_reply_to":"3a50d1a3_28d3393a","updated":"2015-07-21 00:08:09.000000000","message":"At least, I don\u0027t think the resized instance should be counted. Because the shutoff instance can be resized, too. \n\nI will try to find more information about this.","commit_id":"8da7c49dd960d92022c83016987a25b07f3a808c"},{"author":{"_account_id":7488,"name":"Jeffrey Zhang","email":"zhang.lei.fly@gmail.com","username":"Jeffrey4l"},"change_message_id":"5e0280aa59047c519285bc7127293f328c269815","unresolved":false,"context_lines":[{"line_number":93,"context_line":""},{"line_number":94,"context_line":"    @property"},{"line_number":95,"context_line":"    def num_running_vms(self):"},{"line_number":96,"context_line":"        key \u003d \"num_vm_%s\" % vm_states.ACTIVE"},{"line_number":97,"context_line":"        return self.get(key, 0)"},{"line_number":98,"context_line":""},{"line_number":99,"context_line":"    def update_stats_for_instance(self, instance):"}],"source_content_type":"text/x-python","patch_set":2,"id":"3a50d1a3_dbcd8c5e","line":96,"in_reply_to":"3a50d1a3_881c9fc2","updated":"2015-07-21 02:32:43.000000000","message":"How about using the count of power_state.RUNNING as the running_vms?[0]\nThe instance is counted as long as the virt driver think it is running.\n\n[0] https://wiki.openstack.org/wiki/VMState","commit_id":"8da7c49dd960d92022c83016987a25b07f3a808c"}]}