)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":12898,"name":"Tony Breeds","email":"tony@bakeyournoodle.com","username":"tonyb"},"change_message_id":"cbb634eeaa3748080a101579e14437995b74ace7","unresolved":false,"context_lines":[{"line_number":7,"context_line":"xenapi: soft reboot should attempt hard reboot on failure"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"When we issue a soft reboot. If it fails we should then do a hard reboot."},{"line_number":10,"context_line":"This is for consistency with libvirt"},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"Change-Id: Iaca1f241cd9db52f5af0df51e5addc97d838c1a6"},{"line_number":13,"context_line":"Closes-Bug: 1422342"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":5,"id":"da20952f_1c5cb57b","line":10,"updated":"2015-09-01 03:30:20.000000000","message":"I\u0027d like to see a more compelling reason than \"because libvirt does this\"","commit_id":"bc1d88f441b9dbbb35c79cc48355fb01711d96c6"},{"author":{"_account_id":6735,"name":"Bob Ball","email":"bob.ball@citrix.com","username":"bob-ball"},"change_message_id":"3bde1f26019cb6b70547d40994be8b903b43f490","unresolved":false,"context_lines":[{"line_number":7,"context_line":"xenapi: soft reboot should attempt hard reboot on failure"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"When we issue a soft reboot. If it fails we should then do a hard reboot."},{"line_number":10,"context_line":"This is for consistency with libvirt"},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"Change-Id: Iaca1f241cd9db52f5af0df51e5addc97d838c1a6"},{"line_number":13,"context_line":"Closes-Bug: 1422342"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":5,"id":"ba15a1d1_f99b9e64","line":10,"in_reply_to":"da20952f_1c5cb57b","updated":"2015-09-22 10:26:22.000000000","message":"I guess the reason is \u0027A user has requested a reboot, and if the server is not responsive and does not perform a soft reboot, then a hard reboot needs to be invoked\u0027","commit_id":"bc1d88f441b9dbbb35c79cc48355fb01711d96c6"}],"nova/virt/xenapi/driver.py":[{"author":{"_account_id":782,"name":"John Garbutt","email":"john@johngarbutt.com","username":"johngarbutt"},"change_message_id":"b60569e158bc3923302b6dc6005a988d1ac1d5b5","unresolved":false,"context_lines":[{"line_number":227,"context_line":"        try:"},{"line_number":228,"context_line":"            self._vmops.reboot(instance, reboot_type,"},{"line_number":229,"context_line":"                               bad_volumes_callback\u003dbad_volumes_callback)"},{"line_number":230,"context_line":"            return"},{"line_number":231,"context_line":"        except self._session.XenAPI.Failure as exc:"},{"line_number":232,"context_line":"            LOG.debug(\"Instance %s reboot failed: %s\", reboot_type, exc)"},{"line_number":233,"context_line":"            if reboot_type \u003d\u003d \"HARD\":"}],"source_content_type":"text/x-python","patch_set":3,"id":"1a4dcd0f_3d45596f","line":230,"updated":"2015-08-05 10:17:11.000000000","message":"I think it would be easier to read without this return here.","commit_id":"203d1524cc31db901322061a6ca5602f4d68182a"},{"author":{"_account_id":782,"name":"John Garbutt","email":"john@johngarbutt.com","username":"johngarbutt"},"change_message_id":"b60569e158bc3923302b6dc6005a988d1ac1d5b5","unresolved":false,"context_lines":[{"line_number":231,"context_line":"        except self._session.XenAPI.Failure as exc:"},{"line_number":232,"context_line":"            LOG.debug(\"Instance %s reboot failed: %s\", reboot_type, exc)"},{"line_number":233,"context_line":"            if reboot_type \u003d\u003d \"HARD\":"},{"line_number":234,"context_line":"                raise"},{"line_number":235,"context_line":""},{"line_number":236,"context_line":"        reboot_type \u003d \"HARD\""},{"line_number":237,"context_line":"        LOG.warning(_LW(\"Failed to soft reboot instance. \""}],"source_content_type":"text/x-python","patch_set":3,"id":"1a4dcd0f_b891779b","line":234,"updated":"2015-08-05 10:17:11.000000000","message":"I think this retry logic should really go here:\nhttps://github.com/openstack/nova/blob/master/nova/virt/xenapi/vmops.py#L1308","commit_id":"203d1524cc31db901322061a6ca5602f4d68182a"},{"author":{"_account_id":14447,"name":"lyanchih","email":"lyan.h@inwinstack.com","username":"lyanchih"},"change_message_id":"523e481db0534ec1ad6203e16aaa2da4b81e7d93","unresolved":false,"context_lines":[{"line_number":231,"context_line":"        except self._session.XenAPI.Failure as exc:"},{"line_number":232,"context_line":"            LOG.debug(\"Instance %s reboot failed: %s\", reboot_type, exc)"},{"line_number":233,"context_line":"            if reboot_type \u003d\u003d \"HARD\":"},{"line_number":234,"context_line":"                raise"},{"line_number":235,"context_line":""},{"line_number":236,"context_line":"        reboot_type \u003d \"HARD\""},{"line_number":237,"context_line":"        LOG.warning(_LW(\"Failed to soft reboot instance. \""}],"source_content_type":"text/x-python","patch_set":3,"id":"1a4dcd0f_cf84910c","line":234,"in_reply_to":"1a4dcd0f_b891779b","updated":"2015-08-06 02:41:16.000000000","message":"I had saw this file. Yes, it doesn\u0027t contain too many logical here. Most things are done in vm operator instead of openstack driver interface.","commit_id":"203d1524cc31db901322061a6ca5602f4d68182a"}]}