)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":1561,"name":"Russell Bryant","email":"rbryant@redhat.com","username":"russellb"},"change_message_id":"04e6e59651e83fcae70af38600df07333d995a22","unresolved":false,"context_lines":[{"line_number":16,"context_line":"deployer doesn\u0027t want traffic to be routed between vlans. Note"},{"line_number":17,"context_line":"that forward_bridge_interface can be specified multiple times and"},{"line_number":18,"context_line":"should be specified once for each interface that supports floating"},{"line_number":19,"context_line":"ips."},{"line_number":20,"context_line":""},{"line_number":21,"context_line":"DocImpact"},{"line_number":22,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"AAAAM3%2F%2FWV0%3D","line":19,"updated":"2013-01-26 16:02:53.000000000","message":"Since this has DocImpact, I don\u0027t want to risk getting wrong info in the docs on this.  The commit message says that the option can be specified multiple times.  That seems to imply:\n\n    forward_bridge_interface\u003dfoo\n    forward_bridge_interface\u003dbar\n\nThough you just specify it once, but it can take a list of values, right?","commit_id":"27c7475fca949340379817b7adb59b7597d358f4"}],"nova/network/linux_net.py":[{"author":{"_account_id":5441,"name":"Andrew Laski","email":"andrew@lascii.com","username":"alaski"},"change_message_id":"c9cfadff034f8a4a9d506072f3317331ac64f623","unresolved":false,"context_lines":[{"line_number":87,"context_line":"                     \u0027get default gateway from dhcp server\u0027),"},{"line_number":88,"context_line":"    cfg.ListOpt(\u0027forward_bridge_interface\u0027,"},{"line_number":89,"context_line":"               default\u003d[\u0027all\u0027],"},{"line_number":90,"context_line":"               help\u003d\u0027An interfaces that bridges can forward to. If this is \u0027"},{"line_number":91,"context_line":"                    \u0027set to all then all traffic will be forwarded. Can be \u0027"},{"line_number":92,"context_line":"                    \u0027specified multiple times.\u0027),"},{"line_number":93,"context_line":"    cfg.StrOpt(\u0027metadata_host\u0027,"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAAM3%2F%2FYvg%3D","line":90,"updated":"2013-01-24 15:32:41.000000000","message":"\"An interface\" or \"All interfaces\"?","commit_id":"6692474fc68a83a9f149d7b6316d99c5755d0acc"},{"author":{"_account_id":1561,"name":"Russell Bryant","email":"rbryant@redhat.com","username":"russellb"},"change_message_id":"04e6e59651e83fcae70af38600df07333d995a22","unresolved":false,"context_lines":[{"line_number":89,"context_line":"               default\u003d[\u0027all\u0027],"},{"line_number":90,"context_line":"               help\u003d\u0027An interface that bridges can forward to. If this is \u0027"},{"line_number":91,"context_line":"                    \u0027set to all then all traffic will be forwarded. Can be \u0027"},{"line_number":92,"context_line":"                    \u0027specified multiple times.\u0027),"},{"line_number":93,"context_line":"    cfg.StrOpt(\u0027metadata_host\u0027,"},{"line_number":94,"context_line":"               default\u003d\u0027$my_ip\u0027,"},{"line_number":95,"context_line":"               help\u003d\u0027the ip for the metadata api server\u0027),"}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAAM3%2F%2FWVw%3D","line":92,"updated":"2013-01-26 16:02:53.000000000","message":"It seems more natural to me to have the default be an empty list here and have the default behavior happen if nothing is specified.  I guess it\u0027s just a preference thing though ...","commit_id":"27c7475fca949340379817b7adb59b7597d358f4"},{"author":{"_account_id":5280,"name":"Nicolas Simonds","email":"nic@metacloud.com","username":"nicolas.simonds"},"change_message_id":"10894705338c8c0cd9c0371eeffa93b2c0d5e080","unresolved":false,"context_lines":[{"line_number":1504,"context_line":"    rules.append((\u0027FORWARD\u0027, \u0027-i %s -o %s -j ACCEPT\u0027 % (bridge, bridge)))"},{"line_number":1505,"context_line":"    rules.append((\u0027FORWARD\u0027, \u0027-i %s -j DROP\u0027 % bridge))"},{"line_number":1506,"context_line":"    rules.append((\u0027FORWARD\u0027, \u0027-o %s -j DROP\u0027 % bridge))"},{"line_number":1507,"context_line":"    return rules"},{"line_number":1508,"context_line":""},{"line_number":1509,"context_line":""},{"line_number":1510,"context_line":"# plugs interfaces using Open vSwitch"}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAAM3%2F%2FU14%3D","line":1507,"updated":"2013-01-28 22:12:04.000000000","message":"This returns a tuple in the \"all\" case, and a list in all other cases.  I know they behave mostly the same, but this result should be coerced into tuple form (or the short-circuit should return a list) for consistencies\u0027 sake.","commit_id":"27c7475fca949340379817b7adb59b7597d358f4"}]}