)]}'
{"bin/nova-dhcpbridge":[{"author":{"_account_id":5441,"name":"Andrew Laski","email":"andrew@lascii.com","username":"alaski"},"change_message_id":"62d64e3360262948f1ce4855a1c0b39c2f2cd855","unresolved":false,"context_lines":[{"line_number":125,"context_line":"    if int(os.environ.get(\u0027TESTING\u0027, \u00270\u0027)):"},{"line_number":126,"context_line":"        from nova.tests import conf_fixture"},{"line_number":127,"context_line":""},{"line_number":128,"context_line":"    if CONF.action.name in [\u0027add\u0027, \u0027del\u0027, \u0027old\u0027]:"},{"line_number":129,"context_line":"        msg \u003d (_(\"Called \u0027%(action)s\u0027 for mac \u0027%(mac)s\u0027 with ip \u0027%(ip)s\u0027\") %"},{"line_number":130,"context_line":"               {\"action\": CONF.action.name,"},{"line_number":131,"context_line":"                \"mac\": CONF.action.mac,"}],"source_content_type":"application/octet-stream","patch_set":1,"id":"AAAAM3%2F%2FYwM%3D","line":128,"updated":"2013-01-24 15:21:19.000000000","message":"Would it make sense to log the hostname here, if passed?","commit_id":"0c99c5bdeb78e61b5f1697c8a086ccf4d8e6f5a4"},{"author":{"_account_id":5441,"name":"Andrew Laski","email":"andrew@lascii.com","username":"alaski"},"change_message_id":"62d64e3360262948f1ce4855a1c0b39c2f2cd855","unresolved":false,"context_lines":[{"line_number":130,"context_line":"               {\"action\": CONF.action.name,"},{"line_number":131,"context_line":"                \"mac\": CONF.action.mac,"},{"line_number":132,"context_line":"                \"ip\": CONF.action.ip})"},{"line_number":133,"context_line":"        LOG.debug(msg)"},{"line_number":134,"context_line":"        CONF.action.func(CONF.action.mac, CONF.action.ip)"},{"line_number":135,"context_line":"    else:"},{"line_number":136,"context_line":"        try:"}],"source_content_type":"application/octet-stream","patch_set":1,"id":"AAAAM3%2F%2FYwI%3D","line":133,"updated":"2013-01-24 15:21:19.000000000","message":"Is it valuable to pass the hostname to methods here?","commit_id":"0c99c5bdeb78e61b5f1697c8a086ccf4d8e6f5a4"},{"author":{"_account_id":5441,"name":"Andrew Laski","email":"andrew@lascii.com","username":"alaski"},"change_message_id":"ac675b326969f45b65e1d4ff463e72a2aac9ab28","unresolved":false,"context_lines":[{"line_number":100,"context_line":"        parser \u003d subparsers.add_parser(action)"},{"line_number":101,"context_line":"        parser.add_argument(\u0027mac\u0027)"},{"line_number":102,"context_line":"        parser.add_argument(\u0027ip\u0027)"},{"line_number":103,"context_line":"        parser.add_argument(\u0027hostname\u0027, nargs\u003d\u0027?\u0027, default\u003d\u0027\u0027)"},{"line_number":104,"context_line":"        parser.set_defaults(func\u003dglobals()[action + \u0027_lease\u0027])"},{"line_number":105,"context_line":""},{"line_number":106,"context_line":""}],"source_content_type":"application/octet-stream","patch_set":3,"id":"AAAAM3%2F%2FX%2Fc%3D","line":103,"updated":"2013-01-24 22:06:56.000000000","message":"Can you add a note here explaining why it\u0027s being grabbed but not used anywhere.","commit_id":"b0fde58a3c32e1f75d8112c7805bbe1952b00fbf"},{"author":{"_account_id":5441,"name":"Andrew Laski","email":"andrew@lascii.com","username":"alaski"},"change_message_id":"e646cc220f3d119bea11ca14ed4ede2097a825c5","unresolved":false,"context_lines":[{"line_number":95,"context_line":""},{"line_number":96,"context_line":"def add_action_parsers(subparsers):"},{"line_number":97,"context_line":"    parser \u003d subparsers.add_parser(\u0027init\u0027)"},{"line_number":98,"context_line":"    "},{"line_number":99,"context_line":"    # NOTE(cfb): dnsmasq always passes mac, and ip. hostname"},{"line_number":100,"context_line":"    #            is bassed if known. We don\u0027t care about "},{"line_number":101,"context_line":"    #            hostname, but argparse will complain if we"}],"source_content_type":"application/octet-stream","patch_set":4,"id":"AAAAM3%2F%2FX7I%3D","line":98,"updated":"2013-01-24 23:07:41.000000000","message":"extra whitespace","commit_id":"9f392ac3667313a67eef11dc3111bae9e435d53a"},{"author":{"_account_id":5441,"name":"Andrew Laski","email":"andrew@lascii.com","username":"alaski"},"change_message_id":"e646cc220f3d119bea11ca14ed4ede2097a825c5","unresolved":false,"context_lines":[{"line_number":97,"context_line":"    parser \u003d subparsers.add_parser(\u0027init\u0027)"},{"line_number":98,"context_line":"    "},{"line_number":99,"context_line":"    # NOTE(cfb): dnsmasq always passes mac, and ip. hostname"},{"line_number":100,"context_line":"    #            is bassed if known. We don\u0027t care about "},{"line_number":101,"context_line":"    #            hostname, but argparse will complain if we"},{"line_number":102,"context_line":"    #            accept it."},{"line_number":103,"context_line":"    for action in [\u0027add\u0027, \u0027del\u0027, \u0027old\u0027]:"}],"source_content_type":"application/octet-stream","patch_set":4,"id":"AAAAM3%2F%2FX7M%3D","line":100,"updated":"2013-01-24 23:07:41.000000000","message":"s/bassed/passed/\nAnd extra whitespace at end of line.","commit_id":"9f392ac3667313a67eef11dc3111bae9e435d53a"},{"author":{"_account_id":5441,"name":"Andrew Laski","email":"andrew@lascii.com","username":"alaski"},"change_message_id":"e646cc220f3d119bea11ca14ed4ede2097a825c5","unresolved":false,"context_lines":[{"line_number":99,"context_line":"    # NOTE(cfb): dnsmasq always passes mac, and ip. hostname"},{"line_number":100,"context_line":"    #            is bassed if known. We don\u0027t care about "},{"line_number":101,"context_line":"    #            hostname, but argparse will complain if we"},{"line_number":102,"context_line":"    #            accept it."},{"line_number":103,"context_line":"    for action in [\u0027add\u0027, \u0027del\u0027, \u0027old\u0027]:"},{"line_number":104,"context_line":"        parser \u003d subparsers.add_parser(action)"},{"line_number":105,"context_line":"        parser.add_argument(\u0027mac\u0027)"}],"source_content_type":"application/octet-stream","patch_set":4,"id":"AAAAM3%2F%2FX7E%3D","line":102,"updated":"2013-01-24 23:07:41.000000000","message":"Should this be \"don\u0027t accept it\"?","commit_id":"9f392ac3667313a67eef11dc3111bae9e435d53a"}]}