)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":1653,"name":"garyk","email":"gkotton@vmware.com","username":"garyk"},"change_message_id":"ce29505d1fa1e713fd78bf186055b9590c804b91","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     Tiago Mello \u003ctmello@linux.vnet.ibm.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2015-07-29 08:42:36 -0400"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Handle unsupported Spice feature for PowerKVM"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"PowerKVM currently does not support Spice protocol. So we raise"},{"line_number":10,"context_line":"an exception if the feature is enabled in the configuration and"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":6,"id":"3a50d1a3_0bf46dee","line":7,"updated":"2015-07-29 12:56:54.000000000","message":"please prefix with libvirt","commit_id":"21a6cdb4daecff5dd77e5d6cee348241d4183835"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"12b2144dcf09ad0a6606aa15a2bca4a1fd25f2f1","unresolved":false,"context_lines":[{"line_number":9,"context_line":"PowerKVM currently does not support Spice protocol. So we raise"},{"line_number":10,"context_line":"an exception if the feature is enabled in the configuration and"},{"line_number":11,"context_line":"skip any test that enables spice."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"Change-Id: I823b44ba65ec6c7aabf8f3e1b962b10d4d5257aa"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":9,"id":"da20952f_30db55ef","line":12,"updated":"2015-09-10 14:07:17.000000000","message":"Seems there should be a bug for this, right?","commit_id":"43b335e78e33a12da0a11a758572abc097bbef48"}],"nova/exception.py":[{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"12b2144dcf09ad0a6606aa15a2bca4a1fd25f2f1","unresolved":false,"context_lines":[{"line_number":1905,"context_line":""},{"line_number":1906,"context_line":""},{"line_number":1907,"context_line":"class SpiceProtocolUnsupported(Invalid):"},{"line_number":1908,"context_line":"    msg_fmt \u003d _(\"%(type)s hypervisor does not support Spice protocol\")"}],"source_content_type":"text/x-python","patch_set":9,"id":"da20952f_b0ed2590","line":1908,"updated":"2015-09-10 14:07:17.000000000","message":"I\u0027m not sure if this is OK given string freeze, maybe it is if we\u0027re in \u0027soft\u0027 string freeze.","commit_id":"43b335e78e33a12da0a11a758572abc097bbef48"},{"author":{"_account_id":11303,"name":"Markus Zoeller (markus_z)","email":"mzoeller@linux.vnet.ibm.com","username":"mzoeller"},"change_message_id":"584a1efda962af9b5212edb0a9f85a1b6d6f3768","unresolved":false,"context_lines":[{"line_number":2011,"context_line":""},{"line_number":2012,"context_line":""},{"line_number":2013,"context_line":"class SpiceProtocolUnsupported(Invalid):"},{"line_number":2014,"context_line":"    msg_fmt \u003d _(\"%(type)s hypervisor does not support Spice protocol\")"}],"source_content_type":"text/x-python","patch_set":17,"id":"3a7e1126_59bec9ae","line":2014,"range":{"start_line":2014,"start_character":19,"end_line":2014,"end_character":23},"updated":"2015-12-22 09:23:43.000000000","message":"nit: maybe that could create confusion with the python builtin \"type()\"","commit_id":"55a2e6b2827b0995d3238317b5dadc27cdbf3e48"}],"nova/spice/__init__.py":[{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"935b864bf8f685716aaf31a00f12fadbae9ef8aa","unresolved":false,"context_lines":[{"line_number":33,"context_line":"    cfg.BoolOpt(\u0027enabled\u0027,"},{"line_number":34,"context_line":"                default\u003dFalse,"},{"line_number":35,"context_line":"                help\u003d\u0027Enable spice related features. Feature is currently \u0027"},{"line_number":36,"context_line":"                     \u0027unsupported for PPC/PPC64/S390/S390x architectures.\u0027),"},{"line_number":37,"context_line":"    cfg.BoolOpt(\u0027agent_enabled\u0027,"},{"line_number":38,"context_line":"                default\u003dTrue,"},{"line_number":39,"context_line":"                help\u003d\u0027Enable spice guest agent support\u0027),"}],"source_content_type":"text/x-python","patch_set":11,"id":"ba15a1d1_3d5a9784","line":36,"updated":"2015-09-14 14:17:18.000000000","message":"This probably requires a DocImpact in the commit message just to notify the docs team of the changed config option help text.","commit_id":"69091ea5865e92b2b283d84a24caaa24c15b5385"},{"author":{"_account_id":11303,"name":"Markus Zoeller (markus_z)","email":"mzoeller@linux.vnet.ibm.com","username":"mzoeller"},"change_message_id":"4c01f4277a21df7f665c19da6511a1107e02636e","unresolved":false,"context_lines":[{"line_number":33,"context_line":"    cfg.BoolOpt(\u0027enabled\u0027,"},{"line_number":34,"context_line":"                default\u003dFalse,"},{"line_number":35,"context_line":"                help\u003d\u0027Enable spice related features. Feature is currently \u0027"},{"line_number":36,"context_line":"                     \u0027unsupported for PPC/PPC64/S390/S390x architectures.\u0027),"},{"line_number":37,"context_line":"    cfg.BoolOpt(\u0027agent_enabled\u0027,"},{"line_number":38,"context_line":"                default\u003dTrue,"},{"line_number":39,"context_line":"                help\u003d\u0027Enable spice guest agent support\u0027),"}],"source_content_type":"text/x-python","patch_set":17,"id":"3a7e1126_c4814291","line":36,"updated":"2015-12-17 08:59:53.000000000","message":"Wouldn\u0027t that added comment be enough for customers to make a decision if they want to enabled it?","commit_id":"55a2e6b2827b0995d3238317b5dadc27cdbf3e48"},{"author":{"_account_id":11303,"name":"Markus Zoeller (markus_z)","email":"mzoeller@linux.vnet.ibm.com","username":"mzoeller"},"change_message_id":"716d0213f5117c35b3c2491db05c2a576edc7bdc","unresolved":false,"context_lines":[{"line_number":33,"context_line":"    cfg.BoolOpt(\u0027enabled\u0027,"},{"line_number":34,"context_line":"                default\u003dFalse,"},{"line_number":35,"context_line":"                help\u003d\u0027Enable spice related features. Feature is currently \u0027"},{"line_number":36,"context_line":"                     \u0027unsupported for PPC/PPC64/S390/S390x architectures.\u0027),"},{"line_number":37,"context_line":"    cfg.BoolOpt(\u0027agent_enabled\u0027,"},{"line_number":38,"context_line":"                default\u003dTrue,"},{"line_number":39,"context_line":"                help\u003d\u0027Enable spice guest agent support\u0027),"}],"source_content_type":"text/x-python","patch_set":17,"id":"fa69d971_ad23e9a6","line":36,"in_reply_to":"3a7e1126_1f07d082","updated":"2016-01-07 10:24:03.000000000","message":"FYI: There is work in progress to move the config options to the central location \"/nova/conf\". For these spice options it is in progress with commit [1]. This will conflict with this change here.\n\n[1] https://review.openstack.org/#/c/264271/","commit_id":"55a2e6b2827b0995d3238317b5dadc27cdbf3e48"},{"author":{"_account_id":12898,"name":"Tony Breeds","email":"tony@bakeyournoodle.com","username":"tonyb"},"change_message_id":"e6111fcb8493ae1ccabc2132159e095d5b34de8c","unresolved":false,"context_lines":[{"line_number":33,"context_line":"    cfg.BoolOpt(\u0027enabled\u0027,"},{"line_number":34,"context_line":"                default\u003dFalse,"},{"line_number":35,"context_line":"                help\u003d\u0027Enable spice related features. Feature is currently \u0027"},{"line_number":36,"context_line":"                     \u0027unsupported for PPC/PPC64/S390/S390x architectures.\u0027),"},{"line_number":37,"context_line":"    cfg.BoolOpt(\u0027agent_enabled\u0027,"},{"line_number":38,"context_line":"                default\u003dTrue,"},{"line_number":39,"context_line":"                help\u003d\u0027Enable spice guest agent support\u0027),"}],"source_content_type":"text/x-python","patch_set":17,"id":"3a7e1126_1f07d082","line":36,"in_reply_to":"3a7e1126_c4814291","updated":"2015-12-22 01:20:35.000000000","message":"Actually the text is wrong in that it doesn\u0027t call out that (certainly in the ppc* case) it\u0027s the *guest* architecture that matters not the host.\n\nI\u0027ve run ppc64le *guests* with spice on both ppc64 and ppc64le hosts.","commit_id":"55a2e6b2827b0995d3238317b5dadc27cdbf3e48"},{"author":{"_account_id":12898,"name":"Tony Breeds","email":"tony@bakeyournoodle.com","username":"tonyb"},"change_message_id":"c1d9795f86ccdf65dce0900df693590343f151bd","unresolved":false,"context_lines":[{"line_number":33,"context_line":"    cfg.BoolOpt(\u0027enabled\u0027,"},{"line_number":34,"context_line":"                default\u003dFalse,"},{"line_number":35,"context_line":"                help\u003d\u0027Enable spice related features. Feature is currently \u0027"},{"line_number":36,"context_line":"                     \u0027unsupported for PPC/PPC64/S390/S390x architectures.\u0027),"},{"line_number":37,"context_line":"    cfg.BoolOpt(\u0027agent_enabled\u0027,"},{"line_number":38,"context_line":"                default\u003dTrue,"},{"line_number":39,"context_line":"                help\u003d\u0027Enable spice guest agent support\u0027),"}],"source_content_type":"text/x-python","patch_set":17,"id":"fa69d971_b8bf69fb","line":36,"in_reply_to":"fa69d971_7b47dd4b","updated":"2016-01-08 06:02:54.000000000","message":"Yeah and to add complications.  but fixing the client is wrong it needs to be done in the protocol / server side.","commit_id":"55a2e6b2827b0995d3238317b5dadc27cdbf3e48"},{"author":{"_account_id":8175,"name":"Rafael Folco","email":"rfolco@redhat.com","username":"rfolco"},"change_message_id":"c7d6fb2bcb582e2a22d4593d960b0aa3a14ddbf1","unresolved":false,"context_lines":[{"line_number":33,"context_line":"    cfg.BoolOpt(\u0027enabled\u0027,"},{"line_number":34,"context_line":"                default\u003dFalse,"},{"line_number":35,"context_line":"                help\u003d\u0027Enable spice related features. Feature is currently \u0027"},{"line_number":36,"context_line":"                     \u0027unsupported for PPC/PPC64/S390/S390x architectures.\u0027),"},{"line_number":37,"context_line":"    cfg.BoolOpt(\u0027agent_enabled\u0027,"},{"line_number":38,"context_line":"                default\u003dTrue,"},{"line_number":39,"context_line":"                help\u003d\u0027Enable spice guest agent support\u0027),"}],"source_content_type":"text/x-python","patch_set":17,"id":"fa69d971_7b47dd4b","line":36,"in_reply_to":"fa69d971_ad23e9a6","updated":"2016-01-07 16:17:08.000000000","message":"Right. This actually deserves more investigation and testing. I just found this http://lists.freedesktop.org/archives/spice-devel/2015-March/019235.html","commit_id":"55a2e6b2827b0995d3238317b5dadc27cdbf3e48"}],"nova/tests/unit/virt/libvirt/test_driver.py":[{"author":{"_account_id":8175,"name":"Rafael Folco","email":"rfolco@redhat.com","username":"rfolco"},"change_message_id":"9f23f17fa10b7f205fc62e9225b1ce680430ea09","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"3a50d1a3_f17879c6","updated":"2015-07-21 18:49:22.000000000","message":"PowerKVM does not support spice so \u0027vga\u0027 isn\u0027t the expected driver. I believe This test should be skipped by arch, with something like: spice_support \u003d { arch.X86_64 \u003d True, arch.ppc64 \u003d False ... }, and skip with if spice_support: just like hpet example.","commit_id":"87066de5616d6bb319959af7844fd17fc0c09424"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"20d69752a558eb64dfb3e6b5fe5bbb1a2d057834","unresolved":false,"context_lines":[{"line_number":200,"context_line":"    done.send()"},{"line_number":201,"context_line":""},{"line_number":202,"context_line":""},{"line_number":203,"context_line":"def _is_spice_supported():"},{"line_number":204,"context_line":"    expect \u003d {\"ppc\": False, \"ppc64\": False, \"s390\": False, \"s390x\": False}"},{"line_number":205,"context_line":"    return expect.get(blockinfo.libvirt_utils.get_arch({}), True)"},{"line_number":206,"context_line":""}],"source_content_type":"text/x-python","patch_set":10,"id":"da20952f_f1c2be52","line":203,"updated":"2015-09-10 15:14:00.000000000","message":"I kind of wish this were a singleton, but not really a big deal.","commit_id":"e0718d0eeb8655f1d2b96096811dc38768d4f0d5"},{"author":{"_account_id":7730,"name":"Sahid Orentino Ferdjaoui","email":"sahid.ferdjaoui@industrialdiscipline.com","username":"sahid"},"change_message_id":"a4b41a9cb9b61b62bed0788f48d5f8cc64a6570c","unresolved":false,"context_lines":[{"line_number":2686,"context_line":"        self.assertEqual(cfg.devices[4].type, \"tablet\")"},{"line_number":2687,"context_line":"        self.assertEqual(cfg.devices[5].type, \"spice\")"},{"line_number":2688,"context_line":""},{"line_number":2689,"context_line":"    @testtools.skipIf(_is_spice_supported(),"},{"line_number":2690,"context_line":"                      \u0027Architecture does support Spice\u0027)"},{"line_number":2691,"context_line":"    def test_unsupported_spice(self):"},{"line_number":2692,"context_line":"        self.flags(enabled\u003dFalse, group\u003d\u0027vnc\u0027)"}],"source_content_type":"text/x-python","patch_set":12,"id":"ba15a1d1_ec6e1aff","line":2689,"updated":"2015-09-24 08:17:24.000000000","message":"You should do not skip tests, all is mocked here. Skip a test should be addressed only if it is in relation with system which run unit tests.","commit_id":"4867c7b7366538c5a540819455d799bf495cd050"},{"author":{"_account_id":12898,"name":"Tony Breeds","email":"tony@bakeyournoodle.com","username":"tonyb"},"change_message_id":"3ee2ef0278ba1aeab993a82d853b9e0952704052","unresolved":false,"context_lines":[{"line_number":2751,"context_line":"                                   return_value\u003dguestarch):"},{"line_number":2752,"context_line":"                if _is_spice_supported():"},{"line_number":2753,"context_line":"                    cfg \u003d drvr._get_guest_config(instance_ref, [],"},{"line_number":2754,"context_line":"                                                 image_meta, disk_info)"},{"line_number":2755,"context_line":"                    self.assertEqual(len(cfg.devices), 8)"},{"line_number":2756,"context_line":"                    self.assertIsInstance(cfg.devices[0],"},{"line_number":2757,"context_line":"                                          vconfig.LibvirtConfigGuestDisk)"}],"source_content_type":"text/x-python","patch_set":15,"id":"7a740942_fb773fd2","line":2754,"updated":"2015-12-04 02:46:16.000000000","message":"Here","commit_id":"e126ce20e6903041c3e443c4b552840c6d9c48bd"},{"author":{"_account_id":8175,"name":"Rafael Folco","email":"rfolco@redhat.com","username":"rfolco"},"change_message_id":"8501af78d82d4cd79a1419404820c3caf057ca0c","unresolved":false,"context_lines":[{"line_number":2751,"context_line":"                                   return_value\u003dguestarch):"},{"line_number":2752,"context_line":"                if _is_spice_supported():"},{"line_number":2753,"context_line":"                    cfg \u003d drvr._get_guest_config(instance_ref, [],"},{"line_number":2754,"context_line":"                                                 image_meta, disk_info)"},{"line_number":2755,"context_line":"                    self.assertEqual(len(cfg.devices), 8)"},{"line_number":2756,"context_line":"                    self.assertIsInstance(cfg.devices[0],"},{"line_number":2757,"context_line":"                                          vconfig.LibvirtConfigGuestDisk)"}],"source_content_type":"text/x-python","patch_set":15,"id":"7a740942_e617a2eb","line":2754,"in_reply_to":"7a740942_fb773fd2","updated":"2015-12-04 03:05:55.000000000","message":":)","commit_id":"e126ce20e6903041c3e443c4b552840c6d9c48bd"},{"author":{"_account_id":12898,"name":"Tony Breeds","email":"tony@bakeyournoodle.com","username":"tonyb"},"change_message_id":"3ee2ef0278ba1aeab993a82d853b9e0952704052","unresolved":false,"context_lines":[{"line_number":3232,"context_line":"        disk_info \u003d blockinfo.get_disk_info(CONF.libvirt.virt_type,"},{"line_number":3233,"context_line":"                                            instance_ref,"},{"line_number":3234,"context_line":"                                            image_meta)"},{"line_number":3235,"context_line":"        cfg \u003d drvr._get_guest_config(instance_ref, [],"},{"line_number":3236,"context_line":"                                     image_meta, disk_info)"},{"line_number":3237,"context_line":"        for guestarch in _arch_list:"},{"line_number":3238,"context_line":"            with mock.patch.object(libvirt_driver.libvirt_utils,"}],"source_content_type":"text/x-python","patch_set":15,"id":"7a740942_3b6dc704","line":3235,"range":{"start_line":3235,"start_character":14,"end_line":3235,"end_character":37},"updated":"2015-12-04 02:46:16.000000000","message":"This looks strange to me. Shouldn\u0027t it be inside the with mock.patch()? Like you did above.","commit_id":"e126ce20e6903041c3e443c4b552840c6d9c48bd"},{"author":{"_account_id":8175,"name":"Rafael Folco","email":"rfolco@redhat.com","username":"rfolco"},"change_message_id":"8501af78d82d4cd79a1419404820c3caf057ca0c","unresolved":false,"context_lines":[{"line_number":3232,"context_line":"        disk_info \u003d blockinfo.get_disk_info(CONF.libvirt.virt_type,"},{"line_number":3233,"context_line":"                                            instance_ref,"},{"line_number":3234,"context_line":"                                            image_meta)"},{"line_number":3235,"context_line":"        cfg \u003d drvr._get_guest_config(instance_ref, [],"},{"line_number":3236,"context_line":"                                     image_meta, disk_info)"},{"line_number":3237,"context_line":"        for guestarch in _arch_list:"},{"line_number":3238,"context_line":"            with mock.patch.object(libvirt_driver.libvirt_utils,"}],"source_content_type":"text/x-python","patch_set":15,"id":"7a740942_c6f146cf","line":3235,"in_reply_to":"7a740942_3b6dc704","updated":"2015-12-04 03:05:55.000000000","message":"Oops! will fix this.","commit_id":"e126ce20e6903041c3e443c4b552840c6d9c48bd"},{"author":{"_account_id":12898,"name":"Tony Breeds","email":"tony@bakeyournoodle.com","username":"tonyb"},"change_message_id":"3ee2ef0278ba1aeab993a82d853b9e0952704052","unresolved":false,"context_lines":[{"line_number":3520,"context_line":"                                            instance_ref,"},{"line_number":3521,"context_line":"                                            image_meta)"},{"line_number":3522,"context_line":""},{"line_number":3523,"context_line":"        cfg \u003d drvr._get_guest_config(instance_ref, [],"},{"line_number":3524,"context_line":"                                     image_meta, disk_info)"},{"line_number":3525,"context_line":"        for guestarch in _arch_list:"},{"line_number":3526,"context_line":"            with mock.patch.object(libvirt_driver.libvirt_utils,"}],"source_content_type":"text/x-python","patch_set":15,"id":"7a740942_fb5e5f44","line":3523,"updated":"2015-12-04 02:46:16.000000000","message":"ditto","commit_id":"e126ce20e6903041c3e443c4b552840c6d9c48bd"},{"author":{"_account_id":8175,"name":"Rafael Folco","email":"rfolco@redhat.com","username":"rfolco"},"change_message_id":"8501af78d82d4cd79a1419404820c3caf057ca0c","unresolved":false,"context_lines":[{"line_number":3520,"context_line":"                                            instance_ref,"},{"line_number":3521,"context_line":"                                            image_meta)"},{"line_number":3522,"context_line":""},{"line_number":3523,"context_line":"        cfg \u003d drvr._get_guest_config(instance_ref, [],"},{"line_number":3524,"context_line":"                                     image_meta, disk_info)"},{"line_number":3525,"context_line":"        for guestarch in _arch_list:"},{"line_number":3526,"context_line":"            with mock.patch.object(libvirt_driver.libvirt_utils,"}],"source_content_type":"text/x-python","patch_set":15,"id":"7a740942_a6bf5acf","line":3523,"in_reply_to":"7a740942_fb5e5f44","updated":"2015-12-04 03:05:55.000000000","message":"good catch thx","commit_id":"e126ce20e6903041c3e443c4b552840c6d9c48bd"}],"nova/virt/libvirt/driver.py":[{"author":{"_account_id":1653,"name":"garyk","email":"gkotton@vmware.com","username":"garyk"},"change_message_id":"ce29505d1fa1e713fd78bf186055b9590c804b91","unresolved":false,"context_lines":[{"line_number":3712,"context_line":"        elif guestarch in (arch.PPC, arch.PPC64):"},{"line_number":3713,"context_line":"            # NOTE(timello): PowerKVM doesn\u0027t support Spice protocol"},{"line_number":3714,"context_line":"            if CONF.spice.enabled:"},{"line_number":3715,"context_line":"                raise exception.SpiceProtocolUnsupported(type\u003dguestarch)"},{"line_number":3716,"context_line":"            # NOTE(ldbragst): PowerKVM doesn\u0027t support \u0027cirrus\u0027 be default"},{"line_number":3717,"context_line":"            # so use \u0027vga\u0027 instead when running on Power hardware."},{"line_number":3718,"context_line":"            video.type \u003d \u0027vga\u0027"}],"source_content_type":"text/x-python","patch_set":6,"id":"3a50d1a3_cb93e5a1","line":3715,"updated":"2015-07-29 12:56:54.000000000","message":"would it not be better to log that this is not supported and not configure a video type?","commit_id":"21a6cdb4daecff5dd77e5d6cee348241d4183835"},{"author":{"_account_id":4601,"name":"Tiago Mello","email":"tmello@linux.vnet.ibm.com","username":"tmello"},"change_message_id":"b14df5a4df1f76e97e376f25ea74634d536b549a","unresolved":false,"context_lines":[{"line_number":3712,"context_line":"        elif guestarch in (arch.PPC, arch.PPC64):"},{"line_number":3713,"context_line":"            # NOTE(timello): PowerKVM doesn\u0027t support Spice protocol"},{"line_number":3714,"context_line":"            if CONF.spice.enabled:"},{"line_number":3715,"context_line":"                raise exception.SpiceProtocolUnsupported(type\u003dguestarch)"},{"line_number":3716,"context_line":"            # NOTE(ldbragst): PowerKVM doesn\u0027t support \u0027cirrus\u0027 be default"},{"line_number":3717,"context_line":"            # so use \u0027vga\u0027 instead when running on Power hardware."},{"line_number":3718,"context_line":"            video.type \u003d \u0027vga\u0027"}],"source_content_type":"text/x-python","patch_set":6,"id":"3a50d1a3_370746cb","line":3715,"in_reply_to":"3a50d1a3_cb93e5a1","updated":"2015-07-29 13:57:28.000000000","message":"Actually, it is better to check that before this routine... it is not video driver dependent... spice is unsupported regardless the video driver.","commit_id":"21a6cdb4daecff5dd77e5d6cee348241d4183835"},{"author":{"_account_id":7730,"name":"Sahid Orentino Ferdjaoui","email":"sahid.ferdjaoui@industrialdiscipline.com","username":"sahid"},"change_message_id":"6879b9e076c892dfc27b9cdebd7c0f7f28db601c","unresolved":false,"context_lines":[{"line_number":4060,"context_line":"        if tablet:"},{"line_number":4061,"context_line":"            guest.add_device(tablet)"},{"line_number":4062,"context_line":""},{"line_number":4063,"context_line":"        # NOTE(timello): PowerKVM doesn\u0027t support Spice protocol"},{"line_number":4064,"context_line":"        guestarch \u003d libvirt_utils.get_arch(image_meta)"},{"line_number":4065,"context_line":"        if (CONF.spice.enabled and"},{"line_number":4066,"context_line":"                guestarch in (arch.PPC, arch.PPC64)):"}],"source_content_type":"text/x-python","patch_set":8,"id":"3a50d1a3_aabc966c","line":4063,"updated":"2015-08-03 13:34:05.000000000","message":"Please remove that NOTE(timello) it\u0027s a comment.","commit_id":"84978bcf79e0844a26e26e627b659f8ec9a509c0"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"571f1798755bc2e7c742d38bf9d1acd620521b33","unresolved":false,"context_lines":[{"line_number":4203,"context_line":"        # PowerKVM doesn\u0027t support Spice protocol"},{"line_number":4204,"context_line":"        guestarch \u003d libvirt_utils.get_arch(image_meta)"},{"line_number":4205,"context_line":"        if (CONF.spice.enabled and"},{"line_number":4206,"context_line":"                guestarch in (arch.PPC, arch.PPC64)):"},{"line_number":4207,"context_line":"            raise exception.SpiceProtocolUnsupported(type\u003dguestarch)"},{"line_number":4208,"context_line":""},{"line_number":4209,"context_line":"        if (CONF.spice.enabled and CONF.spice.agent_enabled and"}],"source_content_type":"text/x-python","patch_set":9,"id":"da20952f_102ad190","line":4206,"updated":"2015-09-10 14:08:32.000000000","message":"Given:\n\nhttp://docs.openstack.org/developer/nova/support-matrix.html#console_spice\n\nWe should have a follow on change for s390 and s390x.","commit_id":"43b335e78e33a12da0a11a758572abc097bbef48"},{"author":{"_account_id":14594,"name":"Alexander Schmidt","email":"alexs@linux.vnet.ibm.com","username":"alexs"},"change_message_id":"9a4b37ae952f56a0b585bd5a2620f4ebee450412","unresolved":false,"context_lines":[{"line_number":4203,"context_line":"        # PowerKVM doesn\u0027t support Spice protocol"},{"line_number":4204,"context_line":"        guestarch \u003d libvirt_utils.get_arch(image_meta)"},{"line_number":4205,"context_line":"        if (CONF.spice.enabled and"},{"line_number":4206,"context_line":"                guestarch in (arch.PPC, arch.PPC64)):"},{"line_number":4207,"context_line":"            raise exception.SpiceProtocolUnsupported(type\u003dguestarch)"},{"line_number":4208,"context_line":""},{"line_number":4209,"context_line":"        if (CONF.spice.enabled and CONF.spice.agent_enabled and"}],"source_content_type":"text/x-python","patch_set":9,"id":"da20952f_4bf3b89f","line":4206,"in_reply_to":"da20952f_102ad190","updated":"2015-09-10 14:22:20.000000000","message":"yes, please also add arch.S390 and arch.S390X here.\n\nAnd you can also add \"PowerKVM and KVM for z don\u0027t support Spirce protocol\".\n\nThanks!","commit_id":"43b335e78e33a12da0a11a758572abc097bbef48"},{"author":{"_account_id":12898,"name":"Tony Breeds","email":"tony@bakeyournoodle.com","username":"tonyb"},"change_message_id":"0de0bae35b1724aa24f9603e6cef758af2ad33fa","unresolved":false,"context_lines":[{"line_number":4205,"context_line":"        if (CONF.spice.enabled and"},{"line_number":4206,"context_line":"                guestarch in (arch.PPC, arch.PPC64)):"},{"line_number":4207,"context_line":"            raise exception.SpiceProtocolUnsupported(type\u003dguestarch)"},{"line_number":4208,"context_line":""},{"line_number":4209,"context_line":"        if (CONF.spice.enabled and CONF.spice.agent_enabled and"},{"line_number":4210,"context_line":"                virt_type not in (\u0027lxc\u0027, \u0027uml\u0027, \u0027xen\u0027)):"},{"line_number":4211,"context_line":"            channel \u003d vconfig.LibvirtConfigGuestChannel()"}],"source_content_type":"text/x-python","patch_set":9,"id":"1a4dcd0f_270368c0","line":4208,"updated":"2015-08-14 00:48:08.000000000","message":"The more I think about it the less comfortable I am with this hunk.  I\u0027d prefer to see this logic inverted:\n\n# Spice is only well tested on intel\nguestarch \u003d libvirt_utils.get_arch(image_meta)\nif (CONF.spice.enabled and\n                guestarch not in (arch.I686, arch.X86_64)):\n    raise exception.SpiceProtocolUnsupported(type\u003dguestarch)\n\nWith the appropriate updates to the testing changes.","commit_id":"43b335e78e33a12da0a11a758572abc097bbef48"},{"author":{"_account_id":1779,"name":"Daniel Berrange","email":"berrange@redhat.com","username":"berrange"},"change_message_id":"8ebd6ae4a45ebb152408742818fb11668f30f9f4","unresolved":false,"context_lines":[{"line_number":4205,"context_line":"        if (CONF.spice.enabled and"},{"line_number":4206,"context_line":"                guestarch in (arch.PPC, arch.PPC64)):"},{"line_number":4207,"context_line":"            raise exception.SpiceProtocolUnsupported(type\u003dguestarch)"},{"line_number":4208,"context_line":""},{"line_number":4209,"context_line":"        if (CONF.spice.enabled and CONF.spice.agent_enabled and"},{"line_number":4210,"context_line":"                virt_type not in (\u0027lxc\u0027, \u0027uml\u0027, \u0027xen\u0027)):"},{"line_number":4211,"context_line":"            channel \u003d vconfig.LibvirtConfigGuestChannel()"}],"source_content_type":"text/x-python","patch_set":9,"id":"1a4dcd0f_d3efd8e7","line":4208,"in_reply_to":"1a4dcd0f_270368c0","updated":"2015-08-14 08:56:52.000000000","message":"That would not be right - while SPICE is not built on PPC64 arch (on Fedora/RHEL at least), it is built on other arches like arm","commit_id":"43b335e78e33a12da0a11a758572abc097bbef48"},{"author":{"_account_id":12898,"name":"Tony Breeds","email":"tony@bakeyournoodle.com","username":"tonyb"},"change_message_id":"fe0de51309eddc2bca59e866b0a64dd126ec5747","unresolved":false,"context_lines":[{"line_number":4205,"context_line":"        if (CONF.spice.enabled and"},{"line_number":4206,"context_line":"                guestarch in (arch.PPC, arch.PPC64)):"},{"line_number":4207,"context_line":"            raise exception.SpiceProtocolUnsupported(type\u003dguestarch)"},{"line_number":4208,"context_line":""},{"line_number":4209,"context_line":"        if (CONF.spice.enabled and CONF.spice.agent_enabled and"},{"line_number":4210,"context_line":"                virt_type not in (\u0027lxc\u0027, \u0027uml\u0027, \u0027xen\u0027)):"},{"line_number":4211,"context_line":"            channel \u003d vconfig.LibvirtConfigGuestChannel()"}],"source_content_type":"text/x-python","patch_set":9,"id":"da20952f_76438daf","line":4208,"in_reply_to":"1a4dcd0f_d3efd8e7","updated":"2015-09-01 05:15:19.000000000","message":"That\u0027s kind of my point.  Just because they\u0027re built (for arm) doesn\u0027t mean spice well tested (on arm).","commit_id":"43b335e78e33a12da0a11a758572abc097bbef48"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"4c626ba4cdbf48aba2b8e8f6473a9935e9279b07","unresolved":false,"context_lines":[{"line_number":4204,"context_line":""},{"line_number":4205,"context_line":"        # PowerKVM and KVM for z don\u0027t support Spice protocol"},{"line_number":4206,"context_line":"        guestarch \u003d libvirt_utils.get_arch(image_meta)"},{"line_number":4207,"context_line":"        if (CONF.spice.enabled and"},{"line_number":4208,"context_line":"                guestarch in (arch.PPC, arch.PPC64, arch.S390, arch.S390X)):"},{"line_number":4209,"context_line":"            raise exception.SpiceProtocolUnsupported(type\u003dguestarch)"},{"line_number":4210,"context_line":""}],"source_content_type":"text/x-python","patch_set":10,"id":"da20952f_54a4b806","line":4207,"updated":"2015-09-10 15:26:29.000000000","message":"Maybe for another change, but we should update the config help for CONF.spice.enabled and point out that it doesn\u0027t work on these platforms.","commit_id":"e0718d0eeb8655f1d2b96096811dc38768d4f0d5"},{"author":{"_account_id":1653,"name":"garyk","email":"gkotton@vmware.com","username":"garyk"},"change_message_id":"3f70e8f455cae2fffdc753a3e3d3c3657c9793fe","unresolved":false,"context_lines":[{"line_number":4205,"context_line":"        if tablet:"},{"line_number":4206,"context_line":"            guest.add_device(tablet)"},{"line_number":4207,"context_line":""},{"line_number":4208,"context_line":"        # PowerKVM and KVM for z don\u0027t support Spice protocol"},{"line_number":4209,"context_line":"        guestarch \u003d libvirt_utils.get_arch(image_meta)"},{"line_number":4210,"context_line":"        if (CONF.spice.enabled and"},{"line_number":4211,"context_line":"                guestarch in (arch.PPC, arch.PPC64, arch.S390, arch.S390X)):"}],"source_content_type":"text/x-python","patch_set":12,"id":"ba15a1d1_8773b77f","line":4208,"updated":"2015-09-24 08:24:10.000000000","message":"i think that you should do this at the beginning of the method. it would save a lot of cycles","commit_id":"4867c7b7366538c5a540819455d799bf495cd050"},{"author":{"_account_id":11303,"name":"Markus Zoeller (markus_z)","email":"mzoeller@linux.vnet.ibm.com","username":"mzoeller"},"change_message_id":"4c01f4277a21df7f665c19da6511a1107e02636e","unresolved":false,"context_lines":[{"line_number":4285,"context_line":"        guestarch \u003d libvirt_utils.get_arch(image_meta)"},{"line_number":4286,"context_line":"        if (CONF.spice.enabled and"},{"line_number":4287,"context_line":"                guestarch in (arch.PPC, arch.PPC64, arch.S390, arch.S390X)):"},{"line_number":4288,"context_line":"            raise exception.SpiceProtocolUnsupported(type\u003dguestarch)"},{"line_number":4289,"context_line":""},{"line_number":4290,"context_line":"        if (CONF.spice.enabled and CONF.spice.agent_enabled and"},{"line_number":4291,"context_line":"                virt_type not in (\u0027lxc\u0027, \u0027uml\u0027, \u0027xen\u0027)):"}],"source_content_type":"text/x-python","patch_set":17,"id":"3a7e1126_1f24730b","line":4288,"updated":"2015-12-17 08:59:53.000000000","message":"That\u0027s too late to signalize to the ops that they configured the compute node in a way which is most likely not going to work. The method \"_do_quality_warnings\" in the driver would be more suitable as this gets called when the nova-compute service gets started.\n\nWhat worries me more is, when ppc or s390 decide to support spice, we have to remove this piece of code and wait until the next release to exploit it. With the current release model this means that can be 6 month at worst.","commit_id":"55a2e6b2827b0995d3238317b5dadc27cdbf3e48"},{"author":{"_account_id":11303,"name":"Markus Zoeller (markus_z)","email":"mzoeller@linux.vnet.ibm.com","username":"mzoeller"},"change_message_id":"40a3a4cf76d94f58065e523cbcbd648c7e25e50f","unresolved":false,"context_lines":[{"line_number":4285,"context_line":"        guestarch \u003d libvirt_utils.get_arch(image_meta)"},{"line_number":4286,"context_line":"        if (CONF.spice.enabled and"},{"line_number":4287,"context_line":"                guestarch in (arch.PPC, arch.PPC64, arch.S390, arch.S390X)):"},{"line_number":4288,"context_line":"            raise exception.SpiceProtocolUnsupported(type\u003dguestarch)"},{"line_number":4289,"context_line":""},{"line_number":4290,"context_line":"        if (CONF.spice.enabled and CONF.spice.agent_enabled and"},{"line_number":4291,"context_line":"                virt_type not in (\u0027lxc\u0027, \u0027uml\u0027, \u0027xen\u0027)):"}],"source_content_type":"text/x-python","patch_set":17,"id":"fa69d971_d830f603","line":4288,"in_reply_to":"1a7b0d38_f1f76ef3","updated":"2016-01-04 13:41:50.000000000","message":"Let me use an example to show what my (maybe unfounded) thinking was. Imaging the following timeline:\n- Jan. 2016: this patch merges\n- Apr. 2016: Nova mitaka release is published\n- May 2016: s390x decides that they have enough confidence to support the spice protocol on the platform. The \"IF\" from above gets changed to reflect that.\n- Oct. 2016: Nova Nxxx release is published\n\nMy thinking was, that it takes until Oct. 2015 (Nova Nxxx release) until customers will benefit from that because I assume that customers (especially from s390x) will only use the stable releases (regardless of the stability of our master).\n\nI think part of my concern is that I don\u0027t understand what we gain from the usage of the exception (which stops the spawn) over a warning log (which provides the same amount of information but doesn\u0027t stop the spawn)?","commit_id":"55a2e6b2827b0995d3238317b5dadc27cdbf3e48"},{"author":{"_account_id":12898,"name":"Tony Breeds","email":"tony@bakeyournoodle.com","username":"tonyb"},"change_message_id":"e6111fcb8493ae1ccabc2132159e095d5b34de8c","unresolved":false,"context_lines":[{"line_number":4285,"context_line":"        guestarch \u003d libvirt_utils.get_arch(image_meta)"},{"line_number":4286,"context_line":"        if (CONF.spice.enabled and"},{"line_number":4287,"context_line":"                guestarch in (arch.PPC, arch.PPC64, arch.S390, arch.S390X)):"},{"line_number":4288,"context_line":"            raise exception.SpiceProtocolUnsupported(type\u003dguestarch)"},{"line_number":4289,"context_line":""},{"line_number":4290,"context_line":"        if (CONF.spice.enabled and CONF.spice.agent_enabled and"},{"line_number":4291,"context_line":"                virt_type not in (\u0027lxc\u0027, \u0027uml\u0027, \u0027xen\u0027)):"}],"source_content_type":"text/x-python","patch_set":17,"id":"3a7e1126_df970838","line":4288,"in_reply_to":"3a7e1126_1f24730b","updated":"2015-12-22 01:20:35.000000000","message":"We can\u0027t do it in _do_quality_warnings() as it depends on the *guest* arch.\n\nI\u0027m not sure why we\u0027d need to wait to exploit the code.","commit_id":"55a2e6b2827b0995d3238317b5dadc27cdbf3e48"},{"author":{"_account_id":12898,"name":"Tony Breeds","email":"tony@bakeyournoodle.com","username":"tonyb"},"change_message_id":"25d5b91bccc05d39cc2884ef8367c68fd748b56a","unresolved":false,"context_lines":[{"line_number":4285,"context_line":"        guestarch \u003d libvirt_utils.get_arch(image_meta)"},{"line_number":4286,"context_line":"        if (CONF.spice.enabled and"},{"line_number":4287,"context_line":"                guestarch in (arch.PPC, arch.PPC64, arch.S390, arch.S390X)):"},{"line_number":4288,"context_line":"            raise exception.SpiceProtocolUnsupported(type\u003dguestarch)"},{"line_number":4289,"context_line":""},{"line_number":4290,"context_line":"        if (CONF.spice.enabled and CONF.spice.agent_enabled and"},{"line_number":4291,"context_line":"                virt_type not in (\u0027lxc\u0027, \u0027uml\u0027, \u0027xen\u0027)):"}],"source_content_type":"text/x-python","patch_set":17,"id":"1a7b0d38_f1f76ef3","line":4288,"in_reply_to":"3a7e1126_9655d3fa","updated":"2015-12-22 22:33:52.000000000","message":"So just to clarify and confusion:\n@Markus said:\n\n \u003e What worries me more is, when ppc or s390 decide to support spice, we have\n \u003e to remove this piece of code and wait until the next release to exploit it.\n \u003e With the current release model this means that can be 6 month at worst.\n\nMy query:\n\n \u003e I\u0027m not sure why we\u0027d need to wait to exploit the code.\n\nis because I don\u0027t understand why the release model would prevent us from removing this exception once we\u0027re confident that the underlying code works and is supported by distributions.\n\n@Markus: can you expand on your thinking?","commit_id":"55a2e6b2827b0995d3238317b5dadc27cdbf3e48"},{"author":{"_account_id":8175,"name":"Rafael Folco","email":"rfolco@redhat.com","username":"rfolco"},"change_message_id":"5d1318f4db2b5dd293157db0492359566af7b34a","unresolved":false,"context_lines":[{"line_number":4285,"context_line":"        guestarch \u003d libvirt_utils.get_arch(image_meta)"},{"line_number":4286,"context_line":"        if (CONF.spice.enabled and"},{"line_number":4287,"context_line":"                guestarch in (arch.PPC, arch.PPC64, arch.S390, arch.S390X)):"},{"line_number":4288,"context_line":"            raise exception.SpiceProtocolUnsupported(type\u003dguestarch)"},{"line_number":4289,"context_line":""},{"line_number":4290,"context_line":"        if (CONF.spice.enabled and CONF.spice.agent_enabled and"},{"line_number":4291,"context_line":"                virt_type not in (\u0027lxc\u0027, \u0027uml\u0027, \u0027xen\u0027)):"}],"source_content_type":"text/x-python","patch_set":17,"id":"3a7e1126_9655d3fa","line":4288,"in_reply_to":"3a7e1126_df970838","updated":"2015-12-22 12:45:51.000000000","message":"Could you please elaborate more on the 2nd sentence? What code exploitation you referring to?","commit_id":"55a2e6b2827b0995d3238317b5dadc27cdbf3e48"},{"author":{"_account_id":11303,"name":"Markus Zoeller (markus_z)","email":"mzoeller@linux.vnet.ibm.com","username":"mzoeller"},"change_message_id":"584a1efda962af9b5212edb0a9f85a1b6d6f3768","unresolved":false,"context_lines":[{"line_number":4285,"context_line":"        guestarch \u003d libvirt_utils.get_arch(image_meta)"},{"line_number":4286,"context_line":"        if (CONF.spice.enabled and"},{"line_number":4287,"context_line":"                guestarch in (arch.PPC, arch.PPC64, arch.S390, arch.S390X)):"},{"line_number":4288,"context_line":"            raise exception.SpiceProtocolUnsupported(type\u003dguestarch)"},{"line_number":4289,"context_line":""},{"line_number":4290,"context_line":"        if (CONF.spice.enabled and CONF.spice.agent_enabled and"},{"line_number":4291,"context_line":"                virt_type not in (\u0027lxc\u0027, \u0027uml\u0027, \u0027xen\u0027)):"}],"source_content_type":"text/x-python","patch_set":17,"id":"3a7e1126_19c0414f","line":4288,"in_reply_to":"3a7e1126_df970838","updated":"2015-12-22 09:23:43.000000000","message":"Oh, I was under the impression that this depends on the host arch.","commit_id":"55a2e6b2827b0995d3238317b5dadc27cdbf3e48"},{"author":{"_account_id":11303,"name":"Markus Zoeller (markus_z)","email":"mzoeller@linux.vnet.ibm.com","username":"mzoeller"},"change_message_id":"716d0213f5117c35b3c2491db05c2a576edc7bdc","unresolved":false,"context_lines":[{"line_number":4285,"context_line":"        guestarch \u003d libvirt_utils.get_arch(image_meta)"},{"line_number":4286,"context_line":"        if (CONF.spice.enabled and"},{"line_number":4287,"context_line":"                guestarch in (arch.PPC, arch.PPC64, arch.S390, arch.S390X)):"},{"line_number":4288,"context_line":"            raise exception.SpiceProtocolUnsupported(type\u003dguestarch)"},{"line_number":4289,"context_line":""},{"line_number":4290,"context_line":"        if (CONF.spice.enabled and CONF.spice.agent_enabled and"},{"line_number":4291,"context_line":"                virt_type not in (\u0027lxc\u0027, \u0027uml\u0027, \u0027xen\u0027)):"}],"source_content_type":"text/x-python","patch_set":17,"id":"fa69d971_5d0da9e6","line":4288,"in_reply_to":"fa69d971_1de09128","updated":"2016-01-07 10:24:03.000000000","message":"I discussed with my colleague of mine, Alex, who +1\u0027ed in a previous patchset. I finally understand the dependency to the guest os and Matt\u0027s explanation. The change is OK for me now.","commit_id":"55a2e6b2827b0995d3238317b5dadc27cdbf3e48"},{"author":{"_account_id":11303,"name":"Markus Zoeller (markus_z)","email":"mzoeller@linux.vnet.ibm.com","username":"mzoeller"},"change_message_id":"643bf2852c9bbcdd89cac98f01e7e3232031a292","unresolved":false,"context_lines":[{"line_number":4285,"context_line":"        guestarch \u003d libvirt_utils.get_arch(image_meta)"},{"line_number":4286,"context_line":"        if (CONF.spice.enabled and"},{"line_number":4287,"context_line":"                guestarch in (arch.PPC, arch.PPC64, arch.S390, arch.S390X)):"},{"line_number":4288,"context_line":"            raise exception.SpiceProtocolUnsupported(type\u003dguestarch)"},{"line_number":4289,"context_line":""},{"line_number":4290,"context_line":"        if (CONF.spice.enabled and CONF.spice.agent_enabled and"},{"line_number":4291,"context_line":"                virt_type not in (\u0027lxc\u0027, \u0027uml\u0027, \u0027xen\u0027)):"}],"source_content_type":"text/x-python","patch_set":17,"id":"fa69d971_1de09128","line":4288,"in_reply_to":"fa69d971_d15e8411","updated":"2016-01-05 10:49:00.000000000","message":"The last info I had was, that spice won\u0027t work on s390 because it depends on a graphical framebuffer on the host which is not available on that platform. I don\u0027t understand how spice is connected to the version of the guest operating system.","commit_id":"55a2e6b2827b0995d3238317b5dadc27cdbf3e48"},{"author":{"_account_id":12898,"name":"Tony Breeds","email":"tony@bakeyournoodle.com","username":"tonyb"},"change_message_id":"c1d9795f86ccdf65dce0900df693590343f151bd","unresolved":false,"context_lines":[{"line_number":4285,"context_line":"        guestarch \u003d libvirt_utils.get_arch(image_meta)"},{"line_number":4286,"context_line":"        if (CONF.spice.enabled and"},{"line_number":4287,"context_line":"                guestarch in (arch.PPC, arch.PPC64, arch.S390, arch.S390X)):"},{"line_number":4288,"context_line":"            raise exception.SpiceProtocolUnsupported(type\u003dguestarch)"},{"line_number":4289,"context_line":""},{"line_number":4290,"context_line":"        if (CONF.spice.enabled and CONF.spice.agent_enabled and"},{"line_number":4291,"context_line":"                virt_type not in (\u0027lxc\u0027, \u0027uml\u0027, \u0027xen\u0027)):"}],"source_content_type":"text/x-python","patch_set":17,"id":"fa69d971_b520d2b1","line":4288,"in_reply_to":"fa69d971_d15e8411","updated":"2016-01-08 06:02:54.000000000","message":"You\u0027re right we should be checking something in the guest/image.","commit_id":"55a2e6b2827b0995d3238317b5dadc27cdbf3e48"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"115e5b02b7877240787f201b44dca08f85cfb6c8","unresolved":false,"context_lines":[{"line_number":4285,"context_line":"        guestarch \u003d libvirt_utils.get_arch(image_meta)"},{"line_number":4286,"context_line":"        if (CONF.spice.enabled and"},{"line_number":4287,"context_line":"                guestarch in (arch.PPC, arch.PPC64, arch.S390, arch.S390X)):"},{"line_number":4288,"context_line":"            raise exception.SpiceProtocolUnsupported(type\u003dguestarch)"},{"line_number":4289,"context_line":""},{"line_number":4290,"context_line":"        if (CONF.spice.enabled and CONF.spice.agent_enabled and"},{"line_number":4291,"context_line":"                virt_type not in (\u0027lxc\u0027, \u0027uml\u0027, \u0027xen\u0027)):"}],"source_content_type":"text/x-python","patch_set":17,"id":"fa69d971_d15e8411","line":4288,"in_reply_to":"fa69d971_d830f603","updated":"2016-01-04 18:14:30.000000000","message":"Don\u0027t you then need a version check on the guest OS? If you\u0027re not checking the version, you don\u0027t know when/if ppc/s390 supports spice. If you merged this and then that support was added in bleeding edge versions, but the operator still had older images, then we\u0027d still have the bug, right? So it seems you\u0027d need to check based on some version from the guest. If that version is currently unknown, then it seems like failing the spawn would be OK and if/when the support is added, you would then know the min version to check for per arch and could change this restriction in the code.","commit_id":"55a2e6b2827b0995d3238317b5dadc27cdbf3e48"}]}