)]}'
{"nova/api/openstack/json_home.py":[{"author":{"_account_id":6062,"name":"jichenjc","email":"jichenjc@cn.ibm.com","username":"jichenjc"},"change_message_id":"17e10f61df856aae057622772464ee7d61ddd719","unresolved":false,"context_lines":[{"line_number":60,"context_line":"    \u0027os-security-group-rules\u0027: [\u0027os-security-group-rule\u0027,"},{"line_number":61,"context_line":"                                \u0027security_group_id\u0027],"},{"line_number":62,"context_line":"    \u0027flavors\u0027: [\u0027flavor\u0027, \u0027flavor_id\u0027],"},{"line_number":63,"context_line":"    \u0027os-floating-ips-bulk\u0027: [\u0027os-floating-ips-bulk\u0027, \u0027host_name\u0027],"},{"line_number":64,"context_line":"    \u0027os-console-auth-tokens\u0027: [\u0027os-console-auth-token\u0027, \u0027token_id\u0027],"},{"line_number":65,"context_line":"    \u0027os-baremetal-nodes\u0027: [\u0027os-baremetal-node\u0027, \u0027baremetal_nodes_id\u0027],"},{"line_number":66,"context_line":"    \u0027os-floating-ips\u0027: [\u0027os-floating-ip\u0027, \u0027floating_ip_id\u0027],"}],"source_content_type":"text/x-python","patch_set":6,"id":"3a50d1a3_50654a1b","line":63,"updated":"2015-07-29 09:35:51.000000000","message":"host_name?","commit_id":"28cdc8abcceb293cb6576d29c6adaca02c4b4129"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"165a2d7308b887f4945ef8f4a35dac90e6779c11","unresolved":false,"context_lines":[{"line_number":60,"context_line":"    \u0027os-security-group-rules\u0027: [\u0027os-security-group-rule\u0027,"},{"line_number":61,"context_line":"                                \u0027security_group_id\u0027],"},{"line_number":62,"context_line":"    \u0027flavors\u0027: [\u0027flavor\u0027, \u0027flavor_id\u0027],"},{"line_number":63,"context_line":"    \u0027os-floating-ips-bulk\u0027: [\u0027os-floating-ips-bulk\u0027, \u0027host_name\u0027],"},{"line_number":64,"context_line":"    \u0027os-console-auth-tokens\u0027: [\u0027os-console-auth-token\u0027, \u0027token_id\u0027],"},{"line_number":65,"context_line":"    \u0027os-baremetal-nodes\u0027: [\u0027os-baremetal-node\u0027, \u0027baremetal_nodes_id\u0027],"},{"line_number":66,"context_line":"    \u0027os-floating-ips\u0027: [\u0027os-floating-ip\u0027, \u0027floating_ip_id\u0027],"}],"source_content_type":"text/x-python","patch_set":6,"id":"3a50d1a3_b2bfbdfb","line":63,"in_reply_to":"3a50d1a3_50654a1b","updated":"2015-07-30 07:38:01.000000000","message":"Yes, this is to list FIPs for given host","commit_id":"28cdc8abcceb293cb6576d29c6adaca02c4b4129"},{"author":{"_account_id":6062,"name":"jichenjc","email":"jichenjc@cn.ibm.com","username":"jichenjc"},"change_message_id":"17e10f61df856aae057622772464ee7d61ddd719","unresolved":false,"context_lines":[{"line_number":136,"context_line":"    if (\u0027show\u0027 in controller or \u0027update\u0027 in controller or"},{"line_number":137,"context_line":"        \u0027delete\u0027 in controller):"},{"line_number":138,"context_line":"        resource_subname \u003d RESOURCE_PARAM_MAPPING[resource_name][0]"},{"line_number":139,"context_line":"        sub_param \u003d RESOURCE_PARAM_MAPPING[resource_name][1]"},{"line_number":140,"context_line":"        sub_relation \u003d build_resource_relation(resource_subname)"},{"line_number":141,"context_line":"        sub_template \u003d build_resource_template(resource_name)"},{"line_number":142,"context_line":"        template_with_param \u003d build_template_parameter_relation(sub_template,"}],"source_content_type":"text/x-python","patch_set":6,"id":"3a50d1a3_d0271ac8","line":139,"updated":"2015-07-29 09:35:51.000000000","message":"any criteria for the names such as xxx_id etc?","commit_id":"28cdc8abcceb293cb6576d29c6adaca02c4b4129"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"165a2d7308b887f4945ef8f4a35dac90e6779c11","unresolved":false,"context_lines":[{"line_number":136,"context_line":"    if (\u0027show\u0027 in controller or \u0027update\u0027 in controller or"},{"line_number":137,"context_line":"        \u0027delete\u0027 in controller):"},{"line_number":138,"context_line":"        resource_subname \u003d RESOURCE_PARAM_MAPPING[resource_name][0]"},{"line_number":139,"context_line":"        sub_param \u003d RESOURCE_PARAM_MAPPING[resource_name][1]"},{"line_number":140,"context_line":"        sub_relation \u003d build_resource_relation(resource_subname)"},{"line_number":141,"context_line":"        sub_template \u003d build_resource_template(resource_name)"},{"line_number":142,"context_line":"        template_with_param \u003d build_template_parameter_relation(sub_template,"}],"source_content_type":"text/x-python","patch_set":6,"id":"3a50d1a3_b2c9fd7b","line":139,"in_reply_to":"3a50d1a3_d0271ac8","updated":"2015-07-30 07:38:01.000000000","message":"Actually those are param which will be used for href-vars","commit_id":"28cdc8abcceb293cb6576d29c6adaca02c4b4129"}],"nova/tests/unit/api/openstack/test_json_home.py":[{"author":{"_account_id":6062,"name":"jichenjc","email":"jichenjc@cn.ibm.com","username":"jichenjc"},"change_message_id":"17e10f61df856aae057622772464ee7d61ddd719","unresolved":false,"context_lines":[{"line_number":82,"context_line":"                         resource_data[\u0027href-vars\u0027][\u0027project_id\u0027])"},{"line_number":83,"context_line":"        self.assertEqual(\u0027http://docs.openstack.org/api/openstack-compute/2.1/\u0027"},{"line_number":84,"context_line":"                         \u0027param/server_id\u0027,"},{"line_number":85,"context_line":"                         resource_data[\u0027href-vars\u0027][\u0027server_id\u0027])"}],"source_content_type":"text/x-python","patch_set":6,"id":"3a50d1a3_b0ffee00","line":85,"updated":"2015-07-29 09:35:51.000000000","message":"can we expand the test to cover all cases? a little bit aggressive..","commit_id":"28cdc8abcceb293cb6576d29c6adaca02c4b4129"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"165a2d7308b887f4945ef8f4a35dac90e6779c11","unresolved":false,"context_lines":[{"line_number":82,"context_line":"                         resource_data[\u0027href-vars\u0027][\u0027project_id\u0027])"},{"line_number":83,"context_line":"        self.assertEqual(\u0027http://docs.openstack.org/api/openstack-compute/2.1/\u0027"},{"line_number":84,"context_line":"                         \u0027param/server_id\u0027,"},{"line_number":85,"context_line":"                         resource_data[\u0027href-vars\u0027][\u0027server_id\u0027])"}],"source_content_type":"text/x-python","patch_set":6,"id":"3a50d1a3_92e5e10b","line":85,"in_reply_to":"3a50d1a3_b0ffee00","updated":"2015-07-30 07:38:01.000000000","message":"Yes, that will gets added in followup patches. Actually when we will register the data from API Router then, we will test whether all resources gets registered or not. But not sure we need to do that in Unit tests as it will be huge, I am planning to test all in Functional tests via sample file.","commit_id":"28cdc8abcceb293cb6576d29c6adaca02c4b4129"}]}