)]}'
{"nova/tests/test_libvirt_volume.py":[{"author":{"_account_id":5441,"name":"Andrew Laski","email":"andrew@lascii.com","username":"alaski"},"change_message_id":"0a476e4bddc4b79128bfc83bd0b871d5f2e1571e","unresolved":false,"context_lines":[{"line_number":1,"context_line":"# vim: tabstop\u003d4 shiftwidth\u003d4 softtabstop\u003d4"},{"line_number":2,"context_line":"#"},{"line_number":3,"context_line":"#    Copyright 2010 OpenStack LLC"},{"line_number":4,"context_line":"#    Copyright 2012 University Of Minho"},{"line_number":5,"context_line":"#"},{"line_number":6,"context_line":"#    Licensed under the Apache License, Version 2.0 (the \"License\"); you may"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAM3%2F%2FVB0%3D","line":3,"updated":"2013-01-28 20:28:22.000000000","message":"Should this be updated to 2013 since it\u0027s a new file?","commit_id":"97513c0a4e2edeaa38e872227503ae29de5e5221"},{"author":{"_account_id":1779,"name":"Daniel Berrange","email":"berrange@redhat.com","username":"berrange"},"change_message_id":"971a1331cac6f0d35272e96312c640304b1ed948","unresolved":false,"context_lines":[{"line_number":1,"context_line":"# vim: tabstop\u003d4 shiftwidth\u003d4 softtabstop\u003d4"},{"line_number":2,"context_line":"#"},{"line_number":3,"context_line":"#    Copyright 2010 OpenStack LLC"},{"line_number":4,"context_line":"#    Copyright 2012 University Of Minho"},{"line_number":5,"context_line":"#"},{"line_number":6,"context_line":"#    Licensed under the Apache License, Version 2.0 (the \"License\"); you may"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAM3%2F%2FUHI%3D","line":3,"in_reply_to":"AAAAM3%2F%2FVB0%3D","updated":"2013-01-29 11:56:40.000000000","message":"There have been no changes to the code, so it is inappropriate to change the copyright tag IMHO. In any case I work for Red Hat not OpenStack, so I wouldn\u0027t change their copyright line regardless","commit_id":"97513c0a4e2edeaa38e872227503ae29de5e5221"},{"author":{"_account_id":5441,"name":"Andrew Laski","email":"andrew@lascii.com","username":"alaski"},"change_message_id":"0a476e4bddc4b79128bfc83bd0b871d5f2e1571e","unresolved":false,"context_lines":[{"line_number":59,"context_line":"    def test_libvirt_volume_driver_serial(self):"},{"line_number":60,"context_line":"        libvirt_driver \u003d volume.LibvirtVolumeDriver(self.fake_conn)"},{"line_number":61,"context_line":"        name \u003d \u0027volume-00000001\u0027"},{"line_number":62,"context_line":"        vol \u003d {\u0027id\u0027: 1, \u0027name\u0027: name}"},{"line_number":63,"context_line":"        connection_info \u003d {"},{"line_number":64,"context_line":"            \u0027driver_volume_type\u0027: \u0027fake\u0027,"},{"line_number":65,"context_line":"            \u0027data\u0027: {"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAM3%2F%2FVBA%3D","line":62,"updated":"2013-01-28 20:28:22.000000000","message":"This variable doesn\u0027t appear to be used anywhere.  I know this is a straight copy but would you mind cleaning this one up?","commit_id":"97513c0a4e2edeaa38e872227503ae29de5e5221"},{"author":{"_account_id":1779,"name":"Daniel Berrange","email":"berrange@redhat.com","username":"berrange"},"change_message_id":"971a1331cac6f0d35272e96312c640304b1ed948","unresolved":false,"context_lines":[{"line_number":59,"context_line":"    def test_libvirt_volume_driver_serial(self):"},{"line_number":60,"context_line":"        libvirt_driver \u003d volume.LibvirtVolumeDriver(self.fake_conn)"},{"line_number":61,"context_line":"        name \u003d \u0027volume-00000001\u0027"},{"line_number":62,"context_line":"        vol \u003d {\u0027id\u0027: 1, \u0027name\u0027: name}"},{"line_number":63,"context_line":"        connection_info \u003d {"},{"line_number":64,"context_line":"            \u0027driver_volume_type\u0027: \u0027fake\u0027,"},{"line_number":65,"context_line":"            \u0027data\u0027: {"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAM3%2F%2FUHM%3D","line":62,"in_reply_to":"AAAAM3%2F%2FVBA%3D","updated":"2013-01-29 11:56:40.000000000","message":"It is really bad practice to hide code cleanups inside changes that move / rename code. Any cleanup should be a completely separate commit so that it is obvious to a reviewer than something is being changed.","commit_id":"97513c0a4e2edeaa38e872227503ae29de5e5221"}]}